Re: [Intel-gfx] [PATCH 1/4] drm/i915/tgl/dsi: Program TRANS_VBLANK register

2019-07-29 Thread Kulkarni, Vandita
> -Original Message- > From: Shankar, Uma > Sent: Tuesday, July 16, 2019 3:29 PM > To: Kulkarni, Vandita ; intel- > g...@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Nikula, Jani > Subject: RE: [PATCH 1/4] drm/i915/tgl/dsi: Program TRANS_VBLANK register > > > > >-Ori

Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove duplicate entry of trace

2019-07-29 Thread Zhao, Yan Y
Reviewed-by: Yan Zhao > -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Zhenyu Wang > Sent: Wednesday, June 12, 2019 11:23 AM > To: Hariprasad Kelam > Cc: David Airlie ; intel-gfx@lists.freedesktop.org; Joonas > Lahtinen ; linu

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use upstream version of header tests

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: use upstream version of header tests URL : https://patchwork.freedesktop.org/series/64389/ State : success == Summary == CI Bug Log - changes from CI_DRM_6574_full -> Patchwork_13787_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for Call uC functions from GT ones

2019-07-29 Thread Patchwork
== Series Details == Series: Call uC functions from GT ones URL : https://patchwork.freedesktop.org/series/64406/ State : success == Summary == CI Bug Log - changes from CI_DRM_6576 -> Patchwork_13793 Summary --- **SUCCESS** No re

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Call uC functions from GT ones

2019-07-29 Thread Patchwork
== Series Details == Series: Call uC functions from GT ones URL : https://patchwork.freedesktop.org/series/64406/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/uc: move uC WOPCM setup in uc_init_hw +drivers/gpu/drm/i915/gt/uc/intel_uc.c:410:5

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: don't enable communication twice on resume

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915/uc: don't enable communication twice on resume URL : https://patchwork.freedesktop.org/series/64405/ State : success == Summary == CI Bug Log - changes from CI_DRM_6576 -> Patchwork_13792 Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop genereating old header test files

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: stop genereating old header test files URL : https://patchwork.freedesktop.org/series/64402/ State : success == Summary == CI Bug Log - changes from CI_DRM_6576 -> Patchwork_13791 Summary --- **

[Intel-gfx] [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-29 Thread Brian Welty
[ By request, resending to include amd-gfx + intel-gfx. Since resending, I fixed the nit with ordering of header includes that Sam noted. ] This RFC series is first implementation of some ideas expressed earlier on dri-devel [1]. Some of the goals (open for much debate) are: - Create common

[Intel-gfx] [RFC PATCH 1/3] drm: introduce new struct drm_mem_region

2019-07-29 Thread Brian Welty
Move basic members of ttm_mem_type_manager into a new DRM memory region structure. The idea is for this base structure to be nested inside the TTM structure and later in Intel's proposed intel_memory_region. As comments in the code suggest, the following future work can extend the usefulness of t

[Intel-gfx] [RFC PATCH 3/3] drm/i915: Update intel_memory_region to use nested drm_mem_region

2019-07-29 Thread Brian Welty
Some fields are deleted from intel_memory_region in favor of instead using the new nested drm_mem_region structure. Note, this is based upon unmerged i915 series [1] in order to show how i915 might begin to integrate the proposed drm_mem_region. [1] https://lists.freedesktop.org/archives/intel-gf

[Intel-gfx] [RFC PATCH 2/3] drm: Introduce DRM_MEM defines for specifying type of drm_mem_region

2019-07-29 Thread Brian Welty
Introduce DRM memory region types to be common for both drivers using TTM and for i915. For now, TTM continues to define it's own set but uses the DRM base definitions. Signed-off-by: Brian Welty --- include/drm/drm_mm.h| 8 include/drm/ttm/ttm_placement.h | 8 2 f

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop genereating old header test files

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: stop genereating old header test files URL : https://patchwork.freedesktop.org/series/64402/ State : warning == Summary == $ dim checkpatch origin/drm-tip 10638294b77e drm/i915: stop genereating old header test files -:54: WARNING:FILE_PATH_CHANGES: added

[Intel-gfx] [PATCH 3/6] drm/i915/uc: move uc early functions inside the gt ones

2019-07-29 Thread Daniele Ceraolo Spurio
uc is a subcomponent of GT, so initialize/clean it as part of it. The wopcm_init_early doesn't have to be happen before the uC one, but since in other parts of the code we consider wopcm first do the same for consistency. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: Chris Wilso

[Intel-gfx] [PATCH 4/6] drm/i915/gt: introduce intel_gt_runtime_suspend/resume

2019-07-29 Thread Daniele Ceraolo Spurio
To be called from the top level runtime functions, to hide the gt-specific bits (mainly related to intel_uc). Signed-off-by: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 drivers/gpu/drm/i915/gt/intel_gt_pm.h | 2 ++ dr

[Intel-gfx] [PATCH 1/6] drm/i915/uc: move uC WOPCM setup in uc_init_hw

2019-07-29 Thread Daniele Ceraolo Spurio
The register we write are not WOPCM regs but uC ones related to how GuC and HuC are going to use the WOPCM, so it makes logical sense for them to be programmed as part of uc_init_hw. The wopcm map on the other side is not uC-specific (although that is our main use-case), so keep that separate. Sig

[Intel-gfx] [PATCH 6/6] drm/i915/gt: introduce intel_gt_suspend

2019-07-29 Thread Daniele Ceraolo Spurio
For symmetry with intel_gt_resume and to hide more stuff from the top level under intel_gt. Note that the switch_to_kernel_context_sync has not been moved dure to the locking and ordering requirements that exist at the moment. Signed-off-by: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Tvrtko Urs

[Intel-gfx] [PATCH 5/6] drm/i915/uc: move uc_resume under gt_resume

2019-07-29 Thread Daniele Ceraolo Spurio
intel_uc is part of intel_gt so it makes logical sense for it to be resumed as part of it. Note that, since gt_resume is also called during the init flow, a state variable has been added to intel_uc to avoid asking an already running GuC to resume. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal

[Intel-gfx] [PATCH 2/6] drm/i915: move gt_cleanup_early out of gem_cleanup_early

2019-07-29 Thread Daniele Ceraolo Spurio
We don't call the init_early function from within the gem code, so we shouldn't do it for the cleanup either. Signed-off-by: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_gem.c | 2 -- 2 files changed, 2 inserti

[Intel-gfx] [PATCH 0/6] Call uC functions from GT ones

2019-07-29 Thread Daniele Ceraolo Spurio
The plan is to completely hide intel_uc under intel_gt and this series starts in that direction by moving the init early and suspend/resume functions. The _init and init_hw have for now been skipped as they should be covered when gt_init_hw is introduced; however, the init_hw path has been simplifi

[Intel-gfx] ✓ Fi.CI.BAT: success for Tiger Lake: MOCS table handling (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: Tiger Lake: MOCS table handling (rev2) URL : https://patchwork.freedesktop.org/series/64275/ State : success == Summary == CI Bug Log - changes from CI_DRM_6576 -> Patchwork_13790 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Flush the i915_vm_release before ggtt shutdown (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: Flush the i915_vm_release before ggtt shutdown (rev2) URL : https://patchwork.freedesktop.org/series/64383/ State : success == Summary == CI Bug Log - changes from CI_DRM_6573_full -> Patchwork_13786_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Tiger Lake: MOCS table handling (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: Tiger Lake: MOCS table handling (rev2) URL : https://patchwork.freedesktop.org/series/64275/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf36018c1df4 drm/i915/tgl: Move fault registers to their new offset a8fe00865d19 drm/i915/tgl: stop using ERRO

[Intel-gfx] [PATCH] drm/i915/uc: don't enable communication twice on resume

2019-07-29 Thread Daniele Ceraolo Spurio
When coming out of S3/S4 we sanitize and re-init the HW, which includes enabling communication during uc_init_hw. We therefore don't want to do that again in uc_resume and can just tell GuC to reload its state. Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: Chris Wilson --- dri

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-29 Thread Daniele Ceraolo Spurio
On 7/29/19 2:19 PM, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be modified, but new ones can be added. Adding entries increases table version. The patch includes version 1 entries. Two of the 3 legacy ent

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/tgl: stop using ERROR_GEN6 and DONE_REG

2019-07-29 Thread Daniele Ceraolo Spurio
On 7/29/19 2:19 PM, Lucas De Marchi wrote: These registers have been removed on gen12. Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_gpu_error.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH] drm/i915: stop genereating old header test files

2019-07-29 Thread Lucas De Marchi
Commit e846f0dc57f4 ("kbuild: add support for ensuring headers are self-contained") replaced the old mechanism we had in i915 to test the header files are self-contained, but later commits kept adding Makefiles to subdirs. The end result is that after a build we have several header_test_* files tha

[Intel-gfx] [PATCH v2 5/5] drm/i915: Move MOCS setup to intel_mocs.c

2019-07-29 Thread Lucas De Marchi
From: Tvrtko Ursulin Hide the details of MOCS setup from i915_gem by moving both current calls into one in intel_mocs_init. Cc: Stuart Summers Signed-off-by: Tvrtko Ursulin Signed-off-by: Lucas De Marchi Reviewed-by: Stuart Summers Link: https://patchwork.freedesktop.org/patch/msgid/2019071

[Intel-gfx] [PATCH v2 3/5] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-29 Thread Lucas De Marchi
From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be modified, but new ones can be added. Adding entries increases table version. The patch includes version 1 entries. Two of the 3 legacy entries used for gen9 are no longer expected to wo

[Intel-gfx] [PATCH v2 4/5] drm/i915/tgl: Tigerlake only has global MOCS registers

2019-07-29 Thread Lucas De Marchi
From: Michel Thierry Until Icelake, each engine had its own set of 64 MOCS registers. In order to simplify, Tigerlake moves to only 64 Global MOCS registers, which are no longer part of the engine context. Since these registers are now global, they also only need to be initialized once. From Gen

[Intel-gfx] [PATCH v2 0/5] Tiger Lake: MOCS table handling

2019-07-29 Thread Lucas De Marchi
v2 of https://patchwork.freedesktop.org/series/64275/ Accompanying IGT patches: v2 of https://patchwork.freedesktop.org/series/64263/ Changes: - add a new table for Tiger Lake instead of sharing the table with Ice Lake. - split changes as requested Lucas De Marchi (2): drm/i915/tgl: M

[Intel-gfx] [PATCH v2 1/5] drm/i915/tgl: Move fault registers to their new offset

2019-07-29 Thread Lucas De Marchi
The fault registers moved to another offset. The old location is now taken by the global MOCS registers, to be added in a follow up change. Based on previous patches by Michel Thierry . Signed-off-by: Lucas De Marchi Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH v2 2/5] drm/i915/tgl: stop using ERROR_GEN6 and DONE_REG

2019-07-29 Thread Lucas De Marchi
These registers have been removed on gen12. Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_gpu_error.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for add more probe failures (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: add more probe failures (rev2) URL : https://patchwork.freedesktop.org/series/64390/ State : failure == Summary == Applying: drm/i915: Report -ENODEV after injecting probe failure error: patch failed: drivers/base/dd.c:613 error: drivers/base/dd.c: patch does not a

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Report -ENODEV after injecting probe failure

2019-07-29 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-07-29 18:54:15) > > > On 7/29/19 8:22 AM, Michal Wajdeczko wrote: > > We want to do more driver testing using injected load errors, > > but we don't want to limit ourselves to use only -ENODEV (as > > other errors are interpreted as real issues, like this: > >

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Avoid using borked engines

2019-07-29 Thread Chris Wilson
Check for viability of store-dword before use. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_schedule.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index 4ccacba41..6e8466299 100644 --- a/tests/i9

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/display/icl: Bump up the hdisplay and vdisplay as per transcoder limits

2019-07-29 Thread Manasi Navare
Hi Ville, Thanks for your review, so do we want to merge this as is or do we need some function to reject the 8K mode on ICL in intel_dp_mode_valid()? Manasi On Fri, Jul 12, 2019 at 11:29:38PM +0300, Ville Syrjälä wrote: > On Fri, Jul 12, 2019 at 01:22:13PM -0700, Manasi Navare wrote: > > On ICL

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Refuse modes with hdisplay==4096 on pre-HSW DP

2019-07-29 Thread Manasi Navare
On Thu, Jul 18, 2019 at 05:43:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The DP port/pipe goes wonky if we try to use timings with > hdisplay==4096 on pre-HSW platforms. The link fails to train > and the pipe may not signal vblank interrupts. On HDMI such at > mode works just fine

Re: [Intel-gfx] [PATCH 4/4] drm/i915/wopcm: Don't fail on WOPCM partitioning failure

2019-07-29 Thread Daniele Ceraolo Spurio
On 7/29/19 8:23 AM, Michal Wajdeczko wrote: We shouldn't immediately fail on WOPCM partitioning or programming as we plan to restore fallback on any GuC related failures. While around, add some more probe failure injections. I was planning to move the uC wopcm programming to intel_uc_init_h

Re: [Intel-gfx] [RFC PATCH 1/3] drm: introduce new struct drm_mem_region

2019-07-29 Thread Sam Ravnborg
Hi Brian. Small nit below - did not try to understand your patch. Sam > diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h > index 2c3bbb43c7d1..3d123eb10d62 100644 > --- a/include/drm/drm_mm.h > +++ b/include/drm/drm_mm.h > @@ -43,6 +43,8 @@ > #include > #include > #include

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Report -ENODEV after injecting probe failure

2019-07-29 Thread Daniele Ceraolo Spurio
On 7/29/19 8:22 AM, Michal Wajdeczko wrote: We want to do more driver testing using injected load errors, but we don't want to limit ourselves to use only -ENODEV (as other errors are interpreted as real issues, like this: <4> [381.569479] i915: probe of :00:02.0 failed with error -7 Sugg

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-07-29 Thread Sam Ravnborg
Hi Christian. On Mon, Jul 29, 2019 at 03:28:15PM +, Koenig, Christian wrote: > Am 29.07.19 um 16:35 schrieb Sam Ravnborg: > Even then it so useless (which drm driver is this message for???) that I > want to remove them all :( > >>> Yeah, agree. I mean it is nice if the core drm funct

[Intel-gfx] ✓ Fi.CI.BAT: success for add more probe failures

2019-07-29 Thread Patchwork
== Series Details == Series: add more probe failures URL : https://patchwork.freedesktop.org/series/64390/ State : success == Summary == CI Bug Log - changes from CI_DRM_6574 -> Patchwork_13788 Summary --- **SUCCESS** No regressio

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use upstream version of header tests

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: use upstream version of header tests URL : https://patchwork.freedesktop.org/series/64389/ State : success == Summary == CI Bug Log - changes from CI_DRM_6574 -> Patchwork_13787 Summary --- **SU

[Intel-gfx] [RFC PATCH 2/3] drm: Introduce DRM_MEM defines for specifying type of drm_mem_region

2019-07-29 Thread Brian Welty
Introduce DRM memory region types to be common for both drivers using TTM and for i915. For now, TTM continues to define it's own set but uses the DRM base definitions. Signed-off-by: Brian Welty --- include/drm/drm_mm.h| 8 include/drm/ttm/ttm_placement.h | 8 2 f

[Intel-gfx] [RFC PATCH 3/3] drm/i915: Update intel_memory_region to use nested drm_mem_region

2019-07-29 Thread Brian Welty
Some fields are deleted from intel_memory_region in favor of instead using the new nested drm_mem_region structure. Note, this is based upon unmerged i915 series [1] in order to show how i915 might begin to integrate the proposed drm_mem_region. [1] https://lists.freedesktop.org/archives/intel-gf

[Intel-gfx] [RFC PATCH 1/3] drm: introduce new struct drm_mem_region

2019-07-29 Thread Brian Welty
Move basic members of ttm_mem_type_manager into a new DRM memory region structure. The idea is for this base structure to be nested inside the TTM structure and later in Intel's proposed intel_memory_region. As comments in the code suggest, the following future work can extend the usefulness of t

[Intel-gfx] [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-29 Thread Brian Welty
This RFC series is first implementation of some ideas expressed earlier on dri-devel [1]. Some of the goals (open for much debate) are: - Create common base structure (subclass) for memory regions (patch #1) - Create common memory region types (patch #2) - Create common set of memory_region

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Bloomfield, Jon
> -Original Message- > From: Joonas Lahtinen > Sent: Monday, July 29, 2019 5:50 AM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org; Chris Wilson > Cc: Ursulin, Tvrtko > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Chris Wilson (2019-07-29 12:45:

Re: [Intel-gfx] [PATCH v11 1/6] drm: Add Content protection type property

2019-07-29 Thread Ramalingam C
On 2019-07-29 at 17:20:40 +0300, Pekka Paalanen wrote: > On Sun, 14 Jul 2019 16:30:08 +0530 > Ramalingam C wrote: > > > This patch adds a DRM ENUM property to the selected connectors. > > This property is used for mentioning the protected content's type > > from userspace to kernel HDCP authentic

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use upstream version of header tests

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: use upstream version of header tests URL : https://patchwork.freedesktop.org/series/64389/ State : warning == Summary == $ dim checkpatch origin/drm-tip a8bcdef1fcc9 drm/i915: use upstream version of header tests -:41: WARNING:FILE_PATH_CHANGES: added, mo

[Intel-gfx] [PATCH 1/4] drm/i915: Report -ENODEV after injecting probe failure

2019-07-29 Thread Michal Wajdeczko
We want to do more driver testing using injected load errors, but we don't want to limit ourselves to use only -ENODEV (as other errors are interpreted as real issues, like this: <4> [381.569479] i915: probe of :00:02.0 failed with error -7 Suggested-by: Daniele Ceraolo Spurio Signed-off-by:

[Intel-gfx] [PATCH 4/4] drm/i915/wopcm: Don't fail on WOPCM partitioning failure

2019-07-29 Thread Michal Wajdeczko
We shouldn't immediately fail on WOPCM partitioning or programming as we plan to restore fallback on any GuC related failures. While around, add some more probe failure injections. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/gt/uc/intel

[Intel-gfx] [PATCH 3/4] drm/i915/uc: Inject load errors into intel_uc_init_hw

2019-07-29 Thread Michal Wajdeczko
Inject load errors into intel_uc_init_hw to make sure we correctly handle uC initialization failures. To avoid complains from CI about inserted errors or warnings, use helper macro that checks if there was an error injection. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris

Re: [Intel-gfx] [PATCH] drm/i915: Inline engine->init_context into its caller

2019-07-29 Thread Tvrtko Ursulin
On 29/07/2019 12:37, Chris Wilson wrote: We only use the init_context vfunc once while recording the default context state, and we use the same sequence in each backend (eliding steps that do not apply). Remove the vfunc for simplicity and de-duplication. Signed-off-by: Chris Wilson --- driv

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-07-29 Thread Koenig, Christian
Am 29.07.19 um 16:35 schrieb Sam Ravnborg: Even then it so useless (which drm driver is this message for???) that I want to remove them all :( >>> Yeah, agree. I mean it is nice if the core drm functions use a prefix >>> for debug output. >>> >>> But I actually don't see the point for ind

Re: [Intel-gfx] [PATCH] drm/i915: Use drm_i915_private directly from drv_get_drvdata()

2019-07-29 Thread Michal Wajdeczko
On Mon, 29 Jul 2019 13:04:49 +0200, Chris Wilson wrote: As we store a pointer to i915 in the drvdata field (as the pointer is both an alias to the drm_device and drm_i915_private), we can use the stored pointer directly as the i915 device. as we store drm_device* there, let's always trea

[Intel-gfx] [PATCH 0/4] add more probe failures

2019-07-29 Thread Michal Wajdeczko
There are still many places where we can inject failures, but doing so without preparation may make CI unhappy as it will treat any new ERROR/WARN very seriously. Mitigate that by converting some of dmesg messages to debug after injecting fake error. Michal Wajdeczko (4): drm/i915: Report -ENOD

[Intel-gfx] [PATCH 2/4] drm/i915: Add i915 to i915_inject_probe_failure

2019-07-29 Thread Michal Wajdeczko
With i915 added to i915_inject_probe_failure we can use dedicated printk when injecting artificial load failure. Also make this function look like other i915 functions that return error code and make it more flexible to return any provided error code instead of previously assumed -ENODEV. Signed-

[Intel-gfx] [PATCH] drm/i915: use upstream version of header tests

2019-07-29 Thread Jani Nikula
Throw out our local hacks of header tests now that the more generic kbuild versions are upstream. At least for now, continue to keep the header tests behind CONFIG_DRM_I915_WERROR=y knob. Cc: Chris Wilson Signed-off-by: Jani Nikula --- Technically the upstream versions are only in drm-tip, an

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush the i915_vm_release before ggtt shutdown (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: Flush the i915_vm_release before ggtt shutdown (rev2) URL : https://patchwork.freedesktop.org/series/64383/ State : success == Summary == CI Bug Log - changes from CI_DRM_6573 -> Patchwork_13786 Summar

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/uc: Don't fail on HuC firmware failure (rev2)

2019-07-29 Thread Michal Wajdeczko
On Mon, 29 Jul 2019 16:56:37 +0200, Patchwork wrote: == Series Details == Series: drm/i915/uc: Don't fail on HuC firmware failure (rev2) URL : https://patchwork.freedesktop.org/series/64326/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6573 -> Patchwork_13785 ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/uc: Don't fail on HuC firmware failure (rev2)

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915/uc: Don't fail on HuC firmware failure (rev2) URL : https://patchwork.freedesktop.org/series/64326/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6573 -> Patchwork_13785 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 vgpu PV to improve vgpu performance

2019-07-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/64372/ State : success == Summary == CI Bug Log - changes from CI_DRM_6570_full -> Patchwork_13781_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Use drm_i915_private directly from drv_get_drvdata()

2019-07-29 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-29 15:32:02) > On Mon, 29 Jul 2019 13:04:49 +0200, Chris Wilson > wrote: > > > As we store a pointer to i915 in the drvdata field (as the pointer is > > both > > an alias to the drm_device and drm_i915_private), we can use the stored > > pointer directly as t

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-07-29 Thread Sam Ravnborg
> >> > >> Even then it so useless (which drm driver is this message for???) that I > >> want to remove them all :( > > > > Yeah, agree. I mean it is nice if the core drm functions use a prefix > > for debug output. > > > > But I actually don't see the point for individual drivers. > > We should a

Re: [Intel-gfx] [PATCH] drm/i915: use upstream version of header tests

2019-07-29 Thread Jani Nikula
On Mon, 29 Jul 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-07-29 15:08:47) >> Throw out our local hacks of header tests now that the more generic >> kbuild versions are upstream. >> >> At least for now, continue to keep the header tests behind >> CONFIG_DRM_I915_WERROR=y knob. >> >> Cc

Re: [Intel-gfx] [PATCH v11 1/6] drm: Add Content protection type property

2019-07-29 Thread Pekka Paalanen
On Sun, 14 Jul 2019 16:30:08 +0530 Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected content

[Intel-gfx] Fixes that failed to apply to v5.3-rc2

2019-07-29 Thread Jani Nikula
The following commits have been marked as Cc: stable or fixing something in v5.3-rc2 or earlier, but failed to cherry-pick to drm-intel-fixes. Please see if they are worth backporting, and please do so if they are. Failed to cherry-pick: 18398904ca9e ("drm/i915: Only recover active engines") 092b

Re: [Intel-gfx] [PATCH v3 1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-29 Thread Michel Dänzer
On 2019-07-26 11:06 p.m., Sam Ravnborg wrote: > DRM_WAIT_ON() is from the deprecated drm_os_linux header and > the modern replacement is the wait_event_*. > > The return values differ, so a conversion is needed to > keep the original interface towards userspace. > Introduced a switch/case to make

Re: [Intel-gfx] [PATCH] drm/i915: Flush the i915_vm_release before ggtt shutdown

2019-07-29 Thread Tvrtko Ursulin
On 29/07/2019 14:24, Chris Wilson wrote: As the gen6_ppgtt may refer back to the GGTT for their page-directory slots, make sure those __i915_vm_release are completed prior to shutting down the GGTT. Fixes: b32fa8111563 ("drm/i915/gtt: Defer address space cleanup to an RCU worker") Signed-off-b

Re: [Intel-gfx] [PATCH] drm/i915: use upstream version of header tests

2019-07-29 Thread Chris Wilson
Quoting Jani Nikula (2019-07-29 15:08:47) > Throw out our local hacks of header tests now that the more generic > kbuild versions are upstream. > > At least for now, continue to keep the header tests behind > CONFIG_DRM_I915_WERROR=y knob. > > Cc: Chris Wilson > Signed-off-by: Jani Nikula > >

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-29 12:45:52) > Quoting Joonas Lahtinen (2019-07-29 10:26:47) > > Ok, so just confirming here. The plan is still to have userspace set a > > per context (or per request) time limit for expected completion of a > > request. This will be useful for the media workloads tha

Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h

2019-07-29 Thread Jani Nikula
On Fri, 19 Jul 2019, "Koenig, Christian" wrote: > Am 18.07.19 um 18:46 schrieb Chris Wilson: >> Quoting Sam Ravnborg (2019-07-18 17:14:58) >>> drm_print.h used DRM_NAME - thus adding a dependency from >>> include/drm/drm_print.h => uapi/drm/drm.h >>> >>> Hardcode the name "drm" to break this depen

Re: [Intel-gfx] [PATCH v2 02/10] i915:Added DC3CO mask to allowed_dc_mask and gen9_dc_mask.

2019-07-29 Thread Jani Nikula
In the subject, please use "drm/i915:" as the prefix. Please add a space after ":". Please use the imperative style, i.e. "add" instead of "added". On Wed, 17 Jul 2019, Anshuman Gupta wrote: > This patch enables dc3co state in enable_dc module param > and adds dc3co enable mask to allowed_dc_ma

Re: [Intel-gfx] [PATCH 05/27] drm/i915/gem: Make caps.scheduler static

2019-07-29 Thread Tvrtko Ursulin
On 26/07/2019 09:45, Chris Wilson wrote: We do not notify userspace when the scheduler capabilities are changed (due to wedging the driver) and as such userspace will expect the caps to be static and unchanging. Make it so, and so we only need to compute our caps once during driver registration.

[Intel-gfx] [PATCH] drm/i915: Flush the i915_vm_release before ggtt shutdown

2019-07-29 Thread Chris Wilson
As the gen6_ppgtt may refer back to the GGTT for their page-directory slots, make sure those __i915_vm_release are completed prior to shutting down the GGTT. Fixes: b32fa8111563 ("drm/i915/gtt: Defer address space cleanup to an RCU worker") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- The

[Intel-gfx] [PATCH] drm/i915: Flush the i915_vm_release before ggtt shutdown

2019-07-29 Thread Chris Wilson
As the gen6_ppgtt may refer back to the GGTT for their page-directory slots, make sure those __i915_vm_release are completed prior to shutting down the GGTT. Fixes: b32fa8111563 ("drm/i915/gtt: Defer address space cleanup to an RCU worker") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Inline engine->init_context into its caller

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: Inline engine->init_context into its caller URL : https://patchwork.freedesktop.org/series/64378/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6571 -> Patchwork_13784 Summary ---

Re: [Intel-gfx] [PATCH 05/27] drm/i915/gem: Make caps.scheduler static

2019-07-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-29 13:54:27) > > On 26/07/2019 09:45, Chris Wilson wrote: > > We do not notify userspace when the scheduler capabilities are changed > > (due to wedging the driver) and as such userspace will expect the caps > > to be static and unchanging. Make it so, and so we onl

[Intel-gfx] [PATCH v2] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-29 Thread Michal Wajdeczko
HuC is usually not a critical component, so we can safely ignore firmware load or authentication failures unless HuC was explicitly requested by the user. v2: add convenient way to disable loading (Chris) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Joonas La

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use drm_i915_private directly from drv_get_drvdata()

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_i915_private directly from drv_get_drvdata() URL : https://patchwork.freedesktop.org/series/64377/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6571 -> Patchwork_13783 Summary

Re: [Intel-gfx] [PATCH 04/23] drm/i915: Push the ring creation flags to the backend

2019-07-29 Thread Tvrtko Ursulin
On 26/07/2019 09:43, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-24 12:11:54) On 23/07/2019 19:38, Chris Wilson wrote: Push the ring creation flags from the outer GEM context to the inner intel_cotnext to avoid an unsightly back-reference from inside the backend. Sorry I find this q

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2] drm/i915/perf: Initialise err to 0 before looping over ce->engines (rev3)

2019-07-29 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/perf: Initialise err to 0 before looping over ce->engines (rev3) URL : https://patchwork.freedesktop.org/series/64309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6571 -> Patchwork_13782 ===

[Intel-gfx] [PATCH i-g-t] i915/gem_eio: Break early for small rings

2019-07-29 Thread Chris Wilson
If the shared legacy ringbuffer is too small to fit 64 new contexts, it will hang and report -EIO before we are expecting it. Accommodate this eio as it part of the ABI we are testing. Signed-off-by: Chris Wilson --- tests/i915/gem_eio.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 vgpu PV to improve vgpu performance

2019-07-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/64372/ State : success == Summary == CI Bug Log - changes from CI_DRM_6570 -> Patchwork_13781 Summary --- **SUCCESS*

[Intel-gfx] ✓ Fi.CI.IGT: success for i915_hangman: Force error capture

2019-07-29 Thread Patchwork
== Series Details == Series: i915_hangman: Force error capture URL : https://patchwork.freedesktop.org/series/64353/ State : success == Summary == CI Bug Log - changes from CI_DRM_6570_full -> IGTPW_3300_full Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915: Inline engine->init_context into its caller

2019-07-29 Thread Chris Wilson
We only use the init_context vfunc once while recording the default context state, and we use the same sequence in each backend (eliding steps that do not apply). Remove the vfunc for simplicity and de-duplication. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_types.h | 1

[Intel-gfx] [PATCH] drm/i915: Use drm_i915_private directly from drv_get_drvdata()

2019-07-29 Thread Chris Wilson
As we store a pointer to i915 in the drvdata field (as the pointer is both an alias to the drm_device and drm_i915_private), we can use the stored pointer directly as the i915 device. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c| 7 +++ drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Careful not to flush hang_fini on error setups

2019-07-29 Thread Tvrtko Ursulin
On 29/07/2019 09:59, Chris Wilson wrote: Smatch spotted that we test at the start of hang_fini for a valid (h->gt is only set after a request is created) but then used it regardless later on. v2: Alternatively, we do not need to check as we now always prime h->gt in hang_init() Fixes: cb823ed9

Re: [Intel-gfx] [PULL] gvt-fixes

2019-07-29 Thread Jani Nikula
On Mon, 29 Jul 2019, Zhenyu Wang wrote: > ping.. Sorry for the delay. Unfortunately, dim hit the following issues: Pulling https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23 ... From https://github.com/intel/gvt-linux * tag gvt-fixes-2019-07-23 -> FETCH_HEA

[Intel-gfx] ✓ Fi.CI.IGT: success for uapi/perf: Squelch compiler warning

2019-07-29 Thread Patchwork
== Series Details == Series: uapi/perf: Squelch compiler warning URL : https://patchwork.freedesktop.org/series/64346/ State : success == Summary == CI Bug Log - changes from CI_DRM_6568_full -> Patchwork_13780_full Summary --- **SUC

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-27 01:27:02) > Quoting Bloomfield, Jon (2019-07-26 23:19:38) > > Hmmn. We're still on orthogonal perspectives as far as our previous > > arguments stand. But it doesn't matter because while thinking through your > > replies, I realized there is one argument in favour

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Careful not to flush hang_fini on error setups

2019-07-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-29 10:50:56) > > On 29/07/2019 09:59, Chris Wilson wrote: > > Smatch spotted that we test at the start of hang_fini for a valid (h->gt > > is only set after a request is created) but then used it regardless > > later on. > > > > v2: Alternatively, we do not need to

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-07-29 10:26:47) > Quoting Chris Wilson (2019-07-27 01:27:02) > > Quoting Bloomfield, Jon (2019-07-26 23:19:38) > > > Hmmn. We're still on orthogonal perspectives as far as our previous > > > arguments stand. But it doesn't matter because while thinking through > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-29 Thread Tvrtko Ursulin
On 29/07/2019 09:54, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-29 08:46:59) On 25/07/2019 14:14, Chris Wilson wrote: +static int __live_remote_context(struct intel_engine_cs *engine, + struct i915_gem_context *fixme) +{ + struct intel_context *local,

Re: [Intel-gfx] [PATCH v6 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-07-29 Thread Philipp Zabel
On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Philipp Zabel regards Philipp > --- > drivers/gpu/drm/imx/imx-tve.c | 6 -- > 1 file changed, 4 insertions(+), 2 del

Re: [Intel-gfx] [PATCH v6 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-07-29 Thread Philipp Zabel
On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Philipp Zabel Thanks! regards Philipp > --- > drivers/gpu/drm/imx/imx-ldb.c | 7 --- > 1 file changed, 4 insertions

[Intel-gfx] [PATCH v2] drm/i915/selftests: Careful not to flush hang_fini on error setups

2019-07-29 Thread Chris Wilson
Smatch spotted that we test at the start of hang_fini for a valid (h->gt is only set after a request is created) but then used it regardless later on. v2: Alternatively, we do not need to check as we now always prime h->gt in hang_init() Fixes: cb823ed9915b ("drm/i915/gt: Use intel_gt as the prim

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: Fixup kerneldoc after params flipped

2019-07-29 Thread Patchwork
== Series Details == Series: drm/i915/uc: Fixup kerneldoc after params flipped URL : https://patchwork.freedesktop.org/series/64345/ State : success == Summary == CI Bug Log - changes from CI_DRM_6568_full -> Patchwork_13779_full Summary --

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-29 08:46:59) > > On 25/07/2019 14:14, Chris Wilson wrote: > > +static int __live_remote_context(struct intel_engine_cs *engine, > > + struct i915_gem_context *fixme) > > +{ > > + struct intel_context *local, *remote; > > + struct

  1   2   >