== Series Details ==
Series: Refactor to expand subslice mask
URL : https://patchwork.freedesktop.org/series/59742/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5954_full -> Patchwork_12839_full
Summary
---
**FAILUR
== Series Details ==
Series: Perma-pin uC firmware and re-enable global reset (rev2)
URL : https://patchwork.freedesktop.org/series/59255/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954_full -> Patchwork_12838_full
Summ
On Wed, 2019-04-17 at 15:37 -0700, José Roberto de Souza wrote:
> PSR registers are a mess, some have the full address while others just
> have the additional offset from psr_mmio_base.
>
> psr_mmio_base is nothing more than TRANSCODER_EDP_OFFSET + 0x800 and
> using it makes more difficult for peo
== Series Details ==
Series: drm/i915: Remove unwarranted clamping for hsw/bdw
URL : https://patchwork.freedesktop.org/series/59736/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954_full -> Patchwork_12837_full
Summary
--
On Fri, 19 Apr 2019 00:44:17 +0200 (CEST)
Thomas Gleixner wrote:
> On Thu, 18 Apr 2019, Steven Rostedt wrote:
> > On Thu, 18 Apr 2019 10:41:20 +0200
> > Thomas Gleixner wrote:
> >
> > > @@ -412,23 +404,20 @@ stack_trace_sysctl(struct ctl_table *tab
> > > void __user *buffer, size
== Series Details ==
Series: Refactor to expand subslice mask
URL : https://patchwork.freedesktop.org/series/59742/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954 -> Patchwork_12839
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Start some re-org around IRQ.
URL : https://patchwork.freedesktop.org/series/59735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954_full -> Patchwork_12836_full
Summary
---
**SUCCESS**
== Series Details ==
Series: Refactor to expand subslice mask
URL : https://patchwork.freedesktop.org/series/59742/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Use local variable for SSEU info in GETPARAM ioctl
Okay!
Commit: drm/i915: Add
== Series Details ==
Series: Refactor to expand subslice mask
URL : https://patchwork.freedesktop.org/series/59742/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c768f68e461e drm/i915: Use local variable for SSEU info in GETPARAM ioctl
d85bb21514db drm/i915: Add macro for SSEU
== Series Details ==
Series: Perma-pin uC firmware and re-enable global reset (rev2)
URL : https://patchwork.freedesktop.org/series/59255/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954 -> Patchwork_12838
Summary
--
Subslice stride and EU stride are calculated multiple times in
i915_query. Move this calculation to a macro to reduce code duplication.
Cc: Daniele Ceraolo Spurio
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/i915_query.c| 17 -
drivers/gpu/drm/i915/intel_device
Currently, the subslice_mask runtime parameter is stored as an
array of subslices per slice. Expand the subslice mask array to
better match what is presented to userspace through the
I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
then calculated:
slice * subslice stride + subslice i
Add a new function to return the number of subslices per slice to
consolidate code usage.
Cc: Daniele Ceraolo Spurio
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
drivers/gpu/drm/i915/intel_device_info.c | 4 ++--
drivers/gpu/drm/i915/intel_device_info.h | 6
In the GETPARAM ioctl handler, use a local variable to consolidate
usage of SSEU runtime info.
Cc: Daniele Ceraolo Spurio
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/i915_drv.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_d
This patch series contains a few code clean-up patches, followed
by a patch which changes the storage of the subslice mask to better
match the userspace access through the I915_QUERY_TOPOLOGY_INFO
ioctl. The index into the subslice_mask array is then calculated:
slice * subslice stride + subslice
On 4/18/19 4:31 PM, Fernando Pacheco wrote:
> The intent is to move the GuC and HuC firmware images to the
> top of the address space. This portion is inaccessible during
> normal GuC operations and should be relatively safe to house
> both firmware images. By making the move we can re-enable the
== Series Details ==
Series: Perma-pin uC firmware and re-enable global reset (rev2)
URL : https://patchwork.freedesktop.org/series/59255/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/uc: Rename uC firmware init/fini functions
Okay!
Commit:
GuC and HuC depend on struct_mutex for device
reinitialization. Moving away from this dependency
requires perma-pinning the firmware images in GGTT.
The upper portion of the GuC address space has
a sizeable hole (several MB) that is inaccessible
by GuC. Reserve this range within GGTT as it can
comf
The uC firmware init function is called during
GuC/HuC init early phases. Rename to include "_early"
and properly reflect which phase we are at.
The uC firmware fini function is cleaning up the
state set/created on firmware fetch. Replace
"_fini" with "_cleanup_fetch".
v2: also rename uC fw fini
The intent is to move the GuC and HuC firmware images to the
top of the address space. This portion is inaccessible during
normal GuC operations and should be relatively safe to house
both firmware images. By making the move we can re-enable the
full gpu reset with GuC enabled.
Placing the firmwar
GPU reset is now available with GuC enabled,
so re-enable our check that this reset is usable
from atomic context.
Signed-off-by: Fernando Pacheco
---
drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/s
This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8.
Signed-off-by: Fernando Pacheco
---
drivers/gpu/drm/i915/i915_reset.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reset.c
b/drivers/gpu/drm/i915/i915_reset.c
index 677d59304e78..1092d16c289c 100644
Currently we pin the GuC or HuC firmware image just
before uploading. Perma-pin during uC initialization
instead and use the range reserved at the top of the
address space.
Moving the firmware resulted in needing to:
- restore the ggtt mapping during the suspend/resume path.
- use an additional pi
== Series Details ==
Series: drm/i915: Fix skl+ max plane width
URL : https://patchwork.freedesktop.org/series/59734/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954_full -> Patchwork_12835_full
Summary
---
**SUCC
On Thu, Apr 18, 2019 at 10:15:55PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-04-18 21:53:41)
> > The plan is to consolidate all IRQ related stuff together
> > under the new intel_irq.
> >
> > So let's continue with RPS stuff.
>
> Nah, this is the wrong direction
you mean just this
On Thu, 18 Apr 2019, Steven Rostedt wrote:
> On Thu, 18 Apr 2019 10:41:20 +0200
> Thomas Gleixner wrote:
>
> > @@ -412,23 +404,20 @@ stack_trace_sysctl(struct ctl_table *tab
> >void __user *buffer, size_t *lenp,
> >loff_t *ppos)
> > {
> > - int ret;
> > + int
== Series Details ==
Series: drm/i915: Remove unwarranted clamping for hsw/bdw
URL : https://patchwork.freedesktop.org/series/59736/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954 -> Patchwork_12837
Summary
---
*
On Thu, 18 Apr 2019 10:41:20 +0200
Thomas Gleixner wrote:
> @@ -412,23 +404,20 @@ stack_trace_sysctl(struct ctl_table *tab
> void __user *buffer, size_t *lenp,
> loff_t *ppos)
> {
> - int ret;
> + int ret, was_enabled;
One small nit. Could this be:
On Thu, 18 Apr 2019 17:24:43 -0400
Steven Rostedt wrote:
> I believe it was for historical leftovers (there was a time it was
> required), and left there for "paranoid" sake. But let me apply the
> patch and see if it is really needed.
I removed the +1 on the max_entries and set SET_TRACE_ENTRIE
== Series Details ==
Series: Start some re-org around IRQ.
URL : https://patchwork.freedesktop.org/series/59735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954 -> Patchwork_12836
Summary
---
**SUCCESS**
No reg
== Series Details ==
Series: Start some re-org around IRQ.
URL : https://patchwork.freedesktop.org/series/59735/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Introduce intel_irq
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3616:16: warning
On Thu, 18 Apr 2019 23:14:45 +0200 (CEST)
Thomas Gleixner wrote:
> On Thu, 18 Apr 2019, Josh Poimboeuf wrote:
>
> > On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:
> > > - Remove the extra array member of stack_dump_trace[]. It's not required
> > > as
> > > the stack tracer
Quoting Rodrigo Vivi (2019-04-18 21:53:41)
> The plan is to consolidate all IRQ related stuff together
> under the new intel_irq.
>
> So let's continue with RPS stuff.
Nah, this is the wrong direction as we don't have to pull this under a
more global lock but push it under a local one. If you are
On Thu, 18 Apr 2019, Josh Poimboeuf wrote:
> On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:
> > - Remove the extra array member of stack_dump_trace[]. It's not required as
> > the stack tracer stores at max array size - 1 entries so there is still
> > an empty slot.
>
> What
Now that we are free from passing uncore around let's free ourselves
from passing the whole i915 reference and only passing the struct
with all information that we need for handling the interrupts.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_irq.c | 57 +
We always start off at an "efficient frequency" and can let the system
autotune from there, eliminating the need to clamp the available range.
Signed-off-by: Chris Wilson
Reviewed-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/intel_pm.c | 11 ++-
1 file changed, 2 insertions(+), 9 dele
Let's continue the migration starting from newer to old platforms.
The goal is to use intel_irq struct and intel_uncore_* functions
along all i915_irq.c as much as possible.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_irq.c | 36 ++---
1 file changed, 2
Another step towards the consolidation of all irq
related stuff under new intel_irq
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 14 ++---
drivers/gpu/drm/i915/i915_irq.c | 76 -
drivers/gpu/drm/i915/intel_ringbuffer.c | 16 +++---
3 f
== Series Details ==
Series: drm/i915: Fix skl+ max plane width
URL : https://patchwork.freedesktop.org/series/59734/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5954 -> Patchwork_12835
Summary
---
**SUCCESS**
N
Let's start the re-org of irqs with the introduction of intel_irq
structure.
Since irq_lock is used everywhere let's start intel_irq with
this lock first.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_debugfs.c| 8 +-
drivers/gpu/drm/i915/i915_drv.c| 6 +-
dr
Let's continue the IRQ consolidation with display_irqs_enabled.
Another possibility was a full split on gt_irq vs de_irq,
but for now display_irqs_enabled is already protected
buy the same lock. So, at least for now, let's keep
them together.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915
When playing with IRQ code here I noticed many IRQ stuff
are spreaded all around our code. So I'm starting the
organization by consolidating as much as possible on a
new intel_irq.
So we could use this intel_irq to pass around as argument
instead of dev_priv, i915 or uncore.
So, besides starting
The plan is to consolidate all IRQ related stuff together
under the new intel_irq.
So let's continue with RPS stuff.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 8 ++-
drivers/gpu/drm/i915/i915_irq.c | 41 ++---
2 files changed, 24 insertio
The plan is to convert most of arguments to use intel_irq
instead of intel_core or i915.
Note that dev_priv is not getting replaced by i915 because
the plan also include to move dev_priv to intel_irq.
The caveat is that we will need the uncore for tracking
the mmio region that we need, but at lea
Get all friends back together.
For gen8 gt_ prefix would be better than pm_ on them
since these regs include more stuff then PM, but let's
keep for legacy reasons.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
drivers/gpu/drm/i915/i915_irq.c | 30 +++
Hi,
Requesting to have the below changes-
The following changes since commit 260cb35b11a968e7896f911565b75e411636ad69:
Merge branch 'for-upstream' of git://git.chelsio.net/pub/git/linux-firmware
(2019-04-09 06:41:10 -0400)
are available in the Git repository at:
git://anongit.freedesktop.o
== Series Details ==
Series: drm/i915: Fix skl+ max plane width
URL : https://patchwork.freedesktop.org/series/59734/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7737cf4a3d6c drm/i915: Fix skl+ max plane width
-:64: CHECK:LINE_SPACING: Please don't use multiple blank lines
#6
Hi Steve,
On Thu, 2019-04-18 at 16:13 -0400, Steven Rostedt wrote:
> On Thu, 18 Apr 2019 14:58:55 -0500
> Tom Zanussi wrote:
>
> > > Tom,
> > >
> > > Can you review this too?
> >
> > Looks good to me too!
> >
> > Acked-by: Tom Zanussi
> >
>
> Would you be OK to upgrade this to a Reviewed
On Thu, 18 Apr 2019 14:58:55 -0500
Tom Zanussi wrote:
> > Tom,
> >
> > Can you review this too?
>
> Looks good to me too!
>
> Acked-by: Tom Zanussi
>
Would you be OK to upgrade this to a Reviewed-by tag?
Thanks!
-- Steve
___
Intel-gfx mailing
From: Ville Syrjälä
The spec has changed since skl_max_plane_width() was written.
Now the SKL limits are lower than what they were initially, and
GLK and ICL have different limits. Update the code to match the
spec.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 73 +++
On Thu, 2019-04-18 at 09:40 -0400, Steven Rostedt wrote:
> [ Added Tom Zanussi ]
>
> On Thu, 18 Apr 2019 10:41:39 +0200
> Thomas Gleixner wrote:
>
> > The indirection through struct stack_trace is not necessary at all.
> > Use the
> > storage array based interface.
> >
> > Signed-off-by: Thomas
== Series Details ==
Series: series starting with [1/2] drm/i915: Stop overwriting RING_IMR in rcs
resume
URL : https://patchwork.freedesktop.org/series/59713/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5953_full -> Patchwork_12834_full
On 04/18, Chris Wilson wrote:
> Quoting Rodrigo Siqueira (2019-04-18 15:01:49)
> > +bool kms_has_vblank(int fd)
> > +{
> > + drmVBlank dummy_vbl;
> > +
> > + memset(&dummy_vbl, 0, sizeof(drmVBlank));
> > + dummy_vbl.request.type = DRM_VBLANK_RELATIVE;
> > +
> > + drmWaitVBla
On Thu, 18 Apr 2019, Gwan-gyeong Mun wrote:
> The hotplug detection routine of drm_helper_hpd_irq_event() can detect
> changing of status of connector, but it can not detect changing of
> properties of the connector.
> e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
>
>
On Wed, 17 Apr 2019, "Souza, Jose" wrote:
> On Tue, 2019-04-16 at 11:28 +0300, Jani Nikula wrote:
>> The cdclk init/uninit code was changed by commit 93a643f29bcb
>> ("drm/i915/cdclk: have only one init/uninit function") between the
>> versions of commit 39564ae86d51 ("drm/i915/ehl: Inherit Ice La
== Series Details ==
Series: series starting with [1/2] drm/i915: Stop overwriting RING_IMR in rcs
resume
URL : https://patchwork.freedesktop.org/series/59713/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5953 -> Patchwork_12834
==
== Series Details ==
Series: series starting with [1/2] lib/igt_dummyload: Introduce igt_spin_reset
URL : https://patchwork.freedesktop.org/series/59717/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5953 -> IGTPW_2895
Summ
On Thu, 18 Apr 2019 17:43:59 +0200 (CEST)
Thomas Gleixner wrote:
> On Thu, 18 Apr 2019, Steven Rostedt wrote:
> > On Thu, 18 Apr 2019 10:41:40 +0200
> > Thomas Gleixner wrote:
> > > -static DEFINE_PER_CPU(struct ftrace_stack, ftrace_stack);
> > > +/* This allows 8 level nesting which is plenty
On Thu, 18 Apr 2019, Steven Rostedt wrote:
> On Thu, 18 Apr 2019 10:41:40 +0200
> Thomas Gleixner wrote:
> > -static DEFINE_PER_CPU(struct ftrace_stack, ftrace_stack);
> > +/* This allows 8 level nesting which is plenty */
>
> Can we make this 4 level nesting and increase the size? (I can see us
On Thu, 18 Apr 2019, Josh Poimboeuf wrote:
> On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote:
> > All architectures which support stacktrace carry duplicated code and
> > do the stack storage and filtering at the architecture side.
> >
> > Provide a consolidated interface with a c
Quoting Rodrigo Siqueira (2019-04-18 15:01:49)
> +bool kms_has_vblank(int fd)
> +{
> + drmVBlank dummy_vbl;
> +
> + memset(&dummy_vbl, 0, sizeof(drmVBlank));
> + dummy_vbl.request.type = DRM_VBLANK_RELATIVE;
> +
> + drmWaitVBlank(fd, &dummy_vbl);
> + return (errno != E
Quoting Tvrtko Ursulin (2019-04-18 16:08:58)
>
> On 18/04/2019 15:59, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-04-18 15:34:09)
> >>
> >> On 18/04/2019 14:27, Chris Wilson wrote:
> >>> We store the engine->imr mask and set up the RING_IMR register on
> >>> restarting the engine. We do n
On 18/04/2019 14:27, Chris Wilson wrote:
We need to set the various ring registers prior to restarting the
engine, or else we may restart it after reset/resume in an ill-defined
state.
Reported-by: Tvrtko Ursulin
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel
On 18/04/2019 15:59, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-04-18 15:34:09)
On 18/04/2019 14:27, Chris Wilson wrote:
We store the engine->imr mask and set up the RING_IMR register on
restarting the engine. We do not then want to overwrite it with
an incomplete mask later as we may t
Quoting Tvrtko Ursulin (2019-04-18 15:34:09)
>
> On 18/04/2019 14:27, Chris Wilson wrote:
> > We store the engine->imr mask and set up the RING_IMR register on
> > restarting the engine. We do not then want to overwrite it with
> > an incomplete mask later as we may then lose interrupts!
> >
> >
On Thu, 18 Apr 2019 10:41:40 +0200
Thomas Gleixner wrote:
> The per cpu stack trace buffer usage pattern is odd at best. The buffer has
> place for 512 stack trace entries on 64-bit and 1024 on 32-bit. When
> interrupts or exceptions nest after the per cpu buffer was acquired the
> stacktrace len
On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote:
> All architectures which support stacktrace carry duplicated code and
> do the stack storage and filtering at the architecture side.
>
> Provide a consolidated interface with a callback function for consuming the
> stack entries pro
From: Janusz Krzysztofik
The driver does not currently support unbinding from a device which is
in use. Since open file descriptors may still be pointing into kernel
memory where the device structures used to be, entirely correct kernel
panics protect the driver from being unbound as we should n
Use drm_dev_unplug() to have device resources protected from user access
by DRM layer as soon as the driver is going to be unbound.
Janusz Krzysztofik (1):
drm/i915: Use drm_dev_unplug()
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Since this patch sho
On 18/04/2019 14:27, Chris Wilson wrote:
We store the engine->imr mask and set up the RING_IMR register on
restarting the engine. We do not then want to overwrite it with
an incomplete mask later as we may then lose interrupts!
Reported-by: Tvrtko Ursulin
Signed-off-by: Chris Wilson
Cc: Tvrtk
== Series Details ==
Series: drm/i915: fix spelling mistake "resseting" -> "resetting"
URL : https://patchwork.freedesktop.org/series/59701/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952_full -> Patchwork_12832_full
Su
To simplify emitting the recursive batch, make batch
always the first object on the execbuf list.
v2: set handles early, poll_ptr indecency (Chris)
Cc: Chris Wilson
Signed-off-by: Mika Kuoppala
---
lib/igt_dummyload.c | 129
lib/igt_dummyload.h
Libify resetting a spin for reuse.
v2: use also in perf_pmu
Cc: Chris Wilson
Cc: Tvrtko Ursulin
Signed-off-by: Mika Kuoppala
---
lib/igt_dummyload.c | 20
lib/igt_dummyload.h | 2 ++
tests/i915/gem_exec_latency.c | 19 ---
tests/i915/g
== Series Details ==
Series: drm: Fire off KMS hotplug events if probe detect says the connector is
connected (rev2)
URL : https://patchwork.freedesktop.org/series/59691/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5952 -> Patchwork_12833
===
The kms_flip test relies on VBlank support, and this situation may
exclude some virtual drivers to take advantage of this set of tests.
This commit adds a mechanism that checks if a module has VBlank. If the
target module has VBlank support, kms_flip will run all the VBlank
tests; otherwise, the VB
On 4/17/2019 1:39 PM, Michal Wajdeczko wrote:
Today our most desired GuC configuration is to only enable HuC
if it is available and we really don't care about GuC submission.
Change platform default GuC mode to match our desire.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wi
On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:
> - Remove the extra array member of stack_dump_trace[]. It's not required as
> the stack tracer stores at max array size - 1 entries so there is still
> an empty slot.
What is the empty slot used for?
--
Josh
_
== Series Details ==
Series: HDCP2.2 Phase II (rev7)
URL : https://patchwork.freedesktop.org/series/57232/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952_full -> Patchwork_12831_full
Summary
---
**SUCCESS**
No
[ Added Tom Zanussi ]
On Thu, 18 Apr 2019 10:41:39 +0200
Thomas Gleixner wrote:
> The indirection through struct stack_trace is not necessary at all. Use the
> storage array based interface.
>
> Signed-off-by: Thomas Gleixner
> Cc: Steven Rostedt
Looks fine to me
Acked-by: Steven Rostedt (
On Thu, 18 Apr 2019 14:11:44 +0200
Alexander Potapenko wrote:
> On Thu, Apr 18, 2019 at 1:54 PM Thomas Gleixner wrote:
> >
> > On Thu, 18 Apr 2019, Alexander Potapenko wrote:
> > > On Thu, Apr 18, 2019 at 11:06 AM Thomas Gleixner
> > > wrote:
> > > > - save_stack_trace(&b->stack_trac
We need to set the various ring registers prior to restarting the
engine, or else we may restart it after reset/resume in an ill-defined
state.
Reported-by: Tvrtko Ursulin
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +
1 file changed, 1 in
We store the engine->imr mask and set up the RING_IMR register on
restarting the engine. We do not then want to overwrite it with
an incomplete mask later as we may then lose interrupts!
Reported-by: Tvrtko Ursulin
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_r
The hotplug detection routine of drm_helper_hpd_irq_event() can detect
changing of status of connector, but it can not detect changing of
properties of the connector.
e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
Following scenario explains one of them; A detection of
Quoting Chris Wilson (2019-04-18 14:07:49)
> Quoting Tvrtko Ursulin (2019-04-18 13:42:59)
> >
> > On 17/04/2019 08:56, Chris Wilson wrote:
> > > -static int init_render_ring(struct intel_engine_cs *engine)
> > > +static int rcs_resume(struct intel_engine_cs *engine)
> > > {
> > > struct dr
On Thu, 2019-04-18 at 10:28 +0200, Daniel Vetter wrote:
> On Thu, Apr 18, 2019 at 11:09:29AM +0300, Gwan-gyeong Mun wrote:
> > The hotplug detection routine of drm_helper_hpd_irq_event() can
> > detect
> > changing of status of connector, but it can not detect changing of
> > properties of the conn
== Series Details ==
Series: drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1 (rev2)
URL : https://patchwork.freedesktop.org/series/59494/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952_full -> Patchwork_12830_full
On Thu, Apr 18, 2019 at 09:13:04AM +0200, Daniel Vetter wrote:
> On Wed, Apr 17, 2019 at 02:57:31PM +0300, Ville Syrjälä wrote:
> > On Wed, Apr 17, 2019 at 09:28:19AM +0200, Daniel Vetter wrote:
> > > On Fri, Apr 12, 2019 at 03:50:56PM +0530, Uma Shankar wrote:
> > > > This series adds support for
Quoting Tvrtko Ursulin (2019-04-18 13:42:59)
>
> On 17/04/2019 08:56, Chris Wilson wrote:
> > +static bool switch_to_kernel_context(struct intel_engine_cs *engine)
> > +{
> > + struct i915_request *rq;
> > +
> > + /* Already inside the kernel context, safe to power down. */
> > + if (e
On 17/04/2019 08:56, Chris Wilson wrote:
In the current scheme, on submitting a request we take a single global
GEM wakeref, which trickles down to wake up all GT power domains. This
is undesirable as we would like to be able to localise our power
management to the available power domains and to
On 4/11/2019 4:44 PM, Michal Wajdeczko wrote:
This patch adds the support to load HuC on ICL.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Anusha Srivatsa
Cc: Tony Ye
---
drivers/gpu/drm/i915/intel_huc_fw.c | 12
1 file changed, 12 inser
On Wed, Apr 17, 2019 at 08:50:58PM -0700, Dhinakaran Pandiyan wrote:
> On Wed, 2019-04-17 at 15:37 -0700, José Roberto de Souza wrote:
> > Just moving it to reduce the tabs and avoid break code lines.
> > No behavior changes intended here.
> >
> > v2:
> > - Reading misc display IRQ outside of gen8
== Series Details ==
Series: series starting with [1/3] lib/igt_dummyload: libify checks for spin
batch activation (rev4)
URL : https://patchwork.freedesktop.org/series/59655/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952_full -> IGTPW_2891_full
=
== Series Details ==
Series: drm/i915: fix spelling mistake "resseting" -> "resetting"
URL : https://patchwork.freedesktop.org/series/59701/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952 -> Patchwork_12832
Summary
+ Jani and Rodrigo to comment
I'm definitely all for doing this, so it's only a matter of the timing.
Question is, do we want to do it right now after last drm-intel-next was
tagged, or do we want to wait a couple of release candidates.
I'm leaning towards doing this ASAP, as git cherry-pick sho
Hi,
First of all, thank you for your review.
I just have a few questions below.
On 04/10, Arkadiusz Hiler wrote:
> On Wed, Apr 03, 2019 at 07:24:39PM -0300, Rodrigo Siqueira wrote:
> > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a
> > similar code. Due to this similarity, th
On Thu, 18 Apr 2019, Mike Rapoport wrote:
> On Thu, Apr 18, 2019 at 10:41:22AM +0200, Thomas Gleixner wrote:
> >
> > -void depot_fetch_stack(depot_stack_handle_t handle, struct stack_trace
> > *trace)
> > +/**
> > + * stack_depot_fetch - Fetch stack entries from a depot
> > + *
>
> Nit: kernel-d
On Thu, 18 Apr 2019, Mike Rapoport wrote:
> On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote:
> > +/**
> > + * arch_stack_walk - Architecture specific function to walk the stack
> > +
>
> Nit: no '*' at line beginning makes kernel-doc unhappy
Oops.
> > + * @consume_entry: Callback
On Thu, 18 Apr 2019, Alexander Potapenko wrote:
> On Thu, Apr 18, 2019 at 11:06 AM Thomas Gleixner wrote:
> > - save_stack_trace(&b->stack_trace);
> > + b->stack_len = stack_trace_save(b->stack_entries, MAX_STACK, 2);
> As noted in one of similar patches before, can we have an inline
>
On Thu, 18 Apr 2019, Andrey Ryabinin wrote:
> On 4/18/19 11:41 AM, Thomas Gleixner wrote:
> > Replace the indirection through struct stack_trace by using the storage
> > array based interfaces.
> >
> > Signed-off-by: Thomas Gleixner
> > Acked-by: Dmitry Vyukov
> > Cc: Andrey Ryabinin
> > Cc: Al
== Series Details ==
Series: HDCP2.2 Phase II (rev7)
URL : https://patchwork.freedesktop.org/series/57232/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5952 -> Patchwork_12831
Summary
---
**SUCCESS**
No regressio
1 - 100 of 174 matches
Mail list logo
