[Intel-gfx] [PATCH 3/6] drm/i915: Propagating correct error codes to the userspace

2015-10-07 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Propagating correct error codes to userspace by using ERR_PTR and PTR_ERR macros for stolen memory based object allocation. We generally return -ENOMEM to the user whenever there is a failure in object allocation. This patch helps user to identify the correct reason for t

[Intel-gfx] [PATCH 2/6] drm/i915: Support for creating Stolen memory backed objects

2015-10-07 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memory, which if set, an attempt will be made to allocate the object from s

[Intel-gfx] [PATCH 1/6] drm/i915: Clearing buffer objects via CPU/GTT

2015-10-07 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from stolen region. v2: Added kernel doc for i915_gem_clear_object(), corre

[Intel-gfx] [PATCH 4/6] drm/i915: Add support for stealing purgable stolen pages

2015-10-07 Thread ankitprasad . r . sharma
From: Chris Wilson If we run out of stolen memory when trying to allocate an object, see if we can reap enough purgeable objects to free up enough contiguous free space for the allocation. This is in principle very much like evicting objects to free up enough contiguous space in the vma when bind

[Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-10-07 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing

[Intel-gfx] [PATCH v8 0/6] Support for creating/using Stolen memory backed objects

2015-10-07 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch series adds support for creating/using Stolen memory backed objects. Despite being a unified memory architecture (UMA) some bits of memory are more equal than others. In particular we have the thorny issue of stolen memory, memory stolen from the system by the

[Intel-gfx] [PATCH 5/6] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-10-07 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover prime objects as well as stolen memory backed objects but for userptr objects it is still forbidden. v2: D

[Intel-gfx] [v2] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os

2015-10-07 Thread Shobhit Kumar
Reuse what is programmed by pre-os, but in case there is no pre-os initialization, init the cdclk with the max value by default untill dynamic cdclk support comes. v2: Check if BIOS programmed correctly rather than always calling init - Do validation of programmed cdctl and what it is expected

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add DOC for i915_component

2015-10-07 Thread Yang, Libin
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Wednesday, October 07, 2015 9:39 PM > To: Yang, Libin > Cc: intel-gfx@lists.freedesktop.org; daniel.vet...@ffwll.ch; > jani.nik...@linux.intel.com; ville.syrj...@linux

[Intel-gfx] NUC5i7RYH compatibly

2015-10-07 Thread Annon Pong
Hi all, I recently purchased one of these NUCs to use as a general purpose server and stream some Steam games to my living room and need some help getting setup. I heard Ubuntu was what they developed Steam for Linux on, so I started by installing Ubuntu 15.04 and then tried the Intel Graphics Inst

[Intel-gfx] [PATCH] drm/i915: 4K audio N value incorrect at 29.97 and 23.98 refresh rate

2015-10-07 Thread clinton . a . taylor
From: Clint Taylor The TMDS_296M define was computing as 296704 but the mode->clock is 296700 as defined by EDID. Adjusted define to allow correct detection of the need to program the correct N value for 29.97 and 23.98 refresh rate. Signed-off-by: Clint Taylor --- drivers/gpu/drm/i915/intel_a

Re: [Intel-gfx] [PATCH] igt/kms_addfb_basic: New subtest to check for fb modifier and tiling mode mismatch

2015-10-07 Thread Vivek Kasireddy
Hi Tvrtko, On Wed, 7 Oct 2015 15:07:30 +0100 Tvrtko Ursulin wrote: > > Hi, > > On 07/10/15 03:35, Vivek Kasireddy wrote: > > This new subtest will validate a Y-tiled object's tiling mode > > against its associated fb modifier. > > > > Cc: Tvrtko Ursulin > > Signed-off-by: Vivek Kasireddy >

[Intel-gfx] [PATCH 2/2] drm/i915: Enable DPLL VGA mode before P1/P2 divider write

2015-10-07 Thread ville . syrjala
From: Ville Syrjälä Apparently writing the DPLL register P1/P2 divider fields won't trigger an actual change in the DPLL output unless VGA mode is enabled for prior to the register write that changes the P1/P2 dividers. The write with the new P1/P2 divider can itself disable VGA mode again withou

[Intel-gfx] [PATCH 1/2] drm/i915: Restore lost DPLL register write on gen2-4

2015-10-07 Thread ville . syrjala
From: Ville Syrjälä We accidentally lost the initial DPLL register write in 1c4e02746147 drm/i915: Fix DVO 2x clock enable on 830M The "three times for luck" hack probably saved us from a total disaster. But anyway, bring the initial write back so that the code actually makes some sense. Cc: st

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 02:50:34PM -0400, Nick Bowler wrote: > On 10/7/15, Ville Syrjälä wrote: > > On Wed, Oct 07, 2015 at 10:29:22AM -0400, Nick Bowler wrote: > >> On 10/7/15, Ville Syrjälä wrote: > >> > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: > >> >> On 9/24/15, Nick Bowle

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Nick Bowler
On 10/7/15, Ville Syrjälä wrote: > On Wed, Oct 07, 2015 at 10:29:22AM -0400, Nick Bowler wrote: >> On 10/7/15, Ville Syrjälä wrote: >> > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: >> >> On 9/24/15, Nick Bowler wrote: >> >> > Testing out 4.3-rc2, first thing I notice is that the

[Intel-gfx] [PATCH] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

2015-10-07 Thread Wayne Boyer
From: Chris Wilson A long time ago (before 3.14) we relied on a permanent pinning of the ifbdev to lock the fb in place inside the GGTT. However, the introduction of stealing the BIOS framebuffer and reusing its address in the GGTT for the fbdev has muddied waters and we use an inherited fb. Howe

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread Jesse Barnes
On 10/07/2015 10:17 AM, David Woodhouse wrote: > On Wed, 2015-10-07 at 09:28 -0700, Jesse Barnes wrote: >> On 10/07/2015 09:14 AM, Daniel Vetter wrote: >>> On Wed, Oct 07, 2015 at 08:16:42AM -0700, Jesse Barnes wrote: On 10/07/2015 06:00 AM, David Woodhouse wrote: > On Fri, 2015-09-04 at 0

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread David Woodhouse
On Wed, 2015-10-07 at 09:28 -0700, Jesse Barnes wrote: > On 10/07/2015 09:14 AM, Daniel Vetter wrote: > > On Wed, Oct 07, 2015 at 08:16:42AM -0700, Jesse Barnes wrote: > > > On 10/07/2015 06:00 AM, David Woodhouse wrote: > > > > On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote: > > > > > + > >

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread Jesse Barnes
On 10/07/2015 09:14 AM, Daniel Vetter wrote: > On Wed, Oct 07, 2015 at 08:16:42AM -0700, Jesse Barnes wrote: >> On 10/07/2015 06:00 AM, David Woodhouse wrote: >>> On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote: + + ret = handle_mm_fault(mm, vma, address, +

Re: [Intel-gfx] [PATCH i-g-t] lib/core: Fix docs for igt_assert_lt(e)

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 04:52:46PM +0100, Daniel Stone wrote: > Hi, > > On 2 October 2015 at 11:56, Daniel Vetter wrote: > > Logical negation is hard. > > > > Cc: "Morton, Derek J" > > Signed-off-by: Daniel Vetter > > Almost identical to what I had locally. > > s/second integers/second intege

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level

2015-10-07 Thread Chris Wilson
On Wed, Oct 07, 2015 at 04:57:25PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 06/10/15 11:39, Chris Wilson wrote: > >Since the remove of the pin-ioctl, we only care about not changing the > >cache level on buffers pinned to the hardware as indicated by > >obj->pin_display. So we can safely repla

Re: [Intel-gfx] periodic wakeup from DPMS suspend

2015-10-07 Thread Johannes Stezenbach
On Tue, Oct 06, 2015 at 11:04:53PM -0400, Alex Deucher wrote: > On Tue, Oct 6, 2015 at 11:10 AM, Johannes Stezenbach wrote: > > > > I have a NEC EA244WMi monitor connected to an Asus P8H77-V > > mainboard with Ivy Bridge Core i5-3550 via DVI. > > If DPMS suspend is enabled (by xscreensaver, or for

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Nick Bowler
On 10/7/15, Nick Bowler wrote: > On 10/7/15, Ville Syrjälä wrote: >> On Wed, Oct 07, 2015 at 10:29:22AM -0400, Nick Bowler wrote: >>> On 10/7/15, Ville Syrjälä wrote: >>> > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: >>> >> On 9/24/15, Nick Bowler wrote: >>> >> > Testing out 4.

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Nick Bowler
On 10/7/15, Ville Syrjälä wrote: > On Wed, Oct 07, 2015 at 10:29:22AM -0400, Nick Bowler wrote: >> On 10/7/15, Ville Syrjälä wrote: >> > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: >> >> On 9/24/15, Nick Bowler wrote: >> >> > Testing out 4.3-rc2, first thing I notice is that the

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Nick Bowler
On 10/7/15, Ville Syrjälä wrote: > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: >> On 9/24/15, Nick Bowler wrote: >> > Testing out 4.3-rc2, first thing I notice is that the VGA output is >> > not working. Specifically, the display is continuously powering on >> > and off -- at no

[Intel-gfx] periodic wakeup from DPMS suspend

2015-10-07 Thread Johannes Stezenbach
Hi, I have a NEC EA244WMi monitor connected to an Asus P8H77-V mainboard with Ivy Bridge Core i5-3550 via DVI. If DPMS suspend is enabled (by xscreensaver, or for testing by "xset dpms force off/suspend/standby"), the monitor enters standby mode but wakes up every 10...30 seconds for 6 seconds to

[Intel-gfx] [PULL] drm-intel-next

2015-10-07 Thread Daniel Vetter
Hi Dave, drm-intel-next-2015-09-28: - fastboot by default for some systems (Maarten Lankhorts) - piles of workarounds for bxt and skl - more fbc work from Paulo - fix hdmi hotplug detection (Sonika) - first few patches from Ville to parametrize register macros, prep work for typesafe mmio functi

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 08:16:42AM -0700, Jesse Barnes wrote: > On 10/07/2015 06:00 AM, David Woodhouse wrote: > > On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote: > >> + > >> + ret = handle_mm_fault(mm, vma, address, > >> + desc.wr_req ? FAULT_FLAG_WRITE : 0

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add the CPU mapping of the hw context to the pinned items.

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 03:52:03PM +0100, Nick Hoath wrote: > Pin the hw ctx mapping so that it is not mapped/unmapped per bb > when doing GuC submission. > > Issue: VIZ-4277 > Cc: David Gordon > Signed-off-by: Nick Hoath > --- > drivers/gpu/drm/i915/i915_debugfs.c | 14 -- > drivers/gp

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-07 Thread Chris Wilson
On Wed, Oct 07, 2015 at 06:03:48PM +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > > There is a desire to simplify the i915 driver by reducing the number of > > different code paths introduced by the LRC / execlists support. As the > > execlists request

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Improve dynamic management/eviction of lrc backing objects

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 03:52:02PM +0100, Nick Hoath wrote: > Shovel all context related objects through the active queue and obj > management. > > - Added callback in vma_(un)bind to add CPU (un)mapping at same time > if desired > - Inserted LRC hw context & ringbuf to vma active list > > Issu

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > There is a desire to simplify the i915 driver by reducing the number of > different code paths introduced by the LRC / execlists support. As the > execlists request is now part of the gem request it is possible and > desirable to unify

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level

2015-10-07 Thread Tvrtko Ursulin
Hi, On 06/10/15 11:39, Chris Wilson wrote: Since the remove of the pin-ioctl, we only care about not changing the cache level on buffers pinned to the hardware as indicated by obj->pin_display. So we can safely replace i915_gem_object_is_pinned() i915_gem_obj_is_pinned here with a plain obj

Re: [Intel-gfx] [PATCH i-g-t] lib/core: Fix docs for igt_assert_lt(e)

2015-10-07 Thread Daniel Stone
Hi, On 2 October 2015 at 11:56, Daniel Vetter wrote: > Logical negation is hard. > > Cc: "Morton, Derek J" > Signed-off-by: Daniel Vetter Almost identical to what I had locally. s/second integers/second integer/ and: Reviewed-by: Daniel Stone Cheers, Daniel _

Re: [Intel-gfx] [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 04:30:06PM +0200, Daniel Vetter wrote: > On Wed, Oct 07, 2015 at 04:27:24PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 07, 2015 at 11:17:45AM +0300, Jani Nikula wrote: > > > Signed-off-by: Jani Nikula > > > --- > > > drivers/gpu/drm/i915/i915_gem_gtt.c | 7 --- > > >

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 10:29:22AM -0400, Nick Bowler wrote: > On 10/7/15, Ville Syrjälä wrote: > > On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: > >> On 9/24/15, Nick Bowler wrote: > >> > Testing out 4.3-rc2, first thing I notice is that the VGA output is > >> > not working. Spec

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread Jesse Barnes
On 10/07/2015 06:00 AM, David Woodhouse wrote: > On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote: >> + >> + ret = handle_mm_fault(mm, vma, address, >> + desc.wr_req ? FAULT_FLAG_WRITE : 0); >> + if (ret & VM_FAULT_ERROR) { >> + gpu_mm_segv

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Hook up ring workaround writes at context creation time on Gen6-7.

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 02:44:02PM +0300, Francisco Jerez wrote: > intel_rcs_ctx_init() emits all workaround register writes on the list > to the ring, in addition to calling i915_gem_render_state_init(). The > workaround list is currently empty on Gen6-7 so this shouldn't cause > any functional c

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Don't warn if the workaround list is empty.

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 02:44:01PM +0300, Francisco Jerez wrote: > It's not an error for the workaround list to be empty if no > workarounds are needed. This will avoid spamming the logs > unnecessarily on Gen6 after the workaround list is hooked up on > pre-Gen8 hardware by the following commits.

Re: [Intel-gfx] [PATCH 1/5] drm/i915/kbl: Add Kabylake PCI ID

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 03:55:31PM +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 05:31:30PM +, Vivi, Rodrigo wrote: > > On Tue, 2015-10-06 at 12:09 +0300, Jani Nikula wrote: > > > On Tue, 06 Oct 2015, Rodrigo Vivi wrote: > > > > From: Deepak S > > > > > > > > v2: separate out device

Re: [Intel-gfx] [PATCH] drm/i915: Resurrect golden context on gen6/7

2015-10-07 Thread Daniel Vetter
On Thu, Oct 01, 2015 at 07:13:11PM +0300, Francisco Jerez wrote: > Daniel Vetter writes: > > > In > > > > commit 8f0e2b9d95a88ca5d8349deef2375644faf184ae > > Author: Daniel Vetter > > Date: Tue Dec 2 16:19:07 2014 +0100 > > > > drm/i915: Move golden context init into ->init_context > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Set mode->crtc_clock during hardware state readout

2015-10-07 Thread Matt Roper
On Wed, Oct 07, 2015 at 04:26:03PM +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 09:26:31AM -0700, Matt Roper wrote: > > intel_mode_from_pipe_config() fills in a mode structure from the CRTC > > state that was read out of the hardware, but does not set the > > .crtc_clock field (it only set

Re: [Intel-gfx] [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 04:28:48PM +0300, Ville Syrjälä wrote: > On Wed, Oct 07, 2015 at 11:17:46AM +0300, Jani Nikula wrote: > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/intel_pm.c | 55 > > + > > 1 file changed, 22 insertions(+), 33 de

Re: [Intel-gfx] [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 04:27:24PM +0300, Ville Syrjälä wrote: > On Wed, Oct 07, 2015 at 11:17:45AM +0300, Jani Nikula wrote: > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/i915_gem_gtt.c | 7 --- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH] drm/i915: Set mode->crtc_clock during hardware state readout

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 09:26:31AM -0700, Matt Roper wrote: > intel_mode_from_pipe_config() fills in a mode structure from the CRTC > state that was read out of the hardware, but does not set the > .crtc_clock field (it only sets the .clock). This causes the subsequent > call to drm_calc_timestamp

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 05:26:48PM +0300, Mika Kuoppala wrote: > From: Mika Kuoppala > > Rewrite everything in mmio workaround list right after > gpu reset. This ensures that we start the reinitialization > with proper mmio workarounds in place, before we > start the rings. > > This commit just

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 04:52:54PM +0300, Ville Syrjälä wrote: > On Wed, Oct 07, 2015 at 09:43:07AM +0100, Chris Wilson wrote: > > On Tue, Oct 06, 2015 at 05:26:48PM +0300, Mika Kuoppala wrote: > > > @@ -6973,8 +6989,12 @@ void intel_init_clock_gating(struct drm_device > > > *dev) > > > { > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/skl: Allow universal planes to position

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 07:28:10PM +0300, Ville Syrjälä wrote: > On Tue, Oct 06, 2015 at 08:16:19AM -0700, Matt Roper wrote: > > On Tue, Oct 06, 2015 at 05:42:42PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 06, 2015 at 07:29:54AM -0700, Matt Roper wrote: > > > > On Tue, Oct 06, 2015 at 02:32:47P

Re: [Intel-gfx] [PATCH] igt/kms_addfb_basic: New subtest to check for fb modifier and tiling mode mismatch

2015-10-07 Thread Tvrtko Ursulin
Hi, On 07/10/15 03:35, Vivek Kasireddy wrote: This new subtest will validate a Y-tiled object's tiling mode against its associated fb modifier. Cc: Tvrtko Ursulin Signed-off-by: Vivek Kasireddy --- tests/kms_addfb_basic.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/

Re: [Intel-gfx] [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 04:35:51PM +0300, Imre Deak wrote: > On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote: > > On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote: > > > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote: > > > > From: Akash Goel > > > > > > > > Signed-off-b

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Kill DRI1 cliprects

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 04:37:13PM +0100, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 03:19:36PM +0100, Tvrtko Ursulin wrote: > > > > On 06/10/15 11:39, Chris Wilson wrote: > > >Passing cliprects into the kernel for it to re-execute the batch buffer > > >with different CMD_DRAWRECT died out long

Re: [Intel-gfx] [PATCH 1/5] drm/i915/kbl: Add Kabylake PCI ID

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 05:31:30PM +, Vivi, Rodrigo wrote: > On Tue, 2015-10-06 at 12:09 +0300, Jani Nikula wrote: > > On Tue, 06 Oct 2015, Rodrigo Vivi wrote: > > > From: Deepak S > > > > > > v2: separate out device info into different GT (Damien) > > > v3: Add is_kabylake to the KBL gt3 st

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 09:43:07AM +0100, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 05:26:48PM +0300, Mika Kuoppala wrote: > > @@ -6973,8 +6989,12 @@ void intel_init_clock_gating(struct drm_device *dev) > > { > > struct drm_i915_private *dev_priv = dev->dev_private; > > > > + intel_wa_

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Avoid GPU stalls from kswapd

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 02:18:34PM +0100, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 03:01:45PM +0200, Daniel Vetter wrote: > > On Thu, Oct 01, 2015 at 12:18:29PM +0100, Chris Wilson wrote: > > > Exclude active GPU pages from the purview of the background shrinker > > > (kswapd), as these cause

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Add a tracepoint for the shrinker

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 02:16:56PM +0100, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 02:54:25PM +0200, Daniel Vetter wrote: > > On Thu, Oct 01, 2015 at 12:18:26PM +0100, Chris Wilson wrote: > > > Often it is very useful to know why we suddenly purge vast tracts of > > > memory and surprisingly u

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add DOC for i915_component

2015-10-07 Thread Daniel Vetter
On Wed, Oct 07, 2015 at 07:47:09AM +, Yang, Libin wrote: > Hi all, > > Any comments? Thanks. Was simply held up with some merge ordering troubles, I had to wait for Takashi to apply the last patch so I could do a backmerge. And then I forget about your patch series, thanks a lot for the remin

Re: [Intel-gfx] [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us

2015-10-07 Thread Imre Deak
On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote: > > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote: > > > From: Akash Goel > > > > > > Signed-off-by: Ankitprasad Sharma > > > Signed-off-by: Akash Goel > > > Signed-of

Re: [Intel-gfx] [PATCH v2] drm/i915: set proper N/CTS in modeset

2015-10-07 Thread Daniel Vetter
On Fri, Sep 25, 2015 at 10:11 AM, Takashi Iwai wrote: > On Fri, 25 Sep 2015 10:01:48 +0200, > Jani Nikula wrote: >> >> On Fri, 25 Sep 2015, libin.y...@intel.com wrote: >> > From: Libin Yang >> > >> > When modeset occurs and the TMDS frequency is set to some >> > speical values, the N/CTS need to

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Implement L3 partitioning set-up from the workaround list.

2015-10-07 Thread Francisco Jerez
Chris Wilson writes: > On Wed, Oct 07, 2015 at 02:44:00PM +0300, Francisco Jerez wrote: >> This programs the L3 configuration based on the sizes given for each >> partition as arguments. The relevant register writes are added to the >> workaround list so that they are re-applied to each context

Re: [Intel-gfx] [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 11:17:46AM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_pm.c | 55 > + > 1 file changed, 22 insertions(+), 33 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/

Re: [Intel-gfx] [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 11:17:45AM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 620d57e2526b..

Re: [Intel-gfx] [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote: > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote: > > From: Akash Goel > > > > Signed-off-by: Ankitprasad Sharma > > Signed-off-by: Akash Goel > > Signed-off-by: Sagar Arun Kamble > > The comment about units in gen6_set_rps

Re: [Intel-gfx] [PATCH 1/3] drm/i915/snb: remove pre-production hardware workaround

2015-10-07 Thread Ville Syrjälä
On Wed, Oct 07, 2015 at 11:17:44AM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_gem.c | 18 +- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index

Re: [Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-10-07 Thread David Woodhouse
On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote: > + > + ret = handle_mm_fault(mm, vma, address, > + desc.wr_req ? FAULT_FLAG_WRITE : 0); > + if (ret & VM_FAULT_ERROR) { > + gpu_mm_segv(tsk, address, SEGV_ACCERR); /* ? */ > +

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Implement L3 partitioning set-up from the workaround list.

2015-10-07 Thread Chris Wilson
On Wed, Oct 07, 2015 at 02:44:00PM +0300, Francisco Jerez wrote: > This programs the L3 configuration based on the sizes given for each > partition as arguments. The relevant register writes are added to the > workaround list so that they are re-applied to each context while it's > initialized, pr

Re: [Intel-gfx] [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip

2015-10-07 Thread Tvrtko Ursulin
On 07/10/15 13:10, Jindal, Sonika wrote: On 10/7/2015 3:31 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Previously rotation was ignored and wrong stride programmed into the plane registers resulting in a corrupt image on screen. Signed-off-by: Tvrtko Ursulin Cc: Sonika Jindal --- dri

Re: [Intel-gfx] [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip

2015-10-07 Thread Jindal, Sonika
On 10/7/2015 3:31 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Previously rotation was ignored and wrong stride programmed into the plane registers resulting in a corrupt image on screen. Signed-off-by: Tvrtko Ursulin Cc: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c | 16

Re: [Intel-gfx] [PATCH] drm: Check fb against plane size rather than CRTC mode for pageflip

2015-10-07 Thread Ville Syrjälä
On Tue, Oct 06, 2015 at 05:02:47PM -0700, Matt Roper wrote: > The legacy pageflip ioctl calls drm_crtc_check_viewport() to determine > whether the framebuffer being flipped is big enough to fill the display > it is being flipped to. However some drivers support "windowing" of > their primary plane

Re: [Intel-gfx] PROBLEM: Intel VGA output busticated on 4.3-rc2 (regression)

2015-10-07 Thread Ville Syrjälä
On Tue, Oct 06, 2015 at 11:42:33AM -0400, Nick Bowler wrote: > Hi, > > This issue is still present in 4.3-rc4. > > On 9/24/15, Nick Bowler wrote: > > Testing out 4.3-rc2, first thing I notice is that the VGA output is > > not working. Specifically, the display is continuously powering on > > an

[Intel-gfx] [PATCH 4/6] drm/i915: Program the L3 configuration to hardware defaults on context init.

2015-10-07 Thread Francisco Jerez
Use init_l3_partitioning_workarounds() to set up the L3 partitioning on context creation according to the hardware boot-up defaults for each device. Signed-off-by: Francisco Jerez --- drivers/gpu/drm/i915/intel_ringbuffer.c | 53 +++-- 1 file changed, 51 insertions(+)

[Intel-gfx] [PATCH 1/6] drm/i915: Implement L3 partitioning set-up from the workaround list.

2015-10-07 Thread Francisco Jerez
This programs the L3 configuration based on the sizes given for each partition as arguments. The relevant register writes are added to the workaround list so that they are re-applied to each context while it's initialized, preventing state leaks from other userspace processes which may have modifi

[Intel-gfx] [PATCH 5/6] drm/i915/hsw: Move L3 atomics workaround to the workaround list.

2015-10-07 Thread Francisco Jerez
This makes sure that the workaround is not accidentally undone by some process (which is possible because the HSW_SCRATCH1 and HSW_ROW_CHICKEN3 registers are partially whitelisted), what could cause the next context to be created to hang if it wasn't expecting L3 atomics to be enabled. Signed-off-

[Intel-gfx] [PATCH 6/6] drm/i915/vlv: Remove WaIncreaseL3CreditsForVLVB0 from init_clock_gating.

2015-10-07 Thread Francisco Jerez
The same work-arond is applied per-context in init_l3_partitioning_workarounds(), so the direct MMIO write of GEN7_L3SQCREG1 should be redundant now. Applying the work-around at context creation time also makes sure that the MMIO writes are not accidentally undone by userspace. Signed-off-by: Fra

[Intel-gfx] [PATCH 3/6] drm/i915: Hook up ring workaround writes at context creation time on Gen6-7.

2015-10-07 Thread Francisco Jerez
intel_rcs_ctx_init() emits all workaround register writes on the list to the ring, in addition to calling i915_gem_render_state_init(). The workaround list is currently empty on Gen6-7 so this shouldn't cause any functional changes. Signed-off-by: Francisco Jerez --- This is based on top of Dani

[Intel-gfx] [PATCH 2/6] drm/i915: Don't warn if the workaround list is empty.

2015-10-07 Thread Francisco Jerez
It's not an error for the workaround list to be empty if no workarounds are needed. This will avoid spamming the logs unnecessarily on Gen6 after the workaround list is hooked up on pre-Gen8 hardware by the following commits. Signed-off-by: Francisco Jerez --- drivers/gpu/drm/i915/intel_ringbuf

[Intel-gfx] [PATCH v2 i-g-t] kms_rotation_crc: Exercise page flips with 90 degree rotation

2015-10-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Do some page flipping on the rotated plane just to exercise that code path. v2: Actually render to flip fb and fixed flip counter. Signed-off-by: Tvrtko Ursulin Cc: Sonika Jindal Cc: Arun R Murthy --- tests/kms_rotation_crc.c | 90 +++

Re: [Intel-gfx] [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip

2015-10-07 Thread kbuild test robot
Hi Tvrtko, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-x013-201540 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/g

Re: [Intel-gfx] [PATCH 1/3] drm: Track drm_mm nodes with an interval tree

2015-10-07 Thread David Herrmann
Hi On Tue, Oct 6, 2015 at 1:19 PM, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 01:11:56PM +0200, Daniel Vetter wrote: >> On Tue, Oct 06, 2015 at 11:53:09AM +0100, Chris Wilson wrote: >> > In addition to the last-in/first-out stack for accessing drm_mm nodes, >> > we occasionally and in the futu

[Intel-gfx] [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip

2015-10-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Previously rotation was ignored and wrong stride programmed into the plane registers resulting in a corrupt image on screen. Signed-off-by: Tvrtko Ursulin Cc: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c | 16 1 file changed, 12 insertions(+), 4

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset

2015-10-07 Thread Chris Wilson
On Tue, Oct 06, 2015 at 05:26:48PM +0300, Mika Kuoppala wrote: > @@ -6973,8 +6989,12 @@ void intel_init_clock_gating(struct drm_device *dev) > { > struct drm_i915_private *dev_priv = dev->dev_private; > > + intel_wa_init(&dev_priv->mmio_workarounds); > + > if (dev_priv->display.i

Re: [Intel-gfx] [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds

2015-10-07 Thread kbuild test robot
Hi Jani, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-x006-201540 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): driver

Re: [Intel-gfx] [PATCH 2/3] drm/i915/bxt: add revision id for A1 stepping and use it

2015-10-07 Thread Jani Nikula
On Tue, 06 Oct 2015, Ville Syrjälä wrote: > On Tue, Oct 06, 2015 at 04:43:11PM +0300, Jani Nikula wrote: >> On Tue, 06 Oct 2015, Ville Syrjälä wrote: >> > On Tue, Oct 06, 2015 at 02:41:15PM +0300, Jani Nikula wrote: >> >> Prefer inclusive ranges for revision checks rather than "below B0". Per >>

[Intel-gfx] [PATCH 1/3] drm/i915/snb: remove pre-production hardware workaround

2015-10-07 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 52642aff1dab..1e67484fd5dc 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++

[Intel-gfx] [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround

2015-10-07 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 620d57e2526b..4e328f71a454 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/g

[Intel-gfx] [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds

2015-10-07 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_pm.c | 55 + 1 file changed, 22 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 60d120c472ab..598ee4c8d86e 100644 --- a/drivers/gp

Re: [Intel-gfx] [DMC_REDESIGN_V2 07/14] drm/i915/gen9: Simplify csr loading failure printing.

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 12:38:00PM -0700, Marc Herbert wrote: > On 30/09/15 07:28, Imre Deak wrote: > >On ke, 2015-08-26 at 16:58 +0530, Animesh Manna wrote: > >> > >>-void i915_firmware_load_error_print(const char *fw_path, int err) > >>-{ > >>- DRM_ERROR("failed to load firmware %s (%d)\n", fw_

Re: [Intel-gfx] [PATCH 3/5] drm/i915/kbl: Kabylake A0 is based on Skylake H0.

2015-10-07 Thread Jani Nikula
On Wed, 07 Oct 2015, Ben Widawsky wrote: > On Tue, Oct 06, 2015 at 08:51:13PM +, Rodrigo Vivi wrote: >> cc'ing Ben to get his opinion... >> > > Of course anything is possible wrt the delta of KBL features vs SKL. With the > knowledge we have, we can make a pretty educated guess that there wil

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add DOC for i915_component

2015-10-07 Thread Yang, Libin
Hi all, Any comments? Thanks. Regards, Libin > -Original Message- > From: Yang, Libin > Sent: Thursday, October 01, 2015 5:01 PM > To: intel-gfx@lists.freedesktop.org; daniel.vet...@ffwll.ch; > jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com > Cc: Yang, Libin > Subject: [PATCH