Re: [Intel-gfx] [PATCH] drm/i915/chv: Use 16 and 32 for low and high drain latency precision.

2014-10-21 Thread Ville Syrjälä
On Fri, Oct 17, 2014 at 08:05:08AM -0700, Rodrigo Vivi wrote: > Current chv spec teels we can only use either 16 or 32 bits as precision. > > Although in the past VLV went from 16/32 to 32/64 and spec might not be > updated, > these precision values brings stability and fixes some issues Wayne wa

[Intel-gfx] [RFC] drm: Add utility function to check for edp1.4

2014-10-21 Thread sonika . jindal
From: Sonika Jindal v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_CAPABLE field is set (Satheesh) v3: Moving the utility function to drm_dp_helper (Daniel) Signed-off-by: Sonika Jindal --- drivers/gpu/drm/drm_dp_helper.c | 15 +++ include/drm/drm_dp_helper.h |2 ++

[Intel-gfx] tile group support (v2)

2014-10-21 Thread Dave Airlie
This is just a second round of the previous series, cleaned up the problems pointed out (except property hotplug - bigger problem), Dave. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/6] drm/mst: cached EDID for logical ports

2014-10-21 Thread Dave Airlie
From: Dave Airlie Logical ports are never going to have EDID changes, they are used for the internal ports on MST monitors. We cache the EDIDs from these to save time at MST probe. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_dp_mst_topology.c | 20 ++-- drivers/gpu/drm/

[Intel-gfx] [PATCH 2/6] drm: add tile_group support. (v2)

2014-10-21 Thread Dave Airlie
From: Dave Airlie A tile group is an identifier shared by a single monitor, DisplayID topology has 8 bytes we can use for this, just use those for now until something else comes up in the future. We assign these to an idr and use the idr to tell userspace what connectors are in the same tile grou

[Intel-gfx] [PATCH 1/6] drm/displayid: add displayid defines and edid extension (v2)

2014-10-21 Thread Dave Airlie
From: Dave Airlie These are just taken from the DisplayID v1.3 spec, and the DDC spec. v2: use __packed (Jani) Signed-off-by: Dave Airlie --- include/drm/drm_displayid.h | 76 + include/drm/drm_edid.h | 2 ++ 2 files changed, 78 insertions(+)

[Intel-gfx] [PATCH 5/6] drm/tile: expose the tile property to userspace (v2)

2014-10-21 Thread Dave Airlie
From: Dave Airlie This takes the tiling info from the connector and exposes it to userspace, as a blob object in a connector property. The contents of the blob is ABI. v2: add property + function documentation. Signed-off-by: Dave Airlie --- Documentation/DocBook/drm.tmpl | 9 +++-

[Intel-gfx] [PATCH 4/6] drm/connector: store tile information from displayid (v2)

2014-10-21 Thread Dave Airlie
From: Dave Airlie This creates a tile group from DisplayID block, and stores the pieces of parsed info from the DisplayID block into the connector. v2: add missing signoff, add new connector bits to docs. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_crtc.c | 5 ++ drivers/gpu/drm/drm_

[Intel-gfx] [PATCH 6/6] drm/fb: add support for tiled monitor configurations.

2014-10-21 Thread Dave Airlie
From: Dave Airlie This adds fbdev/con support for tiled monitors, so that we only set a mode on the correct half of the monitor, or span the two halves if needed. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_fb_helper.c| 122 +++-- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/6] drm: add tile_group support.

2014-10-21 Thread Dave Airlie
> Don't you need a kref_get_unless_zero here since we only destroy the idr > entry after the refcount dropped to zero? Or is there some magic thing > that prevents this like another mutex (in which case some mutex assert in > get/put would be good)? This does all happen under mode_config.mutex but

[Intel-gfx] [PATCH] drm/mode: document path property and function to set it.

2014-10-21 Thread Dave Airlie
From: Dave Airlie These two didn't get documented properly, do so. Pointed out by Daniel. Signed-off-by: Dave Airlie --- Documentation/DocBook/drm.tmpl | 9 - drivers/gpu/drm/drm_crtc.c | 10 ++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/Documentation/

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Make intel_pipe_has_type() and

2014-10-21 Thread He, Shuang
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, October 21, 2014 4:29 AM > To: He, Shuang > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander > Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Make intel_pi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ignore long hpds on eDP ports

2014-10-21 Thread Dave Airlie
> Aside: We don't handle hpd for port A anyway, so for most panels this > doesn't matter all that much. Or we'd have piles more bug reports I think. > https://bugzilla.redhat.com/show_bug.cgi?id=1118448 probably like this. Dave. ___ Intel-gfx mailing l

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items in

2014-10-21 Thread He, Shuang
> -Original Message- > From: Daniel, Thomas > Sent: Tuesday, October 21, 2014 8:46 PM > To: Daniel Vetter; He, Shuang > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items > in > > > > > -Original Message- > > From:

[Intel-gfx] [PATCH 7/8] drm/i915: Remove crtc_mode_set() hook

2014-10-21 Thread Ander Conselvan de Oliveira
There's no users left after the conversion to calculate clocks before disabling crtcs during mode set. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 3 --- drivers/gpu/drm/i915/intel_display.c | 11 --- 2 files changed, 14 deletions(-) diff --gi

[Intel-gfx] [PATCH 8/8] drm/i915: Don't store current shared DPLL in the new pipe_config

2014-10-21 Thread Ander Conselvan de Oliveira
Now that shared DPLLs configuration is staged, there's no need to track the current ones in the new pipe_config since those are released before making the new pipe_config effective. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 8 1 file changed,

Re: [Intel-gfx] [PATCH 07/16] drm/i915: fix S4 suspend while switcheroo state is off

2014-10-21 Thread Imre Deak
On Tue, 2014-10-21 at 15:41 +0300, Ville Syrjälä wrote: > On Wed, Sep 10, 2014 at 06:17:00PM +0300, Imre Deak wrote: > > If the device is suspended already through the switcheroo interface we > > shouldn't suspend it again. We have the corresponding check for S3 > > suspend already, add it for S4 f

Re: [Intel-gfx] [PATCH 07/16] drm/i915: fix S4 suspend while switcheroo state is off

2014-10-21 Thread Ville Syrjälä
On Tue, Oct 21, 2014 at 04:08:21PM +0300, Imre Deak wrote: > On Tue, 2014-10-21 at 15:41 +0300, Ville Syrjälä wrote: > > On Wed, Sep 10, 2014 at 06:17:00PM +0300, Imre Deak wrote: > > > If the device is suspended already through the switcheroo interface we > > > shouldn't suspend it again. We have

Re: [Intel-gfx] [PULL] drm-intel-next

2014-10-21 Thread Dave Airlie
On 21 October 2014 23:38, Daniel Vetter wrote: > Hi Dave, > > drm-intel-next-2014-10-03: > - first batch of skl stage 1 enabling > - fixes from Rodrigo to the PSR, fbc and sink crc code > - kerneldoc for the frontbuffer tracking code, runtime pm code and the basic > interrupt enable/disable func

Re: [Intel-gfx] [PATCH] drm/i915/chv: Use 16 and 32 for low and high drain latency precision.

2014-10-21 Thread Boyer, Wayne
Tested-by: Wayne Boyer Before this patch I was getting pipe underrun errors on pipe A and pipe C when running various workloads. Shortly after the errors, the screens would go black and could not be recovered without rebooting. With this patch I don't get the underrun errors and the machine has

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Build workaround list in ring initialization

2014-10-21 Thread Mika Kuoppala
Mika Kuoppala writes: > If we build the workaround list in ring initialization > and decouple it from the actual writing of values, we > gain the ability to decide where and how we want to apply > the values. > > The advantage of this will become more clear when > we need to initialize workaround

[Intel-gfx] [PATCH 5/8] drm/i915: Covert ILK-IVB to choose DPLLS before disabling CRTCs

2014-10-21 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 610de3f..9475271 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH] lib: fix #define max

2014-10-21 Thread Mika Kuoppala
Regression from: commit be4710a541b517b5f8663448bffed5656d59b47b Author: Thomas Wood Date: Fri Oct 10 11:20:35 2014 +0100 lib: add common min and max macros Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85218 Tested-by: Guo Jinxian Signed-off-by: Mika Kuoppala --- lib/igt_aux.

[Intel-gfx] [PATCH 0/8] Stage shared dpll config

2014-10-21 Thread Ander Conselvan de Oliveira
This series changes the mode set sequence so that the clock and PLL logic that was done in the *_crtc_mode_set() hooks is done before disabling crtcs. This avoids having to restore the old configuration in the case of failure, since the hardware was never touched. Ander Conselvan de Oliveira (8):

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-10-21 Thread Ville Syrjälä
On Thu, Sep 11, 2014 at 07:15:27AM -0700, Jesse Barnes wrote: > On Thu, 11 Sep 2014 14:59:35 +0300 > Imre Deak wrote: > > > On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: > > > On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: > > > > Since correctness wins over optimal code and

[Intel-gfx] [PATCH 2/8] drm/i915: Move dpll crtc_mask and hw_state fields into separate struct

2014-10-21 Thread Ander Conselvan de Oliveira
The new struct will be used in a follow up patch to allow a current and a staged config to exist for the same shared DPLL. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_debugfs.c | 13 drivers/gpu/drm/i915/i915_drv.h | 8 +++-- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH] tests/gem_workarounds: adapt to constant wa list from driver

2014-10-21 Thread Mika Kuoppala
Read and verify workaround list before and after the reset/resume. In addition wait for the gpu before reading through mmio, so that the rc context gets properly loaded before we read. Cc: Arun Siluvery Signed-off-by: Mika Kuoppala --- tests/gem_workarounds.c | 127 ++---

Re: [Intel-gfx] [PATCH 16/16] drm/i915: add comments on what stage a given PM handler is called

2014-10-21 Thread Imre Deak
On Tue, 2014-10-21 at 16:42 +0300, Ville Syrjälä wrote: > On Wed, Sep 10, 2014 at 06:17:09PM +0300, Imre Deak wrote: > > This will hopefully make it easier to navigate the code without the need > > to consult the full PM documentation. > > > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 16/16] drm/i915: add comments on what stage a given PM handler is called

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:17:09PM +0300, Imre Deak wrote: > This will hopefully make it easier to navigate the code without the need > to consult the full PM documentation. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 13 + > 1 file changed, 13 insertions(+

Re: [Intel-gfx] [PATCH 14/16] drm/i915: add poweroff_late handler

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:17:07PM +0300, Imre Deak wrote: > The suspend_late handler saves some registers and powers off the device, > so it doesn't have a big overhead. Calling it at S4 poweroff_late time > makes the power off handling identical to the S3 suspend and S4 freeze > handling, so do t

Re: [Intel-gfx] [PATCH 00/16] fix VLV S4 suspend/resume, unify S3/S4 handlers

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:16:53PM +0300, Imre Deak wrote: > The first part of the patchset (1-6) fixes an S4 bug on VLV introduced > recently. The rest unifies the various S3/S4 handlers, which are in > practice the same. The only real difference - besides some unused code - > is that during S3 su

Re: [Intel-gfx] [PATCH] drm/i915: add runtime PM get/put call in i915_execlists

2014-10-21 Thread Daniel Vetter
On Thu, Oct 16, 2014 at 04:13:38PM +0100, Michel Thierry wrote: > Otherwise we will get WARNs when we read context status registers and > the machine is suspended. > > Testcase: igt/pm_rpm/debugfs-read > Signed-off-by: Michel Thierry Queued for -next, thanks for the patch. -Daniel -- Daniel Vet

Re: [Intel-gfx] [PATCH] lib/igt_aux: move audio RPM code to igt_setup_runtime_pm()

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 03:01:49PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we don't enable audio runtime PM, the audio driver won't release > its reference, the refcount won't ever become zero, so we will never > actually runtime suspend. So move this code from pm_rpm.c to > igt_au

Re: [Intel-gfx] [PATCH] drm/i915: add missing forcewake put on i915_wa_registers()

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 02:58:08PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Otherwise, a simple "cat" to the debugfs file can make the machine use > much more power than needed, and prevent it from runtime suspending. > > Related commit: > > commit 8452e1d173a16d9812422a2272c4ab0

Re: [Intel-gfx] [PATCH] drm/i915: run intel_uncore_early_sanitize earlier on resume on non-VLV

2014-10-21 Thread Daniel Vetter
On Mon, Oct 20, 2014 at 01:20:50PM +0300, Imre Deak wrote: > On Fri, 2014-10-17 at 16:01 -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > As far as I understand, intel_uncore_early_sanitize() was supposed to > > be ran before any register access, but currently > > intel_resume_prepare()

[Intel-gfx] [PATCH] lib/igt_aux: move audio RPM code to igt_setup_runtime_pm()

2014-10-21 Thread Paulo Zanoni
From: Paulo Zanoni If we don't enable audio runtime PM, the audio driver won't release its reference, the refcount won't ever become zero, so we will never actually runtime suspend. So move this code from pm_rpm.c to igt_aux.c, so kms_flip - and any other IGT test case using RPM - can benefit fro

[Intel-gfx] [PATCH] drm/i915: add missing forcewake put on i915_wa_registers()

2014-10-21 Thread Paulo Zanoni
From: Paulo Zanoni Otherwise, a simple "cat" to the debugfs file can make the machine use much more power than needed, and prevent it from runtime suspending. Related commit: commit 8452e1d173a16d9812422a2272c4ab0f0ba81057 Author: Mika Kuoppala Date: Tue Oct 7 17:21:26 2014 +0300

Re: [Intel-gfx] [PATCH v2 0/8] Add enlightenments for vGPU

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 06:16:26PM +0200, Daniel Vetter wrote: > On Fri, Oct 17, 2014 at 01:37:11PM +0800, Yu Zhang wrote: > > Intel GVT-g (previously known as XenGT), is a complete GPU > > virtualization solution with mediated pass-through for 4th > > generation Intel Core processors - Haswell pla

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915: Create vgpu specific write MMIO to reduce traps

2014-10-21 Thread Daniel Vetter
On Thu, Oct 16, 2014 at 02:24:27PM +0800, Yu Zhang wrote: > In the virtualized environment, forcewake operations are not > necessory for the driver, because mmio accesses will be trapped > and emulated by the host side, and real forcewake operations are > also done in the host. New mmio write handl

Re: [Intel-gfx] [PATCH v2 0/8] Add enlightenments for vGPU

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 01:37:11PM +0800, Yu Zhang wrote: > Intel GVT-g (previously known as XenGT), is a complete GPU > virtualization solution with mediated pass-through for 4th > generation Intel Core processors - Haswell platform. This > technology presents a virtual full-fledged GPU to each Vi

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Fix chv PCS DW11 register defines

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 12:08:38PM +0300, Jani Nikula wrote: > On Thu, 16 Oct 2014, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > I managed to fumble the per spline PCS DW11 register defines in: > > commit 9d4f193b077c1973add53e40ff9410a3371900af > > Looks like commit 570e

Re: [Intel-gfx] [PATCH] lib/igt_aux: make igt_wait_for_pm_status() resist the signal helper

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 01:52:46PM -0200, Paulo Zanoni wrote: > 2014-10-21 13:18 GMT-02:00 Daniel Vetter : > > On Tue, Oct 14, 2014 at 04:12:22PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> If the signal helper is active, the usleep() calls return earlier, and > >> we may end up r

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ignore long hpds on eDP ports

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 09:08:28AM -0700, Todd Previte wrote: > > On 10/17/2014 1:43 AM, Ville Syrjälä wrote: > >On Thu, Oct 16, 2014 at 12:38:55PM -0700, Todd Previte wrote: > >>On 10/16/2014 10:46 AM, ville.syrj...@linux.intel.com wrote: > >>>From: Ville Syrjälä > >>> > >>>Turning vdd on/off ca

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do a dummy DPCD read before the actual read

2014-10-21 Thread Daniel Vetter
On Thu, Oct 16, 2014 at 12:39:29PM -0700, Todd Previte wrote: > > On 10/16/2014 10:46 AM, ville.syrj...@linux.intel.com wrote: > >From: Ville Syrjälä > > > >Sometimes we seem to get utter garbage from DPCD reads. The resulting > >buffer is filled with the same byte, and the operation completed wi

Re: [Intel-gfx] [PATCH] lib/igt_aux: make igt_wait_for_pm_status() resist the signal helper

2014-10-21 Thread Paulo Zanoni
2014-10-21 13:18 GMT-02:00 Daniel Vetter : > On Tue, Oct 14, 2014 at 04:12:22PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> If the signal helper is active, the usleep() calls return earlier, and >> we may end up returning false way before the 10s timeout, failing the >> subtests. This c

Re: [Intel-gfx] [PATCH] drm/i915: Abort command parsing for chained batches

2014-10-21 Thread Daniel Vetter
On Thu, Oct 16, 2014 at 12:24:42PM -0700, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > libva uses chained batch buffers in a way that the command parser > can't generally handle. Fortunately, libva doesn't need to write > registers from batch buffers in the way that mesa does, so thi

Re: [Intel-gfx] [PATCH 01/17] drm/i915: Warn if trying to register eDP on port != B/C on vlv/chv

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 08:26:13PM +0300, Mika Kuoppala wrote: > Jani Nikula writes: > > > On Thu, 16 Oct 2014, ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> Only ports B and C have the power sequencer and backlight controls, > >> so complain if we ever try to register

Re: [Intel-gfx] dmar messages caused by graphics.

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 05:17:16PM -0400, Dave Jones wrote: > Just hit this while fuzz-testing, (curiously, no graphics > related stuff was happening, X isn't even loaded on that box). > > dmar: DRHD: handling fault status reg 2 > dmar: DMAR:[DMA Write] Request device [00:02.0] fault addr 7ff0

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the pipe CRCs.

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 06:42:03PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > For some yet-undiscovered reason, when IPS gets enabled, the pipe CRC > changes. Since hsw_enable_ips() doesn't really guarantees to enable > IPS (it depends on package C-states), we can't really predict if IPS

Re: [Intel-gfx] [PATCH 1/2] tests/gem_exec_parse: fix batch_len setting for cmd-crossing-page

2014-10-21 Thread Daniel Vetter
On Wed, Oct 15, 2014 at 02:52:41PM -0700, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > The size of the batch buffer passed to the kernel is significantly > larger than the size of the batch buffer passed to the function. A > proposed optimization as part of the batch copy kernel seri

Re: [Intel-gfx] [PATCH] drm/i915: call drm_vblank_cleanup() earlier at unload

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 02:18:34PM +0300, Ville Syrjälä wrote: > On Wed, Oct 15, 2014 at 02:15:04PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > In its current place, it just segfaults while trying to access the > > CRTC structures: > > > > [ 9132.421681] Call Trace: > > [ 9132.4217

Re: [Intel-gfx] [PATCH] lib/igt_aux: make igt_wait_for_pm_status() resist the signal helper

2014-10-21 Thread Daniel Vetter
On Tue, Oct 14, 2014 at 04:12:22PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If the signal helper is active, the usleep() calls return earlier, and > we may end up returning false way before the 10s timeout, failing the > subtests. This currently happens on the kms_flip RPM interruptibl

Re: [Intel-gfx] [PATCH 1/4] igt/gem_concurrent_blit: Inject hangs before verifying contents

2014-10-21 Thread Daniel Vetter
On Tue, Oct 14, 2014 at 12:28:39PM +0100, Chris Wilson wrote: > After setting up the copy operations, add a hanging batch. This should > mean that we complete the copy and the compare then races against the > GEM reset. Hopefully, this will catch driver bugs where the target > object is no longer a

Re: [Intel-gfx] [PATCH] drm/i915: fix wait ioctl with negative timeout

2014-10-21 Thread Daniel Vetter
On Mon, Oct 13, 2014 at 12:40:48AM +0800, Chia-I Wu wrote: > On Sun, Oct 12, 2014 at 1:21 AM, Chia-I Wu wrote: > > > When timeout_ns is negative, it really means to wait indefinitely instead > > of > > returning immediately. But since userspace can no longer rely on that, I > > am > > not sure i

Re: [Intel-gfx] [PATCH V2] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready

2014-10-21 Thread Daniel Vetter
On Fri, Oct 17, 2014 at 11:41:12AM -0700, Todd Previte wrote: > V2 changes: > - Moved the intel_dp_enable_port() call out of intel_dp_enable() and placed > it > before the calls to intel_dp_enable() and vlv_wait_port_ready() > - Cleaned up a spacing issues with the code indents > - Amended the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow dev_priv for HAS_PCH_* macros too

2014-10-21 Thread Daniel Vetter
On Fri, Oct 10, 2014 at 06:10:41PM +0300, Jani Nikula wrote: > On Fri, 10 Oct 2014, Chris Wilson wrote: > > On Fri, Oct 10, 2014 at 05:53:32PM +0300, Jani Nikula wrote: > >> Follow-up to > >> commit dbbe91279511d6a18a521b953a3c139e4787e660 > >> Author: Chris Wilson > >> Date: Sat Aug 9 19:18:43

Re: [Intel-gfx] [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode

2014-10-21 Thread Daniel Vetter
On Thu, Oct 09, 2014 at 12:57:45PM -0700, Jesse Barnes wrote: > From: Kristian Høgsberg > > The BIOS may set a native mode that doesn't quite match the preferred > mode timings. It should be ok to use however if it uses the same size, > so try to avoid a mode set in that case. > > Signed-off-by

Re: [Intel-gfx] [PATCH 3/4] drm: add drm_mode_same_size function

2014-10-21 Thread Daniel Vetter
On Thu, Oct 09, 2014 at 12:57:44PM -0700, Jesse Barnes wrote: > From: Kristian Høgsberg > > Like mode_equal but w/o the clock checks. Useful for checking if modes > are close enough to re-use to avoid a boot time mode set for example. > > Signed-off-by: Kristian Høgsberg > Signed-off-by: Jesse

Re: [Intel-gfx] [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4

2014-10-21 Thread Daniel Vetter
On Thu, Oct 09, 2014 at 12:57:43PM -0700, Jesse Barnes wrote: > Some machines (like MBAs) might use a tiled framebuffer but not enable > display swizzling at boot time. We want to preserve that configuration > if possible to prevent a boot time mode set. On IVB+ it shouldn't > affect performance

Re: [Intel-gfx] [PATCH] drm/i915: Improve reliability for Displayport link training

2014-10-21 Thread Daniel Vetter
On Thu, Oct 09, 2014 at 09:39:01AM -0700, Todd Previte wrote: > Link training for Displayport can fail in many ways and at multiple different > points > during the training process. Previously, errors were logged but no additional > action > was taken based on them. Consequently, training attempt

[Intel-gfx] [PULL] drm-intel-next

2014-10-21 Thread Daniel Vetter
Hi Dave, drm-intel-next-2014-10-03: - first batch of skl stage 1 enabling - fixes from Rodrigo to the PSR, fbc and sink crc code - kerneldoc for the frontbuffer tracking code, runtime pm code and the basic interrupt enable/disable functions - smaller stuff all over drm-intel-next-2014-09-19: - b

[Intel-gfx] [PATCH 3/8] drm/i915: Add infrastructure for choosing DPLLs before disabling crtcs

2014-10-21 Thread Ander Conselvan de Oliveira
It is possible for a mode set to fail if there aren't shared DPLLS that match the new configuration requirement or other errors in clock computation. If that step is executed after disabling crtcs, in the failure case the hardware configuration is changed and needs to be restored. Doing those thing

[Intel-gfx] [PATCH 6/8] drm/i915: Covert remaining platforms to choose DPLLS before disabling CRTCs

2014-10-21 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 9475271..9e92ad6 100644 --- a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 1/8] drm/i915: Convert shared dpll reference count to a crtc mask

2014-10-21 Thread Ander Conselvan de Oliveira
This will be used in a follow up patch to properly release shared DPLLs without relying on the shared_dpll field in pipe_config. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_debugfs.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 4 +-- drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH 4/8] drm/i915: Covert HSW+ to choose DPLLS before disabling CRTCs

2014-10-21 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_ddi.c | 2 -- drivers/gpu/drm/i915/intel_display.c | 9 - 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 7b8c4b8..b42d76

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Build workaround list in ring initialization

2014-10-21 Thread Daniel Vetter
On Mon, Oct 20, 2014 at 05:13:45PM +0100, Siluvery, Arun wrote: > On 07/10/2014 15:21, Mika Kuoppala wrote: > >If we build the workaround list in ring initialization > >and decouple it from the actual writing of values, we > >gain the ability to decide where and how we want to apply > >the values.

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items in

2014-10-21 Thread Daniel, Thomas
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, October 21, 2014 1:14 PM > To: He, Shuang > Cc: intel-gfx@lists.freedesktop.org; Daniel, Thomas > Subject: Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue

Re: [Intel-gfx] [PULL] drm-intel-next

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 2:27 PM, Daniel Vetter wrote: > There's some simple merge conflicts with current upstream but nothing > serious really, I can push out a merge point if you want to. As usual > -nightly has the solution for you to peek at. Sorrry I've lied, there's an annoying conflict that

Re: [Intel-gfx] [PATCH 07/16] drm/i915: fix S4 suspend while switcheroo state is off

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:17:00PM +0300, Imre Deak wrote: > If the device is suspended already through the switcheroo interface we > shouldn't suspend it again. We have the corresponding check for S3 > suspend already, add it for S4 freeze and poweroff too. > > Note that there is still the proble

Re: [Intel-gfx] [PATCH 01/16] drm/i915: vlv: fix gunit HW state corruption during S4 suspend

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:16:54PM +0300, Imre Deak wrote: > During S4 freeze we don't call intel_suspend_complete(), which would > save the gunit HW state, but during S4 thaw/restore events we call > intel_resume_prepare() which restores it, thus ending up in a corrupted > HW state. > > Fix this

[Intel-gfx] [PULL] drm-intel-next

2014-10-21 Thread Daniel Vetter
Hi Dave, So -rc1 is out the door and the first i915 pull request for 3.19 in your inbox ;-) Due to the early drm-next merge window we've already accumulated two testing cycles instead of the usual one, but somehow there wasn't too much going on really. drm-intel-next-2014-10-03: - first batch of

Re: [Intel-gfx] [PATCH] drm/i915: remove redundant #ifdef CONFIG_COMPAT

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 02:40:37PM +0300, Jani Nikula wrote: > The whole file is only built with CONFIG_COMPAT=y. > > Signed-off-by: Jani Nikula Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items in

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 01:32:44AM -0700, shuang...@intel.com wrote: > Tested-By: PRC QA PRTS (Patch Regression Test System Contact: > shuang...@intel.com) > -Summary- > Platform: baseline_drm_intel_nightly_pass_rate->patch_ap

Re: [Intel-gfx] [PATCH 3/9] drm/i915: MIPI Port Ctrl related changes for dual link configuration

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 12:00:30PM +0530, Singh, Gaurav K wrote: > > On 9/24/2014 2:57 PM, Jani Nikula wrote: > >On Wed, 24 Sep 2014, Gaurav K Singh wrote: > >>Signed-off-by: Gaurav K Singh > >>Signed-off-by: Shobhit Kumar > >>--- > >> drivers/gpu/drm/i915/i915_reg.h|1 + > >>

Re: [Intel-gfx] [PATCH 02/16] drm/i915: remove dead code from legacy suspend handler

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 02:56:46PM +0300, Ville Syrjälä wrote: > On Wed, Sep 10, 2014 at 06:16:55PM +0300, Imre Deak wrote: > > The legacy DRM suspend logic (effective in UMS) doesn't handle any S4 thaw > > events so we don't need to care about it either. Only S3 suspend and S4 > > freeze events ar

Re: [Intel-gfx] [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup bridge for VED

2014-10-21 Thread Daniel Vetter
On Tue, Oct 21, 2014 at 02:36:41PM +0800, Yao Cheng wrote: > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2. Make the platform device child of i915 device for runtime PM. > 3. Create IRQ chip to forward the VED irqs. > VED dri

Re: [Intel-gfx] [PATCH 02/16] drm/i915: remove dead code from legacy suspend handler

2014-10-21 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 06:16:55PM +0300, Imre Deak wrote: > The legacy DRM suspend logic (effective in UMS) doesn't handle any S4 thaw > events so we don't need to care about it either. Only S3 suspend and S4 > freeze events are handled. Leave an assert behind to be sure. > > Signed-off-by: Imre

[Intel-gfx] [PATCH] drm/i915: remove redundant #ifdef CONFIG_COMPAT

2014-10-21 Thread Jani Nikula
The whole file is only built with CONFIG_COMPAT=y. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_ioc32.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_ioc32.c b/drivers/gpu/drm/i915/i915_ioc32.c index 2e0613e26251..176de6322e4d 100644 --- a/drivers/gp

Re: [Intel-gfx] [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup bridge for VED

2014-10-21 Thread Ville Syrjälä
On Tue, Oct 21, 2014 at 02:36:41PM +0800, Yao Cheng wrote: > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2. Make the platform device child of i915 device for runtime PM. > 3. Create IRQ chip to forward the VED irqs. > VED dri

[Intel-gfx] Broken TIMESTAMP on x86_64 - how to stay compatible

2014-10-21 Thread Michał Winiarski
Hi, Some time ago I've raised an issue, that only 32bits of TIMESTAMP are being exposed to userspace on x86_64, you suggested that we need to stay compatible with old (and new) userspace and proposed adding a new param that can can be accessed via getparam. However, after checking beignet and mes

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items in

2014-10-21 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform: baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate BYT: pass/total=19/19->3/19 PNV: pass/total=2/2->1/2 ILK: pas