Thanks for your comments Stéphane
Please find mine inline.
In general, I got the overall recommendations that if this implementation comes
from generic DRM property, it would be easy to club with general interfaces,
and atomic modeset calls.
I will work on this, and will come back with modified
On Mon, 2014-02-24 at 14:11 +0200, Ville Syrjälä wrote:
> On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote:
> > On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote:
> > >
> > > We can kill of the drm_vblank_{pre,post}_modeset() calls since those are
> > > there simp
On Mon, Feb 24, 2014 at 11:56:59AM +, joao.san...@intel.com wrote:
> From: Joao Santos
>
> Making libdrm and kernel drm uniform. The lack of this macro makes igt test
> build break.
>
> Change-Id: Ie62a2507e48eb3927bcf8f43a1606e56625db2e8
> Signed-off-by: Joao Santos
This should already be
In response to the demand for Broadwell features and fixes which are not
yet merged in our upstream drm-intel repository
(http://cgit.freedesktop.org/drm-intel/) I will be maintaining a branch
in my freedesktop repository with some of the features and fixes that I
have been using myself.
Platform
On Sat, Feb 22, 2014 at 08:08:23PM +, Chris Wilson wrote:
> On Sat, Feb 22, 2014 at 11:40:43AM -0800, Ben Widawsky wrote:
> > On Sat, Feb 22, 2014 at 07:37:04PM +, Chris Wilson wrote:
> > > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote:
> > > > On Sat, Feb 22, 2014 at 01:37:1
On Mon, Feb 24, 2014 at 07:03:12PM +0200, Imre Deak wrote:
> On Thu, 2014-02-20 at 11:51 -0800, Ben Widawsky wrote:
> > The previous allocation mechanism would get 2 contiguous allocations,
> > one for the page directories, and one for the page tables. As each page
> > table is 1 page, and there ar
On Mon, Feb 24, 2014 at 08:30:22AM +, Chris Wilson wrote:
> On Sun, Feb 23, 2014 at 12:12:25PM -0800, Ben Widawsky wrote:
> > On Mon, Aug 26, 2013 at 12:06:43PM +0100, Chris Wilson wrote:
> > > Obtaining the forcwake requires expensive and time consuming
> > > serialisation. And we often try to
On Mon, Feb 24, 2014 at 01:27:09PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote:
> > On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote:
> > > From: Mika Kuoppala
> > >
> > > Sometimes generic driver code gets forcewake explicitly
Btw,
I don't know whether the following observation is related or not, but it
so happens that after resume from suspend-to-disk, I see the booting up
of the resume kernel on the console but when it is time for the original
kernel to take over and switch to graphics, the screen remains black but
th
From: Rob Bradford
The LLC check echoes the check made by i915_gem_fault() which will
handle the mapping the pages through the GTT.
The aim is that this is functionally equivalent to using the
I915_GEM_MMAP_GTT ioctl and then mmaping using the offset returned.
Signed-off-by: Rob Bradford
---
On Tue, 18 Feb 2014, Jesse Barnes wrote:
> On Tue, 28 Jan 2014 10:14:03 +0100
> Daniel Vetter wrote:
>
>> On Tue, Jan 28, 2014 at 10:10 AM, Goel, Akash wrote:
>> > Hi Daniel,
>> >
>> > Please let us know about this patch, will this be up-streamed.
>>
>> 1. I've just sent out the merge confirmat
On Fri, 2014-02-21 at 13:06 -0800, Ben Widawsky wrote:
> With the original PPGTT implementation if the number of PDPs was not a
> power of two, the number of pages for the page tables would end up being
> rounded up. The code actually had a bug here afaict, but this is a
> theoretical bug as I don'
On Thu, 2014-02-20 at 11:51 -0800, Ben Widawsky wrote:
> The previous allocation mechanism would get 2 contiguous allocations,
> one for the page directories, and one for the page tables. As each page
> table is 1 page, and there are 512 of these per page directory, this
> goes to 2MB. An unfriendl
On Thu, 2014-02-20 at 11:50 -0800, Ben Widawsky wrote:
> This patch converts insert_entries and clear_range, both functions which
> are specific to the VM. These functions tend to encapsulate the gen
> specific PTE writes. Passing absolute addresses to the insert_entries,
> and clear_range will hel
On Thu, 2014-02-20 at 11:47 -0800, Ben Widawsky wrote:
> GEN8 never freed the PPGTT struct. As GEN8 doesn't use full PPGTT, the
> leak is small and only found on a module reload. ie. I don't think this
> needs to go to stable.
>
> v2: The very naive, kfree in gen8 ppgtt cleanup, is subject to a do
This started happening this morning after booting -rc4+tip, let's
add *everybody* to CC :-)
We have intel_uncore_init, snb_uncore_imc_init_box, uncore_pci_probe and
other goodies on the stack.
...
[0.488998] software IO TLB [mem 0xcac3-0xcec3] (64MB) mapped at
[8800cac3-8
On Thu, 2014-02-20 at 11:47 -0800, Ben Widawsky wrote:
> At one time it was expected to be called in multiple places by kref_put.
> At the current time however, it is all contained within
> i915_gem_context.c.
>
> This patch makes an upcoming required addition a bit nicer since it too
> doesn't ne
On Sun, 23 Feb 2014 10:50:59 -0500
Josh Boyer wrote:
> On Thu, Feb 20, 2014 at 07:31:41PM -0500, Josh Boyer wrote:
> >On Wed, Feb 19, 2014 at 9:20 PM, Josh Boyer
> >wrote:
> >> Hi All,
> >>
> >> We've had a rather weird report[1] of the brightness adjustments being
> >> broken in a specific cas
On Mon, Feb 24, 2014 at 09:11:43PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> With this patch we allow larger cursor planes of sizes 128x128
> and 256x256.
>
> v2: Added more precise check on size while setting cursor plane.
>
> Testcase: igt/kms_cursor_crc
> Cc: Daniel Vet
On Mon, Feb 24, 2014 at 09:07:05PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> Signed-off-by: Sagar Kamble
> ---
> tests/kms_cursor_crc.c | 51
> ++
> 1 file changed, 31 insertions(+), 20 deletions(-)
>
> diff --git a/tests/k
Gentle Reminder !!!
Kindly review and provide feedback
thanks,
Sagar
On Wed, 2014-02-19 at 15:38 +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> With this patch two properties are added. One for CRTC+Sprite planes
> and another for Cursor planes. Through these client will be abl
From: Sagar Kamble
Signed-off-by: Sagar Kamble
---
tests/kms_cursor_crc.c | 51 ++
1 file changed, 31 insertions(+), 20 deletions(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 38aa1ab..4458248 100644
--- a/tests/kms_cursor
From: Sagar Kamble
With this patch we allow larger cursor planes of sizes 128x128
and 256x256.
v2: Added more precise check on size while setting cursor plane.
Testcase: igt/kms_cursor_crc
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...
From: Ville Syrjälä
VLV is the only platform where we increment/decrement the forcewake
count around register access. Drop the inc/dec on VLV to make the
forcewake code a bit more unified.
The inc/dec are not necessary since we hold the uncore lock around
the whole operation.
Signed-off-by: Vil
From: Ville Syrjälä
While looking at the gen8 forcewake stuff I noticed that the VLV code is a bit
different, and also the post-reset forcewake handling is broken. This series
fixes those issues. git am didn't like Mika's forcewake patches for some reason
so I had to base this on nightly. That's
From: Ville Syrjälä
Use the render/media specific forcewake counts to properly restore the
forcewake status after a GPU reset on VLV.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_uncore.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/d
2014-02-24 8:33 GMT-03:00 Imre Deak :
> On Fri, 2014-02-21 at 13:52 -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> Otherwise we'll read registers that return 0x, trigger some
>> WARNs, think CRT is actually connected (because certain bits are 1),
>> and fail the drm-resources-equal
2014-02-24 8:23 GMT-03:00 Imre Deak :
> On Fri, 2014-02-21 at 13:52 -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> Otherwise, when we run intel_modeset_check_state we may already be
>> runtime suspended, and our state checking code will read registers
>> while the device is suspended. This
On Mon, 2014-02-24 at 10:23 -0300, Paulo Zanoni wrote:
> 2014-02-17 19:02 GMT-03:00 Imre Deak :
> > These functions are used only by a single call site and are simple
> > enough to just fold them in.
> >
> > No functional change.
> >
> > Signed-off-by: Imre Deak
>
> IMHO, this makes the code hard
On Mon, 2014-02-24 at 10:38 -0300, Paulo Zanoni wrote:
> 2014-02-20 16:21 GMT-03:00 Jesse Barnes :
> > On Tue, 18 Feb 2014 00:02:05 +0200
> > Imre Deak wrote:
> >
> >> These macros are used only locally, so move them to the .c file.
> >>
> >> Also since logically the init power domain should be pa
2014-02-20 16:21 GMT-03:00 Jesse Barnes :
> On Tue, 18 Feb 2014 00:02:05 +0200
> Imre Deak wrote:
>
>> These macros are used only locally, so move them to the .c file.
>>
>> Also since logically the init power domain should be part of all power
>> wells add it to the always-on power wells too for
On Thu, 2014-02-20 at 11:56 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:18 +0200
> Imre Deak wrote:
>
> > We'll need to disable/re-enable the display-side IRQs when turning
> > off/on the VLV display power well. Factor out the helper functions
> > for this. For now keep the display IRQ
2014-02-17 19:02 GMT-03:00 Imre Deak :
> These functions are used only by a single call site and are simple
> enough to just fold them in.
>
> No functional change.
>
> Signed-off-by: Imre Deak
IMHO, this makes the code harder to read. I would prefer to not have
this change.
> ---
> drivers/gp
On Thu, 2014-02-20 at 11:48 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:15 +0200
> Imre Deak wrote:
>
> > On VLV at least the display IRQ register access and functionality
> > depends on its power well to be on, so move the power domain HW init
> > before we install the IRQs.
> >
> >
On Thu, 2014-02-20 at 11:46 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:13 +0200
> Imre Deak wrote:
>
> > In the upcoming patches we'll need to access the rest of the fields in
> > the punit power gating register, so prepare for that.
> >
> > Signed-off-by: Imre Deak
> > ---
> > dri
On Wed, Feb 19, 2014 at 10:19:19PM -0800, Ben Widawsky wrote:
> @@ -634,6 +641,85 @@ static void render_ring_cleanup(struct intel_ring_buffer
> *ring)
> ring->scratch.obj = NULL;
> }
>
> +static int gen8_rcs_signal(struct intel_ring_buffer *signaller,
> +unsigned
On Wed, Feb 19, 2014 at 10:19:17PM -0800, Ben Widawsky wrote:
> With the ring mask we now have an easy way to know the number of rings
> in the system, and therefore can accurately predict the number of dwords
> to emit for semaphore signalling. This was not possible (easily)
> previously.
>
> The
On Wed, Feb 19, 2014 at 10:19:23PM -0800, Ben Widawsky wrote:
> Since the semaphore information is in an object, just dump it, and let
> the user parse it later.
>
> NOTE: The page being used for the semaphores are incoherent with the
> CPU. No matter what I do, I cannot figure out a way to read a
On Wed, Feb 19, 2014 at 10:19:21PM -0800, Ben Widawsky wrote:
> Signed-off-by: Ben Widawsky
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
> b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 3d5dd4
On Wed, Feb 19, 2014 at 10:19:18PM -0800, Ben Widawsky wrote:
> Gen8 has already had some differentiation with how it handles rings.
> Semaphores bring yet more differences, and now is as good a time as any
> to do the split.
>
> Also, since gen8 doesn't actually use semaphores up until this point
On Thu, 2014-02-20 at 11:36 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:10 +0200
> Imre Deak wrote:
>
> > Since the encoder is tied to its port, we need to make sure the power
> > domain for that port is on before reading out the encoder HW state.
> >
> > Signed-off-by: Imre Deak
> >
On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote:
> On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote:
> >
> > We can kill of the drm_vblank_{pre,post}_modeset() calls since those are
> > there simply to make drm_vblank_get() fail during a modeset.
>
> Actually,
From: Joao Santos
Making libdrm and kernel drm uniform. The lack of this macro makes igt test
build break.
Change-Id: Ie62a2507e48eb3927bcf8f43a1606e56625db2e8
Signed-off-by: Joao Santos
---
include/drm/i915_drm.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/drm/i915_drm.h
On Thu, 2014-02-20 at 11:33 -0800, Jesse Barnes wrote:
> On Wed, 19 Feb 2014 14:39:58 +0200
> Imre Deak wrote:
>
> > On Wed, 2014-02-19 at 14:35 +0200, Ville Syrjälä wrote:
> > > On Tue, Feb 18, 2014 at 12:02:09AM +0200, Imre Deak wrote:
> > > > The connector detect and get_mode handlers need to
On Thu, 2014-02-20 at 11:31 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:08 +0200
> Imre Deak wrote:
>
> > Parts that poke port specific HW blocks like the encoder HW state
> > readout or connector hotplug detect code need a way to check whether
> > required power domains are on or enab
On Thu, 2014-02-20 at 11:26 -0800, Jesse Barnes wrote:
> On Tue, 18 Feb 2014 00:02:06 +0200
> Imre Deak wrote:
>
> > Split the 'set' power well handler into an 'enable', 'disable' and
> > 'sync_hw' handler. This maps more conveniently to higher level
> > operations, for example it allows us to pu
On Fri, 2014-02-21 at 13:52 -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Otherwise we'll read registers that return 0x, trigger some
> WARNs, think CRT is actually connected (because certain bits are 1),
> and fail the drm-resources-equal testcase!
>
> Tested on a SNB machine with
On Fri, Feb 21, 2014 at 01:13:39PM -0800, Jesse Barnes wrote:
> To silence locking complaints. This was a rebase failure on my part in
>
> commit fa9fa083d0606cb323f6105c17702460ea0a6780
> Author: Jesse Barnes
> Date: Tue Feb 11 15:28:56 2014 -0800
>
> drm/i915: read out hw state earlier
On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote:
> On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote:
> > From: Mika Kuoppala
> >
> > Sometimes generic driver code gets forcewake explicitly by
> > gen6_gt_force_wake_get(), which check forcewake_count before acce
On Fri, 2014-02-21 at 13:52 -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Otherwise, when we run intel_modeset_check_state we may already be
> runtime suspended, and our state checking code will read registers
> while the device is suspended. This can only happen if your
> autosuspend_delay
Shobhit, any ideas?
On Mon, 17 Feb 2014, "Chen, Xueyi Z" wrote:
> Hi, Experts
>
>
> When I debug a mipi panel on the valley view board, and sometimes got the
> following error interrupt.
>
> RXECC_SINGLE_BIT_ERROR/RXECC_MULTIBIT_ERROR/RXCHECKSUM_ERROR
>
> Does anybody have any advice for these
On Sun, Feb 23, 2014 at 12:12:25PM -0800, Ben Widawsky wrote:
> On Mon, Aug 26, 2013 at 12:06:43PM +0100, Chris Wilson wrote:
> > Obtaining the forcwake requires expensive and time consuming
> > serialisation. And we often try to obtain the forcewake multiple times
> > in very quick succession. We
52 matches
Mail list logo
