On Fri, 22 Apr 2011 22:22:28 +0100, Chris Wilson
wrote:
> fp = FP0(pipe);
> else
> fp = FP1(pipe);
> + fp = I915_READ(fp);
Please use different variables for the offset vs the value...
--
keith.pack...@intel.com
pgpaGbAUtaJf4.pgp
Description: PGP signat
On Thu, 2011-04-21 at 16:36 -0700, Eric Anholt wrote:
> On Thu, 21 Apr 2011 22:18:20 +0100, Chris Wilson
> wrote:
> > From: Zhao Yakui
> >
> > ... otherwise the TV type will be misdetected and cause spurious
> > connections.
> >
> > This was originally applied as fb8b5a39b6310379d7b54c0c711370
On Fri, 22 Apr 2011 22:34:46 +0100
Chris Wilson wrote:
> Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after
> "cleanup"), we missed one neighbouring read that was mistakenly replaced
> with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).
> This was preventing
Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after
"cleanup"), we missed one neighbouring read that was mistakenly replaced
with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).
This was preventing us from correctly determining the mode the BIOS left
the panel in
On Fri, 22 Apr 2011 22:22:28 +0100
Chris Wilson wrote:
> Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after
> "cleanup"), we missed one neighbouring read that was mistakenly replaced
> with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).
> This was preventing
Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after
"cleanup"), we missed one neighbouring read that was mistakenly replaced
with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).
This was preventing us from correctly determining the mode the BIOS left
the panel in
Leftover from the training split, we don't need these guys anymore.
Signed-off-by: Jesse Barnes
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 0daefca..0558e0a 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1275,7 +127
On Thu, Apr 21, 2011 at 10:18:18PM +0100, Chris Wilson wrote:
> Reported-by: Alan Cox
> Signed-off-by: Chris Wilson
> Cc: sta...@kernel.org
> ---
> drivers/gpu/drm/i915/intel_display.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_di
On Fri, 22 Apr 2011 10:50:47 -0700, Ben Widawsky wrote:
> How about to save some eyestrain, using some macro helpers?
>
> struct intel_lvds_connector {
> struct intel_connector base;
> #define drm_base \
> base.base
> #define drm_dev \
> drm_base.dev
> #define drm_funcs \
>
On Fri, Apr 22, 2011 at 10:19:10AM +0100, Chris Wilson wrote:
> Introduce a local structure to move LVDS specific information away from
> the drm_i915_private and onto the LVDS connector.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 31 +--
On Fri, 22 Apr 2011 09:20:17 -0700, Ben Widawsky wrote:
> I don't understand what you're asking for. I'm pretty convinced I need
> the mutex protected intel_update_fbc, because the call trace could be:
>
> intel_update_fbc()
> intel_enable_fbc()
> ironlake_enable_fbc()
> sandybridge_blit_fbc_upda
On Fri, Apr 22, 2011 at 09:20:17AM -0700, Ben Widawsky wrote:
> On Thu, Apr 21, 2011 at 07:18:24AM +0100, Chris Wilson wrote:
> > On Wed, 20 Apr 2011 16:53:17 -0700, Ben Widawsky wrote:
> > >
> > > Signed-off-by: Ben Widawsky
> >
> > Just to annoy you, this needs to be split up into the various
On Fri, 22 Apr 2011 10:19:18 +0100
Chris Wilson wrote:
> ... otherwise just left userspace handle the notification and change
> modes as it desires.
>
> Signed-off-by: Chris Wilson
> ---
Problem is that old userspace didn't do anything. The change is a nice
one though; maybe a setparam is nee
On Fri, 22 Apr 2011 10:19:17 +0100
Chris Wilson wrote:
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/intel_dp.c| 54 +--
> drivers/gpu/drm/i915/intel_drv.h |3 ++
> drivers/gpu/drm/i915/intel_lvds.c | 33 ++---
> driver
On Fri, 22 Apr 2011 10:19:16 +0100
Chris Wilson wrote:
> ... and so we can simplify some conditionals.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/intel_dp.c | 17 +++--
> 1 files changed, 7 insertions(+), 10 deletions(-)
Only downside of this is that it makes t
On Fri, 22 Apr 2011 10:19:15 +0100
Chris Wilson wrote:
> ... as matches usage.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_drv.h|1 -
> drivers/gpu/drm/i915/intel_dp.c| 43 +
> drivers/gpu/drm/i915/intel_drv.h |4 ++-
>
On Fri, 22 Apr 2011 10:19:13 +0100
Chris Wilson wrote:
> ... in preparation for enabling it from eDP as well.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/intel_drv.h |8 +++
> drivers/gpu/drm/i915/intel_lvds.c | 79 ++-
> drivers/gpu/drm/i9
On Thu, Apr 21, 2011 at 07:18:24AM +0100, Chris Wilson wrote:
> On Wed, 20 Apr 2011 16:53:17 -0700, Ben Widawsky wrote:
> >
> > Signed-off-by: Ben Widawsky
>
> Just to annoy you, this needs to be split up into the various categories
> of fixes. Because...
>
> > static void ironlake_crtc_dpms(
On Fri, 22 Apr 2011 10:19:12 +0100
Chris Wilson wrote:
> As there is 1:1 mapping between encoder and connector for the LVDS, the
> goal is to simply reduce the amount of noise within the connector
> functions, i.e. we split the encoder/connector for LVDS as best we can
> and try to only operate o
On Fri, 22 Apr 2011 10:19:11 +0100
Chris Wilson wrote:
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_drv.h |3 ---
> drivers/gpu/drm/i915/intel_lvds.c | 33 +
> 2 files changed, 17 insertions(+), 19 deletions(-)
>
Yeah, much better.
R
On Fri, 22 Apr 2011 10:19:10 +0100
Chris Wilson wrote:
> Introduce a local structure to move LVDS specific information away from
> the drm_i915_private and onto the LVDS connector.
>
> Signed-off-by: Chris Wilson
> ---
Nice to split this out.
Acked-by: Jesse Barnes
--
Jesse Barnes, Intel O
On Fri, 22 Apr 2011 10:19:09 +0100
Chris Wilson wrote:
> In preparation for introducing intel_lvds_connector to move some of the
> LVDS specific storage away from drm_i915_private, first rename the
> encoder to avoid potential confusion.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/
On Thu, Apr 21, 2011 at 07:34:08AM +0100, Chris Wilson wrote:
> > + /*
> > +* Lock not held here, because clearing is non-destructive, and
> > +* the interrupt handler is the only other place where it is written.
> > +*/
> > + I915_WRITE(GEN6_PMIMR, pm_imr & ~pm_iir); }
>
> But do
Pushed, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Date: Fri, 22 Apr 2011 15:09:12 +0200
Signed-off-by: Paul Menzel
---
NEWS |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index bf55b4b..61866b0 100644
--- a/NEWS
+++ b/NEWS
@@ -2,7 +2,7 @@ Release 2.15.0 (2011-04-14)
==
We are
... otherwise just left userspace handle the notification and change
modes as it desires.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_panel.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_dp.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 0daefca..3ef944f 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm
In preparation for introducing intel_lvds_connector to move some of the
LVDS specific storage away from drm_i915_private, first rename the
encoder to avoid potential confusion.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lvds.c | 227 +++--
1 files
... as matches usage.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|1 -
drivers/gpu/drm/i915/intel_dp.c| 43 +
drivers/gpu/drm/i915/intel_drv.h |4 ++-
drivers/gpu/drm/i915/intel_lvds.c | 45 ---
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |3 ---
drivers/gpu/drm/i915/intel_lvds.c | 33 +
2 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index b21470
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_dp.c| 54 +--
drivers/gpu/drm/i915/intel_drv.h |3 ++
drivers/gpu/drm/i915/intel_lvds.c | 33 ++---
drivers/gpu/drm/i915/intel_panel.c | 19
4 files changed, 58
... and so we can simplify some conditionals.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_dp.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 384017c..4c42f39 100644
As there is 1:1 mapping between encoder and connector for the LVDS, the
goal is to simply reduce the amount of noise within the connector
functions, i.e. we split the encoder/connector for LVDS as best we can
and try to only operate on the LVDS connector from the connector funcs
and the LVDS encode
... in preparation for enabling it from eDP as well.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_drv.h |8 +++
drivers/gpu/drm/i915/intel_lvds.c | 79 ++-
drivers/gpu/drm/i915/intel_panel.c | 92
3 files c
The eDP panel handling lacked a lot of the finese that we have developed
for LVDS, such as handling lid notifications and cacheing EDIDs. Also we
had a lot of connector specific data stuffed into the global
drm_i915_private which makes for a confusing read.
Let's try to reduce that confusion by sh
Introduce a local structure to move LVDS specific information away from
the drm_i915_private and onto the LVDS connector.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lvds.c | 31 +--
1 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/dri
36 matches
Mail list logo
