On Fri, 22 Apr 2011 10:19:16 +0100 Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> ... and so we can simplify some conditionals. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/intel_dp.c | 17 +++++++---------- > 1 files changed, 7 insertions(+), 10 deletions(-) Only downside of this is that it makes the code a little less readable. The is_edp checks make it obvious that you're looking fro eDP, while looking at the fixed mode is more implicit. Maybe a new macro, is_panel() or something that does the check? -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx