Re: [13] RFR 8217254, 8217721: CompactNumberFormat​() constructor does not comply with spec and format​() method spec for IAEx is not complaint

2019-03-07 Thread Nishit Jain
Thanks Naoto, Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/ Regards, Nishit Jain On 06-03-2019 23:24, naoto.s...@oracle.com wrote: Hi Nishit, Just one comment on j.t.CompactNumberFormat.java. At line 425, Null check can be done at the top of the method, as a paramet

Re: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time

2019-03-07 Thread Rachna Goel
Hi Naoto, This fix looks good to me. Thanks, Rachna On 3/6/19 4:50 AM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8218948 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ This

Re: [13] RFR 8217254, 8217721: CompactNumberFormat​() constructor does not comply with spec and format​() method spec for IAEx is not complaint

2019-03-07 Thread Naoto Sato
Looks good. Naoto On 3/7/19 3:51 AM, Nishit Jain wrote: Thanks Naoto, Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/ Regards, Nishit Jain On 06-03-2019 23:24, naoto.s...@oracle.com wrote: Hi Nishit, Just one comment on j.t.CompactNumberFormat.java. At line 425, Nul

Re: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time

2019-03-07 Thread Lance Andersen
Hi Naoto, Sorry for the late review, It looks good to me > On Mar 5, 2019, at 6:20 PM, Naoto Sato wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8218948 > > The proposed changeset is located at: > > http://cr.openjdk.java.n

[13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10

2019-03-07 Thread Toshio 5 Nakamura
Hi, Could you review this fix? I'd like to have a sponsor of it, since I'm an author. Bug: https://bugs.openjdk.java.net/browse/JDK-8220227 Webrev: http://cr.openjdk.java.net/~tnakamura/8220227/webrev.00/ Issue: Under Windows 10 non-English, Locale.getDisplayCountry() shows an error message, i