Hi Naoto, Sorry for the late review, It looks good to me
> On Mar 5, 2019, at 6:20 PM, Naoto Sato <naoto.s...@oracle.com> wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8218948 > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ > > This is a follow on fix to 8217366. There are several root causes included in > this bug, when the runtime supplements missing display names in non-US > locales :- > > - Retrieve the names for the requested id first, before it maps to the > canonical id, and on canonicalizing the id, use unique way (canonicalTZID()) > to canonicalize. > > - Retrieve the names in the same manner, between > DateFormatSymbols.getZoneStrings() and TimeZone.getDisplayName(). > > - Correctly map the Chinese locales between JDK and CLDR, in terms of > Simplified/Traditional scripts. > > Naoto <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>