Looks good.
Naoto
On 3/7/19 3:51 AM, Nishit Jain wrote:
Thanks Naoto,
Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/
Regards,
Nishit Jain
On 06-03-2019 23:24, naoto.s...@oracle.com wrote:
Hi Nishit,
Just one comment on j.t.CompactNumberFormat.java. At line 425, Null
check can be done at the top of the method, as a parameter check, so
that all the unnecessary "if-elseif" can be avoided. Others look good.
Naoto
On 3/6/19 3:56 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8217254 and JDK-8217721
Bug: https://bugs.openjdk.java.net/browse/JDK-8217254
https://bugs.openjdk.java.net/browse/JDK-8217721
Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/
Issue: The exception thrown by constructor and format() method was
not compliant with the specification
Fix: Updated the constructor and format method to throw exception as
per the specification
Regards,
Nishit Jain
