Result: New Internationalization Group Lead: Naoto Sato

Voting for Internationalization Group Lead Naoto Sato [1] is now closed. Yes: 1 No: 0 Abstain: 0 According to the Bylaws definition of Simple Majority, this is sufficient to approve the new Group Lead. The OpenJDK Lead will ask the Governing Board to ratify this nomination. Masayoshi Okutsu

Re: RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era

ed webrev: http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.01/ While I was testing more, I realized the default implementation of Era.getDisplayName doesn't work with non-IsoChronology. I filed new bug report JDK-8171049. Thanks, Masayoshi On 12/8/2016 5:55 PM, Masayoshi Okutsu wrote: Hi, P

RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era

Hi, Please review the fix for JDK-8054214. It was necessary to override Era::getDisplayName to get era names from the specified property. This one fixes getAbbreviation() as well. Issue: https://bugs.openjdk.java.net/browse/JDK-8054214 Webrev: http://cr.openjdk.java.net/~okutsu/9/8054214/web

CFV: New Internationalization Group Lead: Naoto Sato

vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Simple Majority voting instructions, see [3]. Masayoshi Okutsu [1]: http://openjdk.java.net/bylaws#group-lead [2]: http://openjdk.java.net/census#i18n [3]: http://openjdk.java.net/groups#lead-vote

Resigning as the Internationalization Group Lead

I am resigning as the lead of this group because I'm leaving the company. Thanks, Masayoshi

Re: RFR: JDK-8075577: java.time does not support HOST provider

Looks good to me. Masayoshi On 11/22/2016 6:30 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8075577. Bug : https://bugs.openjdk.java.net/browse/JDK-8075577 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/ Fix is to introduce new private spi "sun.text.spi.JavaTimeD

Re: RFR: 8169191: (tz) Support tzdata2016j

Sorry, but I was confused with the wrong bug ID in Subject... Looks good to me. Masayoshi On 11/29/2016 4:28 AM, Martin Buchholz wrote: Thanks as always for keeping the tzdata pipeline moving! Looks good to me. On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil wrote: Hi all, Please review t

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

Hi Rachna, It's still unclear for me how this addition will be useful for applications. But here are my comments on the implementation. src/java.base/share/classes/java/util/LocaleISOData.java: - iso3166CodesMap has to use a ConcurrentHashMap. - The following code should use AssertionError rat

Re: RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

test/sun/util/locale/provider/Bug8152817.java is a test with a SecurityManager. I18n SQE should have some. Masayoshi On 11/14/2016 11:59 PM, Sean Mullan wrote: Looks good. Are there any regression tests for this component that run with a SecurityManager? If not, it would be useful to add some

Re: RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

+1 Masayoshi On 11/15/2016 1:07 AM, Naoto Sato wrote: +1 Naoto On 11/13/16 11:12 PM, Rachna Goel wrote: Hi, Kindly review fix for JDK-8168906. https://bugs.openjdk.java.net/browse/JDK-8168906 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/ fix: As jdk.localedata module does

Re: Request for Review: JDK-8165296: update i18n test cases in test/java/util/

Looks good to me. Masayoshi On 11/14/2016 4:13 PM, Nancy Nigam wrote: Hi, Please review the fix for JDK-8165296. Bug : https://bugs.openjdk.java.net/browse/JDK-8165296 Webrev: http://cr.openjdk.java.net/~nishjain/Nancy/8165296/webrev.07/

Re: RFR: jdk8u-dev Backport of 8169191: (tz) Support tzdata2016i

+1 On 11/11/2016 1:48 AM, Martin Buchholz wrote: Looks good! On Thu, Nov 10, 2016 at 1:48 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2016i) to JDK8U. Since tzdata is cumulative, this bug fix backports both the tzdata versions(tzdata2016h+tzdata2016i

Re: RFR: 8169191: (tz) Support tzdata2016i

+1 On 11/8/2016 1:36 AM, Martin Buchholz wrote: Looks good to me! On Mon, Nov 7, 2016 at 2:43 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2016i) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 Webrev: http://cr.openjdk.java.net/~rpatil/

Re: Review Request for JDK-8166994: Improve sun.util.locale.LocaleMatcher

Looks good to me. Masayoshi On 11/7/2016 4:51 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8166994 Bug: https://bugs.openjdk.java.net/browse/JDK-8166994 Webrev: http://cr.openjdk.java.net/~nishjain/8166994/webrev.02/ Fix: Modified values of LocaleEquivalentMaps.multiEquivsMap is

Re: RFR: 8168512: (tz) Support tzdata2016h

+1 Masayoshi On 10/24/2016 11:14 PM, Martin Buchholz wrote: Looks good to me! On Mon, Oct 24, 2016 at 12:28 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2016h) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8168512 Webrev: http://cr.openjd

RFR: 8152926: PropertyResourceBundle constructor don't understand the System.setProperty change

Hi, Please review the fix for JDK-8152926. This is a doc fix to clarify initialization of the encoding information with the java.util.PropertyResourceBundle.encoding property. Issue: https://bugs.openjdk.java.net/browse/JDK-8152926 Webrev: http://cr.openjdk.java.net/~okutsu/9/8152926/webrev.

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de, de_DE, en_US.

Looks good to me. Masayoshi On 10/20/2016 5:27 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names

RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIterator.gmk in order to avoid compiling non-BreakIterator*.java for the build tool with boot JDK. - Added sun.ut

Re: RFR: JDK-8167992 : Update documentation of java.util.Date class

10/17/16 3:00 PM, Masayoshi Okutsu wrote: Hi Rachna, Use of double quote is preferable for href. (i.e., href="http://...";>). Otherwise, the fix looks good to me. Thanks, Masayoshi On 10/14/2016 6:46 PM, Rachna Goel wrote: Hi, Please review a simple documentation fix for java.ut

Re: RFR: JDK-8167992 : Update documentation of java.util.Date class

Hi Rachna, Use of double quote is preferable for href. (i.e., href="http://...";>). Otherwise, the fix looks good to me. Thanks, Masayoshi On 10/14/2016 6:46 PM, Rachna Goel wrote: Hi, Please review a simple documentation fix for java.util.Date class. Bug : https://bugs.openjdk.java.net/br

Re: RFR: 8166875: (tz) Support tzdata2016g

Hi Ramanand, I don't think it's appropriate to add the bug ID to test/sun/util/resources/cldr/Bug8134384.java. This test doesn't verify the TimeZoneNames*.java changes of this fix. Otherwise, the change looks OK to me. Thanks, Masayoshi On 10/4/2016 7:22 PM, Ramanand Patil wrote: Hi Marti

Re: RFR:JDK-8166993: Typo in java.util.Locale

+1 Masayoshi On 10/3/2016 6:49 PM, Yuka Kamiya wrote: Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 16:22, Rachna Goel wrote: Hi, Please review this simple documentation fix for JDK-8166993. Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 webrev :http://cr.op

Re: Review Request for JDK-8165466: DecimalFormat percentage format can contain unexpected %

+1 Masayoshi On 10/3/2016 10:52 PM, Yuka Kamiya wrote: Hi Nisht, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 19:56, Nishit Jain wrote: Hi, Please review the fix for JDK-8165466 Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 Webrev: http://cr.openjdk.java.net/~nishjain

Re: RFR:JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider.

Hi Rachna, Sorry, but I've somehow overlooked this fix as java.time changes. The test needs to be written for java.time. Thanks, Masayoshi On 9/28/2016 5:13 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http:

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

Looks good to me. Masayoshi On 9/24/2016 2:00 PM, Philip Race wrote: 1) version change is only if the format is incompatible - so no change there. 2) paths being absent is not a new issue. It has always been the case that a file is not present on a system at runtime. This was historically ver

Re: Review Request for JDK-8165984: ResourceBundle lookup fields not completely thread-safe

+1 Masayoshi On 9/17/2016 2:00 AM, Naoto Sato wrote: Looks good. BTW, I believe making it "final" means to make sure every threads are guaranteed to see the same value, not because it is not changed after the construction. Naoto On 9/16/16 2:09 AM, Nishit Jain wrote: Hi, Please review

Re: RFR(xs): 8165936: Potential Heap buffer overflow when seaching timezone info files

Looks good to me. Thank you for fixing this bug! Masayoshi On 9/13/2016 11:49 PM, Thomas Stüfe wrote: Hi Christoph, thanks for your review! Yes, I can remove the blank. Kind Regards, Thomas On Tue, Sep 13, 2016 at 2:35 PM, Langer, Christoph wrote: Hi Thomas, your change looks good. I'm als

Re: Request for Review: JDK-8164791: update i18n test cases in test/java/text/Format

Looks good. Masayoshi On 9/2/2016 6:20 PM, Nancy Nigam wrote: Hi, Please review the fix for JDK-8164791. Bug : https://bugs.openjdk.java.net/browse/JDK-8164791 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8164791/webrev.06/ Fix : Updated I18n test cases in test/java/text/Format for deprec

RFR: 8157792: After Integrating tzdata2016d the test/sun/util/calendar/zi/TestZoneInfo310.java fails for "Asia/Oral" and "Asia/Qyzylorda" Timezones

Hi, Please review the fix for JDK-8157792. When a zone item wasn't used for any standard-daylight transition, the zone information was discarded. Therefore, its GMT offset change wasn't taken. Issue: https://bugs.openjdk.java.net/browse/JDK-8157792 Webrev: http://cr.openjdk.java.net/~okutsu/

Re: RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

Looks good to me. Masayoshi On 8/22/2016 1:26 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/ This is a cleanup fix in which Reflection usage in JavaAWTFontAcces

Re: RFR: JDK-8135055.java.util.Date.after(java.sql.Timestamp ) does not return correct results

Looks good to me. Masayoshi On 8/22/2016 1:51 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8135055. Bug: https://bugs.openjdk.java.net/browse/JDK-8135055 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8135055/webrev.02/ Fix is to return getTime() if argument to getMillisOf() is a

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

Looks good to me. Masayoshi On 8/22/2016 1:10 PM, Rachna Goel wrote: Hi Masayoshi, Thanks for the review. please have a look at updated webrev http://cr.openjdk.java.net/~rgoel/jdk-8163350/webrev.04/ Thanks, Rachna On 8/16/16 1:16 PM, Masayoshi Okutsu wrote: Hi Rachna, The fix looks

Re: RFR: JDK-7094818, JDK-8132861 and JDK-8134733

Looks good to me. Masayoshi On 8/22/2016 10:31 AM, Yuka Kamiya wrote: Hello, http://cr.openjdk.java.net/~peytoia/7094818.8132861.8134733/webrev.00/ Please review the fix for the following bugs: https://bugs.openjdk.java.net/browse/JDK-7094818 https://bugs.openjdk.java.net/browse/JDK-8132861

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

Hi Rachna, The fix looks good to me. But the test should be changed. - It's unnecessary to statically import sun.util.locale.provider.LocaleProviderAdapter.Type. - Variable name PreferenceList should be preferenceList. - No need to initialize preferenceList with an ArrayList. Thanks, Masayosh

Re: Review Request for JDK-8129555: DateFormatSymbols: month-related methods must refer to Calendar constants

Looks good to me. Masayoshi On 8/16/2016 2:26 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8129555 Bug: https://bugs.openjdk.java.net/browse/JDK-8129555 Webrev: http://cr.openjdk.java.net/~nishjain/8129555/webrev.02/ Fix: Added references to the Calendar constants in the api spe

Re: RFR: 8161203: ResourceBundle.getBundle performance regression

undleName(), ! bundle.getLocale(), ! bundle.format, loadSession.getLoader(), bundle, bundle.loadTime); In my opinion, the change of the semantics of ResourceBundle.clearCache(ClassLoader) could be tolerated if the invocation of that method was not a requirement for application cont

Re: Review Request for JDK-7153347: System read/stat/open calls should be hardened to handle EINTR

+1 Masayoshi On 8/1/2016 11:47 PM, Langer, Christoph wrote: Hi Nishit, this looks good and aligns with other places which were hardened for EINTR. But I'm not a reviewer, so you need to get a higher vote, still :) Best regards Christoph -Original Message- From: i18n-dev [mailto:i1

Re: Review Request : JDK-8066652 : Default TimeZone is GMT not local if user.timezone is invalid on Mac OS

+1 Masayoshi On 8/1/2016 6:40 AM, Langer, Christoph wrote: Thanks Rachna, that's fine now :) -Original Message- From: i18n-dev [mailto:i18n-dev-boun...@openjdk.java.net] On Behalf Of Rachna Goel Sent: Sonntag, 31. Juli 2016 19:47 To: i18n-dev@openjdk.java.net Subject: Re: Review Req

Re: RFR: 8161203: ResourceBundle.getBundle performance regression

eing GCed immediately. I can prototype such caching if you like. Regards, Peter On 07/22/2016 06:07 AM, Masayoshi Okutsu wrote: Hi Peter, Thank you for your suggestion. Actually CacheKey is used for storing information required to load resource bundles during a ResourceBundle.getBundle call.

Re: RFR: 8161203: ResourceBundle.getBundle performance regression

t future modification of code could unintentionally produce a class loader leak. To prevent that, I would somehow mark the clone so that any attempt to invoke getProviders() on the clone would throw IllegalStateException. Regards, Peter On 07/21/2016 06:14 AM, Masayoshi Okutsu wrote: Hi, Plea

RFR: 8161203: ResourceBundle.getBundle performance regression

Hi, Please review the fix for JDK-8161203. The fix is to lazily load ResourceBundleProviders. It's not necessary to load providers before cache look-up. Issue: https://bugs.openjdk.java.net/browse/JDK-8161203 Webrev: http://cr.openjdk.java.net/~okutsu/9/8161203/webrev.01 Thanks, Masayoshi

Re: Review Request-JDK-8154797:Localization data for "GMT"

+1 Masayoshi On 7/14/2016 2:15 AM, Naoto Sato wrote: +1 Naoto On 7/13/16 10:14 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. Please have a look at updated webrev : http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.05/ Thanks, Rachna On 7/13/2016 9:04 PM, Naoto Sato wrote: H

Re: RFR: 8159684: (tz) Support tzdata2016f

I don't think it's appropriate to add 8159684 to TimeZoneTest.java which doesn't test the data changes of 2016e/f at all. I think there should be a time zone data test in java.time to confirm the tzdata changes. Otherwise, the changes look good to me. Thanks, Masayoshi On 7/12/2016 6:27 PM, R

Re: Review Request for JDK-8055900: j.t.SimpleDateFormat spec needs to be clarified regarding month patterns

+1 Masayoshi On 7/7/2016 5:07 PM, Yuka Kamiya wrote: Hi, The fix looks okay to me. Thanks, -- Yuka On 2016/07/07 16:17, Nishit Jain wrote: Hi, Please review the fix for JDK-8055900 Bug: https://bugs.openjdk.java.net/browse/JDK-8055900 Webrev: http://cr.openjdk.java.net/~nishjain/8055900

RFR: 8136356: Add time zone mappings on Windows

Hi, Please review the fix for JDK-8136356. This fix addresses time zone changes of KB3039024, KB3148851, KB914387, and KB3162835. Issue: https://bugs.openjdk.java.net/browse/JDK-8136356 Webrev: http://cr.openjdk.java.net/~okutsu/9/8136356/webrev.00 Thanks, Masayoshi

RFR: 8159943: JavaTimeSupplementary resource bundles need update

Hi, Please review the fix for JDK-8159943. There were some problems in a tool to generate resource bundles. In addition, src/java.base/share/classes/sun/util/resources/LocaleData.java was fixed to look up resource bundles in java.base correctly. Issue: https://bugs.openjdk.java.net/browse/JD

Re: RFR: JDK-7090039: Wrong link in comment of java.text.DateFormatSymbols

Looks good. Masayoshi On 6/30/2016 4:07 PM, Yuka Kamiya wrote: Hi, Please review a simple doc fix. https://bugs.openjdk.java.net/browse/JDK-7090039 --- a/src/java.base/share/classes/java/text/DateFormatSymbols.java +++ b/src/java.base/share/classes/java/text/DateFormatSymbols.java @@ -221,7

Re: Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

+1 Masayoshi On 6/28/2016 2:12 AM, Naoto Sato wrote: I'd wrap long lines, others look good to me. Naoto On 6/27/16 2:46 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. I have modified test as per suggestions. Please have a look at : http://cr.openjdk.java.net/~rgoel/8158504/webrev

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

6/20/16 7:53 PM, Masayoshi Okutsu wrote: If the long pattern string is avoided, it'll be unnecessary to use "%%" and replaceAll? I'm also concerned to keep concatenating strings to produce a long string (rather than using a StringBuilder). Would that be the reason to put -verbose:

RFR: 8159766: "Switching encoding from UTF-8 to ISO-8859-1" log message should be trace/debug message

Hi, Please review the fix for JDK-8159766. The logging code has been removed after all. No additional regression test. The message should no longer be logged to the .jtr file with java/util/ResourceBundle/UTF8Properties/CodePointTest.java. Issue: https://bugs.openjdk.java.net/browse/JDK-8159

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

If the long pattern string is avoided, it'll be unnecessary to use "%%" and replaceAll? I'm also concerned to keep concatenating strings to produce a long string (rather than using a StringBuilder). Would that be the reason to put -verbose:gc in the test program? Use of List will simplify the p

Re: Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

Looks good. Thanks, Masayoshi On 6/17/2016 5:16 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Changed the toLowerCase() method on language-ranges and

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

I've been waiting for JDK-8159206 to be fixed. But this test still fails after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and pushed this test fix with the following ProblemList.txt change: diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++

Re: Review Request for JDK-8135061: java.util.Locale#lookup throws java.lang.StringIndexOutOfBoundsException for range having '-' as second character

Looks good to me. Masayoshi On 6/13/2016 6:54 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8135061 Bug: https://bugs.openjdk.java.net/browse/JDK-8135061 Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.01/ Fix : Added a check on the lastIndexOf "-" before using substri

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

On 6/11/2016 5:53 AM, Mandy Chung wrote: On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu wrote: (re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. : Webrev: http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00 It’s

Re: Review Request for JDK-8040211: Update LSR datafile for BCP 47

Looks good to me. Masayoshi On 6/10/2016 3:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8040211 Bug: https://bugs.openjdk.java.net/browse/JDK-8040211 Webrev: http://cr.openjdk.java.net/~nishjain/8040211/webrev.02/ Fix: Updated the Language Subtag Registry data provided by IAN

RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

(re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. - A child process doesn't inherit IO. Any outputs from the child process are not logged. - The exit code of a child process is ignored. The exit code needs to be checked by the t

RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

Hi, Please review fixes for 8158272 and 8158468. The test had several problems. - A child process doesn't inherit IO. Any outputs from the child process are not logged. - The exit code of a child process is ignored. The exit code needs to be checked by the test. - A child process should use th

Re: Review Request for JDK-8047780: Locale.LanguageRange() throws an undocumented IAE when range is ill-formed.

Looks good. Masayoshi On 6/7/2016 2:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8047780 Bug: https://bugs.openjdk.java.net/browse/JDK-8047780 Webrev: http://cr.openjdk.java.net/~nishjain/8047780/webrev.01/ Fix: Added in the api spec that the IllegalArgumentException can be

Re: Review request: JDK-8158604: test/java/util/ResourceBundle/modules/appbasic missing @test

Glad you fixed this earlier prototype of appbasic which had accidentally(?) been pushed to Jake. The copyright year of some files haven't been updated. Otherwise, this fix looks good to me. Thanks, Masayoshi On 6/3/2016 1:09 PM, Mandy Chung wrote: Masayoshi, test/java/util/ResourceBundle/mo

Re: Review Request for JDK-8072099: Format "ha" is unable to parse hours 10-12

+1 On 5/31/2016 4:14 PM, Yuka Kamiya wrote: Hi, The fix looks good to me. Thanks, -- Yuka On 2016/05/31 15:00, Nishit Jain wrote: Hi, Please review the fix for JDK-8072099. Webrev: http://cr.openjdk.java.net/~nishjain/8072099/webrev.03/ Bug: https://bugs.openjdk.java.net/browse/JDK-80720

Re: RFR: 8151876: (tz) Support tzdata2016d

sia/Almaty" instead of "Alma-Ata Time" Regards, Sean. On 27/05/16 15:24, Masayoshi Okutsu wrote: This change seems to beyond my proposal that the "GMT±hh:mm" format is used for *new* zones with the "±hh" format. But this change

Re: Review Request for JDK-8158025: Typo in java.util.Locale

Looks good to me. Masayoshi On 5/30/2016 3:00 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8158025. Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8158025 Fix: corrected a small typo in Locale.java. Regards, Nishi

RFR: 8039565: Remove test exclusion for java/util/ResourceBundle/RestrictedBundleTest.java

Hi, Please review the fix for JDK-8039565. I don't think it's worth keeping this old test and decided to remove it. Issue: https://bugs.openjdk.java.net/browse/JDK-8039565 Webrev: http://cr.openjdk.java.net/~okutsu/9/8039565/webrev.00 Thanks, Masayoshi

Re: Review Request for JDK-8145136:Upgrade CLDR locale data

Other than the copyright year things, all looks good to me. I don't think further review is required for copyright update. Masayoshi On 5/28/2016 3:25 AM, Naoto Sato wrote: Hi Rachna, Here are my comments to the webrev (I am assuming the tool that extracts JavaTime*.java are working correctl

Re: RFR: 8151876: (tz) Support tzdata2016d

ame(..) calls that can be made. e.g. "Asia/Almaty" instead of "Alma-Ata Time" Regards, Sean. On 27/05/16 15:24, Masayoshi Okutsu wrote: This change seems to beyond my proposal that the "GMT±hh:mm" format is used for *new* zones with the "±hh" format. But th

Re: RFR: 8151876: (tz) Support tzdata2016d

This change seems to beyond my proposal that the "GMT±hh:mm" format is used for *new* zones with the "±hh" format. But this change removes *existing* zones which have changed to use the "±hh" format in tzdata. Can this cause any compatibility issues? And have we agreed to use the "GMT±hh:mm" f

Re: RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

On 5/26/2016 7:07 PM, Alan Bateman wrote: On 26/05/2016 10:41, Masayoshi Okutsu wrote: Naoto pointed out that test/java/text/Format/common/*Format.props should have the copyright header. Unfortunately, test/java/text/Format/common/PParser.java, which parses the .props files, doesn't su

Re: RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

tsu/9/8031145/webrev.01. On 5/24/2016 11:49 PM, Masayoshi Okutsu wrote: Changed all binary files (serialized objects) into hex dump text files (with ".ser.txt" suffix) and added a utility class to read it as an InputStream. Updated webrev: http://javasoft.jp.oracle.com/~mokutsu/9/80

Re: RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

eman wrote: On 23/05/2016 10:12, Masayoshi Okutsu wrote: On 5/23/2016 5:10 PM, Alan Bateman wrote: Is there anything that we can do with the binary files? In the case of the .ser file then could it be a byte[] in the test with an execution mode that re-generates it? There is also at least one .data

Re: RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

On 5/23/2016 5:10 PM, Alan Bateman wrote: Is there anything that we can do with the binary files? In the case of the .ser file then could it be a byte[] in the test with an execution mode that re-generates it? There is also at least one .data file that looks to be the serialized version of a b

RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

Hi, Please review changes for JDK-8031145 that is to open closed i18n tests. There are many old tests which should be cleaned up. I did some, but there are still many. Issue: https://bugs.openjdk.java.net/browse/JDK-8031145 Webrev: http://cr.openjdk.java.net/~okutsu/9/8031145/webrev.00/ Tha

Re: Review Request for JDK-8149452: j.t.SimpleDateFormat.getDateFormatSymbols().getZoneStrings() returns incorrect result for some time zones

Looks good to me. Masayoshi On 5/18/2016 6:38 PM, Nishit Jain wrote: Hello All, Please review the fix for JDK-8149452 Bug: https://bugs.openjdk.java.net/browse/JDK-8149452 Webrev: http://cr.openjdk.java.net/~nishjain/8149452/webrev.01/ Fix: Made some changes to the CLDRConverter.java to han

Re: Review Request for JDK-7102969 and JDK-8157138: "currency.properties supercede..." and "Error while fetching currency instance..."

+1 Masayoshi On 5/19/2016 5:40 PM, Yuka Kamiya wrote: Hi Nishit, The fix looks okay to me. Thanks, -- Yuka On 2016/05/19 16:04, Nishit Jain wrote: Hello All, Please review the updated webrev synced with the latest repository. http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webre

Re: Review Request for JDK-8154295 : Currency iso code is int and hence looses the preceeding zero.

Looks good to me. Thanks, Masayoshi On 5/6/2016 3:19 PM, Nishit Jain wrote: Hello All, Please review the fix for JDK-8154295. http://cr.openjdk.java.net/~nishjain/8154295/webrev.07/ Changes made to the webrev.04: Added a simple test case and some comments Regards, Nishit Jain On 5/2/2016 11

Re: Review Request for JDK-8150324: java/util/Currency/CurrencyTest.java does not restore default TimeZone

Looks good to me. Masayoshi On 4/11/2016 9:18 PM, Nishit Jain wrote: Hi, Thanks for pointing that out. Please review the updated webrev at the below mentioned link http://cr.openjdk.java.net/~peytoia/Nishit/8150324/webrev.02/ Regards, Nishit Jain On 4/11/2016 4:46 PM, Yuka Kamiya wrote: H

RFR: 8153836: java/util/ResourceBundle/Bug6299235Test.sh depends on java.desktop

Hi all, Please review the fix for JDK-8153836. Issue: https://bugs.openjdk.java.net/browse/JDK-8153836 Webrev: http://cr.openjdk.java.net/~okutsu/9/8153836/webrev.00/ Thanks, Masayoshi

Re: RFR: JDK-7129443: (cal) Difference between comment and implementation of DAY_OF_WEEK_IN_MONTH

Looks good to me. Masayoshi On 4/8/2016 1:40 PM, Yuka Kamiya wrote: > Hi, > > I'm sending this RFR in place of Nishit Jain.This is a small doc change. > > Please review the webrev for the JDK-7129443 > > Bug: https://bugs.openjdk.java.net/browse/JDK-7129443 > Webrev: http://cr.openjdk.java.net/~p

Re: RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

the cache. Right. But that one is too tricky to handle there. - DateFormatSymbolsCloneTest.java: import sentence for the Locale class can be removed. Good catch. Fixed. Masayoshi Naoto On 4/6/16 2:10 AM, Masayoshi Okutsu wrote: Hi all, Please review the fix for JDK-8151431. clone() is no

RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

Hi all, Please review the fix for JDK-8151431. clone() is no longer called to create a cache entry. Issue: https://bugs.openjdk.java.net/browse/JDK-8151431 Webrev: http://cr.openjdk.java.net/~okutsu/9/8151431/webrev.00/ Thanks, Masayoshi

Re: RFR: 8151876: (tz) Support tzdata2016c

Looks good to me. But I'd like someone from java.time to review the changes to see if it's OK for java.time. Masayoshi On 4/4/2016 6:50 PM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA (tzdata2016c) integration to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8151876

Re: [9] RFR: 8153041: Remove unused redundant parameter in CLDRConverter

Looks good to me. Masayoshi On 3/31/2016 2:03 AM, Naoto Sato wrote: Hello, Please review this simple fix to the subject bug: https://bugs.openjdk.java.net/browse/JDK-8153041 The fix is located at: http://cr.openjdk.java.net/~naoto/8153041/webrev.00/ Naoto

Re: RFR: 8152817: Locale data loading fails silently when running with a security manager

/ Thanks, Masayoshi On 3/31/2016 8:56 AM, Masayoshi Okutsu wrote: On 3/31/2016 12:54 AM, Alan Bateman wrote: On 30/03/2016 16:48, Mandy Chung wrote: On Mar 30, 2016, at 8:40 AM, Masayoshi Okutsu wrote: Hello, Please review the fix for JDK-8152817. The fix is to load locale data from its own

Re: RFR: 8152817: Locale data loading fails silently when running with a security manager

On 3/31/2016 12:54 AM, Alan Bateman wrote: On 30/03/2016 16:48, Mandy Chung wrote: On Mar 30, 2016, at 8:40 AM, Masayoshi Okutsu wrote: Hello, Please review the fix for JDK-8152817. The fix is to load locale data from its own module without calling

RFR: 8152817: Locale data loading fails silently when running with a security manager

Hello, Please review the fix for JDK-8152817. The fix is to load locale data from its own module without calling ResourceBundleProviderSupport.loadResourceBundle. I changed the synopsis of the JBS issue because it's a general issue of loading locale data under a security manager, and the reg

RFR: 8152077: (cal) Calendar.roll does not always roll the hours during daylight savings changes

Hello, Please review the fix for JDK-8152077. There's a bug in the roll method around the standard/daylight saving time transitions. I've changed the implementation to perform the "roll" operation based on the wall-clock time rather than the UTC time (the offset from the Epoch). Issue: https

Re: RFR: 8151876: (tz) Support tzdata2016b

"Astrakhan Time", "ASTT"}}, +{"Europe/Ulyanovsk", new String[] {"Ulyanovsk Time", "ULT", + "Ulyanovsk Summer Time", "ULST", +

Re: Review Request for JDK-8150432: java/util/Locale/LocaleProviders.sh failed on Win10.

Looks good to me. Masayoshi On 3/28/2016 3:15 PM, Rachna Goel wrote: Hi all, Please review a small fix for JDK-8150432. Bug and proposed fix are located at below links respectively. https://bugs.openjdk.java.net/browse/JDK-8150432 http://cr.openjdk.java.net/~rgoel/8150432/webrev/

Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

you in advance, Dmitry On 20/03/2016 07:11, Masayoshi Okutsu wrote: The fix looks Okay to me. But there should be a regression test for this particular case? I wonder if we can have a test case to verify width(s) of monospaced glyphs. Masayoshi On 3/18/2016 4:54 AM, Phil Race wrote: I think you

Re: RFR: 8151876: (tz) Support tzdata2016b

Sorry for this belated response. I prefer to follow the tzdata abbreviations, like "+04". But that would require some major changes. An option would be not to define time zone names for the new zones with the +hh format. Thanks, Masayoshi On 3/17/2016 4:38 AM, Ramanand Patil wrote: Hi all,

Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

The fix looks Okay to me. But there should be a regression test for this particular case? I wonder if we can have a test case to verify width(s) of monospaced glyphs. Masayoshi On 3/18/2016 4:54 AM, Phil Race wrote: I think you are still waiting on i18n to reply here since the exclusion rang

Re: RFR: JDK-8087104: DateFormatSymbols triggers this.clone() in the constructor

Looks good to me. Masayoshi On 2/24/2016 4:40 PM, Ramanand Patil wrote: Hi all, Please review the fix for bug: https://bugs.openjdk.java.net/browse/JDK-8087104 Bug Description: DateFormatSymbols caches its own instance and calls this.clone() in the constructor. Because of this, any subclass im

Re: [9] RFR: 8148346: Reduce number of packages in jdk.localedata module

This one is much easier to take a look than the previous webrevs. This time I've looked at all diffs while I did a sampling for our internal review. Looks OK to me. I still prefer the per-language (not per-language.country) grouping, though. Masayoshi On 2/19/2016 2:50 AM, Naoto Sato wrote:

Re: RFR: 8148446: (tz) Support tzdata2016a

Looks good to me. Masayoshi On 2/4/2016 5:55 PM, Ramanand Patil wrote: Hi Masayoshi/all, Please review the updated Webrev at: http://cr.openjdk.java.net/~rpatil/8148446/webrev.01/ Regards, Ramanand. -Original Message- From: Masayoshi Okutsu Sent: Thursday, February 04, 2016 12:17 PM

Re: RFR: 8148446: (tz) Support tzdata2016a

Hi Ramanand, I noticed that the zones in Yakutsk Time [1] seem to have their own names, such as "Khandyga Time" for Asia/Khandyga, and you seem to follow that convention for Asia/Chita. That causes some mismatch between the long names and abbreviations. I dag out some past tzdata fixes to se

Re: RFR: JDK-8147912: test "parseWithZoneWithoutOffset" of java/time/tck/java/time/format/TCKDTFParsedInstant.java fail on de_DE locale

Looks OK to me. But I'd like some java.time people to review this change to see if the intention of this test is to run only in English. Thanks, Masayoshi On 1/27/2016 1:51 PM, Ramanand Patil wrote: Hi all, Please help me in reviewing this test fix. Regards, Ramanand. From: Raman

Re: RFR: JDK-8144988: Unexpected timezone returned after parsing a date

- From: Masayoshi Okutsu Sent: Friday, January 15, 2016 8:18 AM To: Ramanand Patil; i18n-dev@openjdk.java.net Cc: core-libs-...@openjdk.java.net Subject: Re: RFR: JDK-8144988: Unexpected timezone returned after parsing a date Hi Ramanand, test/java/text/Format/DateFormat/Bug8141243.java

Re: RFR: JDK-8026766: Add toString() to j.u.Locale.LanguageRange.

Looks good to me. Masayoshi On 1/15/2016 1:18 PM, Yuka Kamiya wrote: > Hi, > > Please review this simple fix for JDK-8026766: Add toString() to > j.u.Locale.LanguageRange. > https://bugs.openjdk.java.net/browse/JDK-8026766 > > http://cr.openjdk.java.net/~peytoia/8026766/webrev.00/ > > Of course,

Re: RFR: JDK-8144988: Unexpected timezone returned after parsing a date

Hi Ramanand, test/java/text/Format/DateFormat/Bug8141243.java: 28 * @run main Bug8141243 29 * @run main/othervm -Djava.locale.providers=COMPAT Bug8141243 "COMPAT" is a new name of "JRE" in JDK 9. It's not supported in 8u. I think COMPAT is slightly ignored and that it becomes the same th

Re: [9] RFR: Host Locale Provider Adapter fixes on Windows

The copyright year should be 2016 now. Otherwise, the fixes look OK to me. Masayoshi On 1/5/2016 4:10 AM, Naoto Sato wrote: Hello, I fixed several bugs in Windows' host locale provider adapter: 8039301: [ja] Host Locale Provider uses non-translated Calendar field names 8039969: Old Korean C

  1   2   3   4   >