+1
Masayoshi
On 6/28/2016 2:12 AM, Naoto Sato wrote:
I'd wrap long lines, others look good to me.
Naoto
On 6/27/16 2:46 AM, Rachna Goel wrote:
Hi Naoto,
Thanks for the review.
I have modified test as per suggestions.
Please have a look at :
http://cr.openjdk.java.net/~rgoel/8158504/webrev.06/
Regards,
Rachna
On 6/23/2016 9:35 PM, Naoto Sato wrote:
Hi Rachna,
The test needs to be modified to ensure locales only for ROOT and
en_US* locales for java.base module. Currently it would pass if
getAvailableLocales() included English locales other than US ones, say
en_GB. I should have corrected it, but apparently I overlooked.
> if (nonEnglishLocales.size() > 0) {
You could use !isEmpty() instead.
Naoto
On 6/23/16 2:09 AM, Rachna Goel wrote:
Hi,
Please review fix for JDK-8158504.
Bug : https://bugs.openjdk.java.net/browse/JDK-8158504
Webrev : http://cr.openjdk.java.net/~nishjain/rgoel/8158504/webrev.03/
Fix : Removed java.ext.dirs System property as it is no longer
supported
in JDK9 and used "-limitmods java.base" to load only java.base.
(To hide jdk.localedata module).
JRE is COMPAT in JDK9.
outputted some useful information if test fails somewhere.
