Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-02 Thread Guillaume Smet
Hi Hardy, The SearchFactory.getIndexedTypes API looks nice. Would it be possible to also expose something like getRootIndexedTypes based on the magic done in MassIndexerImpl.toRootEntities? We have copied the code of MassIndexerImpl.toRootEntities in our framework to do so but it would be nice t

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
(Hardy, sorry for the double post, forgot the list) On Mon, Aug 5, 2013 at 3:20 PM, Hardy Ferentschik wrote: > TBH i am not completely sure I understand what the method does. The docs says: > > "From the set of classes a new set is built containing all indexed > subclasses, but removing then all

[hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Guillaume Smet
Hi all, It's been a long time since the last release of JPA modelgen and we fixed a couple of annoying bugs, namely: https://hibernate.atlassian.net/browse/METAGEN-81 https://hibernate.atlassian.net/browse/METAGEN-82 And this one was a work in progress a long time ago and I should probably go bac

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik wrote: >> And this one was a work in progress a long time ago and I should >> probably go back to work on it to provide some feedback to Hardy: >> https://hibernate.atlassian.net/browse/METAGEN-85 > > Right, I still have not been able to reproduce

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 5:37 PM, Sanne Grinovero wrote: > I understand my code, but I'm not sure I understood why you would need this? Instead of calling the mass indexer directly for all our classes, we get the root indexed types and we index them one by one using the mass indexer. This is the o

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 6:07 PM, Sanne Grinovero wrote: > So we actually would be better off fixing that issue, rather than > polluting the metadata API with hard to explain methods. > > Fixing the issue in its entirety is very complex, but what would you > think of having an option to run the Mass

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 6:45 PM, Sanne Grinovero wrote: > Great, that's https://hibernate.atlassian.net/browse/HSEARCH-1384 > then. Guillaume, is that something you would consider giving a try > yourself? Yep. I'll have a look and see if I can come up with something. I assigned the JIRA issue to

[hibernate-dev] Code templates file is empty in the wiki

2013-08-06 Thread Guillaume Smet
Hi, Looks like there is a problem with the code templates file here: https://community.jboss.org/wiki/ContributingToHibernateUsingEclipse It looks empty and it sure wasn't before (there was at least the copyright notice in it). I needed it to set up my new Kepler environment for HSEARCH and I ca

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-06 Thread Guillaume Smet
Hi, On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik wrote: > +1 We really need to get a release out. As you say we have a couple of things > which are actually resolved > and just need a release, but I also think at the very least we need to look > at METAGEN-92. > Basically we need to get th

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-06 Thread Guillaume Smet
On Tue, Aug 6, 2013 at 6:38 PM, Hardy Ferentschik wrote: >> I think we should move to .Next: >> - METAGEN-72 - Generate attributes for @Transient columns : it might >> be nice to have but it's definitely not something required (there are >> a lot of other binding generators out there like bindgen)

[hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Guillaume Smet
Hi, AFAICS in the pom.xml, Search is now compiled for Java 6. I think It would be a good idea to add the @Override annotation to the methods implemented from an interface, considering it's supported in Java 6. I'm willing to do the grunt work and prepare a pull request in the next few days if yo

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Guillaume Smet
Hi Gunnar, On Fri, Aug 9, 2013 at 6:19 PM, Gunnar Morling wrote: > Not sure though whether an ad-hoc action is required to add it everywhere. > In Eclipse I'm having a "save action" which adds it to every file I'm > touching in the course of other work I'm doing. I don't like that much this sort

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-12 Thread Guillaume Smet
Hi, On Fri, Aug 9, 2013 at 6:41 PM, Guillaume Smet wrote: > I'll see what I can do about it as everyone seems to agree with it. Done thanks to Eclipse quick fix: https://hibernate.atlassian.net/browse/HSEARCH-1387 https://github.com/hibernate/hibernate-search/pull/467 It would proba

[hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Guillaume Smet
Hi, I'm planning to work on the pom files in the next few days. Here is more or less the plan I have in mind: - centralize all dependencies versions in the properties of the parent pom file. A couple of them are directly in the dependencyManagement block. It's easier to update them this way. - sa

[hibernate-dev] HSEARCH - Different analyzers for Indexing and Querying

2013-08-13 Thread Guillaume Smet
Hi, Note: this is just a prospective idea I'd like to discuss. Even if it's a good idea, it's definitely 5.0 material. Those who have used Solr and are familiar with the Solr schema have already seen the ability to use different analyzer for indexing and querying. It's usually useful when you us

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Guillaume Smet
On Tue, Aug 13, 2013 at 10:58 AM, Sanne Grinovero wrote: > On 13 August 2013 09:12, Guillaume Smet wrote: >> Hi, >> >> I'm planning to work on the pom files in the next few days. >> >> Here is more or less the plan I have in mind: >> - centralize al

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-14 Thread Guillaume Smet
Hi, Here we go for the current state of my work and what I would like to do: https://hibernate.atlassian.net/browse/HSEARCH-1392 I created a PR so that we can discuss the changes already made: https://github.com/hibernate/hibernate-search/pull/472 Thanks for your feedback. -- Guillaume ___

Re: [hibernate-dev] [Search] Why is global @AnalyzerDefs scanning limited to @Entity?

2013-08-22 Thread Guillaume Smet
Hi Emmanuel, On Wed, Aug 21, 2013 at 4:52 PM, Emmanuel Bernard wrote: > To me the real answer is to the programmatic API and add a > programmatic mapping factory to your configuration. > > See Example 4.28. Use a mapping factory in > http://docs.jboss.org/hibernate/search/4.4/reference/en-US/html

Re: [hibernate-dev] HSEARCH - Different analyzers for Indexing and Querying

2013-08-22 Thread Guillaume Smet
Hi Emmanuel, On Wed, Aug 21, 2013 at 5:20 PM, Emmanuel Bernard wrote: > Can you explain to me why you would need a different analyzer for a > wildcard query? My brain is still tanning on the beach. Well, it's the Lucene way. Wildcard queries are usually not analyzed (see QueryParser or what you'

[hibernate-dev] [SEARCH] Result ignored if proxy isn't initialized

2013-11-04 Thread Guillaume Smet
Hi, We have a weird problem here with Search 4.3 and ORM 4.2.7.SP1. I wonder if it rings a bell for anyone? In yet to determined circumstances, an object is missing from the search results. This object is returned by the Lucene search but is not added in the results because it isn't initialized.

Re: [hibernate-dev] [SEARCH] Result ignored if proxy isn't initialized

2013-11-05 Thread Guillaume Smet
Hi Sanne, On Mon, Nov 4, 2013 at 11:21 PM, Sanne Grinovero wrote: > Definitely needs further inspection, could you please open a JIRA? Done: https://hibernate.atlassian.net/browse/HSEARCH-1448 > Would you be able to verify the same problem with the simple HashMap > second level cache? > I'm won

[hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-05 Thread Guillaume Smet
Hi all, ORM 4.2.8.Final breaks the API of EntityKey as it removes tenantId from the constructor. Typically, in HSearch, we have the following call: https://github.com/hibernate/hibernate-search/blob/master/orm/src/main/java/org/hibernate/search/query/hibernate/impl/PersistenceContextObjectsInitia

Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-05 Thread Guillaume Smet
-orm/commit/bf26311474257c2f0118615e003553095c2d87b0 > > > On 12/05/2013 10:51 AM, Guillaume Smet wrote: >> >> Hi all, >> >> ORM 4.2.8.Final breaks the API of EntityKey as it removes tenantId >> from the constructor. >> >> Typically, in HSearch, we have th

Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-05 Thread Guillaume Smet
ly merit going through > an entire SP release. I'd fix it for 4.2.9, before compatibility in other > products became an actual issue. Any strong arguments against that? > > Brett Meyer > Software Engineer > Red Hat, Hibernate ORM > > - Original Message

Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-05 Thread Guillaume Smet
On Thu, Dec 5, 2013 at 5:31 PM, Guillaume Smet wrote: > I'm working on a pull request to fix the problem in search as > requested by Steve. Done: https://github.com/hibernate/hibernate-search/pull/521 -- Guillaume ___ hibernate-dev m

Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-06 Thread Guillaume Smet
just communicate about it? Thanks for your feedback. On Thu, Dec 5, 2013 at 5:46 PM, Guillaume Smet wrote: > On Thu, Dec 5, 2013 at 5:31 PM, Guillaume Smet > wrote: >> I'm working on a pull request to fix the problem in search as >> requested by Steve. > > Done: http

Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and thus HSearch

2013-12-06 Thread Guillaume Smet
forts? > > The release blog would then also be an appropriate medium to warn > about the incompatibility. > > Sanne > > > On 6 December 2013 10:30, Guillaume Smet wrote: >> Is there any decision taken about this? >> >> I find the situation to have 2 major Hiber

Re: [hibernate-dev] To release a Hibernate Search 4.5.0.Alpha2?

2013-12-11 Thread Guillaume Smet
Hi Sanne, On Wed, Dec 11, 2013 at 3:23 PM, Sanne Grinovero wrote: >> Yes - https://github.com/hibernate/hibernate-search/pull/523 (HSEARCH-1442) >> I’ll need to confirm the fix and we should give the reporters a chance to >> verify against >> a snapshot. If the fix looks good we should add it t

[hibernate-dev] Mass indexer and lazy initialization exceptions S03E04

2014-01-08 Thread Guillaume Smet
Hi all, It's been quite a long time since I came up with lazy initialization problems in the mass indexer for the last time. Unfortunately, this time, I don't see exactly how to fix this one and I would like to ask for your advice about it. The problem is quite simple: I want to index the resul

Re: [hibernate-dev] Mass indexer and lazy initialization exceptions S03E04

2014-01-08 Thread Guillaume Smet
Hi Sanne, On Wed, Jan 8, 2014 at 1:43 PM, Sanne Grinovero wrote: > As far as I remember, you and your team reported (and helped fixing!) > a depressingly long list of issues since approximately the migration > to Hibernate ORM 4 of your applications (adopting AFAIR early betas of > Search 4.2 at

Re: [hibernate-dev] Mass indexer and lazy initialization exceptions S03E04

2014-01-13 Thread Guillaume Smet
Hi Sanne, On Mon, Jan 13, 2014 at 1:06 AM, Sanne Grinovero wrote: > Then, you can remove all the previous workarounds too: given we'd be > removing the re-attach processing and all the proxy re-attaching code, > it might even win you something in performance.. I don't know that for > sure, but se

Re: [hibernate-dev] Mass indexer and lazy initialization exceptions S03E04

2014-01-14 Thread Guillaume Smet
On Tue, Jan 14, 2014 at 12:11 AM, Sanne Grinovero wrote: > Of course I'm ok with that. If any I was under the impression you > needed a solution urgently; if that's the case, be aware I suspect > this could be a trivial change. It's for a sort on a table (but an important one) so I can make the c

[hibernate-dev] Make HibernatePersistenceProvider easier to extend

2014-01-23 Thread Guillaume Smet
Hi, I'm starting our migration to ORM 4.3 to be able to provide some (hopefully useful) feedback on ORM 4.3 and Search 4.5. One thing we did in most of our apps was injecting Spring managed interceptor into the session factory using a trick very similar to what is explained there: http://blog.kre

Re: [hibernate-dev] [Search] DisjunctionMaxQuery and MoreLikeThis

2014-02-20 Thread Guillaume Smet
Hi Emmanuel, On Thu, Feb 20, 2014 at 10:19 AM, Emmanuel Bernard wrote: > ## DisMax as top level DSL feature > > Should we add .dismax() like we did bool()? > I am hard pressed to find a use case. It's a project I have for a long time. I wanted to have an intern this year to work on this and a fe

Re: [hibernate-dev] [Search] DisjunctionMaxQuery and MoreLikeThis

2014-02-20 Thread Guillaume Smet
On Thu, Feb 20, 2014 at 6:33 PM, Emmanuel Bernard wrote: > BTW DisjunctionMaxQuery (which is what I refered to in .dismax()) is > used in the DisMax query parser of Slor but is only a component of it. > So I see your requested feature as a different one than what I discussed > in this email. Still

[hibernate-dev] Search: changing the way we search

2014-03-03 Thread Guillaume Smet
Hi, So, it's been a long time since I threw the first idea of this (see HSEARCH-917) but, after a lot more thoughts, and the fact that I'm basically stuck for a long time on this one, it's probably better to agree with a plan before putting together some code. Note that this plan is based on our

Re: [hibernate-dev] [Wildcard] Search: changing the way we search

2014-03-04 Thread Guillaume Smet
On Tue, Mar 4, 2014 at 11:09 AM, Emmanuel Bernard wrote: > I would like to separate the notion of autosuggestion from the wildcard > problem. To me they are separate and I would love to Hibernate Search to > offer an autosuggest and spell checker API. AFAICS from the changelog of each version,

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-04 Thread Guillaume Smet
Hi Emmanuel, On Tue, Mar 4, 2014 at 11:09 AM, Emmanuel Bernard wrote: >> Here are pointers to the main problems I have: >> 1/ the getAllTermsFromText is cute when you want to OR the terms but >> really bad when you need AND, especially when you use analyzers which >> returns several tokens for a

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-04 Thread Guillaume Smet
On Tue, Mar 4, 2014 at 1:36 PM, Emmanuel Bernard wrote: > OK so you want the words hotel + swimming pool to be present somewhere in the > sum of the corpus of title and description. That's the second case I was > describing then. Indeed it kinda fails if you don't order by score but rather > al

Re: [hibernate-dev] [Wildcard] Search: changing the way we search

2014-03-04 Thread Guillaume Smet
On Tue, Mar 4, 2014 at 1:24 PM, Emmanuel Bernard wrote: > And to be fair, how do you plan to make wildcard and wi fi work together in > Lucene (any solution available). The solution I can think of is to index the > property with an analyzer stack that does not split words like that in two > tok

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-04 Thread Guillaume Smet
On Tue, Mar 4, 2014 at 6:27 PM, Emmanuel Bernard wrote: > Yes a text() branch injecting whatever from the user and letting the > developer customise what needs to be searched makes sense to me. > We can explore that but I am a bit skeptical that it will turn into a true > `text()` clause rather

[hibernate-dev] ClassCastException with 2nd level cache not entirely gone?

2014-03-07 Thread Guillaume Smet
Hi all, We just hit the ClassCastException problem with 2nd level cache reported by other people. But... we're using *4.3.4.Final* so I'm not sure this issue has really been fixed with 4.3.4.Final. Typically, we have the following hierarchy: AbstractUser TechnicalUser (id = 1) AccountMan

Re: [hibernate-dev] ClassCastException with 2nd level cache not entirely gone?

2014-03-07 Thread Guillaume Smet
Hi Sanne, On Fri, Mar 7, 2014 at 12:05 PM, Sanne Grinovero wrote: > thanks for the timely notice: that's critical. Please open a new > issue, we usually don't reopen issues which where already included in > some release. Thanks for you quick feedback. Done: https://hibernate.atlassian.net/brows

Re: [hibernate-dev] ClassCastException with 2nd level cache not entirely gone?

2014-03-07 Thread Guillaume Smet
On Fri, Mar 7, 2014 at 12:12 PM, Guillaume Smet wrote: > https://hibernate.atlassian.net/browse/HHH-9028 FWIW, I posted a test case and a patch proposal. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org ht

[hibernate-dev] Code templates empty on "Contributing to Hibernate using Eclipse" page

2014-03-07 Thread Guillaume Smet
Hi, I already mentioned it here a while ago: the code-templates.xml file at the bottom of https://community.jboss.org/wiki/ContributingToHibernateUsingEclipse is empty. IIRC, it should at least contain the Copyright header? Thanks! -- Guillaume ___ h

Re: [hibernate-dev] Code templates empty on "Contributing to Hibernate using Eclipse" page

2014-03-11 Thread Guillaume Smet
On Mon, Mar 10, 2014 at 4:26 PM, Brett Meyer wrote: > Done! Thanks for pointing it out -- not sure how that happened to begin with. Thanks, Brett. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailm

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-18 Thread Guillaume Smet
Hi, On Tue, Mar 4, 2014 at 7:06 PM, Guillaume Smet wrote: > I'll post as soon as I have a working prototype of what I would like > to achieve and then we can discuss from there. I finally succeeded in committing a few hours to prototype what I have in mind: https://github.com/op

[hibernate-dev] DefaultLoadEventListener and second level cache

2014-03-19 Thread Guillaume Smet
Hi, We have a lot of second level cache misses on one of our applications and I wanted to understand why it was the case. These cache misses happen even after loading twice the exact same page. They are coming from entities which are loaded via DefaultLoadEventListener. I tried to debug it and wa

Re: [hibernate-dev] Make HibernatePersistenceProvider easier to extend

2014-03-19 Thread Guillaume Smet
Hi, Any thoughts on this one? I have bandwidth this week if it's considered something we want. Thanks. On Thu, Jan 23, 2014 at 2:08 PM, Guillaume Smet wrote: > Hi, > > I'm starting our migration to ORM 4.3 to be able to provide some > (hopefully useful) feedback on

[hibernate-dev] Bytecode enhancement

2014-03-19 Thread Guillaume Smet
Hi, I took a look at the bytecode enhancement Maven plugin and I also have this issue https://hibernate.atlassian.net/browse/HHH-8833 . As far as I can tell the Maven plugin (and I suppose the Gradle plugin too) doesn't provide any information about the classpath so it's impossible to use the byt

Re: [hibernate-dev] Bytecode enhancement

2014-03-19 Thread Guillaume Smet
On Wed, Mar 19, 2014 at 6:06 PM, Emmanuel Bernard wrote: > My comment about bytecode enhancement was at a time where Hibernate ORM > did not make as much optimizations as it does now. > In an ideal world, the bytecode enhancement is triggered at startup time > like we do for Java EE. I am not sure

Re: [hibernate-dev] Make HibernatePersistenceProvider easier to extend

2014-03-19 Thread Guillaume Smet
Hi Sanne, On Wed, Mar 19, 2014 at 2:54 PM, Sanne Grinovero wrote: > looks like a good idea to me, but my advice would be to make all the > changes and send a pull request: would make it easier to reason about > the implications. Well, it's more that I wasn't sure it was worth wasting your time w

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-20 Thread Guillaume Smet
On Thu, Mar 20, 2014 at 3:08 PM, Emmanuel Bernard wrote: > I tend to disagree with you. The SimpleQueryBuilder seems to disagree > with you too as SHOULD is the default. Care to give your arguments in > favor of a different value for the default? Well, IMHO, this feature is designed for a specifi

[hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Guillaume Smet
Hi, = Context = So, my patch here [1] broke a test which checks that Criteria + restrictions mostly work - even if it's documented as not supported and not working. "Mostly" as in "you can't get the result size but you might get the results". See [2] for explanations. I spent some time yesterda

Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Guillaume Smet
Hi Hardy, On Fri, Mar 21, 2014 at 12:14 PM, Hardy Ferentschik wrote: > I am even wondering whether we should not go a step further and disallow > the use of Criterias altogether in FullTextSessionImpl by throwing an > exception > in case of its use. We then can add an explicit method to FullText

Re: [hibernate-dev] [Search] OSGi split packages

2014-03-27 Thread Guillaume Smet
Hi, My 2 cents as an end user of Search: just move them. It's really not a big deal if it's compilation errors and we just have to reorganize the imports: we clearly see the errors when we upgrade so we can fix them easily. You just put it prominently in the release notes and it's OK. Most of ou

[hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-27 Thread Guillaume Smet
Hi, Before 4.4, when you add a @ContainedIn to a property without the corresponding @IndexedEmbedded, they were still added and taken into account in the dependency resolution which was quite useful to declare dependencies between entities without having an explicit @IndexedEmbedded which are usel

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-27 Thread Guillaume Smet
FWIW, we tried to work around it by adding @IndexedEmbedded(depth = 0) but as we also have @ContainedIn on transient methods, we can't work around it totally. As usual we are committed to work on a test case and fix once we agree it should be fixed. On Thu, Mar 27, 2014 at 11:03 AM, Guil

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-27 Thread Guillaume Smet
Hi Hardy, On Thu, Mar 27, 2014 at 12:52 PM, Hardy Ferentschik wrote: > I think an example/test would be awesome. Then we have some concrete example > to base our discussion upon. I don't think a test would be useful to understand what we do. Here are a few additional information about our busine

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-28 Thread Guillaume Smet
can deploy something on our internal repo. -- Guillaume On Thu, Mar 27, 2014 at 2:46 PM, Guillaume Smet wrote: > Hi Hardy, > > On Thu, Mar 27, 2014 at 12:52 PM, Hardy Ferentschik > wrote: >> I think an example/test would be awesome. Then we have some concrete example >&

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-28 Thread Guillaume Smet
Hi Sanne, On Fri, Mar 28, 2014 at 12:56 PM, Sanne Grinovero wrote: > However - I might not have fully grasped this yet - but I'm thinking > that this is a feature request and not a bugfix that should be hastily > applied on 4.4. It's not a feature request. 4.4 changed this behavior. It was worki

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-03-28 Thread Guillaume Smet
back before considering any further enhancements/features. -- Guillaume On Fri, Mar 28, 2014 at 1:28 PM, Guillaume Smet wrote: > Hi Sanne, > > On Fri, Mar 28, 2014 at 12:56 PM, Sanne Grinovero wrote: >> However - I might not have fully grasped this yet - but I'm thinking

[hibernate-dev] Fix for the Eclipse formatter

2014-03-28 Thread Guillaume Smet
Hi, Here is a fix for the Eclipse formatter posted on the community site. Currently, it changes: x.foo(); to x. foo(); which doesn't respect the checkstyle rules. Thought it might be useful to report it as it's quite painful to have a build broken because of that. Thanks! -- Guillaume __

Re: [hibernate-dev] [Search] Regression with @ContainedIn between 4.3 and 4.4

2014-04-03 Thread Guillaume Smet
Hi Sanne, On Thu, Apr 3, 2014 at 3:28 PM, Sanne Grinovero wrote: > We don't have dates defined, but we can certainly release these when > there are enough good reasons to: for example if Guillaume needs it. It would be nice to have an official release once we have a fix for https://hibernate.atl

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Guillaume Smet
Hi, On Tue, Apr 29, 2014 at 1:45 PM, Hardy Ferentschik wrote: >> Yes I mean we could never include it by default, and allow the >> "includePath" to be the (only) way to include things. > > But this forces you to list all fields to include explicitly in case you want > the id added, but otherwise

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-07 Thread Guillaume Smet
Hi, On Tue, May 6, 2014 at 9:43 PM, Hardy Ferentschik wrote: > I think I favour #2 atm, since it seems more symmetric. I'm also in favour of #2. > On top of this we seem to agree that it is a good idea to set the default > depth value of @IndexedEmbedded to 0. This avoids the change in default

[hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-07-20 Thread Guillaume Smet
Hi, Following the discussion about releasing 5 sooner rather than later, I wanted to point out that we still have to take a decision about HSEARCH-1580: - either commit in 5 the fix we committed to 4.x and update the documentation; - or work on defining another concept. I don't have a strong opin

Re: [hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-07-25 Thread Guillaume Smet
original intentions. > > The important thing is to make sure that the documentation and javadocs are > documenting the > behaviour properly and consistently. > > So +1 for getting the old behaviour back > > —Hardy > > > > > > On 20 Jan 2014, at 11:08,

Re: [hibernate-dev] JCS Hibernate Region Factory

2014-08-20 Thread Guillaume Smet
Hi Petar, On Wed, Aug 20, 2014 at 6:36 PM, Petar Tahchiev wrote: > I would really like to give apache commons jcs a spin (the FAQ says > performancewise it's faster than EHCache) I don't know JCS but I find it funny they criticize the fact that Ehcache published an old benchmark and that they st

Re: [hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-08-20 Thread Guillaume Smet
On Fri, Jul 25, 2014 at 9:59 PM, Guillaume Smet wrote: > Thanks for your feedback. I'll see what I can do next week about it. A little late to the party... but I finally pushed changes along those lines: https://github.com/hibernate/hibernate-search/pull/654 Not really sure the doc part

Re: [hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-08-21 Thread Guillaume Smet
On Thu, Aug 21, 2014 at 1:04 PM, Sanne Grinovero wrote: > your patch is merged, I'll look forward for more feedback from your team now > :) Thanks. Too bad I missed the alpha6 train... We'll try to move our apps to the next alpha (or beta) and see how it goes (not a big fan of having snapshots

[hibernate-dev] [Search] Internship next year

2014-08-21 Thread Guillaume Smet
Hi, Just a heads up: I'm going to propose an internship this year (scholar year more precisely) on Hibernate Search contribution. I'm not sure I'll find the good intern for this but that's the plan. The internship season usually starts in Feb/March in France so it's for early next year. The inte

Re: [hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-08-22 Thread Guillaume Smet
On Thu, Aug 21, 2014 at 5:32 PM, Sanne Grinovero wrote: > I understand. If this is a good time for your team to do such > experiments, I'm willing to switch to weekly tags, or even bi-weekly > if there's need, as two other teams seem to be in the same good mood We'll have the bandwidth starting f

[hibernate-dev] HHH-7610 Embedded: emptiness and dirtiness

2014-10-14 Thread Guillaume Smet
Hi all, So, after a long time without any issue (rest assured we were busy anyway!), we got around a new problem we would like to fix in ORM: HHH-7610 . It's a long standing complaint about the embedded and the fact that empty components are returned from the ORM. We had the "good" idea to fix i

Re: [hibernate-dev] HHH-7610 Embedded: emptiness and dirtiness

2014-10-20 Thread Guillaume Smet
Hi! Any interest in us pursuing this? We are obviously committed to update the documentation once we have validated it's the way to go. Thanks for your feedback. On Tue, Oct 14, 2014 at 3:23 PM, Guillaume Smet wrote: > Hi all, > > So, after a long time without any issue (rest a

Re: [hibernate-dev] HHH-7610 Embedded: emptiness and dirtiness

2014-10-24 Thread Guillaume Smet
Hi Steve, On Fri, Oct 24, 2014 at 3:08 PM, Steve Ebersole wrote: > As to your specific question, yes I think what you propose makes sense. > Namely, if this setting is enabled, I think it is reasonable to treat a null > component reference and an empty component reference as equivalent. Thanks f

Re: [hibernate-dev] HHH-7610 Embedded: emptiness and dirtiness

2014-10-24 Thread Guillaume Smet
On Fri, Oct 24, 2014 at 4:30 PM, Steve Ebersole wrote: > As for 4.3.x, for me that again goes back to this not being a bug. 4.3 is a > maintenance branch now, meaning it should only include bug fixes in any > releases. So IMO this should not be part of the 4.3 branch. I do want to > have a disc

[hibernate-dev] Native query and auto-flush

2014-10-30 Thread Guillaume Smet
Hi! Starting with HHH-8487, when we execute a native query, an auto-flush is executed (and might be limited with addSynchronizedEntityClass and allegates). While I understand the rationale of this change, we are having a few issues with this when the transaction opened is read-only which is the c

Re: [hibernate-dev] Search - HSEARCH-1580 - Dependency graph

2014-10-30 Thread Guillaume Smet
Hi Sanne, On Fri, Aug 22, 2014 at 11:25 PM, Guillaume Smet wrote: > We'll have the bandwidth starting from september 15th so if we have a > release then, we'll start playing with 5. If a new alpha of 5 can be released soon with the above fix, we will be able to start using it in

Re: [hibernate-dev] Native query and auto-flush

2014-10-30 Thread Guillaume Smet
On Thu, Oct 30, 2014 at 2:56 PM, Steve Ebersole wrote: > Personally having entities dirtied as part of a read-only transaction sounds > like an application bug to me. We could try to detect a read-only > transaction state (not sure how we'd do that across all cases) and > circumvent the flush the

Re: [hibernate-dev] hibernate-dev Digest, Vol 100, Issue 8

2014-10-31 Thread Guillaume Smet
Hi Sanne, I think Marc was confused by Steve's email. Steve is talking about ORM 5, not Search 5. -- Guillaume On Fri, Oct 31, 2014 at 2:59 PM, Sanne Grinovero wrote: > Hi Marc, > what does it mean Spring 2015 ? Is that a release of the Spring project? > We plan to release Hibernate Search 5

[hibernate-dev] HHH-7610 - Embedded and nulls

2015-05-06 Thread Guillaume Smet
Hi all, (sorry for the long silence, have been dealing with personal issues) I have cycles next week and I would like to tackle this issue: https://hibernate.atlassian.net/browse/HHH-7610 My colleague, Laurent Almeras, already worked on a patch here: https://github.com/openwide-java/hibernate-or

[hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-05-06 Thread Guillaume Smet
Hi, As I have cycles this week and next week, I thought I might as well do some QA on Hibernate 5. I'm still in the process of porting our code to 5 atm and I have a pattern we used before I can't find an elegant way to port on Hibernate 5: this pattern is used to inject a Spring managed intercep

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-05-07 Thread Guillaume Smet
already > questionable subclass an internal class ;) would be to just override > EntityManagerFactoryBuilderImpl#populate(SessionFactoryBuilder, > StandardServiceRegistry) to apply your Interceptor. > > On Wed, May 6, 2015 at 3:21 PM, Guillaume Smet > wrote: > >> Hi, &

Re: [hibernate-dev] HHH-7610 - Embedded and nulls

2015-05-08 Thread Guillaume Smet
fle). > > On Wed, May 6, 2015 at 9:00 AM, Guillaume Smet > wrote: > >> Hi all, >> >> (sorry for the long silence, have been dealing with personal issues) >> >> I have cycles next week and I would like to tackle this issue: >> https://hibernate.a

[hibernate-dev] Search - Plain text and SimpleQueryParser

2015-05-13 Thread Guillaume Smet
Hi, Having some spare time, I revisited my patch that used the Lucene SimpleQueryParser to provide more advanced search features to the end user. At my company, our search requirements are usually the following: - a full text search on the name and description; - a set of dropdown choices. Our f

Re: [hibernate-dev] Search - Plain text and SimpleQueryParser

2015-05-15 Thread Guillaume Smet
Hi Sanne, Thanks for your feedback. My answers below: On Thu, May 14, 2015 at 11:05 PM, Sanne Grinovero wrote: > - ignoreAnalyzer() I agree with your comment, it doesn't seem to make > much sense. But what about not having the method rather than making it > throw an exception? > I'm assuming t

Re: [hibernate-dev] Hibernate Search for Hibernate 5 - status

2015-05-31 Thread Guillaume Smet
Hi Sanne, On Sun, May 31, 2015 at 2:47 AM, Sanne Grinovero wrote: > > I don't think it's acceptable we withhold an Hibernate 5 compatible > version of Hibernate Search for much longer. > FWIW, I'm waiting for this to test Hibernate 5 on our applications and provide feedback from the field on ORM

[hibernate-dev] ORM 5 - Default schema

2015-06-16 Thread Guillaume Smet
Hi, Still trying to get one of our applications starting with ORM 5. With Search 5.4.0.Beta1 and Spring 4.2.0.RC1, I'm now at the database schema validation phase. I think there's something fishy with the way a table is looked for when we're using specific schemas in our database. Some backgroun

Re: [hibernate-dev] ORM 5 - Default schema

2015-06-16 Thread Guillaume Smet
entImpl used when JDBC is available (I first tried to fix the issue by using this setting). On Tue, Jun 16, 2015 at 12:24 PM, Guillaume Smet wrote: > Hi, > > Still trying to get one of our applications starting with ORM 5. With > Search 5.4.0.Beta1 and Spring 4.2.0.RC1, I'm now at the

Re: [hibernate-dev] [Hibernate Search] DocValues and Sorting API -> new mapping annotations ?

2015-08-04 Thread Guillaume Smet
Hi Sanne, On Wed, Jul 29, 2015 at 1:26 PM, Sanne Grinovero wrote: > I'm not sure if this should be extending the @Field annotation as > there are special restrictions implied in terms of analysis: are we > going to enforce a specific type of tokenizer, or simply take the > analysis option away?

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Hi Steve, On Thu, May 7, 2015 at 5:37 PM, Guillaume Smet wrote: > > Yup, EntityManagerFactoryBuilderImpl.populate(SessionFactoryBuilder, > StandardServiceRegistry) was my favorite spot too but it's currently > private. Would you mind making it protected? > Working on

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Nothing yet. Wanted to be sure you weren't against the principle of making this method protected. If you agree with this plan, I'll do the legwork. On Wed, Aug 26, 2015 at 3:34 PM, Steve Ebersole wrote: > Is there a Jira? PR? > > On Wed, Aug 26, 2015, 8:12 AM Guillaume Sme

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Done: https://hibernate.atlassian.net/browse/HHH-10059 On Wed, Aug 26, 2015 at 4:23 PM, Steve Ebersole wrote: > It's fine > > On Wed, Aug 26, 2015, 8:54 AM Guillaume Smet > wrote: > >> Nothing yet. Wanted to be sure you weren't against the principle of >> m

[hibernate-dev] ORM5 and naming strategies (or get me my foreign keys back!)

2015-09-15 Thread Guillaume Smet
Hi all, (starting with kudos to Steve for the 5 release, it's the first problem I find in my migration journey) I'm currently working on porting 2 of our existing applications to ORM 5 (I already ported our template application to start new projects). The naming strategies are giving me a hard t

Re: [hibernate-dev] ORM5 and naming strategies (or get me my foreign keys back!)

2015-09-15 Thread Guillaume Smet
Hi Steve, On Tue, Sep 15, 2015 at 6:49 PM, Steve Ebersole wrote: > The naming strategies are giving me a hard time: we used the >> DefaultComponentSafeNamingStrategy before and there is no real equivalent >> in ORM 5. >> > > org.hibernate.boot.model.naming.ImplicitNamingStrategyComponentPathImpl

[hibernate-dev] A few questions about Search 5.5.0

2015-09-17 Thread Guillaume Smet
Hi, I upgraded our framework to 5.5.0 and I have a few questions about it. == First, I had to remove the existing indexes otherwise I had exceptions about version of the index. Is this expected? As far as I remember, it's been a long time since we had to remove the indexes after an upgrade. Caus

Re: [hibernate-dev] A few questions about Search 5.5.0

2015-09-22 Thread Guillaume Smet
Hi Sanne, On Sat, Sep 19, 2015 at 11:29 PM, Sanne Grinovero wrote: > But: AFAIR pre-4 support was entirely dropped, this additional > dependency is only useful for indexes created between 4.0 to 5.0. You > never fully rebuilt the indexes since Lucene 3.x? > Probably not - we haven't changed the

[hibernate-dev] [Search] Something fishy with sort by id

2015-09-23 Thread Guillaume Smet
Hi, After the upgrade to Search 5.5 (I think we skipped 5.4 on this app), I have a weird behavior when I sort by id. My id is a Long just indexed with @DocumentId: @Id @DocumentId private Long id; and my sort is defined like this: fullTextQuery.setSort(new Sort(new SortField("id", So

Re: [hibernate-dev] [Search] Something fishy with sort by id

2015-09-23 Thread Guillaume Smet
On Wed, Sep 23, 2015 at 10:59 PM, Gunnar Morling wrote: > What is the exact behaviour you observe? > Oh, yeah, forgot the most important :). The results are completely unsorted. It should be sorted by id desc and I have: 26687 26941 27034 27244 27235 28414 28327

  1   2   3   4   5   6   7   >