[hibernate-dev] Update JDK 9 to build 154 on CI

2017-02-07 Thread Davide D'Alto
Are there any problems if I update the JDK 9 on Jenkins? Let me know, Davide ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Update JDK 9 to build 154 on CI

2017-02-07 Thread Sanne Grinovero
No problem, but we're at build 155 since last week ;) Thanks! On 7 February 2017 at 10:04, Davide D'Alto wrote: > Are there any problems if I update the JDK 9 on Jenkins? > > Let me know, > Davide > ___ > hibernate-dev mailing list > hibernate-dev@list

Re: [hibernate-dev] [HV/HSEARCH] Free form

2017-02-07 Thread Gunnar Morling
Emmanuel, In your PoC, how would a complete tree-like structure be traversed? It's not clear to me, who is driving StructureTraverser, i.e. which component will call processSubstructureInContainer() et al. when traversing an entire tree. @Yoann, maybe you can add a usage example similar to Emmanu

Re: [hibernate-dev] Behaviour of validation mode "auto" in case of error during validator factory bootstrap

2017-02-07 Thread Gunnar Morling
So the issue is a more general one than I thought. We'll run into the same situation, too, when there is an error in BV's validation.xml or any constraint mapping file (e.g. a reference to a non-existent MessageInterpolator). That error will currently be suppressed with validation-mode auto. I'm

Re: [hibernate-dev] Hibernate Commons project

2017-02-07 Thread Guillaume Smet
Hi, On Mon, Feb 6, 2017 at 4:21 PM, Emmanuel Bernard wrote: > On the license, I think ASL 2.0 is the best for such project. > As we discussed it in Lisbon, we might "copy" (using Maven) sources from an internal utility project to the NoORM projects, as we want to avoid dependency hell with diff

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Any comments, or should I take the lack of answers as approval ;) Mark On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE between > conditions (specifically in CollectionBinder.

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Sanne Grinovero
Hi Mark, that's not my area of expertise but it seems like a very reasonable proposal. Please open a JIRA, I'm sure someone from the right team will review and merge any such patch. Thanks, Sanne On 7 February 2017 at 12:26, Mark Rotteveel wrote: > Any comments, or should I take the lack of ans

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Vlad Mihalcea
You're right. For CollectionBinder, we shouldn't use the StringHelper.WHITESPACE. We should probably use a simple whitespace character. I guess that was the original intention. Vlad On Tue, Feb 7, 2017 at 2:26 PM, Mark Rotteveel wrote: > Any comments, or should I take the lack of answers as app

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Vlad Mihalcea
+1. I forgot to mention to add a Jira issue. If you don't have time, let me know, and I'll take care of this issue for you. Vlad On Tue, Feb 7, 2017 at 2:55 PM, Sanne Grinovero wrote: > Hi Mark, > that's not my area of expertise but it seems like a very reasonable > proposal. Please open a JIR

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
On 7-2-2017 14:12, Vlad Mihalcea wrote: > +1. > > I forgot to mention to add a Jira issue. If you don't have time, let me > know, and I'll take care of this issue for you. I was considering doing it as part of my Firebird dialect PR, but if you prefer a separate ticket + PR, I can do that as well

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread andrea boriero
Hi Mark, I think it's better to have a separate PR. Thanks On 7 Feb 2017 13:17, "Mark Rotteveel" wrote: On 7-2-2017 14:12, Vlad Mihalcea wrote: > +1. > > I forgot to mention to add a Jira issue. If you don't have time, let me > know, and I'll take care of this issue for you. I was considering

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread andrea boriero
And naturally a separate jira :) On 7 Feb 2017 13:30, andrea boriero wrote: > It's better to have a separate. > > On 7 Feb 2017 13:17, "Mark Rotteveel" wrote: > > On 7-2-2017 14:12, Vlad Mihalcea wrote: > > +1. > > > > I forgot to mention to add a Jira issue. If you don't have time, let me > >

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Vlad Mihalcea
+1 A separate Jira/PR is better since we can backport to other versions. Vlad On Tue, Feb 7, 2017 at 3:32 PM, andrea boriero wrote: > And naturally a separate jira :) > > On 7 Feb 2017 13:30, andrea boriero wrote: > >> It's better to have a separate. >> >> On 7 Feb 2017 13:17, "Mark Rotteveel

Re: [hibernate-dev] [HV/HSEARCH] Free form

2017-02-07 Thread Yoann Rodiere
This conversation is starting to get a bit complex, so I'll try to organize my answers: # Applying the same solution to HV and HSearch @Emmanuel: right, I didn't see you were also talking about HV. I was only considering the HSearch case. I think I agree with you both, HV and HSearch are a bit d

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Issue: https://hibernate.atlassian.net/browse/HHH-11467 PR: https://github.com/hibernate/hibernate-orm/pull/1781 On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE between > cond

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Sanne Grinovero
merged it, and promoted your JIRA account so you can assign issues to yourself. Thanks! Sanne On 7 February 2017 at 15:58, Mark Rotteveel wrote: > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > On 4-2-2017 15:05, Mark Rottev

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Thanks! I just received a build failure notification with an ExceptionInInitialiserError, but I can't see how my PR would introduce that error. Any idea, or should I just ignore it? Mark - Bericht beantwoorden - Van: "Sanne Grinovero" Aan: "Mark Rotteveel" CC: "Hibernate.org" Onderw

Re: [hibernate-dev] Hibernate Commons project

2017-02-07 Thread Guillaume Smet
Hi, So, apparently, people didn't like internal in the groupId so we ended up with org.hibernate.infra which was one of the groupIds suggested by Emmanuel. The Asciidoctor theme is here: https://github.com/hibernate/hibernate-asciidoctor-theme . I just pushed the first version to our Nexus so I

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Steve Ebersole
>From which job? The JDK 9 one? Those failures you can ignore On Tue, Feb 7, 2017, 11:52 AM Mark Rotteveel wrote: > Thanks! > I just received a build failure notification with an > ExceptionInInitialiserError, but I can't see how my PR would introduce that > error. > > Any idea, or should I jus

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Yes, it is the jdk9 job. Sorry, that I forgot to include that info. Mark - Bericht beantwoorden - Van: "Steve Ebersole" Aan: "Mark Rotteveel" , "Sanne Grinovero" CC: "Hibernate.org" Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 20:11 From whic

[hibernate-dev] Refactor MySQL Dialects

2017-02-07 Thread Vlad Mihalcea
Hi, While working on MariaDB Dialects, I realize that we should also refactor the MySQL ones. The problem is that we introduced the InnoDB hierarchy. Since the only difference between those two is related to 3 methods, I think we should hide them behind a MySQLStorageEngine hierarchy with InnoDB