Yes, it is the jdk9 job. Sorry, that I forgot to include that info. Mark ----- Bericht beantwoorden ----- Van: "Steve Ebersole" <st...@hibernate.org> Aan: "Mark Rotteveel" <m...@lawinegevaar.nl>, "Sanne Grinovero" <sa...@hibernate.org> CC: "Hibernate.org" <hibernate-dev@lists.jboss.org> Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 20:11
From which job? The JDK 9 one? Those failures you can ignore On Tue, Feb 7, 2017, 11:52 AM Mark Rotteveel <m...@lawinegevaar.nl> wrote: Thanks! I just received a build failure notification with an ExceptionInInitialiserError, but I can't see how my PR would introduce that error. Any idea, or should I just ignore it? Mark ----- Bericht beantwoorden ----- Van: "Sanne Grinovero" <sa...@hibernate.org> Aan: "Mark Rotteveel" <m...@lawinegevaar.nl> CC: "Hibernate.org" <hibernate-dev@lists.jboss.org> Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 18:08 merged it, and promoted your JIRA account so you can assign issues to yourself. Thanks! Sanne On 7 February 2017 at 15:58, Mark Rotteveel <m...@lawinegevaar.nl> wrote: > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > On 4-2-2017 15:05, Mark Rotteveel wrote: >> Firebird has a problem with some of the SQL generated by Hibernate, in >> some queries Hibernate appends StringHelper.WHITESPACE between >> conditions (specifically in CollectionBinder.bindFilters(boolean)). >> >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, >> 0x0C), and Firebird does not accept a formfeed as whitespace. >> >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other >> places this constant is used is for splitting/tokenizing strings, and >> not for adding whitespace. >> >> Is there any objection if I replace the usage in >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with >> " \n\t" to produce more similar SQL as previous)? >> >> Mark >> > > > -- > Mark Rotteveel > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
