Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Emmanuel Bernard
I see a few outputs - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core and Search - JBoss Logging 3.1.0.Beta3 will be binary compatible with 3.1.0.Final and we go for a Core and Search release with Logging Beta3 - we wait for JBoss Logging to go final but that means de

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Steve Ebersole
Maybe instead of "shading in" the removed class you could just add it back to the JBoss Logging codebase? On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: > I see a few outputs > > - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core > and Search > - JBoss Logging 3.1.0.

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Hardy Ferentschik
On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole wrote: > Maybe instead of "shading in" the removed class you could just add it > back to the JBoss Logging codebase? Right, why can we not do that? > On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >> I see a few outputs >> >> - JBoss Loggin

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread David M. Lloyd
On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: > On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole > wrote: > >> Maybe instead of "shading in" the removed class you could just add it >> back to the JBoss Logging codebase? > > Right, why can we not do that? You have it backwards. We didn't *re

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Steve Ebersole
Ok, I am totally confused then. I thought this was a discussion about BasicLogger. But we have been using that afaik way before our recent upgrade to 3.1 On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: > On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: >> On Wed, 09 Nov 2011 15:00:07

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread David M. Lloyd
Yeah, the problem was that to *implement* BasicLogger we had switched to using a base class (bundled in 3.1) to implement the multitude of methods, due to problems associated with generating all the implementations in every class. On 11/09/2011 08:39 AM, Steve Ebersole wrote: > Ok, I am totally

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread David M. Lloyd
OK folks. I've pushed out jboss-logging 3.1.0.CR1 and jboss-logging-tools 1.0.0.CR4. Here's what you need to do. 0. Update your dep versions (obviously) 1. Add the following switch to your annotation processing step (or to javac if it's combined): -AloggingVersion=3.0 2. Build your artifacts a

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Steve Ebersole
Thanks David! Just to make sure I understand. Doing the steps above will allow the built artifact to run in either AS 7.0 or 7.1. Correct? I thought we had said on IRC that Hibernate could really get away with (1) and (2) and that JBoss AS 7.0 could specify to use JBoss Logging 3.0 via dep-m

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread David M. Lloyd
Yup, that's correct. And yeah #3 is optional which is why I said "may". On 11/09/2011 02:38 PM, Steve Ebersole wrote: > Thanks David! > > Just to make sure I understand. Doing the steps above will allow the > built artifact to run in either AS 7.0 or 7.1. Correct? > > I thought we had said on IRC

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Steve Ebersole
Chill out man :) Just making sure everyone know the ramifications and intentions. On Wed 09 Nov 2011 02:43:43 PM CST, David M. Lloyd wrote: > Yup, that's correct. And yeah #3 is optional which is why I said "may". > > On 11/09/2011 02:38 PM, Steve Ebersole wrote: >> Thanks David! >> >> Just to

Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core

2011-11-09 Thread Sanne Grinovero
Awesome! just verified on both Hibernate Search and Infinispan, no issues spotted ! thanks a lot, Sanne On 9 November 2011 21:29, Steve Ebersole wrote: > Chill out man :) > > Just making sure everyone know the ramifications and intentions. > > On Wed 09 Nov 2011 02:43:43 PM CST, David M. Lloyd