Maybe instead of "shading in" the removed class you could just add it back to the JBoss Logging codebase?
On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: > I see a few outputs > > - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core > and Search > - JBoss Logging 3.1.0.Beta3 will be binary compatible with 3.1.0.Final and we > go for a Core and Search release with Logging Beta3 > - we wait for JBoss Logging to go final but that means delaying Core, Search > etc and many people on the product side will be impacted > > David, James, can you give your insight to help us chose a way? > > Emmanuel > > On 8 nov. 2011, at 18:24, Strong Liu wrote: > >> if jboss-logging 3.1.0 final would compatible with 3.1.0.Beta3, then i would >> vote for releasing 4.0 Final today >> hope AS7 could cut off a CR release with jboss-logging 3.1.0.Beta3 or Final >> soon >> |------------------------------------------------------- >> or we wait for jboss-logging goes final and --` >> >> shade plugin is not always a good choice and i don't know if there is an >> alternative can be used in gradle >> >> >> >> On Nov 8, 2011, at 6:12 PM, Hardy Ferentschik wrote: >> >>> On Tue, 08 Nov 2011 00:33:23 +0100, David M. Lloyd >>> <david.ll...@redhat.com> wrote: >>> >>>>> I don't think the shade approach is the way to go; it wouldn't work in >>>>> AS 7.1, which is our final goal. >>>> >>>> Yeah, it would actually. It would just put a copy of that base class in >>>> your JAR somewhere, and then your generated classes would extend that >>>> class instead of the one which is missing in 3.0, thus your program >>>> would function normally. >>> >>> Even though this solution seems of the table, I just thought that the >>> productization >>> team cannot use the shade plugin (don't ask me why). For that reasons they >>> actually >>> have to remove the shade plugin from the pom and patch the build in other >>> ways. >>> >>> --Hardy >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> >> _______________________________________________ >> jboss-as7-dev mailing list >> jboss-as7-...@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev -- st...@hibernate.org http://hibernate.org _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
