[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r337973757 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/conta

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r337974011 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniO

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r337974659 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/clien

[GitHub] [hadoop-ozone] mukul1987 commented on issue #65: HDDS-2334. Dummy chunk manager fails with length mismatch error

2019-10-23 Thread GitBox
mukul1987 commented on issue #65: HDDS-2334. Dummy chunk manager fails with length mismatch error URL: https://github.com/apache/hadoop-ozone/pull/65#issuecomment-545395598 Thanks for the contribution @adoroszlai and @bshashikant and @supratimdeka for reviews. I am +1 on the patch as well.

[GitHub] [hadoop-ozone] mukul1987 merged pull request #65: HDDS-2334. Dummy chunk manager fails with length mismatch error

2019-10-23 Thread GitBox
mukul1987 merged pull request #65: HDDS-2334. Dummy chunk manager fails with length mismatch error URL: https://github.com/apache/hadoop-ozone/pull/65 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [hadoop-ozone] adoroszlai commented on issue #65: HDDS-2334. Dummy chunk manager fails with length mismatch error

2019-10-23 Thread GitBox
adoroszlai commented on issue #65: HDDS-2334. Dummy chunk manager fails with length mismatch error URL: https://github.com/apache/hadoop-ozone/pull/65#issuecomment-545414887 Thanks all for reviews and @mukul1987 for merging it. --

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338056264 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338056880 ## File path: hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone

[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction

2019-10-23 Thread GitBox
nandakumar131 commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction URL: https://github.com/apache/hadoop-ozone/pull/72#discussion_r338072207 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyval

[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction

2019-10-23 Thread GitBox
nandakumar131 commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction URL: https://github.com/apache/hadoop-ozone/pull/72#discussion_r338072825 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyval

[GitHub] [hadoop-ozone] elek commented on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone

2019-10-23 Thread GitBox
elek commented on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone URL: https://github.com/apache/hadoop-ozone/pull/74#issuecomment-545472098 Thank you very much @chimney-lee to file this jira. The log4j is inherited from the original hadoop log4j (where we

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-545522617 Other test failures seem unrelated. -

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction

2019-10-23 Thread GitBox
adoroszlai commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction URL: https://github.com/apache/hadoop-ozone/pull/72#discussion_r338166152 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338222375 ## File path: hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/o

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster

2019-10-23 Thread GitBox
adoroszlai opened a new pull request #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster URL: https://github.com/apache/hadoop-ozone/pull/76 ## What changes were proposed in this pull request? Let `checkAccess` propagate original `OMException` wit

[GitHub] [hadoop-ozone] anuengineer merged pull request #75: HDDS-2349 QueryNode does not respect null values for opState or state

2019-10-23 Thread GitBox
anuengineer merged pull request #75: HDDS-2349 QueryNode does not respect null values for opState or state URL: https://github.com/apache/hadoop-ozone/pull/75 This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-23 Thread GitBox
hanishakoneru commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r338297745 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java ##

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-23 Thread GitBox
hanishakoneru commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-545653313 @anuengineer, I fixed the compile failure. Please take a look when you get a chance. Thanks.

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-23 Thread GitBox
hanishakoneru commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#discussion_r338300716 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-23 Thread GitBox
hanishakoneru commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#discussion_r338301299 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigK

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338320989 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338324469 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338324646 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCM

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338324997 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/containe

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster

2019-10-23 Thread GitBox
bharatviswa504 merged pull request #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster URL: https://github.com/apache/hadoop-ozone/pull/76 This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster

2019-10-23 Thread GitBox
bharatviswa504 commented on issue #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster URL: https://github.com/apache/hadoop-ozone/pull/76#issuecomment-545688874 Thank You @adoroszlai for the fix and @dineshchitlangia for the review.

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #15: HDDS-2296. ozoneperf compose cluster shouln't start freon by default

2019-10-23 Thread GitBox
bharatviswa504 commented on issue #15: HDDS-2296. ozoneperf compose cluster shouln't start freon by default URL: https://github.com/apache/hadoop-ozone/pull/15#issuecomment-545693509 Thank You @elek for the contribution and @adoroszlai for the review. --

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #15: HDDS-2296. ozoneperf compose cluster shouln't start freon by default

2019-10-23 Thread GitBox
bharatviswa504 merged pull request #15: HDDS-2296. ozoneperf compose cluster shouln't start freon by default URL: https://github.com/apache/hadoop-ozone/pull/15 This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338340651 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338340651 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338340651 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-23 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338340651 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] chimney-lee commented on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone

2019-10-23 Thread GitBox
chimney-lee commented on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone URL: https://github.com/apache/hadoop-ozone/pull/74#issuecomment-545710700 Thanks for reply @elek , In hadoop ,the namenode/datanode logs are logged to files hadoop-${user}-{namenode|d

[GitHub] [hadoop-ozone] chimney-lee edited a comment on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone

2019-10-23 Thread GitBox
chimney-lee edited a comment on issue #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone URL: https://github.com/apache/hadoop-ozone/pull/74#issuecomment-545710700 Thanks for reply @elek , In hadoop ,the namenode/datanode logs are logged to files hadoop-${user}-{nam

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338361334 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338361688 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
bharatviswa504 opened a new pull request #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77 ## What changes were proposed in this pull request? Make the below log statement debug log. 2019-10-24 03:17:43,087 INFO server.SCMBl

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
bharatviswa504 edited a comment on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77#issuecomment-545727920 Yes, as this is log only change. But let's wait till CI is completed. -

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
bharatviswa504 commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77#issuecomment-545727920 Yes, as this is log only change. This is an automated message

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #16: HDDS-2297. Enable Opentracing for new Freon tests

2019-10-23 Thread GitBox
bharatviswa504 commented on issue #16: HDDS-2297. Enable Opentracing for new Freon tests URL: https://github.com/apache/hadoop-ozone/pull/16#issuecomment-545743215 Thank You @elek for the contribution and @adoroszlai for the review. -

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #16: HDDS-2297. Enable Opentracing for new Freon tests

2019-10-23 Thread GitBox
bharatviswa504 merged pull request #16: HDDS-2297. Enable Opentracing for new Freon tests URL: https://github.com/apache/hadoop-ozone/pull/16 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
dineshchitlangia merged pull request #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
dineshchitlangia commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77#issuecomment-545746468 @bharatviswa504 thanks for the contribution. Merged this to master.

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-23 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338399009 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/stat

[GitHub] [hadoop-ozone] adoroszlai commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs.

2019-10-23 Thread GitBox
adoroszlai commented on issue #77: HDDS-2354. SCM log is full of AllocateBlock logs. URL: https://github.com/apache/hadoop-ozone/pull/77#issuecomment-545767359 Thanks @bharatviswa504 for making this change. This is an automat

[GitHub] [hadoop-ozone] adoroszlai commented on issue #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster

2019-10-23 Thread GitBox
adoroszlai commented on issue #76: HDDS-2352. Client gets internal error instead of volume not found in secure cluster URL: https://github.com/apache/hadoop-ozone/pull/76#issuecomment-545768500 Thanks @dineshchitlangia for the prompt review, and @bharatviswa504 for reviewing and merging it

[GitHub] [hadoop-ozone] cxorm opened a new pull request #80: HDDS-1701. Move dockerbin script to libexec.

2019-10-24 Thread GitBox
cxorm opened a new pull request #80: HDDS-1701. Move dockerbin script to libexec. URL: https://github.com/apache/hadoop-ozone/pull/80 ## What changes were proposed in this pull request? Relocate the docker scripts in dist. (from ```bin/docker/``` to ```libexec/```) ## What

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #79: HDDS-2357. Add replication factor option to new Freon tests

2019-10-24 Thread GitBox
adoroszlai opened a new pull request #79: HDDS-2357. Add replication factor option to new Freon tests URL: https://github.com/apache/hadoop-ozone/pull/79 ## What changes were proposed in this pull request? New Freon generators (OCKG and OKG) use fixed replication factor of 3. Somet

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #78: HDDS-2358. Change to replication factor THREE in acceptance tests

2019-10-24 Thread GitBox
adoroszlai opened a new pull request #78: HDDS-2358. Change to replication factor THREE in acceptance tests URL: https://github.com/apache/hadoop-ozone/pull/78 ## What changes were proposed in this pull request? Let acceptance tests exercise 3-node replication. https://issues.

[GitHub] [hadoop-ozone] fapifta opened a new pull request #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE

2019-10-24 Thread GitBox
fapifta opened a new pull request #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81 ## What changes were proposed in this pull request? We found this issue during Hive TPCDS tests, the basis of the problem is that Hive start

[GitHub] [hadoop-ozone] fapifta commented on issue #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE

2019-10-24 Thread GitBox
fapifta commented on issue #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81#issuecomment-545899019 /label ozone This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] arp7 merged pull request #7: HDDS-1228. Chunk Scanner Checkpoints

2019-10-24 Thread GitBox
arp7 merged pull request #7: HDDS-1228. Chunk Scanner Checkpoints URL: https://github.com/apache/hadoop-ozone/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop-ozone] arp7 merged pull request #78: HDDS-2358. Change to replication factor THREE in acceptance tests

2019-10-24 Thread GitBox
arp7 merged pull request #78: HDDS-2358. Change to replication factor THREE in acceptance tests URL: https://github.com/apache/hadoop-ozone/pull/78 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-ozone] arp7 merged pull request #79: HDDS-2357. Add replication factor option to new Freon tests

2019-10-24 Thread GitBox
arp7 merged pull request #79: HDDS-2357. Add replication factor option to new Freon tests URL: https://github.com/apache/hadoop-ozone/pull/79 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [hadoop-ozone] bshashikant opened a new pull request #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads

2019-10-24 Thread GitBox
bshashikant opened a new pull request #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads URL: https://github.com/apache/hadoop-ozone/pull/82 ## What changes were proposed in this pull request? The issue was primarily caused when

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r338640936 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r338657486 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r338619918 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r338650934 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads

2019-10-24 Thread GitBox
hanishakoneru commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads URL: https://github.com/apache/hadoop-ozone/pull/82#issuecomment-546006006 Thank you @bshashikant for working on this. LGTM. +1 pending CI.

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-24 Thread GitBox
hanishakoneru commented on issue #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#issuecomment-546014078 Thanks for the review @bshashikant . I updated the patch to address your comment. I am caching the DN pe

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
dineshchitlangia commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338695659 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoo

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338715495 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338717238 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338717238 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-24 Thread GitBox
xiaoyuyao commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r338740381 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338750907 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #83: HDDS-2360. Update Ratis snapshot to d6d58d0

2019-10-24 Thread GitBox
adoroszlai opened a new pull request #83: HDDS-2360. Update Ratis snapshot to d6d58d0 URL: https://github.com/apache/hadoop-ozone/pull/83 ## What changes were proposed in this pull request? Update Ratis dependency version to snapshot [d6d58d0](https://github.com/apache/incubator-rat

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
xiaoyuyao commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338778482 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/hel

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338793028 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/o

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
xiaoyuyao commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546112181 +1 pending CI. Thanks @bharatviswa504 for the offline discussion and update.

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0

2019-10-24 Thread GitBox
xiaoyuyao commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0 URL: https://github.com/apache/hadoop-ozone/pull/83#issuecomment-546112572 +1 pending CI. This is an automated message from the Apache Git Service.

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #4: HDDS-2071. Support filters in ozone insight point

2019-10-24 Thread GitBox
xiaoyuyao commented on issue #4: HDDS-2071. Support filters in ozone insight point URL: https://github.com/apache/hadoop-ozone/pull/4#issuecomment-546119025 +1, Thanks @elek for adding this and @adoroszlai for the reviews. T

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #4: HDDS-2071. Support filters in ozone insight point

2019-10-24 Thread GitBox
xiaoyuyao merged pull request #4: HDDS-2071. Support filters in ozone insight point URL: https://github.com/apache/hadoop-ozone/pull/4 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [hadoop-ozone] smengcl commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-24 Thread GitBox
smengcl commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-546128373 1. Compilation passed with `mvn clean install -DskipTests=true -Dmaven.javadoc.skip=true` 2. Checked `./hadoop-ozone/dist/target/ozone-0.5.0-

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546161487 Thank You @xiaoyuyao for the review. Test failure in OzoneNativeAuthorizer is failing now, as we

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546162321 > Thank You @xiaoyuyao for the review. > Test failure in OzoneNativeAuthorizer is failing now,

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 opened a new pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71 …quests. ## What changes were proposed in this pull request? OMVolumeCreateRequest.java L159: o

[GitHub] [hadoop-ozone] bharatviswa504 closed pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 closed pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71 This is an automated message from the Apache Git Servic

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546163737 > > Thank You @xiaoyuyao for the review. > > Test failure in OzoneNativeAuthorizer is failing now

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
bharatviswa504 commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546163973 /retest This is an automated messa

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546164220 @bharatviswa504 Thanks for quick turn around. I verified in my local and seems fine. +1 pending C

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-24 Thread GitBox
bharatviswa504 commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#discussion_r338868517 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/Xceiv

[GitHub] [hadoop-ozone] ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#issuecomment-546182226 Fix failed TestSCMPipelineManager.java. Other failed UT and integration test are either not relevant

[GitHub] [hadoop-ozone] ChenSammi edited a comment on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-24 Thread GitBox
ChenSammi edited a comment on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#issuecomment-546182226 Fix failed TestSCMPipelineManager.java. Other failed UT and integration test are either not r

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #83: HDDS-2360. Update Ratis snapshot to d6d58d0

2019-10-24 Thread GitBox
bharatviswa504 merged pull request #83: HDDS-2360. Update Ratis snapshot to d6d58d0 URL: https://github.com/apache/hadoop-ozone/pull/83 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0

2019-10-24 Thread GitBox
bharatviswa504 commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0 URL: https://github.com/apache/hadoop-ozone/pull/83#issuecomment-546183080 Test failure of ratis is not related to this patch. Thank you @adoroszlai for the contribution and @xiaoyuyao for the review. -

[GitHub] [hadoop-ozone] adoroszlai commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0

2019-10-24 Thread GitBox
adoroszlai commented on issue #83: HDDS-2360. Update Ratis snapshot to d6d58d0 URL: https://github.com/apache/hadoop-ozone/pull/83#issuecomment-546184089 Thanks @xiaoyuyao for the review and @bharatviswa504 for merging it. Thi

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
dineshchitlangia merged pull request #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71 This is an automated message from the Apache Git Serv

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

2019-10-24 Thread GitBox
dineshchitlangia commented on issue #71: HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests. URL: https://github.com/apache/hadoop-ozone/pull/71#issuecomment-546185975 Thanks @xiaoyuyao for reviews and @bharatviswa504 for contribution. This has been merged to maste

[GitHub] [hadoop-ozone] cxorm commented on issue #80: HDDS-1701. Move dockerbin script to libexec.

2019-10-24 Thread GitBox
cxorm commented on issue #80: HDDS-1701. Move dockerbin script to libexec. URL: https://github.com/apache/hadoop-ozone/pull/80#issuecomment-546195651 /retest This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #84: HDDS-2365. Fix TestRatisPipelineProvider#testCreatePipelinesDnExclude

2019-10-24 Thread GitBox
adoroszlai opened a new pull request #84: HDDS-2365. Fix TestRatisPipelineProvider#testCreatePipelinesDnExclude URL: https://github.com/apache/hadoop-ozone/pull/84 ## What changes were proposed in this pull request? Fix TestRatisPipelineProvider#testCreatePipelinesDnExclude, which ha

[GitHub] [hadoop-ozone] cxorm commented on issue #80: HDDS-1701. Move dockerbin script to libexec.

2019-10-24 Thread GitBox
cxorm commented on issue #80: HDDS-1701. Move dockerbin script to libexec. URL: https://github.com/apache/hadoop-ozone/pull/80#issuecomment-546224007 When test-all.sh is ran in distribution, it works well. But when it called by acceptance.sh, it fails. We are looking for the cause.

[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-25 Thread GitBox
bshashikant commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#discussion_r338982546 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverC

[GitHub] [hadoop-ozone] bshashikant commented on issue #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE

2019-10-25 Thread GitBox
bshashikant commented on issue #81: HDDS-2347 XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81#issuecomment-546295056 The changes look good to me. I am +1 on this. This is an

[GitHub] [hadoop-ozone] cxorm opened a new pull request #85: HDDS-2219. Move all the ozone dist scripts/configs to one location

2019-10-25 Thread GitBox
cxorm opened a new pull request #85: HDDS-2219. Move all the ozone dist scripts/configs to one location URL: https://github.com/apache/hadoop-ozone/pull/85 ## What changes were proposed in this pull request? Relocate the separated scripts and confuguration file to the same directory,

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes

2019-10-25 Thread GitBox
sodonnel opened a new pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes URL: https://github.com/apache/hadoop-ozone/pull/86 ## What changes were proposed in this pull request? When a node is marked for decommission or maintenance, the first step i

[GitHub] [hadoop-ozone] arp7 merged pull request #72: HDDS-2341. Validate tar entry path during extraction

2019-10-25 Thread GitBox
arp7 merged pull request #72: HDDS-2341. Validate tar entry path during extraction URL: https://github.com/apache/hadoop-ozone/pull/72 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-25 Thread GitBox
hanishakoneru commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#discussion_r339160033 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/Xceive

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-25 Thread GitBox
hanishakoneru commented on issue #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#issuecomment-546441415 /retest This is an automated message from

<    1   2   3   4   5   6   7   8   9   >