bharatviswa504 commented on a change in pull request #71: HDDS-2344. Add
immutable entries in to the DoubleBuffer for Volume requests.
URL: https://github.com/apache/hadoop-ozone/pull/71#discussion_r338717238
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetOwnerRequest.java
##########
@@ -171,7 +171,8 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
omResponse.setSetVolumePropertyResponse(
SetVolumePropertyResponse.newBuilder().build());
omClientResponse = new OMVolumeSetOwnerResponse(oldOwner,
- oldOwnerVolumeList, newOwnerVolumeList, omVolumeArgs,
+ oldOwnerVolumeList, newOwnerVolumeList,
+ (OmVolumeArgs) omVolumeArgs.clone(),
Review comment:
Yes, but with cache enabled, every time it is not a new object. It is the
same object being in cache is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
