Re: [PATCH] gnu: Add slurm-drmaa.

2016-05-21 Thread Efraim Flashner
On Thu, May 19, 2016 at 10:58:08AM +0200, Ricardo Wurmus wrote: > From: Ricardo Wurmus > > * gnu/packages/parallel.scm (slurm-drmaa): New variable. > --- > gnu/packages/parallel.scm | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/gnu/packages/parallel.scm

Re: [PATCH] gnu: Add slurm.

2016-02-16 Thread Andreas Enge
On Tue, Feb 16, 2016 at 08:21:07AM +0100, Pjotr Prins wrote: > > A number of configure flags were missing - without them, the inputs > > would not be found in their non-standard location. > Hmmm. It compiled, the tools ran... They probably concerned optional inputs, that maybe you did not need in

Re: [PATCH] gnu: Add slurm.

2016-02-15 Thread Pjotr Prins
On Mon, Feb 15, 2016 at 10:51:00PM +0100, Andreas Enge wrote: > On Mon, Feb 15, 2016 at 01:09:01PM +0100, Pjotr Prins wrote: > > New version cleaned up (using python-wrapper) and patch created > > with latest git and en_US.utf8 Guix style... > > Well, it turned out it was still in iso-latin-1, and

Re: [PATCH] gnu: Add slurm.

2016-02-15 Thread Andreas Enge
On Mon, Feb 15, 2016 at 01:09:01PM +0100, Pjotr Prins wrote: > New version cleaned up (using python-wrapper) and patch created > with latest git and en_US.utf8 Guix style... Well, it turned out it was still in iso-latin-1, and patching failed again... Anyway, I applied the modifications and expand

Re: [PATCH] gnu: Add slurm.

2016-02-15 Thread Pjotr Prins
On Sun, Feb 14, 2016 at 02:08:30PM -0500, Leo Famulari wrote: > I think the old version of git must play a role, or every patch with a > copyright attribution line would fail to apply. New version cleaned up (using python-wrapper) and patch created with latest git and en_US.utf8 Guix style... Ah

Re: [PATCH] gnu: Add slurm.

2016-02-14 Thread Leo Famulari
On Sun, Feb 14, 2016 at 03:22:56PM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 03:40:55PM -0500, Leo Famulari wrote: > > If that is it, then I believe git should "do the right thing" when > > generating patches. I've noticed that it progressively sets the encoding > > based on the minimum

Re: [PATCH] gnu: Add slurm.

2016-02-14 Thread Andreas Enge
On Sat, Feb 13, 2016 at 03:40:55PM -0500, Leo Famulari wrote: > If that is it, then I believe git should "do the right thing" when > generating patches. I've noticed that it progressively sets the encoding > based on the minimum required to encode the characters in the patch. The last line of your

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Leo Famulari
On Sat, Feb 13, 2016 at 10:32:01PM +0100, Pjotr Prins wrote: > On Sat, Feb 13, 2016 at 03:38:46PM -0500, Leo Famulari wrote: > > I wonder if the version of git is a factor? 2.1.4 vs 2.6.3. Jan was also > > using 2.1.4, and his patches also failed *only* on the attribution line. > > Thank you Leo a

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
On Sat, Feb 13, 2016 at 03:38:46PM -0500, Leo Famulari wrote: > I wonder if the version of git is a factor? 2.1.4 vs 2.6.3. Jan was also > using 2.1.4, and his patches also failed *only* on the attribution line. Thank you Leo and Andreas for restoring my sanity! I'll upgrade git. I was using the

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Leo Famulari
On Sat, Feb 13, 2016 at 09:34:22PM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 03:13:37PM -0500, Leo Famulari wrote: > > I used diffoscope to compare the non-working patch and a "should-be" > > identical patch that I generated locally. The only differences were in > > the patch headers and

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Leo Famulari
On Sat, Feb 13, 2016 at 03:13:37PM -0500, Leo Famulari wrote: > On Sat, Feb 13, 2016 at 06:20:01PM +0100, Andreas Enge wrote: > > On Sat, Feb 13, 2016 at 06:01:19PM +0100, Pjotr Prins wrote: > > > cat 0001-gnu-Add-slurm.patch |patch -p1 # same patch, different name > > > patching file gnu/packages

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Andreas Enge
On Sat, Feb 13, 2016 at 03:13:37PM -0500, Leo Famulari wrote: > I used diffoscope to compare the non-working patch and a "should-be" > identical patch that I generated locally. The only differences were in > the patch headers and the encoding of the file (UTF-8 vs ISO-8859-1). I think that explain

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Leo Famulari
On Sat, Feb 13, 2016 at 06:20:01PM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 06:01:19PM +0100, Pjotr Prins wrote: > > cat 0001-gnu-Add-slurm.patch |patch -p1 # same patch, different name > > patching file gnu/packages/parallel.scm > > patching file > > gnu/packages/patches/slurm-wlm-co

Ooops: Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
Sorry everyone for the extra E-mail load. On Sat, Feb 13, 2016 at 06:30:58PM +0100, Andreas Enge wrote: > I still have the same problem with your patch. If you do not mind, could > you just send me your final parallel.scm and > slurm-wlm-configure-remove-nonfree-contribs.patch ? Can someone else

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Andreas Enge
I still have the same problem with your patch. If you do not mind, could you just send me your final parallel.scm and slurm-wlm-configure-remove-nonfree-contribs.patch ? When I will have a bit of time I will then go over it again. (I still think we should use python-wrapper, for instance.) Thanks

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Andreas Enge
On Sat, Feb 13, 2016 at 06:01:19PM +0100, Pjotr Prins wrote: > cat 0001-gnu-Add-slurm.patch |patch -p1 # same patch, different name > patching file gnu/packages/parallel.scm > patching file > gnu/packages/patches/slurm-wlm-configure-remove-nonfree-contribs.patch > Works fine. Maybe because I used

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
OK, patch coming up. On Sat, Feb 13, 2016 at 11:28:25AM +0100, Andreas Enge wrote: > On Sat, Feb 13, 2016 at 09:59:40AM +0100, Pjotr Prins wrote: > > Another package name (this time we go down to slurm), another patch. > > Actually, the name of the patch file: slurm-wml-patch should also > be

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
On Sat, Feb 13, 2016 at 05:42:57PM +0100, Pjotr Prins wrote: > > However, your patch still does not apply on top of master: > I am using a recent repo of guix. I did do a rebase and the patch applies > on my tree (as did the previous one). Is there no more information? git pull origin master >From

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Andreas Enge
On Sat, Feb 13, 2016 at 05:42:57PM +0100, Pjotr Prins wrote: > On Sat, Feb 13, 2016 at 11:28:25AM +0100, Andreas Enge wrote: > > Some lines are way beyond 80 characters; this should be detected by > > "guix lint". > guix lint has not been working for me: Strange, it works for me with other package

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
On Sat, Feb 13, 2016 at 11:28:25AM +0100, Andreas Enge wrote: > Some lines are way beyond 80 characters; this should be detected by > "guix lint". guix lint has not been working for me: ./pre-inst-env guix lint slurm warning: failed to install locale: Invalid argument filtered-port: failed to exe

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Andreas Enge
On Sat, Feb 13, 2016 at 09:59:40AM +0100, Pjotr Prins wrote: > Another package name (this time we go down to slurm), another patch. Actually, the name of the patch file: slurm-wml-patch should also be changed... And it needs to be registered in gnu-system.am. Some lines are way beyond 80 char

Re: [PATCH] gnu: Add slurm.

2016-02-13 Thread Pjotr Prins
Another package name (this time we go down to slurm), another patch. I also put the modules in alphabetic order when adding the license name space. Hope that doesn't need a separate patch. Pj. >From ef998204cde384d35b605509be09b25170c28fb8 Mon Sep 17 00:00:00 2001 From: Pjotr Prins Date: Sat, 13

Re: [PATCH] gnu: Add slurm-wlm.

2016-02-12 Thread Andreas Enge
Hi Piotr, "git am" fails on current master with this patch, claiming an error at line 39: + #:use-module (gnu packages tcl) + #:use-module (gnu packages tls)) etc. Did we not agree in the end that the package should simply be called slurm? Could you please send a patch that applies to current

Re: [PATCH] gnu: Add slurm-wlm.

2016-02-12 Thread Pjotr Prins
Removed a few extraneous comments and changed subject. >From 5941b6b2624ee18444c2fa9f0805136cf6924a88 Mon Sep 17 00:00:00 2001 From: Pjotr Prins Date: Fri, 12 Feb 2016 13:26:56 +0100 Subject: [PATCH] gnu: Add slurm-wlm. * gnu/packages/parallel.scm (slurm-wlm): New variable. --- gnu/packages/pa

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-12 Thread Pjotr Prins
On Fri, Feb 12, 2016 at 01:30:10PM +0100, Andreas Enge wrote: > On Fri, Feb 12, 2016 at 01:20:42PM +0100, Pjotr Prins wrote: > > Now I remember. The python3 package does not have python in the path. > > So I patch it with python3. > > Alternatively, I would suggest to use python-wrapper; it is exa

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-12 Thread Pjotr Prins
Hopefully taken all comments into account. For better or for worse, at least this works. Pj. >From 5941b6b2624ee18444c2fa9f0805136cf6924a88 Mon Sep 17 00:00:00 2001 From: Pjotr Prins Date: Fri, 12 Feb 2016 13:26:56 +0100 Subject: [PATCH] gnu: Add slurm-wlm. * gnu/packages/parallel.scm (slurm-w

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-12 Thread Andreas Enge
On Fri, Feb 12, 2016 at 01:20:42PM +0100, Pjotr Prins wrote: > Now I remember. The python3 package does not have python in the path. > So I patch it with python3. Alternatively, I would suggest to use python-wrapper; it is exactly python-3 with symlinks python->python3 etc. added. Andreas

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-12 Thread Pjotr Prins
On Thu, Feb 11, 2016 at 09:15:34AM +0100, Pjotr Prins wrote: > > > + (build-system gnu-build-system) > > > + (arguments > > > +`(#:configure-flags '("--enable-pam") > > > + #:phases > > > + (modify-phases %standard-phases > > > + (add-before > > > +'configure 'rewrit

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Efraim Flashner
On Wed, 10 Feb 2016 18:36:48 +0100 Pjotr Prins wrote: > * gnu/packages/parallel.scm (slurm-llnl): New variable. > --- > gnu/packages/parallel.scm | 51 > --- > 1 file changed, 48 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/parallel.sc

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Eric Bavier
On Thu, 11 Feb 2016 12:11:27 +0100 Pjotr Prins wrote: > On Thu, Feb 11, 2016 at 11:08:01AM +0100, Andreas Enge wrote: > > > > I think we should rather use "slurm-wlm" if we are trying to > > > > dissambiguate with the "Slurm the Realtime network interface monitor". > > > The website https://compu

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Pjotr Prins
On Thu, Feb 11, 2016 at 03:21:21PM +0100, Andreas Enge wrote: > On Thu, Feb 11, 2016 at 12:11:27PM +0100, Pjotr Prins wrote: > > There is already a slurm package. > > Did I overlook anything? No, I also checked. The point is that https://packages.debian.org/sid/slurm is a network tool. So, it is

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Andreas Enge
On Thu, Feb 11, 2016 at 12:11:27PM +0100, Pjotr Prins wrote: > There is already a slurm package. Apparently not in current master: $ guix package -A slurm does not show anything, not even $ grep slurm gnu/packages/*.scm Did I overlook anything? Andreas

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Pjotr Prins
On Thu, Feb 11, 2016 at 11:08:01AM +0100, Andreas Enge wrote: > > > I think we should rather use "slurm-wlm" if we are trying to > > > dissambiguate with the "Slurm the Realtime network interface monitor". > > The website https://computing.llnl.gov/linux/slurm/ suggests > > otherwise. Also archlinu

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Andreas Enge
On Thu, Feb 11, 2016 at 09:15:34AM +0100, Pjotr Prins wrote: > I am under the impression one should fix one package at a time. What > is the policy anyway? With or without namespace? Without the namespace > there is a naming conflict between the openssl license and the openssl > package (in tls).

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Ricardo Wurmus
Pjotr Prins writes: > On Wed, Feb 10, 2016 at 10:33:30PM -0600, Eric Bavier wrote: >> On Wed, 10 Feb 2016 18:36:48 +0100 >> Pjotr Prins wrote: >> >> > * gnu/packages/parallel.scm (slurm-llnl): New variable. >> > --- >> > gnu/packages/parallel.scm | 51 >> > +++

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Pjotr Prins
On Wed, Feb 10, 2016 at 10:33:30PM -0600, Eric Bavier wrote: > On Wed, 10 Feb 2016 18:36:48 +0100 > Pjotr Prins wrote: > > > * gnu/packages/parallel.scm (slurm-llnl): New variable. > > --- > > gnu/packages/parallel.scm | 51 > > --- > > 1 file changed

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-11 Thread Pjotr Prins
Thanks for the review. This apparently a problematic package. Let's try fix a few things at a time. On Wed, Feb 10, 2016 at 10:04:47PM -0600, Eric Bavier wrote: > >#:use-module (guix download) > > + #:use-module (guix licenses) > > + #:use-module ((guix licenses) #:prefix license:) > >#:

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-10 Thread Eric Bavier
On Wed, 10 Feb 2016 18:36:48 +0100 Pjotr Prins wrote: > * gnu/packages/parallel.scm (slurm-llnl): New variable. > --- > gnu/packages/parallel.scm | 51 > --- > 1 file changed, 48 insertions(+), 3 deletions(-) [...] > + (license license:openssl))) T

Re: [PATCH] gnu: Add slurm-llnl.

2016-02-10 Thread Eric Bavier
On Wed, 10 Feb 2016 18:36:48 +0100 Pjotr Prins wrote: > * gnu/packages/parallel.scm (slurm-llnl): New variable. > --- > gnu/packages/parallel.scm | 51 > --- > 1 file changed, 48 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/parallel.sc

Re: [PATCH] gnu: Add slurm

2015-12-28 Thread Leo Famulari
On Mon, Dec 28, 2015 at 11:00:14PM +0100, swedebu...@riseup.net wrote: > My first patch ever to a software project. How did I do? Thanks for your first patch! However, it has some problems that will need to be fixed. Did you follow all the steps described in the manual under "Contributing"? Plea

Re: [PATCH] gnu: Add slurm

2015-12-28 Thread Eric Bavier
Hello, Welcome, and thanks for the patch. > If okay I would like to avoid providing my legal name. Using a pseudonym is fine. On Mon, 28 Dec 2015 23:00:14 +0100 swedebu...@riseup.net wrote: > gnu/packages/networking.scm | 21 + > 1 file changed, 21 insertions(+) Please se