Efraim Flashner writes:
>> It looks like ssh isn't hardcoded within git either. Is it worth doing
>> this for git-review then?
>
> This looks like you are using ssh for talking to the remote server, in
> which case it would exist outside of git-review. Or did I misunderstand
> it?
This error was
On Fri, Sep 09, 2016 at 06:09:40PM +0200, Clément Lassieur wrote:
> Efraim Flashner writes:
>
> > I found ssh and I found an instance of scp, so this should be better.
>
> --8<---cut here---start->8---
> clement@lev ~/foo [env]# git-review -d 36373
> Downloadi
Clément Lassieur writes:
> With the patch already pushed, I get this error:
>
> --8<---cut here---start->8---
> Using global/system git-review config files (/etc/git-review/git-review.conf)
> is deprecated
> Downloading refs/changes/73/36373/1 from gerrit
> Tr
Efraim Flashner (2016-09-09 18:00 +0300) wrote:
[...]
> +(arguments
> + `(#:tests? #f ; tests require a running Gerrit server
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'hardcode-outside-programs
> + (lambda _
A side note: I think
Efraim Flashner writes:
> Oh no! I just pushed this.
With the patch already pushed, I get this error:
--8<---cut here---start->8---
Using global/system git-review config files (/etc/git-review/git-review.conf)
is deprecated
Downloading refs/changes/73/36373/
Efraim Flashner writes:
> I found ssh and I found an instance of scp, so this should be better.
--8<---cut here---start->8---
clement@lev ~/foo [env]# git-review -d 36373
Downloading refs/changes/73/36373/1 from gerrit
Cannot fetch patchset contents
Does spec
On Fri, Sep 09, 2016 at 10:23:20AM +0200, Clément Lassieur wrote:
> Efraim Flashner writes:
>
> > On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
>
> >> I think including git simply as an input is problematic because git-review
> >> calls git via 'subprocess', as evidenced by
> >>
Efraim Flashner writes:
> On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
>> I think including git simply as an input is problematic because git-review
>> calls git via 'subprocess', as evidenced by
>>
>> $ ./pre-inst-env guix environment -C --ad-hoc git-review
>> $ git-review
>>
On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
> Hi there, thanks for the patch. I do not have any experience with Gerrit but
> some comments below:
>
>
> On 08/09/16 17:06, Clément Lassieur wrote:
> > [..]
> > +(source
> > + (origin
> > + (method url-fetch)
> > +
On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
> Hi there, thanks for the patch. I do not have any experience with Gerrit but
> some comments below:
>
>
> On 08/09/16 17:06, Clément Lassieur wrote:
> > [..]
> > +(source
> > + (origin
> > + (method url-fetch)
> > +
Hi there, thanks for the patch. I do not have any experience with Gerrit
but some comments below:
On 08/09/16 17:06, Clément Lassieur wrote:
[..]
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://pypi.python.org/packages/source/g/git-revie
On Thu, Sep 08, 2016 at 09:06:30AM +0200, Clément Lassieur wrote:
> * gnu/packages/openstack.scm (git-review): New variable.
> ---
> gnu/packages/openstack.scm | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/openstack.scm b/gnu/packages/opensta
Hello,
On Thu, Sep 8, 2016 at 9:06 AM, Clément Lassieur wrote:
> * gnu/packages/openstack.scm (git-review): New variable.
Yay !
Cannot comment on the input / native-input thing, but otherwise LGTM...
BTW, do any high-level Guix contributor have experience with git-review+gerrit ?
I have a lit
* gnu/packages/openstack.scm (git-review): New variable.
---
gnu/packages/openstack.scm | 29 +
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 8474904..2a54a20 100644
--- a/gnu/packages/openstack.scm
+++ b/gn
14 matches
Mail list logo
