Efraim Flashner <efr...@flashner.co.il> writes: > On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
>> I think including git simply as an input is problematic because git-review >> calls git via 'subprocess', as evidenced by >> >> $ ./pre-inst-env guix environment -C --ad-hoc git-review >> $ git-review >> [..] >> File >> "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py", >> line 1457, in _execute_child >> raise child_exception_type(errno_num, err_msg) >> FileNotFoundError: [Errno 2] No such file or directory: 'git' >> >> So, I think we need to patch the source code to call the full path to git, >> or otherwise wrap the 'git-review' executable. >> >> > + (home-page "http://docs.openstack.org/infra/git-review/";) >> > + (synopsis "Command-line tool for Gerrit") >> > + (description >> > + "Git-review is a command-line tool that helps submitting Git >> > branches to >> > +Gerrit for review, or fetching existing ones.") >> > + (license asl2.0))) >> Otherwise seems OK to me. Can you test with environment -C -N? >> ben >> > > Try it with the attached patch Hi, sorry for the mess and thanks for the reviews. I did not know about the "guix environment -C -N" way of testing packages, and I'm very happy to learn this. The attached patch seems to work for git, but the same error now happens with ssh. -- Clément
