Efraim Flashner (2016-09-09 18:00 +0300) wrote:
[...]
> + (arguments
> + `(#:tests? #f ; tests require a running Gerrit server
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'hardcode-outside-programs
> + (lambda _
A side note: I think in phases it is better to use 'inputs' argument
instead of %build-inputs:
(lambda* (#:key inputs #:allow-other-keys)
> + (let* ((git (string-append
> + (assoc-ref %build-inputs "git") "/bin/git"))
> + (base (assoc-ref %build-inputs "openssh"))
(assoc-ref inputs "git") and (assoc-ref inputs "openssh") here
> + (ssh (string-append base "/bin/ssh"))
> + (scp (string-append base "/bin/scp")))
> + (substitute* '("git_review/cmd.py"
> "git_review/tests/test_git_review.py"
> + "git_review/tests/test_unit.py"
> "git_review/tests/utils.py")
> + (("\"git ") (string-append "\"" git " "))
> + (("\"git\"") (string-append "\"" git "\""))
> + (("'git'") (string-append "'" git "'")))
> + (substitute* "git_review/cmd.py"
> + (("\"ssh\"") (string-append "\"" ssh "\""))
> + (("'ssh'") (string-append "'" ssh "'"))
> + (("\"scp\"") (string-append "\"" scp "\""))
> + (("'scp") (string-append "'" scp)))
> + #t))))))
> (native-inputs
> `(("python-pbr" ,python-pbr)))
> (inputs
> `(("python-requests" ,python-requests)
> + ("openssh" ,openssh)
> ("git" ,git)))
> (home-page "http://docs.openstack.org/infra/git-review/";)
> (synopsis "Command-line tool for Gerrit")
--
Alex
