Re: [PATCH] add go@1.6

2016-07-31 Thread Ludovic Courtès
Hello! Matthew Jordan skribis: > From fbe9e4074cd27449d2337f62c7004993d087f6ba Mon Sep 17 00:00:00 2001 > From: Matthew Jordan > Date: Thu, 26 May 2016 09:16:48 -0400 > Subject: [PATCH] gnu: Add go@1.6. > > * gnu/packages/golang.scm (go-1.6): New variable. > > Co-author: Efraim Flashner > Co-a

Re: [PATCH] add go@1.6

2016-07-30 Thread Matthew Jordan
Good Day, This patch contains the suggestions made in the previous email. Take a look a let me know if any further changes are needed. >From fbe9e4074cd27449d2337f62c7004993d087f6ba Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Thu, 26 May 2016 09:16:48 -0400 Subject: [PATCH] gnu: Add go@1

Re: [PATCH] add go@1.6

2016-07-30 Thread Alex Griffin
Hey Matthew, On Sat, Jul 30, 2016, at 11:28 AM, Matthew Jordan wrote: > Good Day, > > This patch contains the suggestions made in the previous email. Take a > look a let me know if any further changes are needed. Looks good to me! -- Alex Griffin

Re: [PATCH] add go@1.6

2016-07-28 Thread Leo Famulari
On Wed, Jul 27, 2016 at 07:54:13PM -0400, Matthew Jordan wrote: > Good Day everyone, > > Attached is a patch to add go@1.6. Note that I have taken the > suggestion made in go@1.5 and added it to this patch. Also I have > included many of the suggested changes for go@1.4 in this patch also. > > Ta

Re: [PATCH] add go@1.6

2016-07-28 Thread Matthew Jordan
>> (version "1.6.2") I'll update the version in an updated patch. Assuming no problems I'll be happy to submit it. >>(zero? (system* "sh" "all.bash") > > This seems to work, but I think it should just be `(zero? (system* > "./all.bash"))`. It has a shebang, and expects ba

Re: [PATCH] add go@1.6

2016-07-28 Thread Alex Griffin
On Thu, Jul 28, 2016, at 05:11 AM, Matthew Jordan wrote: > Doesn't sh already handle picking the shell/interpretor? That's why I > put it there. sh or an sh compatible shell is usually the first to > start. Feel free to correct me if I'm wrong. In Guix, sh is provided by bash, but when bash is la

[PATCH] add go@1.6

2016-07-27 Thread Matthew Jordan
Good Day everyone, Attached is a patch to add go@1.6. Note that I have taken the suggestion made in go@1.5 and added it to this patch. Also I have included many of the suggested changes for go@1.4 in this patch also. Take a look and let me know if I missed anything or need to make further change

Re: [PATCH] add go@1.6

2016-07-27 Thread Alex Griffin
Hello Matthew, I'm not done looking at the package, but here are some of my initial thoughts: On Wed, Jul 27, 2016, at 06:54 PM, Matthew Jordan wrote: > (version "1.6.2") Version 1.6.3 was just released to fix a security issue. >(zero? (system* "sh" "all.bash") This see