Hello! Matthew Jordan <matthewjordandev...@yandex.com> skribis:
> From fbe9e4074cd27449d2337f62c7004993d087f6ba Mon Sep 17 00:00:00 2001 > From: Matthew Jordan <matthewjordandev...@yandex.com> > Date: Thu, 26 May 2016 09:16:48 -0400 > Subject: [PATCH] gnu: Add go@1.6. > > * gnu/packages/golang.scm (go-1.6): New variable. > > Co-author: Efraim Flashner <efr...@flashner.co.il> > Co-author: Andy Wingo <wi...@igalia.com> Awesome! I made small changes: > + (arguments > + `(#:modules ((ice-9 match) > + (guix build gnu-build-system) > + (guix build utils)) > + #:tests? #f ; Tests are run by all.bash script > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (add-after 'patch-generated-file-shebangs 'chdir > + (lambda _ (chdir "src"))) … using ‘substitute-keyword-arguments’ here to try to factorize build phases with go@1.4, though in practice there are subtle differences preventing the ‘prebuild’ and ‘install’ phases from being factorized. Would be nice to improve it eventually, somehow. > + (inputs > + `(,@(package-inputs go-1.4))) This is equivalent to: (inputs (package-inputs go-1.4)) which is equivalent to putting nothing, since we already ‘inherit’ from go-1.4. > + (propagated-inputs > + `(,@(package-propagated-inputs go-1.4))))) Ditto. Committed, thank you! Ludo’.
