>> (version "1.6.2") I'll update the version in an updated patch. Assuming no problems I'll be happy to submit it.
>> (zero? (system* "sh" "all.bash"))))) > > This seems to work, but I think it should just be `(zero? (system* > "./all.bash"))`. It has a shebang, and expects bash, not sh. Doesn't sh already handle picking the shell/interpretor? That's why I put it there. sh or an sh compatible shell is usually the first to start. Feel free to correct me if I'm wrong. > If it doesn't cause any problems, we should delete pkg/bootstrap/* so > that it doesn't retain any references to go@1.4. I think that would > drastically reduce the size of its closure. I'll look into this and get back to you. > Also, I'm not sure I'm sold on splitting up into multiple outputs, but I > haven't thought about it much and don't have a strong opinion. The > "tests" output is only 5M and "doc" is only 10M, vs 270M for the default > output. This sounds like the beginning of a long conversation. Suffice to say it's doesn't bother me either way. However I would rather change this in later patch, if it has to be changed. Respectuflly, Matthew Jordan
