Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-09-25 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 08:40:40PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the md RAID 6 code already > present in grub. > > Signed-off-by: Goffredo Ba

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-27 Thread Daniel Kiper
On Wed, Sep 26, 2018 at 10:40:32PM +0200, Goffredo Baroncelli wrote: > On 25/09/2018 17.31, Daniel Kiper wrote: > > On Wed, Sep 19, 2018 at 08:40:32PM +0200, Goffredo Baroncelli wrote: > >> From: Goffredo Baroncelli > >> > >> Signed-off-by: Goffredo Baroncelli

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-09-27 Thread Daniel Kiper
On Wed, Sep 26, 2018 at 09:55:54PM +0200, Goffredo Baroncelli wrote: > On 25/09/2018 19.29, Daniel Kiper wrote: > > On Wed, Sep 19, 2018 at 08:40:35PM +0200, Goffredo Baroncelli wrote: > >> From: Goffredo Baroncelli > >> > >> If a device is not found, do no

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-09-27 Thread Daniel Kiper
On Wed, Sep 26, 2018 at 09:55:57PM +0200, Goffredo Baroncelli wrote: > On 25/09/2018 21.10, Daniel Kiper wrote: > > On Wed, Sep 19, 2018 at 08:40:38PM +0200, Goffredo Baroncelli wrote: > >> From: Goffredo Baroncelli > >> > >> Add support for recovery for

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-09-27 Thread Daniel Kiper
On Wed, Sep 26, 2018 at 09:56:07PM +0200, Goffredo Baroncelli wrote: > On 25/09/2018 21.20, Daniel Kiper wrote: > > On Wed, Sep 19, 2018 at 08:40:40PM +0200, Goffredo Baroncelli wrote: > >> From: Goffredo Baroncelli > >> > [] > >>

Re: efinet SNP issue affects iscsi boot

2018-09-27 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 06:15:45PM +0800, Michael Chang wrote: > On Thu, Sep 20, 2018 at 02:01:08PM +0200, Daniel Kiper wrote: > > On Thu, Sep 20, 2018 at 06:38:07PM +0800, Michael Chang wrote: > > > On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote: > > >

Re: grubenv on md, Btrfs, LUKS, etc

2018-09-27 Thread Daniel Kiper
On Wed, Sep 26, 2018 at 04:45:51PM -0600, Chris Murphy wrote: > On Fri, Sep 21, 2018 at 12:35 PM, Daniel Kiper wrote: > > On Tue, Sep 18, 2018 at 01:40:06PM -0600, Chris Murphy wrote: > >> On Mon, Sep 17, 2018 at 10:59 PM, Chris Murphy > >> wrote: > >&g

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-27 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 06:12:18PM +0200, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote: > > On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > Unfortunately this pulls in some

Re: grubenv on md, Btrfs, LUKS, etc

2018-09-28 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 05:00:31PM -0600, Chris Murphy wrote: > On Thu, Sep 27, 2018 at 10:38 AM, Daniel Kiper wrote: > > On Wed, Sep 26, 2018 at 04:45:51PM -0600, Chris Murphy wrote: > >> On Fri, Sep 21, 2018 at 12:35 PM, Daniel Kiper wrote: > >> > On Tue, Se

[PATCH v3 8/8] efi: Add EFI shim lock verifier

2018-10-03 Thread Daniel Kiper
the iorw and memrw modules are loaded then machine boot is disabled, - GRUB2 defers modules verification to other verifiers. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - disable module unload, - disable the iorw and memrw modules loading, - disable boot if the iorw and

[PATCH v3 0/8] verifiers: Framework and EFI shim lock verifier

2018-10-03 Thread Daniel Kiper
(-) Daniel Kiper (4): verifiers: Add possibility to defer verification to other verifiers verifiers: Rename verify module to pgp module dl: Add support for persistent modules efi: Add EFI shim lock verifier Vladimir Serbinenko (4): verifiers: File type for fine-grained

[PATCH v3 5/8] verifiers: Rename verify module to pgp module

2018-10-03 Thread Daniel Kiper
Just for clarity. No functional change. Signed-off-by: Daniel Kiper --- grub-core/Makefile.core.def |4 +- grub-core/commands/pgp.c| 1018 +++ grub-core/commands/verify.c | 1018 --- 3 files changed, 1020

[PATCH v3 7/8] dl: Add support for persistent modules

2018-10-03 Thread Daniel Kiper
nor complicated hence it make sense to support modularized configs too. Signed-off-by: Daniel Kiper --- grub-core/commands/minicmd.c |3 +++ include/grub/dl.h| 13 + 2 files changed, 16 insertions(+) diff --git a/grub-core/commands/minicmd.c b/grub-core/commands

[PATCH v3 1/8] verifiers: File type for fine-grained signature-verification controlling

2018-10-03 Thread Daniel Kiper
From: Vladimir Serbinenko Let's provide file type info to the I/O layer. This way verifiers framework and its users will be able to differentiate files and verify only required ones. This is preparatory patch. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper -

[PATCH v3 6/8] verifiers: Add the documentation

2018-10-03 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - improve the documentation. --- docs/grub-dev.texi | 57 1 file changed, 57 insertions(+) diff --git a/docs/grub

[PATCH v3 4/8] verifiers: Add possibility to defer verification to other verifiers

2018-10-03 Thread Daniel Kiper
trusted on UEFI systems with secure boot enabled. So, it can defer verification to other verifier, e.g. PGP one. I silently assume that other verifiers are trusted and will do good job for us. Or at least they will not do any harm. Signed-off-by: Daniel Kiper --- grub-core/commands

[PATCH v3 3/8] verifiers: Add possibility to verify kernel and modules command lines

2018-10-03 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub-core/commands/verify_helper.c| 14 ++ grub-core/lib/cmdline.c |9 + grub-core/loader/arm/linux.c |8 ++-- grub-core/loader

[PATCH v3 2/8] verifiers: Framework core

2018-10-03 Thread Daniel Kiper
for the sake of clarity. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - minor improvement and cleanups. --- grub-core/Makefile.core.def|5 + grub-core/commands/verify.c| 565 +--- grub-core

Re: [PATCH 0/8] xen: add pvh guest support

2018-10-09 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 11:35:28AM +0200, Juergen Gross wrote: > On 15/02/2018 13:02, Daniel Kiper wrote: > > Hi Juergen, > > > > Sorry for huge delay. It looks that I am recovering slowly and > > probably I will have more time for reviews. > > > > On Wed, No

Re: [PATCH v3 1/8] verifiers: File type for fine-grained signature-verification controlling

2018-10-09 Thread Daniel Kiper
On Wed, Oct 03, 2018 at 01:33:26PM -0400, Ross Philipson wrote: > On 10/03/2018 05:36 AM, Daniel Kiper wrote: [...] > > grub_file_t > > -grub_file_open (const char *name) > > +grub_file_open (const char *name, enum grub_file_type type) > > { > >grub_device

Re: [PATCH v3 2/8] verifiers: Framework core

2018-10-09 Thread Daniel Kiper
On Wed, Oct 03, 2018 at 01:55:08PM -0400, Ross Philipson wrote: > On 10/03/2018 05:36 AM, Daniel Kiper wrote: [...] > > +struct grub_file_verifier grub_pubkey_verifier = > > + { > > +.name = "pgp", > > +.init = grub_pubkey_init, > > +

Re: [PATCH v3 4/8] verifiers: Add possibility to defer verification to other verifiers

2018-10-09 Thread Daniel Kiper
On Fri, Oct 05, 2018 at 12:09:43PM -0400, Ross Philipson wrote: > On 10/03/2018 05:36 AM, Daniel Kiper wrote: > > This way if a verifier requires verification of a given file it can > > defer task to other verifier if it is not able to do it itself. E.g. > > shim_lock

Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

2018-10-09 Thread Daniel Kiper
On Fri, Oct 05, 2018 at 12:24:18PM -0400, Ross Philipson wrote: > On 10/03/2018 05:36 AM, Daniel Kiper wrote: > > Just for clarity. No functional change. > > > > Signed-off-by: Daniel Kiper > > --- > > grub-core/Makefile.core.def |4 +- > &

Re: [PATCH v3 6/8] verifiers: Add the documentation

2018-10-09 Thread Daniel Kiper
On Fri, Oct 05, 2018 at 12:43:08PM -0400, Ross Philipson wrote: > On 10/03/2018 05:36 AM, Daniel Kiper wrote: > > From: Vladimir Serbinenko > > > > Signed-off-by: Vladimir Serbinenko > > Signed-off-by: Daniel Kiper > > --- > > v3 - suggestions/fi

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-10-09 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 08:34:56PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Signed-off-by: Goffredo Baroncelli Code LGTM. Though comment begs improvement. I will send you updated comment for approval shortly. Daniel ___ Grub-

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-10-09 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 08:34:59PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Change the behavior of find_device(): before the patch, a read of a missed > device may trigger a rescan. However, it is never recorded that a device > is missed, so each single read of a missed de

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-10-09 Thread Daniel Kiper
gned-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-09 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 08:35:02PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add support for recovery for a RAID 5 btrfs profile. In addition > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/

Re: [PATCH v2 1/2] Import upstream zstd-1.3.6

2018-10-09 Thread Daniel Kiper
On Mon, Oct 08, 2018 at 04:06:20PM -0700, Nick Terrell wrote: > Import zstd-1.3.6 from upstream [1]. Only the files need for decompression > are imported. > > I used the latest zstd release, which includes patches [2] to build cleanly > in GRUB. > > Upstream zstd commit hash: 4fa456d7f12f8b27bd3b2f

Re: [PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Daniel Kiper
ion with and without zstd > compression. A test case was also added to the test suite that fails before > the patch, and passes after. > > Signed-off-by: Nick Terrell > --- > v1 -> v2: > - Fix comments from Daniel Kiper > > Makefile.util.def| 10 +++- >

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-10-11 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 07:51:01PM +0200, Daniel Kiper wrote: > On Thu, Sep 27, 2018 at 08:34:56PM +0200, Goffredo Baroncelli wrote: > > From: Goffredo Baroncelli > > > > Signed-off-by: Goffredo Baroncelli > > Code LGTM. Though comment begs improvement. I will sen

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-10-11 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 07:56:43PM +0200, Daniel Kiper wrote: > On Thu, Sep 27, 2018 at 08:34:59PM +0200, Goffredo Baroncelli wrote: > > From: Goffredo Baroncelli > > > > Change the behavior of find_device(): before the patch, a read of a missed > > device may trigg

Re: [PATCH V8] Add support for BTRFS raid5/6 to GRUB

2018-10-11 Thread Daniel Kiper
On Thu, Sep 27, 2018 at 08:34:55PM +0200, Goffredo Baroncelli wrote: > > i All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. I have sent you updated comment and commit message. Please double check it. If everything is OK please repost whole series

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Daniel Kiper
On Wed, Oct 10, 2018 at 08:28:27PM +, Nick Terrell wrote: > > On Oct 10, 2018, at 12:34 AM, Paul Menzel wrote: > > > > Sorry for being ignorant, but you explain, why the library needs to be > > imported and it is not enough to use that library as an external dependency? > > > > Importing the

Re: [PATCH v3 1/2] Import upstream zstd-1.3.6

2018-10-11 Thread Daniel Kiper
IB > mkdir -p $DST_LIB > cp $SRC_LIB/zstd.h $DST_LIB/ > cp $SRC_LIB/common/*.[hc] $DST_LIB/ > cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ > rm $DST_LIB/{pool.[hc],threading.[hc]} > rm -rf zstd-1.3.6* > echo SUCCESS! > --- Ditto. > Signed-off-by: Nick Terrell If you fix th

Re: [PATCH v3 2/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Daniel Kiper
nd passes after. > > Signed-off-by: Nick Terrell > --- > v1 -> v2: > - Fix comments from Daniel Kiper. > > v2 -> v3: > - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). > - Fix style and formatting comments. > > Makefile.util.def| 10 +

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Daniel Kiper
Hi Nick, CC-ing Goffredo. On Tue, Oct 09, 2018 at 04:21:35PM -0700, Nick Terrell wrote: > Hi all, > > This patch set imports the upstream zstd library, adds zstd support to the > btrfs module, and adds a test case. I've also tested the patch set by storing > my boot partition in btrfs with and wi

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-10-17 Thread Daniel Kiper
On Thu, Oct 11, 2018 at 08:50:55PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Signed-off-by: Goffredo Baroncelli > Signed-off-by: Daniel Kiper One nit pick below... Otherwise you can add Reviewed-by: Daniel Kiper > --- > grub-co

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-10-17 Thread Daniel Kiper
found for a given > device. This means that only first time read triggers rescan. > > The patch drops premature return. This way data->devices_attached[] is > filled even when a given device is missing. > > Signed-off-by: Goffredo Baroncelli I changed commit message, so, y

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-17 Thread Daniel Kiper
On Thu, Oct 11, 2018 at 08:51:01PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add support for recovery for a RAID 5 btrfs profile. In addition > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-10-17 Thread Daniel Kiper
gned-off-by: Goffredo Baroncelli > Reviewed-by: Daniel Kiper > --- > grub-core/fs/btrfs.c | 60 +++- > 1 file changed, 54 insertions(+), 6 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index d066d54cc..d20

Re: [PATCH] loader/i386/linux: report UEFI secure boot status to the Linux kernel

2018-10-17 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 04:04:03PM +, Ignat Korchagin wrote: > Linux kernel from 4.11 has secure_boot member as part of linux_kernel_params. > Currently, GRUB does not populate it, so the kernel reports > "Secure boot could not be determined" on boot. We can populate it in EFI mode, > so the ke

Re: [PATCH v2 1/2] efi: add function to read EFI variables with attributes

2018-10-18 Thread Daniel Kiper
e, > + const > grub_efi_guid_t *guid, > + grub_size_t > *datasize_out, > + grub_efi_uint32_t > *attributes);

Re: [PATCH v2 2/2] loader/i386/linux: report UEFI secure boot status to the Linux kernel

2018-10-18 Thread Daniel Kiper
ernel_params >grub_uint16_t vid_mode;/* Video mode control */ >grub_uint16_t root_dev;/* Default root device number */ > > - grub_uint8_t padding10;/* 1fe */ > + grub_uint8_t padding11; /* 1fe */ >grub_uint8_t ps_mouse;

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-18 Thread Daniel Kiper
On Wed, Oct 17, 2018 at 09:03:58PM +0200, Goffredo Baroncelli wrote: > On 17/10/2018 16.14, Daniel Kiper wrote: > > On Thu, Oct 11, 2018 at 08:51:01PM +0200, Goffredo Baroncelli wrote: > >> From: Goffredo Baroncelli > >> > >> Add support for recovery for

Re: [PATCH 1/1] search: Add search by GPT partition type

2018-10-18 Thread Daniel Kiper
Hi Will, Sorry for huge delay but I was swamped by other stuff. Anyway, patch LGTM. Just a few nit picks below. On Wed, Jun 20, 2018 at 04:38:08PM +0100, Will Thompson wrote: > From: Carlo Caione > > Add a new search.fs_type tool to search by GPT partition type UUID. > > Signed-off-by: Carlo Ca

Re: [PATCH v2 01/18] xen: add some xen headers

2018-10-18 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:00PM +0200, Juergen Gross wrote: > In order to support grub2 in Xen PVH environment some additional Xen > headers are needed as grub2 will be started in PVH mode requiring to > use several HVM hypercalls and structures. > > Add the needed headers from Xen 4.10 being th

Re: [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote: > Xen PVH guests will have the RSDP at an arbitrary address. Support that > by passing the RSDP address via the boot parameters to Linux. > > The new protocol version 2.14 requires to set version to 0x8000 ored > with the actually use p

Re: [PATCH v2 01/18] xen: add some xen headers

2018-10-18 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 04:04:04PM +0200, Juergen Gross wrote: > On 18/10/2018 15:45, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:00PM +0200, Juergen Gross wrote: > >> In order to support grub2 in Xen PVH environment some additional Xen > >> headers are needed

Re: [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote: > On 18/10/2018 16:13, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote: > >> Xen PVH guests will have the RSDP at an arbitrary address. Support that > >> by passing th

Re: [PATCH v2 03/18] xen: carve out grant tab initialization into dedicated function

2018-10-18 Thread Daniel Kiper
t; > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 04:36:28PM +0200, Juergen Gross wrote: > On 18/10/2018 16:30, Daniel Kiper wrote: > > On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote: > >> On 18/10/2018 16:13, Daniel Kiper wrote: > >>> On Tue, Oct 09, 2018 at 01:03:01PM +0200, J

Re: [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-18 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:03PM +0200, Juergen Gross wrote: > Some common code needs to be special cased for Xen PVH mode. This hits > mostly Xen PV mode specific areas. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/tsc.c | 2 +- > include/grub/i386/pc/int.h| 3 +

Re: [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 04:53:01PM +0200, Juergen Gross wrote: > On 18/10/2018 16:48, Daniel Kiper wrote: > > On Thu, Oct 18, 2018 at 04:36:28PM +0200, Juergen Gross wrote: > >> On 18/10/2018 16:30, Daniel Kiper wrote: > >>> On Thu, Oct 18, 2018 at 04:18:26PM +0200,

Re: [PATCH v2 05/18] xen: add some dummy headers for PVH mode

2018-10-18 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:04PM +0200, Juergen Gross wrote: > Xen PVH mode needs some headers including the common i386 headers. > Add those to the tree. > > Signed-off-by: Juergen Gross > --- > include/grub/i386/xenpvh/boot.h| 1 + > include/grub/i386/xenpvh/console.h | 1 + > include/gru

Re: [PATCH v2 06/18] xen: rearrange xen/init.c to prepare it for Xen PVH mode

2018-10-18 Thread Daniel Kiper
ross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:06PM +0200, Juergen Gross wrote: > include/grub/offsets.h needs some defines for Xen PVH mode. > > Add them. While at it line up the values in the surrounding lines to > start at the same column. > > Signed-off-by: Juergen Gross > --- > include/grub/offsets.h | 21 ++

Re: [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. I am not against the code itself but it would be nice to know why you add, AIUI, just stubs here which will be filled with proper code later. Daniel

Re: [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > Add the code for the Xen PVH mode boot entry. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/startup_pvh.S | 50 > +++ > 1 file changed, 50 insertions(+) > > diff --git a/grub-core/

Re: [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:10PM +0200, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 98 > +++

Re: [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed, 70

Re: [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the gu

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-22 Thread Daniel Kiper
+ continue; > + } > + > + err = grub_disk_read (dev->disk, paddr >> GRUB_DISK_SECTOR_BITS, > + paddr & (GRUB_DISK_SECTOR_SIZE - 1), > + csize, buffers[i].buf); > + if (err =

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks are present. > > The ne

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: > On 19/10/2018 17:33, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/ker

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 04:50:25PM +0200, Juergen Gross wrote: > On 19/10/2018 14:17, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > >> Add the code for the Xen PVH mode boot entry. > >> > >> Signed-off-by: Juergen Gross

Re: [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > Add all usable memory regions to grub memory management and add the > needed mmap iterate code. I am missing a few words why this patch is needed. Especially why grub_machine_mmap_iterate() has to belong to this patch. However, I thi

Re: [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:13PM +0200, Juergen Gross wrote: > Add the modifications to the build system needed to build a xenpvh > grub. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > gentpl.py | 4 ++-- > grub-cor

Re: [PATCH v2 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-22 Thread Daniel Kiper
gnu.org/bugs/?49012 > > Signed-off-by: Hans van Kranenburg Except s/xenpvh/xen_pvh/ Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 16/18] xenpvh: support building a standalone image

2018-10-22 Thread Daniel Kiper
off-by: Juergen Gross +/- XENPVH/xenpvh play Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 17/18] xenpvh: support grub-install for xenpvh

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:16PM +0200, Juergen Gross wrote: > Add xenpvh support to grub-install. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH play still Reviewed-by: Daniel Kiper Daniel ___ Grub-devel

Re: [PATCH v2 18/18] xenpvh: add support to configure

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:17PM +0200, Juergen Gross wrote: > Support platform i386/xenpvh in configure. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH/xenpvh play still Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Mon, Oct 22, 2018 at 01:43:53PM +0200, Juergen Gross wrote: > On 22/10/2018 13:31, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > >> Add all usable memory regions to grub memory management and add the > >> needed mmap iterate

[PATCH v4 3/9] verifiers: Framework core

2018-10-30 Thread Daniel Kiper
for the sake of clarity. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- v4 - suggestions/fixes: - rename grub-core/commands/verify_helper.c to grub-core/commands/verifiers.c. v3 - suggestions/fixes: - minor improvement and cleanups. --- grub-core

[PATCH v4 6/9] verifiers: Rename verify module to pgp module

2018-10-30 Thread Daniel Kiper
Just for clarity. No functional change. Signed-off-by: Daniel Kiper --- grub-core/Makefile.core.def|4 ++-- grub-core/commands/{verify.c => pgp.c} |0 2 files changed, 2 insertions(+), 2 deletions(-) rename grub-core/commands/{verify.c => pgp.c} (100%) diff --git

[PATCH v4 7/9] verifiers: Add the documentation

2018-10-30 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- v4 - suggestions/fixes: - use complete grammar (suggested by Ross Philipson), - improve the documentation. v3 - suggestions/fixes: - improve the documentation. --- docs/grub-dev.texi

[PATCH v4 0/9] verifiers: Framework and EFI shim lock verifier

2018-10-30 Thread Daniel Kiper
| 78 ++ util/grub-fstest.c |6 +- util/grub-mount.c|6 +- 88 files changed, 1949 insertions(+), 1282 deletions(-) Daniel Kiper (5): bufio: Use grub_size_t instead of plain int for size verifiers: Add

[PATCH v4 5/9] verifiers: Add possibility to defer verification to other verifiers

2018-10-30 Thread Daniel Kiper
modules which have to be trusted on UEFI systems with secure boot enabled. So, it can defer verification to other verifier, e.g. PGP one. I silently assume that other verifiers are trusted and will do good job for us. Or at least they will not do any harm. Signed-off-by: Daniel Kiper --- v4

[PATCH v4 8/9] dl: Add support for persistent modules

2018-10-30 Thread Daniel Kiper
nor complicated hence it make sense to support modularized configs too. Signed-off-by: Daniel Kiper --- grub-core/commands/minicmd.c |3 +++ include/grub/dl.h| 13 + 2 files changed, 16 insertions(+) diff --git a/grub-core/commands/minicmd.c b/grub-core/commands

[PATCH v4 4/9] verifiers: Add possibility to verify kernel and modules command lines

2018-10-30 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub-core/commands/verifiers.c| 14 ++ grub-core/lib/cmdline.c |9 + grub-core/loader/arm/linux.c |8 ++-- grub-core/loader

[PATCH v4 1/9] bufio: Use grub_size_t instead of plain int for size

2018-10-30 Thread Daniel Kiper
Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub-core/io/bufio.c |6 +++--- include/grub/bufio.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/grub-core/io/bufio.c b/grub-core/io/bufio.c index dbed647..d2f4fb4 100644 --- a/grub-core/io

[PATCH v4 2/9] verifiers: File type for fine-grained signature-verification controlling

2018-10-30 Thread Daniel Kiper
From: Vladimir Serbinenko Let's provide file type info to the I/O layer. This way verifiers framework and its users will be able to differentiate files and verify only required ones. This is preparatory patch. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper -

[PATCH v4 9/9] efi: Add EFI shim lock verifier

2018-10-30 Thread Daniel Kiper
the iorw and memrw modules are loaded then machine boot is disabled, - GRUB2 defers modules and ACPI tables verification to other verifiers. Signed-off-by: Daniel Kiper --- v4 - suggestions/fixes: - s/GRUB_VERIFY_FLAGS_DEFER/GRUB_VERIFY_FLAGS_DEFER_AUTH/, - defer ACPI tables

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-31 Thread Daniel Kiper
On Mon, Oct 22, 2018 at 07:49:40PM +, Nick Terrell wrote: > > > > On Oct 22, 2018, at 4:02 AM, Daniel Kiper wrote: > > > > On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: > >> > >> Hi All, > >> > >> the aim o

Re: [PATCH] unix/platform: Initialize variable to fix grub-install on UEFI system

2018-10-31 Thread Daniel Kiper
ariable to 0, so that success is returned, when no entry needs > to be deleted. > > Tested on Dell OptiPlex 7010 with firmware A28. > > $ sudo ./grub-install /dev/sda > Installing for x86_64-efi platform. > Installation finished. No error reported. > >

Re: [PATCH] Cope with / being on a ZFS root dataset

2018-10-31 Thread Daniel Kiper
boot, but > "root=ZFS=${rpool}" works fine, so strip the trailing slash. > > Fixes: https://savannah.gnu.org/bugs/?52746 > Tested-by: Fejes J??zsef > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel

Re: grub2-bhyve

2018-10-31 Thread Daniel Kiper
Hi Alex, On Sat, Oct 27, 2018 at 12:31:52PM +0300, Alex Zimnitsky wrote: > Hola! > > There is a rather dated project named `grub2-bhyve' which grub-loads an > OS to be a bhyve (freebsd hypervisor) guest. > > Is there anything fundamental that prevents implementing bhyve support > in mainline-grub2

Re: [PATCH v4 1/2] Import upstream zstd-1.3.6

2018-11-06 Thread Daniel Kiper
On Wed, Oct 31, 2018 at 10:56:16AM -0700, Nick Terrell wrote: > Import zstd-1.3.6 from upstream [1]. Only the files need for decompression > are imported. Additionally makes zstd a module by adding module.c which > contains the license, and updates Makefile.core.def. > > I used the latest zstd rele

Re: [PATCH v4 2/2] btrfs: Add zstd support to grub btrfs

2018-11-06 Thread Daniel Kiper
nd passes after. > > Signed-off-by: Nick Terrell > --- > v1 -> v2: > - Fix comments from Daniel Kiper. > > v2 -> v3: > - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). > - Fix style and formatting comments. > > v3 -> v4: > - Use attribute

Re: [PATCH v4 1/2] Import upstream zstd-1.3.6

2018-11-07 Thread Daniel Kiper
On Tue, Nov 06, 2018 at 07:43:04PM +, Nick Terrell wrote: > > On Nov 6, 2018, at 6:48 AM, Daniel Kiper wrote: > > On Wed, Oct 31, 2018 at 10:56:16AM -0700, Nick Terrell wrote: > >> Import zstd-1.3.6 from upstream [1]. Only the files need for decompression > >> ar

Re: [PATCH v4 02/19] loader/linux: support passing rsdp address via boot params

2018-11-07 Thread Daniel Kiper
he actually use protocol version (the minimum of the kernel > supplied protocol version and the grub2 supported protocol version) > if 2.14 or higher are in effect. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ G

Re: [PATCH v4 04/19] xen: prepare common code for Xen PVH support

2018-11-07 Thread Daniel Kiper
u fix two nitpicks below you can add Reviewed-by: Daniel Kiper > --- > V3: GRUB_MACHINE_XENPVH -> GRUB_MACHINE_XEN_PVH (Daniel Kiper) > split include/grub/i386/pc/int.h (Daniel Kiper) > move struct grub_e820_mmap_entry definition to header file > --- > grub-core/

Re: [PATCH v4 07/19] xen: add PVH specific defines to offset.h

2018-11-07 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:26PM +0100, Juergen Gross wrote: > include/grub/offsets.h needs some defines for Xen PVH mode. > > Add them. While at it line up the values in the surrounding lines to > start at the same column. > > Signed-off-by: Juergen Gross Reviewed-by: Dan

Re: [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-07 Thread Daniel Kiper
> Signed-off-by: Juergen Gross > --- > V3: updated commit message (Daniel Kiper) > xenpvh->xen_pvh (Daniel Kiper) > --- > include/grub/i386/xen_pvh/boot.h| 1 + > include/grub/i386/xen_pvh/console.h | 1 + > include/grub/i386/xen_pvh/int.h | 1 + >

Re: [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-08 Thread Daniel Kiper
On Wed, Nov 07, 2018 at 03:49:51PM +0100, Juergen Gross wrote: > On 07/11/2018 13:21, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: > >> With Xen PVH mode adding a new machine type the machine related headers > >> need to be prese

Re: [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-08 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. They will be filled > with code later when the related functionality is being added. > > Signed-off-by: Juergen Gross > --- > V3: xenpvh->xen_pvh (Danie

Re: [PATCH v4 09/19] xen: add PVH boot entry code

2018-11-08 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:28PM +0100, Juergen Gross wrote: > Add the code for the Xen PVH mode boot entry. > > Signed-off-by: Juergen Gross One nitpick below. Otherwise Reviewed-by: Daniel Kiper > --- > V3: clear %fs and %gs, too (Daniel K

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-11-09 Thread Daniel Kiper
On Wed, Oct 31, 2018 at 07:48:08PM +0100, Goffredo Baroncelli wrote: > On 31/10/2018 13.06, Daniel Kiper wrote: > [...] > > > > v11 pushed. > > > > Goffredo, thank you for doing the work. > > Great ! Many thanks for your

Re: [Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-09 Thread Daniel Kiper
On Thu, Nov 08, 2018 at 08:23:20PM +0100, Juergen Gross wrote: > On 08/11/2018 16:45, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. They will be filled > >> with

Re: [PATCH v4 10/19] xen: setup hypercall page for PVH

2018-11-09 Thread Daniel Kiper
message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > --- > grub-core/kern/i386/xen/pvh.c | 69 > +++ > 1 file changed, 69 insertions(+) > > diff --git a/grub-core/kern/i386/xen/pvh.c b/gr

<    1   2   3   4   5   6   7   8   9   10   >