On Wed, Oct 10, 2018 at 08:28:27PM +0000, Nick Terrell wrote: > > On Oct 10, 2018, at 12:34 AM, Paul Menzel <pmen...@molgen.mpg.de> wrote: > > > > Sorry for being ignorant, but you explain, why the library needs to be > > imported and it is not enough to use that library as an external dependency? > > > > Importing the library means, it has to be maintained in the GRUB > > repository, which will result in some maintenance burden. > > I've imported zstd because thats the way the rest of the decompressors are > imported. > > We could potentially use libzstd as an external dependency, since its only > dependency is libc > and GRUB provides the definitions of the libc functions that zstd needs to > decompress > (memcpy, and memmove). Theres some other stuff in the library that requires > libc functionality > that GRUB doesn't provide, but that isn't used during decompression. We strip > those files > out in the import. > > Let me know if you want me to switch to an external dependency.
I do not think it is possible. Or it can be at least difficult. Even if it is possible it would require a major rework of GRUB build machine. So, even if current solution is not perfect I would like to stick to it. And zstd library integration is not very difficult. So, I do not think it will add a lot of burden in the future. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
