On Mon, Oct 22, 2018 at 01:43:53PM +0200, Juergen Gross wrote: > On 22/10/2018 13:31, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > >> Add all usable memory regions to grub memory management and add the > >> needed mmap iterate code. > > > > I am missing a few words why this patch is needed. Especially why > > grub_machine_mmap_iterate() has to belong to this patch. However, > > I think that it should be introduced by patch in which > > grub_machine_mmap_iterate() is used at some point. > > That would again lead to one giant PVH patch which you didn't like. > > grub_machine_mmap_iterate() is being used by grub common code like > grub-core/lib/relocator.c or grub-core/mmap/mmap.c > > grub_machine_mmap_iterate() belongs into this patch as it is the > main user of the memory map introduced here.
OK, let's leave it here. Though commit message has to be updated accordingly. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
