Re: [PATCH] switch from sprintf to asprintf and snprintf

On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > + __attribute__ ((format (printf, 1, 2))); It's very confusing that you've made grub_asprintf have a dramatically different interface from asprin

Re: [RFC] Multiboot ammendment: non-VBE video

On Mon, Dec 28, 2009 at 01:07:10PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Tue, Sep 01, 2009 at 05:37:11PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >> Hello. I'm implementing video part of multiboot specification. > >> Currently the only d

Re: autogen.sh warnings

On Mon, Dec 28, 2009 at 09:50:47PM -0600, Bruce Dubbs wrote: > Robert Millan wrote: >> >> What is exactly the problem? > > Using automake without Makefile.am is non-standard and not provided for > within automake. The only thing we use automake for is to copy > config.{guess,sub} to the root

Re: [PATCH] grub-probe support for NetBSD

On Tue, Dec 29, 2009 at 02:31:46AM +0100, Grégoire Sutre wrote: > +#if defined(__NetBSD__) > + /* Convert this block device to its character (raw) device */ > + res = xmalloc (strlen (cwd) + strlen (ent->d_name) + 3); > + sprintf (res, "%s/r%s", cwd, ent->d_name); > +#else >

Re: [PATCH] switch from sprintf to asprintf and snprintf

On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > sprintf is potentially dangerous especially with gettext, when messages > may be larger than coder would expect. I attach the patch to fix it Could you split the patches into one for asprintf and one for *npr

Re: [PATCH] switch from sprintf to asprintf and snprintf

On Fri, Jan 01, 2010 at 09:32:24AM +, Colin Watson wrote: > On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: > > +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > > + __attribute__ ((format (printf, 1, 2))); > > It's very confusing that you

Re: [PATCH] compilation with external intl library

On Wed, Dec 30, 2009 at 11:23:38AM +0100, Yves Blusseau wrote: > Hi, > > this is the patch to "fix" compilation with external intl library. It fix the > #28356 bug (http://savannah.gnu.org/bugs/?28356). > > I follow strictly the guideline of gettext, and now we can compile grub with > external

Re: [PATCH] switch from sprintf to asprintf and snprintf

On Fri, Jan 01, 2010 at 12:52:56PM +0100, Robert Millan wrote: > On Fri, Jan 01, 2010 at 09:32:24AM +, Colin Watson wrote: > > On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' > > Serbinenko wrote: > > > +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > > > + _

Re: Config file generation failure on Linux

On Wed, Dec 30, 2009 at 04:01:01PM +0100, Grégoire Sutre wrote: > Hi, > > Config file generation with grub-mkconfig fails on Linux when grub is > not installed in the same prefix as gettext, since the script > util/grub.d/10_linux.in contains: > > . ${bindir}/gettext.sh > > A possible patch is

Re: [PATCH 2/3] Compilation with external intl library

On Thu, Dec 31, 2009 at 05:55:04PM +0100, Yves Blusseau wrote: > +/* Disabled NLS. > + The casts to 'const char *' serve the purpose of producing warnings > + for invalid uses of the value returned from these functions. > + On pre-ANSI systems without 'const', the config.h file is supposed to

Re: [PATCH 3/3] Compilation with external intl library

On Thu, Dec 31, 2009 at 05:55:09PM +0100, Yves Blusseau wrote: > 2009-12-31 Yves Blusseau > > * util/mkisofs/mkisofs.c: fix a warning about a bad cast when NLS > is disabled > --- > ChangeLog.bad-cast |6 ++ > util/mkisofs/mkisofs.c |2 +- > 2 files changed, 7 inser

Re: [PATCH] macrofy (multiterm branch)

On Thu, Dec 31, 2009 at 07:31:56PM +0100, Carles Pina i Estany wrote: > > Hi, > > Find an attached patch to macrofy pos >> 8 and pos & 0xff in multiter. > In my opinion should be macrofied, it's more clear. Agreed. > === modified file 'include/grub/term.h' > --- include/grub/term.h 2009-1

Re: grub.info

On Thu, Dec 31, 2009 at 01:04:47PM -0500, Bruce O. Benson wrote: > 2009/12/31 Vladimir 'φ-coder/phcoder' Serbinenko > > > Bruce O. Benson wrote: > > > > > > 2009/12/30 Bruce Dubbs > > > > > > > > > Bruce O. Benson wrote: > > > All contributors can safely, legall

Re: [PATCH] spaces (label, UUID)

On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > === modified file 'normal/misc.c' > --- normal/misc.c 2009-12-20 23:32:15 + > +++ normal/misc.c 2009-12-28 01:15:34 + > @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha > if (grub_errno ==

Re: grub-setup: error: no mapping exists for ... in GRUB2 v1.97.1 on fake (IMSM) RAID

On Sun, Dec 27, 2009 at 05:50:35PM -0800, Lapohos Tibor wrote: > > grub-install --modules=raid /dev/md126 You're not supposed to force addition of raid.mod. If it wasn't auto-detected, it means there is a problem somewhere. Working around it just makes GRUB fail later on in a more unpleasant way

Re: Compilation under MacOSX

On Tue, Dec 29, 2009 at 04:29:48PM +0100, Yves Blusseau wrote: > gcc-4.2 -o grub-mkpasswd-pbkdf2 grub_mkpasswd_pbkdf2-gnulib_progname.o > grub_mkpasswd_pbkdf2-util_grub_mkpasswd_pbkdf2.o > grub_mkpasswd_pbkdf2-lib_crypto.o > grub_mkpasswd_pbkdf2-lib_libgcrypt_grub_cipher_sha512.o > grub_mkpassw

Re: [PATCH] compilation with external intl library

On Fri, Jan 01, 2010 at 01:00:10PM +0100, Robert Millan wrote: > > Please can you adjust your mailer so that it marks text attachments as > text/plain? It currently sets Content-Type: application/octet-stream which > makes it hard to send a context-reply with my mailer. Oh, I notice you already

Re: [PATCH] Proof of concept interrupt wrapping

On Thu, Dec 31, 2009 at 01:28:30PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Hello. We were discussing with Robert how to move BIOS interrupt > routines out of kernel. There are following possibilities: > 1) Have a .lowmem section in every concerned module which will always be > placed

Re: Regarding virtual to physical memory mapping..

On Thu, Dec 31, 2009 at 01:31:05PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > I wanted to know whether I can allocate some > > memory in the region below 1MB? > Only in experimental branch. But we're not currently sure if we will use > this. We can use this. My concerns are with mak

Re: [PATCH] spaces (label, UUID)

Hi, On Jan/01/2010, Robert Millan wrote: > On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > > === modified file 'normal/misc.c' > > --- normal/misc.c 2009-12-20 23:32:15 + > > +++ normal/misc.c 2009-12-28 01:15:34 + > > @@ -68,7 +68,10 @@ grub_normal_print_devic

Re: Year 2010

Now that we changed year, the usual mess with Copyright lines strikes again. Remember that when committing copyright-significant changes, copyright lines should be updated. I'll review existing files for all the updates that could have been missed during 2009. Please keep in mi

Re: Year 2010

On Fri, Jan 01, 2010 at 10:38:19AM -0500, Alfred M. Szmidt wrote: >Now that we changed year, the usual mess with Copyright lines >strikes again. > >Remember that when committing copyright-significant changes, >copyright lines should be updated. I'll review existing files for >

Re: [PATCH] spaces (label, UUID)

On Fri, Jan 01, 2010 at 02:10:51PM +0100, Carles Pina i Estany wrote: > > Hi, > > On Jan/01/2010, Robert Millan wrote: > > On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > > > === modified file 'normal/misc.c' > > > --- normal/misc.c 2009-12-20 23:32:15 + > > > +++ norm

Re: autogen.sh warnings

Robert Millan wrote: On Mon, Dec 28, 2009 at 09:50:47PM -0600, Bruce Dubbs wrote: Robert Millan wrote: What is exactly the problem? Using automake without Makefile.am is non-standard and not provided for within automake. The only thing we use automake for is to copy config.{guess,sub} to

[PATCH] help command fix (II)

Hello, Some days ago I sent: http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00433.html As Vladimir commented on IRC: patch was not checking how long the strings appears on the screen (multiple-byte chars, etc.) Find attached a new version, measuring the width of the strings. I have tes

Re: [PATCH] help command fix (II)

Hi, On Jan/01/2010, Carles Pina i Estany wrote: > Find attached a new version, measuring the width of the strings. I have After some comments from Vladimir on IRC, committed. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing

revert in grub2

Manao ahoana, Hello, Bonjour, How to reproduce the "revert" LILO feature with GRUB2? I believe everyone here knows what it is, but a quick explanation for those not knowing: With LILO, I can setup a default image to boot on. But, I also can setup the next entry to boot on, that may be different t

Re: Year 2010

Since it's not a lot of effort, I prefer to strive for correctness. But thanks for the tip :-) It wasn't a `tip', it is what is recommended by the FSF lawyers. From (maint)Copyright Notices: | To update the list of year numbers, add each year in which you have | made nontrivial changes to

Re: [PATCH] spaces (label, UUID)

Carles Pina i Estany wrote: + grub_putchar (' '); + grub_printf_ (N_("- Label \"%s\""), label); ... Avoiding to have trailing spaces helps the translators (they will do less mistakes). In this case it is a space at the beginning, not the end of the strin

Re: Roadmap for LUA support in GRUB

On Fri, Jan 1, 2010 at 6:42 AM, Robert Millan wrote: > On Mon, Dec 28, 2009 at 11:24:08PM -0500, Bruce O. Benson wrote: > > As soon as I see a bootloader that uses Lua as its scripting/config > engine, > > I'm switching to it. > > We have LUA support for GRUB. It's in grub-extras. > > Exactly.

Re: grub.info

On Fri, Jan 1, 2010 at 7:18 AM, Robert Millan wrote: > > This is the typical problem of contributing complaints vs. code. > > Bruce, there's absolutely no problem with Vladimir helping with review of > code, documentation and proposals in general. In fact, I find this very > helpful. > > You too