Re: gettext: commands/*

2009-12-24 Thread Robert Millan
On Mon, Dec 21, 2009 at 10:17:22AM -0600, Bruce Dubbs wrote: > Colin Watson wrote: >> On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' >> Serbinenko wrote: >>> === modified file 'commands/halt.c' >>> --- commands/halt.c 2009-12-03 23:07:29 + >>> +++ commands/halt.c 2009-12-

Re: gettext: commands/*

2009-12-21 Thread Carles Pina i Estany
I've committed the patch. Notes: On Dec/21/2009, Vladimir '??-coder/phcoder' Serbinenko wrote: > === modified file 'commands/blocklist.c' > --- commands/blocklist.c 2009-06-10 21:04:23 + > +++ commands/blocklist.c 2009-12-21 00:09:02 + > @@ -87,7 +87,7 @@ grub_cmd_blocklist (gru

Re: gettext: commands/*

2009-12-21 Thread Bruce Dubbs
Colin Watson wrote: On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: === modified file 'commands/halt.c' --- commands/halt.c 2009-12-03 23:07:29 + +++ commands/halt.c 2009-12-21 00:10:33 + @@ -35,7 +35,7 @@ static grub_command_t cmd; GRUB_M

Re: gettext: commands/*

2009-12-21 Thread Colin Watson
On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > === modified file 'commands/halt.c' > --- commands/halt.c 2009-12-03 23:07:29 + > +++ commands/halt.c 2009-12-21 00:10:33 + > @@ -35,7 +35,7 @@ static grub_command_t cmd; > GRUB_MOD_INIT(halt) >

Re: gettext: commands/*

2009-12-21 Thread Vladimir 'φ-coder/phcoder' Serbinenko
=== modified file 'commands/blocklist.c' --- commands/blocklist.c2009-06-10 21:04:23 + +++ commands/blocklist.c2009-12-21 00:09:02 + @@ -87,7 +87,7 @@ grub_cmd_blocklist (grub_command_t cmd _ if (! file->device->disk) return grub_error (GRUB_ERR_BAD_DEVICE, -

Re: gettext: commands/*

2009-12-20 Thread Carles Pina i Estany
Hi, On Dec/21/2009, Carles Pina i Estany wrote: > Because gettextizze and fix old strings is a bit confusing (for review > and tracking the changes, etc.) I've prepared a patch that should fix better writing: "Because gettextize and fix old strings at the same time and in the same patch can be

Re: gettext: commands/*

2009-12-20 Thread Carles Pina i Estany
Hi, Because gettextizze and fix old strings is a bit confusing (for review and tracking the changes, etc.) I've prepared a patch that should fix some strings from the help in commands/* . Find attached. I will prepare a Changelog for this patch tomorrow. Once commands/* has the correct strings (

Re: gettext: commands/hdparm.c

2009-12-09 Thread richardvo...@gmail.com
On Sun, Dec 6, 2009 at 12:25 PM, Carles Pina i Estany wrote: > > Hello, > > commands/hdparm.c has some grub_printf's: >  grub_printf ("Model:    \"%.40s\"\n", le16_to_char (tmp, &idw[27], 40)); >  grub_printf ("Firmware: \"%.8s\"\n",  le16_to_char (tmp, &idw[23], 8)); >  grub_printf ("Serial:   \"

Re: gettext: commands/hdparm.c

2009-12-09 Thread Christian Franke
Jordi Mallach wrote: > On Sun, Dec 06, 2009 at 06:25:33PM +, Carles Pina i Estany wrote: > > grub_printf ("Model:    \"%.40s\"\n", le16_to_char (tmp, &idw[27], > > 40)); grub_printf ("Firmware: \"%.8s\"\n",  le16_to_char (tmp, > > &idw[23], 8)); grub_printf ("Serial:   \"%.20s\"\n", le16_to_cha

Re: gettext: commands/hdparm.c

2009-12-08 Thread Jordi Mallach
On Sun, Dec 06, 2009 at 06:25:33PM +, Carles Pina i Estany wrote: > grub_printf ("Model:\"%.40s\"\n", le16_to_char (tmp, &idw[27], 40)); > grub_printf ("Firmware: \"%.8s\"\n", le16_to_char (tmp, &idw[23], 8)); > grub_printf ("Serial: \"%.20s\"\n", le16_to_char (tmp, &idw[10], 20));

Re: gettext: commands/*

2009-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hello, > > I've started to add gettext support in commands/* > > See the attached patch and ChangeLog. > > It's not completely exhaustive (hdparm is not in this patch). > > Comments before committing? > > Notice the the grub_register_command use N_(" ") and then these

Re: gettext: commands/*

2009-12-07 Thread Carles Pina i Estany
Hi, On Dec/07/2009, Carles Pina i Estany wrote: > And then implement grub_printf_: > - > int > grub_printf_ (const char *fmt, ...) > { > va_list ap; > int ret; > > va_start (ap, fmt); > ret = grub_vprintf (_(fmt), ap); actually I would better call grub_printf here instead of gr

Re: gettext: commands/*

2009-12-06 Thread Carles Pina i Estany
Hi, On Dec/06/2009, Carles Pina i Estany wrote: > - grub_printf ("The files are identical.\n"); > + grub_printf (_("The files are identical.\n")); Vladimir suggested in IRC that instead of using: grub_printf (grub_gettext (str)) // This is with _() expanded I could use: grub_printf_