Re: Device instability, gettext and default

2012-03-05 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 05.03.2012 12:51, Andreas Vogel wrote: Am 05.03.2012 01:34, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: On 05.03.2012 01:20, Andreas Vogel wrote: Am 05.03.2012 01:03, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: options? Any special reason? 2) Why do you refuse to allow short options

Re: Device instability, gettext and default

2012-03-05 Thread Andreas Vogel
Am 05.03.2012 01:34, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: > On 05.03.2012 01:20, Andreas Vogel wrote: >> Am 05.03.2012 01:03, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: options? Any special reason? >>> 2) Why do you refuse to allow short options for all of the menuentry >>> Becau

Re: Device instability, gettext and default

2012-03-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 05.03.2012 01:20, Andreas Vogel wrote: Am 05.03.2012 01:03, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: options? Any special reason? 2) Why do you refuse to allow short options for all of the menuentry Because it shares the space with options to menuentry. Don't understand what you mean.

Re: Device instability, gettext and default

2012-03-04 Thread Andreas Vogel
Am 05.03.2012 01:03, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: >> options? Any special reason? > 2) Why do you refuse to allow short options for all of the menuentry > Because it shares the space with options to menuentry. Don't understand what you mean. What is shared? >> 3) Wouldn't it be a

Re: Device instability, gettext and default

2012-03-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 05.03.2012 00:51, Andreas Vogel wrote: Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: === modified file 'grub-core/commands/menuentry.c' --- grub-core/commands/menuentry.c 2012-02-26 16:28:05 + +++ grub-core/commands/menuentry.c 2012-03-03 12:11:30 + @@

Re: Device instability, gettext and default

2012-03-04 Thread Andreas Vogel
Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: > === modified file 'grub-core/commands/menuentry.c' > --- grub-core/commands/menuentry.c2012-02-26 16:28:05 + > +++ grub-core/commands/menuentry.c2012-03-03 12:11:30 + > @@ -36,6 +36,8 @@ > N_("Keyboard key t

Re: Device instability, gettext and default

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 21:08, Andreas Vogel wrote: + menu_id = grub_strdup (id ? : menu_title); I don't know about the policy for grub code regarding GNU compiler extensions... at least you don't need in this place. We support only GCC. Any of its extensions available since 4.2 and not too obscure can

Re: Device instability, gettext and default

2012-03-03 Thread Andreas Vogel
> + menu_id = grub_strdup (id ? : menu_title); I don't know about the policy for grub code regarding GNU compiler extensions... at least you don't need in this place. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinf

Re: Device instability, gettext and default

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 20:48, Andreas Vogel wrote: I was thinking about your proposal again and I think your idea introducing a --id option is better than my idea having a --label option. === modified file 'include/grub/menu.h' --- include/grub/menu.h 2011-01-10 22:27:58 + +++ include/grub/menu.h 20

Re: Device instability, gettext and default

2012-03-03 Thread Andreas Vogel
I was thinking about your proposal again and I think your idea introducing a --id option is better than my idea having a --label option. > === modified file 'include/grub/menu.h' > --- include/grub/menu.h 2011-01-10 22:27:58 + > +++ include/grub/menu.h 2012-03-03 12:11:30 + > @

Re: Device instability, gettext and default

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 15:51, Andreas Vogel wrote: Vladimir, this enhancement is part of my patches which i sent some days ago. I introduced an option "--label STRING" which will be used for display if it's set and which can also have environment variables (another part of my patches). It's just

Re: Device instability, gettext and default

2012-03-03 Thread Andreas Vogel
Vladimir, this enhancement is part of my patches which i sent some days ago. I introduced an option "--label STRING" which will be used for display if it's set and which can also have environment variables (another part of my patches). It's just a matter of taste though if to use a new optio

Re: Device instability, gettext and default

2012-03-03 Thread Jordi Mallach
On Sat, Mar 03, 2012 at 02:37:12PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Attached patch changes it to the use of IDs specified by --id but > keeps title possiblity for backward compatibility. Any comments? Massive +1 here! This was something that bugged me quite a lot. Thanks for