On 03.03.2012 15:51, Andreas Vogel wrote:
Vladimir,
this enhancement is part of my patches which i sent some days ago.....
I introduced an option "--label STRING" which will be used for display
if it's set and which can also have environment variables (another
part of my patches).
It's just a matter of taste though if to use a new option --id for an
invariant menu id or to use the actual menuentry title as the
invariant id and to have a new option --label for the display string.
Both ways provide backward compatibility.
BTW, I just wonder a little that you refused my enhancements due to
code freeze but are now enhancing anyway ;-)
The reason is simple: you submitted a huge patch for several things,
most of them new features. If you had submitted small patches each
making one consistent logical change (but it may depend on other
changes) then I would have reviewed the ones fixing bugs (like the one
you describe). That's the general truth that 20 small patches go in much
faster than one patch big patch doing 20 things put together.
Andreas
Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
Hello, all. Currently we use and recommend using the title for
default variable. It has however following problems:
1) When device names change the title changes (because of the "(on
$device)" part)
2) If user changes locale the part ", with" gets translated and again
the title changes
Attached patch changes it to the use of IDs specified by --id but
keeps title possiblity for backward compatibility. Any comments?
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
--
Andreas Vogel
Dipl.-Inform.
Hellerweg 60
73728 Esslingen
Germany
____________________________________________
E-Mail:andreas.vo...@anvo-it.de
Office: +49 (711) 937 1742
FAX: +49 (711) 937 1745
Mobile: +49 (172) 730 7440
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
