Re: [PATCH] Split of normal mode (version 2)

2009-04-11 Thread Bean
On Sat, Apr 11, 2009 at 5:50 PM, Yoshinori K. Okuji wrote: > On Saturday 11 April 2009 05:17:43 Bean wrote: >> Hi, >> >> Another update for the patch: >> >> sync with svn r2074 >> misc bug fixes >> change build script for i386-efi, i386-coreboot, i386-ieee1275 and >> x86_64-efi as well as i386-pc,

Re: [PATCH] Split of normal mode (version 2)

2009-04-11 Thread Yoshinori K. Okuji
On Saturday 11 April 2009 05:17:43 Bean wrote: > Hi, > > Another update for the patch: > > sync with svn r2074 > misc bug fixes > change build script for i386-efi, i386-coreboot, i386-ieee1275 and > x86_64-efi as well as i386-pc, grub-emu now builds properly for > i386-pc. > support the use of #! i

Re: [PATCH] Split of normal mode (version 2)

2009-04-09 Thread Bean
On Fri, Apr 10, 2009 at 7:49 AM, Yoshinori K. Okuji wrote: > On Tuesday 07 April 2009 01:39:23 Bean wrote: >> Hi, >> >> This is another update of the patch. >> >> 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod, >> the reason for the switch is to allow configfile to depend on

Re: [PATCH] Split of normal mode (version 2)

2009-04-09 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 01:39:23 Bean wrote: > Hi, > > This is another update of the patch. > > 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod, > the reason for the switch is to allow configfile to depend on misc.mod > only. I think the name "misc.mod" is ugly. Can you think

Re: [PATCH] Split of normal mode (version 2)

2009-04-06 Thread Yoshinori K. Okuji
On Tuesday 07 April 2009 01:39:23 Bean wrote: > Hi, > > This is another update of the patch. Thank you. I will review your patch and send comments tonight. Regards, Okuji > 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod, > the reason for the switch is to allow configfile to

Re: [PATCH] Split of normal mode (version 2)

2009-04-05 Thread Yoshinori K. Okuji
On Monday 06 April 2009 00:02:59 Bean wrote: > On Sun, Apr 5, 2009 at 10:33 PM, Yoshinori K. Okuji wrote: > > On Saturday 04 April 2009 14:06:18 Bean wrote: > >> One of the problem for normal.mod dependency is its side effect. For > >> example, currently ls.mod depend on normal.mod just for > >> g

Re: [PATCH] Split of normal mode (version 2)

2009-04-05 Thread Bean
On Sun, Apr 5, 2009 at 10:33 PM, Yoshinori K. Okuji wrote: > On Saturday 04 April 2009 14:06:18 Bean wrote: >> One of the problem for normal.mod dependency is its side effect. For >> example, currently ls.mod depend on normal.mod just for >> grub_normal_print_device_info. If we want to embed ls.mo

Re: [PATCH] Split of normal mode (version 2)

2009-04-05 Thread Yoshinori K. Okuji
On Saturday 04 April 2009 14:06:18 Bean wrote: > One of the problem for normal.mod dependency is its side effect. For > example, currently ls.mod depend on normal.mod just for > grub_normal_print_device_info. If we want to embed ls.mod in core.img, > we must embedded normal.mod as well, along with

Re: [PATCH] Split of normal mode (version 2)

2009-04-05 Thread Yoshinori K. Okuji
On Saturday 04 April 2009 08:02:40 Colin D Bennett wrote: > What if you switch back and forth between normal and rescue mode > many times in a row? The stack will grow with each call and eventually > the stack will overflow and Bad Things will happen. Yes. > Now you could also return function po

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread Bean
On Sat, Apr 4, 2009 at 4:12 AM, Yoshinori K. Okuji wrote: > On Saturday 04 April 2009 04:49:36 Bean wrote: >> On Sat, Apr 4, 2009 at 2:40 AM, Yoshinori K. Okuji wrote: >> > On Tuesday 31 March 2009 02:41:14 Bean wrote: >> >> Hi, >> >> >> >> This new patch make some changes based on the discussion

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread Colin D Bennett
On Sat, 04 Apr 2009 00:19:46 +0200 phcoder wrote: > > setjmp is required for the switch between rescue mode and normal mode. > > It isn't. You can just call the corresponding function. What's wrong > with such approach? So you could have something like - void grub_main () { //.

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread phcoder
We can just put them in the normal.mod. What is wrong? Frankly, your argument reminds me of the old discussion about monolithic vs. micro kernels... Yes, it's quite similar and IMO it's better to have more small modules. It also forces to code in an abstratc way which simplifies the maintaining s

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread Yoshinori K. Okuji
On Saturday 04 April 2009 04:49:36 Bean wrote: > On Sat, Apr 4, 2009 at 2:40 AM, Yoshinori K. Okuji wrote: > > On Tuesday 31 March 2009 02:41:14 Bean wrote: > >> Hi, > >> > >> This new patch make some changes based on the discussion of previous > >> patch. > >> > >> 1, Move script engine to script

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread Bean
On Sat, Apr 4, 2009 at 2:40 AM, Yoshinori K. Okuji wrote: > On Tuesday 31 March 2009 02:41:14 Bean wrote: >> Hi, >> >> This new patch make some changes based on the discussion of previous patch. >> >> 1, Move script engine to script/sh (sh.mod) >> 2, Move generic menu code to menu (menu.mod) >> 3,

Re: [PATCH] Split of normal mode (version 2)

2009-04-03 Thread Yoshinori K. Okuji
On Tuesday 31 March 2009 02:41:14 Bean wrote: > Hi, > > This new patch make some changes based on the discussion of previous patch. > > 1, Move script engine to script/sh (sh.mod) > 2, Move generic menu code to menu (menu.mod) > 3, Move text menu viewer to menu/text (textmenu.mod) > 4, Move misc fu