On Saturday 11 April 2009 05:17:43 Bean wrote: > Hi, > > Another update for the patch: > > sync with svn r2074 > misc bug fixes > change build script for i386-efi, i386-coreboot, i386-ieee1275 and > x86_64-efi as well as i386-pc, grub-emu now builds properly for > i386-pc. > support the use of #! in the script file. It would switch to the > selected parser, read the file, then restore to the original parser > before returning. > configfile/source now back to previous syntax, as there is no need to > change parser in here anymore.
I am afraid that this patch is getting too big to review. Honestly, I would like you to check in some parts quickly, and the rest still requires more discussion. Anyway, I think it is a good practice to check in one thing at one time, so splitting the patch is a good thing. For example: - handler unification -> one patch - config embedding -> one patch - parser separation -> one patch - viewer separation -> one patch - misc module -> one patch - etc. Due to the volume, I am not certain if I have really read everything. :( Regards, Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
