On Tuesday 31 March 2009 02:41:14 Bean wrote: > Hi, > > This new patch make some changes based on the discussion of previous patch. > > 1, Move script engine to script/sh (sh.mod) > 2, Move generic menu code to menu (menu.mod) > 3, Move text menu viewer to menu/text (textmenu.mod) > 4, Move misc function to lib (misc.mod) > 5, Move setjmp to lib (setjmp.mod)
I don't agree on the last two. Also, I don't like that you have just removed the rescue command. > Now normal.mod only contains the reader code. To configure script > engine and viewer, you should add these lines at the beginning of > grub.cfg: > > insmod sh > handler parser sh > insmod textmenu I prefer a more sophisticated approach (note: I hate manual loading). For example, we can allow a config file to have a shebang, like "#!sh". If not specified, GRUB can assume that "sh" is used, and load it automatically. This kind of technique could even allow for using different languages in one setup. For textmenu, I think it makes sense to have a command "textmenu". Just like "boot", GRUB can execute "textmenu" implicitly if a config file defines any menu entry but does not execute any menu command. This way, textmenu is automatically loaded. Regards, Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
