On Jun 17, 2008, at 22:42, Robert Millan wrote:
No comment on this? I can't assure you it's 100% bug-free, but I
know it
fixes existing problems, and I think it's the right way to do it.
If I don't hear any objection, I'll check it in tomorrow.
Hi Robert,
For for replying so late, but
On Tue, Jun 17, 2008 at 10:42:45PM +0200, Robert Millan wrote:
>
> No comment on this? I can't assure you it's 100% bug-free, but I know it
> fixes existing problems, and I think it's the right way to do it.
>
> If I don't hear any objection, I'll check it in tomorrow.
In it went :-)
--
Rober
No comment on this? I can't assure you it's 100% bug-free, but I know it
fixes existing problems, and I think it's the right way to do it.
If I don't hear any objection, I'll check it in tomorrow.
On Sun, Jun 15, 2008 at 11:34:36PM +0200, Robert Millan wrote:
> 2008-06-15 Robert Millan <[EMAI
On Sun, Jun 15, 2008 at 11:33:32PM +0200, Robert Millan wrote:
>
> Any comments?
Ah, and usually it helps if I remember to attach things :-)
--
Robert Millan
I know my rights; I want my phone call!
What good is a phone call… if you are unable to speak?
(as seen on /.)
2008-06-15 Robert Mill
On Sun, Jun 15, 2008 at 08:22:19PM +0200, Robert Millan wrote:
>
> The memdisk part of this was basicaly a bugfix, so I checked it in. The rest
> seems to duplicate stuff that grub-setup was already doing, and I think I'll
> have to take a closer look (I'll send another mail about that later).
I
I allready appended this to the Debian bug report, but for the record:
Please make the grub-pc package Recommend: os-prober.
Cheers,
Fabian
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44
On Mon, Apr 07, 2008 at 10:39:46AM +0200, Fabian Greffrath wrote:
>
> Allright, since I haven't heard any further complaints regarding the
> usage of the 'which' command, here's my proposed script. Please remove
> the UTF-8 crap from the shebang line if it is still there.
>
>
> 2008-04-07 Fab
Robert Millan schrieb:
I'll look at your last patch when I have time; which I currently don't.
Allright, thanks for the reply!
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
On Wed, Apr 09, 2008 at 10:32:47AM +0200, Fabian Greffrath wrote:
> Hi Robert,
>
> I am curious why this didn't make it into the last Debian upload?
My policy for Debian uploads is not to diverge from upstream source unless I
can't avoid it.
I'll look at your last patch when I have time; which I
Hi Robert,
I am curious why this didn't make it into the last Debian upload?
Cheers,
Fabian
Fabian Greffrath schrieb:
Fabian Greffrath schrieb:
Fine! However, should the script utilize the 'which' command or not?
Allright, since I haven't heard any further complaints regarding the
usage of
Fabian Greffrath schrieb:
Fine! However, should the script utilize the 'which' command or not?
Allright, since I haven't heard any further complaints regarding the
usage of the 'which' command, here's my proposed script. Please remove
the UTF-8 crap from the shebang line if it is still there.
Robert Millan schrieb:
and please include a ChangeLog entry. As far as I'm concerned, there's nothing
else missing.
Fine! However, should the script utilize the 'which' command or not?
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstech
On Thu, Mar 20, 2008 at 11:02:35AM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >which is very ugly if you ask me. Okuji, do you have any comments on this?
>
> Apart from this issue, is the script allright?
Also, you can remove this check now:
if [ -z "`grub-probe --help 2> /dev/nu
Robert Millan schrieb:
which is very ugly if you ask me. Okuji, do you have any comments on this?
Apart from this issue, is the script allright?
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/1
On Wed, Mar 19, 2008 at 04:18:42PM +0100, Fabian Greffrath wrote:
> >When run in the console it makes Linux spit a truckload of information
> >about
> >filesystem probing. Is there any way we could avoid this?
>
> I don't know why this happens since I allready divert stderr to
> /dev/null in th
Robert Millan schrieb:
Sorry for the delay in repliing. Been very busy :-(
No problem. ;)
When run in the console it makes Linux spit a truckload of information about
filesystem probing. Is there any way we could avoid this?
I don't know why this happens since I allready divert stderr to
Sorry for the delay in repliing. Been very busy :-(
I tried the script and have the following comments:
When run in the console it makes Linux spit a truckload of information about
filesystem probing. Is there any way we could avoid this?
How do you prevent it from detecting your own partitio
Fabian Greffrath schrieb:
I have improved the script a little bit;
Robert, have you allready had a look at it? :)
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49 (
I have improved the script a little bit; in particular I moved the
tests for the required software to the beginning of the script and let
it gracefully 'exit 0' if anything is missing.
Let me comment on these tests:
- The first test (lines 19-22) is to check if grub-probe is recent
enough to s
Robert Millan schrieb:
For 10_linux it isn't that important since the boot parameters are so small,
it's 10_hurd that has more reusable stuff (that big blurb).
This is true. Furthermore I still haven't found out how to get
variables like "host-port", "device-port", "task-create", etc..
In t
On Fri, Feb 29, 2008 at 09:33:13AM +0100, Fabian Greffrath wrote:
> >For this one, I think it'd be much better to rework 10_hurd so that code is
> >shared, rather than duplicating the whole blurb.
>
> Yes, we could source out the complete linux/hurd kernel-adding blurbs
> into an external shell l
On Fri, Feb 29, 2008 at 02:46:17PM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >Better do this like it's done in other scripts (check grub-install). Not
> >sure
> >why, I guess it's more portable that way...
>
> Ah, now I know what you ment. However, I cannot really see the
> adva
Robert Millan schrieb:
Better do this like it's done in other scripts (check grub-install). Not sure
why, I guess it's more portable that way...
Ah, now I know what you ment. However, I cannot really see the
advantage in
grub_probe=${sbindir}/`echo grub-probe | sed ${transform}`
with ${tr
Robert Millan schrieb:
Better do this like it's done in other scripts (check grub-install). Not sure
why, I guess it's more portable that way...
You mean
if [ "x$(FOO)" = "x" ] ...
?
For this one, I think it'd be much better to rework 10_hurd so that code is
shared, rather than duplicating
On Thu, Feb 28, 2008 at 12:46:37PM +0100, Fabian Greffrath wrote:
>
> if [ -x "`which os-prober 2>/dev/null`" ] ; then
Better do this like it's done in other scripts (check grub-install). Not sure
why, I guess it's more portable that way...
> if [ -x "`which linux-boot-prober 2>/dev/n
Robert Millan schrieb:
Ok. Is there any mail for that waiting for input? I lose track of things.
No problem, please find the script attached.
#! /bin/sh -e
# update-grub helper script.
# Copyright (C) 2006,2007,2008 Free Software Foundation, Inc.
#
# GRUB is free software: you can redist
On Thu, Feb 28, 2008 at 11:28:13AM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >Committed.
>
> Great, thanks!
>
> Now let's get support for os-prober output parsing.
Ok. Is there any mail for that waiting for input? I lose track of things.
--
Robert Millan
I know my rights; I
Robert Millan schrieb:
Committed.
Great, thanks!
Now let's get support for os-prober output parsing.
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49 (0)234 / 32-
On Thu, Feb 28, 2008 at 08:26:49AM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >Ok. Does anybody object to Fabian's patch? I'd like to commit it.
>
> Silence is consense. ;)
Committed.
--
Robert Millan
I know my rights; I want my phone call!
What use is a phone call… if you a
Robert Millan schrieb:
Ok. Does anybody object to Fabian's patch? I'd like to commit it.
Silence is consense. ;)
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49
On Mon, Feb 25, 2008 at 10:49:01AM +0100, Fabian Greffrath wrote:
> >If you fix those, include a ChangeLog entry and noone else objects, I'll
> >commit
> >it. Feel free to ping me with a direct mail if I stale for too long.
>
> You are CCed. ;)
>
> Robert Millan schrieb:
> > Is this solved now?
Hello!
Robert Millan schrieb:
It looks good to me. Just a pair of minor details (simply for consistency with
code style in grub):
[...]
done.
If you fix those, include a ChangeLog entry and noone else objects, I'll commit
it. Feel free to ping me with a direct mail if I stale for too long.
On Fri, Feb 22, 2008 at 03:32:02PM +0100, Fabian Greffrath wrote:
> However, grub-probe crashes with a double free error message if run with
> the -d option. I am somehow stuck in this situation, can you please help me?
Is this solved now? If not, you could send a gdb backtrace to give us an id
Sorry for the long delay, I've been very busy (and unfortunately I'll continue
to be :-().
On Fri, Feb 22, 2008 at 04:36:35PM +0100, Fabian Greffrath wrote:
> Well, the solution seems to be easier than I expected. Is the attached
> patch acceptable?
It looks good to me. Just a pair of minor de
Well, the solution seems to be easier than I expected. Is the attached patch
acceptable?
Have a nice weekend,
Fabian
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49
Hi Robert,
I have created another patch which introduces some of your suggestions, e.g.
probe() is called with two arguments and grub_util_check_block_device() does not
strdup() the returned string. However, grub-probe crashes with a double free
error message if run with the -d option. I am s
New patch. Fixed a few errors, enabled grub-install in sbin_SCRIPTS, and made
the CLI consistent with the other grub-installs.
The patch works in my qemu environment [1], so I've added it in Debian already.
If nobody objects, or reports that the patch is wrong whatsoever, I'll add it
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
> But the idea here was to make it easier to make function that operates
> on different render targets without knowing about it. eg:
>
> set_target a
> call common_func
> set target b
> call common_func
> set target c
>
> With your proposal this would
Johan Rydberg wrote:
> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
>
>> Here is the newest modifications to video subsystem.
>
> Hi Vesa. What a suitable name :)
:)
> Sorry for the delay, and lack of earlier comments, but I've been out
> of the GRUB loop for a while. But I have a few commen
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
> Here is the newest modifications to video subsystem.
Hi Vesa. What a suitable name :)
Sorry for the delay, and lack of earlier comments, but I've been out
of the GRUB loop for a while. But I have a few comments on the video
subsystem;
Correct me
more like the rest of GRUB?
I'll try to follow this as good as I can :)
I will send new patch a bit later as a new email as this email gets
quite large :).
Thanks,
Vesa Jääskeläinen
>> Marco Gerards wrote:
>>> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
>> Wel
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
> Marco Gerards wrote:
>> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
>>
>> Hi Vesa,
>>
>> Thanks for your patch. I have done a review, but you should know that
>> I am not a graphics expert and don't understand all of the code in
>> detail. Most
le statement?
>
> No. As structure types are different.
Ok.
>>> +static grub_err_t
>>> +grub_video_vbe_swap_buffers (void)
>>> +{
>>> + /* TODO: Implement buffer swapping. */
>>
>> Sin't this just activating another region in the video m
Vesa Jääskeläinen wrote:
> Is there a nice way to split vbe driver to
> more source files without causing generation of more modules. I was
> thinking that "optimized" versions of some blitting operations would be
> good to place on some other file as source might grow to quite large.
I should ha
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes:
Hi Vesa,
Thanks for your patch. I have done a review, but you should know that
I am not a graphics expert and don't understand all of the code in
detail. Most issues are GCS related, they don't only apply to the
line I commented on, but in general.
, the default should be set to something really safe. So I
>> prefer 640x480. It is up to the user (or the vendor shipping GRUB) to change
>> it to something more comfortable.
>
> Ok. I will change the default to that. I will only make new patch if
> there are issues to be sol
really safe. So I
> prefer 640x480. It is up to the user (or the vendor shipping GRUB) to change
> it to something more comfortable.
Ok. I will change the default to that. I will only make new patch if
there are issues to be solved before commit.
__
On Friday 03 March 2006 15:23, Vesa Jääskeläinen wrote:
> Nowadays 1024x768 is a normal standard resolution.
Even if it is very popular, since the boot loader is a critical part of an
operation system, the default should be set to something really safe. So I
prefer 640x480. It is up to the user
Ruslan Nikolaev <[EMAIL PROTECTED]> writes:
Hi Ruslan,
> I have seen another patch for amd64 by Marco Gerards. In fact month
> ago I sent the patch that also allows compiling on x86_64.
Right, I sent in this new patch because I don't like changing LD and
CC the way you do and b
On Wednesday 21 September 2005 01:10 am, Ruslan Nikolaev wrote:
> I have seen another patch for amd64 by Marco Gerards. In fact month ago I
> sent the patch that also allows compiling on x86_64.
I have no idea which patch is better, so please decide it with Marco.
However, your assignment is not
Hi all!
I have seen another patch for amd64 by Marco Gerards. In fact month ago I sent the patch that also allows compiling on x86_64.
By the way I decided to send new patch (it's really works with amd64).
Some bugs was fixed:
- it doesn't break x86 compiling now (small bug)
- it all
I send a new version of my patch. I added parttype and hide/unhide commands.
Can someone have a look at it?
(I haven't tested it a lot but it works fine for me )
Vladimir
2005-08-02 Vladimir Serbinenko <[EMAIL PROTECTED]>
52 matches
Mail list logo
