On Sun, Jun 15, 2008 at 08:22:19PM +0200, Robert Millan wrote: > > The memdisk part of this was basicaly a bugfix, so I checked it in. The rest > seems to duplicate stuff that grub-setup was already doing, and I think I'll > have to take a closer look (I'll send another mail about that later).
I think I sorted this out. The tip of the iceberg was that grub-setup is prepending a drive to prefix twice when we run LVM on RAID. However, it is actually wrong that grub-setup mangles prefix in first place! core.img might be loaded by other means (e.g. from GRUB Legacy), and then these adjustments have no effect. I also think it's more flexible if these kind of decisions are taken in a higher layer, so my patch moves this to grub-install, which relies on grub-probe. Then with grub-mkimage being capable of prepending a drive to prefix, there's no need to do it in grub-setup. This also fixes some minor issues I found along the way. Any comments? -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
