On 08.03.2012 23:51, Richard Laager wrote:
> I believe the following change is still needed to support pool names
> with spaces. That said, maybe we shouldn't care about pool names with
> spaces. If a pool name has spaces, then we need some way to escape it
> when building the linux_entry command l
On 10.03.2012 16:51, Richard Laager wrote:
> On Sat, 2012-03-10 at 14:39 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
> wrote:
>> Please, don't forget xen counterpart in the future. It's not the first
>> time I have to fix your patches for them
> I didn't realize the Linux code was duplicated for X
On Sat, 2012-03-10 at 14:39 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Please, don't forget xen counterpart in the future. It's not the first
> time I have to fix your patches for them
I didn't realize the Linux code was duplicated for Xen. That seems
sub-optimal. Can that be avoided so
On 08.03.2012 23:51, Richard Laager wrote:
> Index: grub/util/grub.d/10_linux.in
> ===
> --- grub.orig/util/grub.d/10_linux.in 2012-03-08 14:06:00.641410243 -0600
> +++ grub/util/grub.d/10_linux.in 2012-03-08 15:30:53.557993000 -0
On 08.03.2012 23:51, Richard Laager wrote:
> I've rebased my patch sets against BZR revision 4144 and tested. Aside
>
> Index: grub/util/grub.d/10_linux.in
> ===
> --- grub.orig/util/grub.d/10_linux.in 2012-03-08 14:06:00.641410243 -06
On 08.03.2012 23:51, Richard Laager wrote:
> I believe the following change is still needed to support pool names
> with spaces. That said, maybe we shouldn't care about pool names with
> spaces. If a pool name has spaces, then we need some way to escape it
> when building the linux_entry command l
I've rebased my patch sets against BZR revision 4144 and tested. Aside
from the device scanning code (which you wanted me to implement
differently) and the Ubuntu-specific recordfail patch, the following two
changes are all that's left:
-
On Mon, 2012-02-27 at 19:20 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> I've rewritten this code. I've also committed most of your changes
> except the one adding the tree scanning when we already have one
Thanks. I'll catch up on this after my vacation and submit whatever
updated patch
On 27.02.2012 07:01, Richard Laager wrote:
On Mon, 2012-02-27 at 01:00 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
The allowed characters are: [a-zA-Z0-9_.: -]
This isn't a good enough argument. One could purposedly create a pool
named `rm -rf /*` even though it's incorrect.
By "allo
On 27.02.2012 07:04, Richard Laager wrote:
On Mon, 2012-02-27 at 00:01 -0600, Richard Laager wrote:
I haven't verified that the kernel itself refuses to create/load
such a pool.
In any case, what is the threat here? If someone hand-crafts such a
pool, they still have to get the administrator to
On 27.02.2012 07:58, Richard Laager wrote:
On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
zfs-poolname-spaces.patch
...
@@ -420,6 +419,9 @@
if (sscanf (sep, "%s %s", entry.fstype, entry.device) != 2)
continue;
+ unescape (entry.fstype);
+
On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > Index: grub/util/getroot.c
> > ===
> > --- grub.orig/util/getroot.c2012-02-03 05:22:36.227364000 -0600
> > +++ grub/util/getroot.c 2012-02-
On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > zfs-poolname-spaces.patch
> ...
> > @@ -420,6 +419,9 @@
> > if (sscanf (sep, "%s %s", entry.fstype, entry.device) != 2)
> > continue;
> >
> > + unescape (entry.fstype);
> > + unescape (entry.de
2012/2/25 Vladimir 'φ-coder/phcoder' Serbinenko :
> On 25.02.2012 19:44, Mike Gilbert wrote:
>>
>> +if test x"$libzfs_excuse" = x ; then
>> + # Only check for system headers if libzfs support has not been
>> disabled.
>> + AC_CHECK_HEADERS(libzfs.h libnvpair.h)
>> +fi
>
> You should set excuse he
On 25.02.2012 19:44, Mike Gilbert wrote:
+if test x"$libzfs_excuse" = x ; then
+ # Only check for system headers if libzfs support has not been disabled.
+ AC_CHECK_HEADERS(libzfs.h libnvpair.h)
+fi
You should set excuse here if the headers aren't found.
Also it should fail if libzfs is explic
2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko :
> On 21.02.2012 20:04, Mike Gilbert wrote:
>>
>> 2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko:
>>>
>>> Hello, it's to announce that from 27th of February the GRUB will be
>>> frozen
>>> for 2.00 release. From that date on, no new features will be
On Thu, Feb 23, 2012 at 12:43:08PM -0500, Lennart Sorensen wrote:
> gcc-4.6 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
> -DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"
> -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1
> -DGRUB_
On Thu, Feb 23, 2012 at 07:17:49AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> >../../../grub-core/normal/charset.c: In function
> 'grub_bidi_line_logical_to_visual':
> ../../../grub-core/normal/charset.c:737: error: cannot optimize
> possibly infinite
> > loops If I do what is already d
On 22.02.2012 06:35, Richard Laager wrote:
On Tue, 2012-02-21 at 17:12 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> @Richard Laager: Which of ZFS patches aren't committed yet? It's a bit
> tricky to see which ones were superseeded.
I've attached my current patch set. The patches appl
>../../../grub-core/normal/charset.c: In function
'grub_bidi_line_logical_to_visual':
../../../grub-core/normal/charset.c:737: error: cannot optimize possibly
infinite
> loops If I do what is already done for GRUB_LONG_MIN and use: #define
GRUB_INT_MIN (-0x7fff - 1) ...then gcc 4.6 is happy
On 02/22/2012 06:03 PM, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 05:50:37PM -0500, Lennart Sorensen wrote:
Now I get:
gcc-4.6 -DHAVE_CONFIG_H -I. -I../../../grub-core -I.. -Wall -W -I../../../include
-I../include -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERP
On Wed, Feb 22, 2012 at 05:50:37PM -0500, Lennart Sorensen wrote:
> Now I get:
>
> gcc-4.6 -DHAVE_CONFIG_H -I. -I../../../grub-core -I.. -Wall -W
> -I../../../include -I../include -DGRUB_MACHINE_EMU=1
> -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32
> -DGRUB_FILE=\"normal/charset
On Wed, Feb 22, 2012 at 08:00:54PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Alternative is to add a condition which will ensure the loop
> termination but don't interfere with it other wise by using the fact
> that min (UINT_MAX, r)=r if r is unsigned int.
>
>
> --
> Regards
> Vlad
On 22.02.2012 19:41, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 01:28:06PM -0500, Lennart Sorensen wrote:
Oh the feature for doing multiple #pragma statements throughout the code
is new in gcc 4.6. It can't be done in earlier versions. In older
versions whatever you say last applies to th
On Wed, Feb 22, 2012 at 01:28:06PM -0500, Lennart Sorensen wrote:
> Oh the feature for doing multiple #pragma statements throughout the code
> is new in gcc 4.6. It can't be done in earlier versions. In older
> versions whatever you say last applies to the whole file.
>
> Perhaps a slightly ugly
On Wed, Feb 22, 2012 at 01:01:41PM -0500, Lennart Sorensen wrote:
> gcc 4.6 on the other hand now seems to compile with -Werror enabled.
Oh the feature for doing multiple #pragma statements throughout the code
is new in gcc 4.6. It can't be done in earlier versions. In older
versions whatever yo
On Wed, Feb 22, 2012 at 12:41:56PM -0500, Lennart Sorensen wrote:
> On Wed, Feb 22, 2012 at 06:35:49PM +0100, Vladimir 'φ-coder/phcoder'
> Serbinenko wrote:
> > > I don't think -Wno-unsafe-loop-optimisations is valid. One has to
> > remove -Wunsafe-loop-optimisations instead, which is currently in
On Wed, Feb 22, 2012 at 12:46:14PM -0500, Lennart Sorensen wrote:
> Hmm.
>
> gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
> -DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"
> -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1
On Wed, Feb 22, 2012 at 06:35:49PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > I don't think -Wno-unsafe-loop-optimisations is valid. One has to
> remove -Wunsafe-loop-optimisations instead, which is currently in
> WARN_FLAGS.
> It's just a question of spelling.
> Also note that warnin
On Wed, Feb 22, 2012 at 12:16:12PM -0500, Lennart Sorensen wrote:
> OK I checked out the latest bzr tree, and applied this patch.
>
> I now get:
> ../../grub-core/gnulib/argp.h:610:1: warning: no previous declaration for
> 'argp_usage' [-Wmissing-declarations]
> ../../grub-core/gnulib/argp.h:616:
> I don't think -Wno-unsafe-loop-optimisations is valid. One has to
remove -Wunsafe-loop-optimisations instead, which is currently in
WARN_FLAGS.
It's just a question of spelling.
Also note that warnings from gnulib and minilzo are -Wno-error
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
=
On Wed, Feb 22, 2012 at 05:50:31PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> === modified file 'conf/Makefile.common'
> --- conf/Makefile.common 2012-02-22 15:27:39 +
> +++ conf/Makefile.common 2012-02-22 16:29:31 +
> @@ -104,7 +104,7 @@
> CFLAGS_GCRY = -Wno-error -W
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
> On Wed, Feb 22, 2012 at 04:57:11PM +0100, Vladimir 'φ-coder/phcoder'
> Serbinenko wrote:
> >
> > >So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
> >
> > > 102 of those warnings are about missing protot
On 22.02.2012 17:25, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
Well it is in WARN_FLAGS and TARGET_CFLAGS in configure.
And during build:
gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIBDIR=\"/usr/lib/grub\"
-DLO
On Wed, Feb 22, 2012 at 11:25:22AM -0500, Lennart Sorensen wrote:
> That actually looks like a mistake.
>
> HOST_CFLAGS="$HOST_CFLAGS $WARN_FLAGS"
> TARGET_CFLAGS="$TARGET_CFLAGS $WARN_FLAGS -g -Wredundant-decls
> -Wmissing-prototypes"
>
> but WARN_FLAGS="-Wall -W -Wshadow -Wold-style-declaratio
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
> Well it is in WARN_FLAGS and TARGET_CFLAGS in configure.
>
> And during build:
> gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
> -DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"
> -DGR
On Wed, Feb 22, 2012 at 04:57:11PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
>
> >So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
>
> > 102 of those warnings are about missing prototypes for argp_usage
> > _option_is_short and _option_is_end in argp.h which le
So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
102 of those warnings are about missing prototypes for argp_usage
_option_is_short and _option_is_end in argp.h which leaves 99 warnings
for gcc 4.4 and 73 for gcc 4.6.
Hm we don't add -Wmissing-prototypes for util
On Wed, Feb 22, 2012 at 10:34:18AM -0500, Lennart Sorensen wrote:
> OK, still seeing things like:
>
> gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
> -DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"
> -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DG
On Tue, Feb 21, 2012 at 09:29:08PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> diff --exclude Makefile.util.am --exclude Makefile.in --exclude grub.info
> --exclude configure --exclude aclocal.m4 --exclude '*autom4te.cache*' -ur
> mainline/configure.ac mainline-mod/configure.ac
> --- m
On Tue, 2012-02-21 at 17:12 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> @Richard Laager: Which of ZFS patches aren't committed yet? It's a bit
> tricky to see which ones were superseeded.
I've attached my current patch set. The patches apply in the order
listed. They're also roughly ord
On 21.02.2012 20:58, Lennart Sorensen wrote:
On Tue, Feb 21, 2012 at 01:46:27PM -0500, Lennart Sorensen wrote:
That actually seems to have done it. I am still trying to wrap my head
around why that made a difference since it appears to be identical code
moved somewhere else. It isn't inlined a
On Tue, Feb 21, 2012 at 01:46:27PM -0500, Lennart Sorensen wrote:
> That actually seems to have done it. I am still trying to wrap my head
> around why that made a difference since it appears to be identical code
> moved somewhere else. It isn't inlined anymore, but should that make
> a big diffe
2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko :
> On 21.02.2012 20:04, Mike Gilbert wrote:
>>
>> 2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko:
>>>
>>> Hello, it's to announce that from 27th of February the GRUB will be
>>> frozen
>>> for 2.00 release. From that date on, no new features will be
On 21.02.2012 20:04, Mike Gilbert wrote:
2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko:
Hello, it's to announce that from 27th of February the GRUB will be frozen
for 2.00 release. From that date on, no new features will be committed only
bugfixes.
If you have a patch which you think should be
2012/2/21 Vladimir 'φ-coder/phcoder' Serbinenko :
> Hello, it's to announce that from 27th of February the GRUB will be frozen
> for 2.00 release. From that date on, no new features will be committed only
> bugfixes.
> If you have a patch which you think should be included in 2.00 you can ping
> me
On Tue, Feb 21, 2012 at 06:09:36PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Try attached patch
>
>
> --
> Regards
> Vladimir 'φ-coder/phcoder' Serbinenko
>
> === modified file 'grub-core/kern/list.c'
> --- grub-core/kern/list.c 2012-02-12 02:52:17 +
> +++ grub-core/kern/l
On 21.02.2012 17:19, Lennart Sorensen wrote:
On Tue, Feb 21, 2012 at 05:12:12PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Hello, it's to announce that from 27th of February the GRUB will be
frozen for 2.00 release. From that date on, no new features will be
committed only bugfixes.
If
On Tue, Feb 21, 2012 at 05:12:12PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Hello, it's to announce that from 27th of February the GRUB will be
> frozen for 2.00 release. From that date on, no new features will be
> committed only bugfixes.
> If you have a patch which you think should
Hello, it's to announce that from 27th of February the GRUB will be
frozen for 2.00 release. From that date on, no new features will be
committed only bugfixes.
If you have a patch which you think should be included in 2.00 you can
ping me about it but I might answer that it's postponed after 2.
50 matches
Mail list logo
