On 27.02.2012 07:01, Richard Laager wrote:
On Mon, 2012-02-27 at 01:00 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
  The allowed characters are: [a-zA-Z0-9_.: -]
This isn't a good enough argument. One could purposedly create a pool
named `rm -rf /*` even though it's incorrect.
By "allowed characters", I meant that the normal ZFS stack will not
permit you to create a pool using characters outside that range. That
said, I haven't verified that the kernel itself refuses to create/load
such a pool.
I've rewritten this code. I've also committed most of your changes except the one adding the tree scanning when we already have one

The patch I proposed is no worse than the code that's already in GRUB.
Given the impending freeze and the fact that I'm on vacation, can you
apply it and I'll come back to this issue later? I've CC'ed myself so I
don't forget.



--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to