Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Fri, Oct 16, 2009 at 12:58:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >> We may want to embed more in the future. Actual

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-10-16 Thread Robert Millan
On Fri, Oct 16, 2009 at 12:58:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > We may want to embed more in the future. Actually I think it's not > ad-hoc. Basically par

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: > We may want to embed more in the future. Actually I think it's not ad-hoc. Basically partition map defines a function which gives back the sectors available for embedding.

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-13 Thread Robert Millan
On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> We may want to embed more in the future. Actually I think it's not > >> ad-hoc. Basically partition map defines a function which gives back > >> the sectors available for embedding. > > > > Is embedding useful elsew

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-13 Thread Vladimir 'phcoder' Serbinenko
>> We may want to embed more in the future. Actually I think it's not >> ad-hoc. Basically partition map defines a function which gives back >> the sectors available for embedding. > > Is embedding useful elsewhere? Yes. Consider a world of checksummed filesystems. In such world you can't change th

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-13 Thread Seth Goldberg
Hi, Can this go in util/i386/pc/ instead?  This is basicaly ad-hoc code and doesn't seem very meaningful in generic partmap/*.c. We may want to embed more in the future. Actually I think it's not ad-hoc. Basically partition map defines a function which gives back the sectors available for embed

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-13 Thread Robert Millan
On Wed, Aug 12, 2009 at 02:52:12PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 12, 2009 at 2:38 AM, Robert Millan wrote: > > On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Hello. A bug was filed that embedding code in grub-setup.c was > >> ign

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-13 Thread Robert Millan
On Wed, Aug 12, 2009 at 11:39:01AM +0200, Michal Suchanek wrote: > > I wonder, it here any firmware that supports multiple partition formats? GRUB does (GRUB+coreboot is a firmware). Anyhow, we were talking about BIOS, which is partmap-agnostic. -- Robert Millan The DRM opt-in fallacy: "You

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-12 Thread Vladimir 'phcoder' Serbinenko
On Wed, Aug 12, 2009 at 2:38 AM, Robert Millan wrote: > On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. A bug was filed that embedding code in grub-setup.c was >> ignoring partmap metadata which could cause its overwriting. To avoid >> usage of metadata and

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-12 Thread Michal Suchanek
2009/8/12 Robert Millan : > On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. A bug was filed that embedding code in grub-setup.c was >> ignoring partmap metadata which could cause its overwriting. To avoid >> usage of metadata and because of upcoming sunpc em

Re: [RFT,PATCH] Move embedding to appropriate partmap files

2009-08-11 Thread Robert Millan
On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. A bug was filed that embedding code in grub-setup.c was > ignoring partmap metadata which could cause its overwriting. To avoid > usage of metadata and because of upcoming sunpc embedding support I > propose to

[RFT,PATCH] Move embedding to appropriate partmap files

2009-08-11 Thread Vladimir 'phcoder' Serbinenko
Hello. A bug was filed that embedding code in grub-setup.c was ignoring partmap metadata which could cause its overwriting. To avoid usage of metadata and because of upcoming sunpc embedding support I propose to move embedding to partmap/*.c. For this I devised an interface which enables future reu