On Wed, Aug 12, 2009 at 02:52:12PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 12, 2009 at 2:38 AM, Robert Millan<r...@aybabtu.com> wrote: > > On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Hello. A bug was filed that embedding code in grub-setup.c was > >> ignoring partmap metadata which could cause its overwriting. To avoid > >> usage of metadata and because of upcoming sunpc embedding support I > >> propose to move embedding to partmap/*.c. For this I devised an > >> interface which enables future reusage of embedding for other too if > >> necessary. > > > > Can this go in util/i386/pc/ instead? This is basicaly ad-hoc code and > > doesn't seem very meaningful in generic partmap/*.c. > We may want to embed more in the future. Actually I think it's not > ad-hoc. Basically partition map defines a function which gives back > the sectors available for embedding.
Is embedding useful elsewhere? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
