On Fri, Oct 16, 2009 at 12:58:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >>>> We may want to embed more in the future. Actually I think it's not > >>>> ad-hoc. Basically partition map defines a function which gives back > >>>> the sectors available for embedding. > >>>> > >>> Is embedding useful elsewhere? > >>> > >> Yes. Consider a world of checksummed filesystems. In such world you > >> can't change the contents of the file by just writing to its blocklist > >> since it will break the checksum. Similar problems exist with RAIDs > >> and LVMs. On some systems we can't put grub-env in a file. For these > >> cases we can embed grub-env somewhere where we can write it with ease > >> > > > > Ok. Feel free to use partmap/ then. But please make sure #ifdefs only > > enable those functions where they are going to be used. That'd be > > GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them, > > this can be changed. > > > > > This patch fixes an important bug - namely overwriting extended > partition tables
Is there a simpler way to resolve this? I don't object to the restructuring you propose, but it seems too intrusive to do this just a few hours before we release 1.97. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
