Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 19:36, Andrey Borzenkov wrote: > grub_emu_init.c: grub_emu_init.h genemuinit.sh $(MOD_FILES) Forgot to update this one? Otherwise go ahead. signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.o

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
lone? It's difficult to see throught > intermingled patch. From: Andrey Borzenkov Subject: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES MinGW native nm does not support ELF binaries. --- grub-core/Makefile.am | 6 +++--- grub-core/genemuinit.sh | 4 ++--

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 18:12, Andrey Borzenkov wrote: > В Sat, 18 Jan 2014 17:55:38 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 18.01.2014 17:27, Andrey Borzenkov wrote: >>> While on it, pass detected >>> nm arguments instead of hardcoding them. >> please make this part a separate patch.

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
В Sat, 18 Jan 2014 17:55:38 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 18.01.2014 17:27, Andrey Borzenkov wrote: > > While on it, pass detected > > nm arguments instead of hardcoding them. > please make this part a separate patch. is it OK to commit without this part? > This would

Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.01.2014 17:27, Andrey Borzenkov wrote: > While on it, pass detected > nm arguments instead of hardcoding them. please make this part a separate patch. This would indicate that you support non-portable nm output which in this branch isn't the case. Why do you need it in the first place? si

[PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES

2014-01-18 Thread Andrey Borzenkov
MinGW native nm does not support ELF binaries. While on it, pass detected nm arguments instead of hardcoding them. --- grub-core/Makefile.am | 6 +++--- grub-core/genemuinit.sh | 9 + grub-core/genemuinitheader.sh | 9 + 3 files changed, 13 insertions(+), 11 deletion