Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Robert Millan
On Mon, Jan 21, 2008 at 06:42:42PM +0100, Marco Gerards wrote: > > Well, it is fine for me. If I need the size, I will bring this up > again. Feel free to commit the patch as suggested. Ok then. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are u

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 06:02:20PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: >> >> >> >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: >> >>

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Robert Millan
On Mon, Jan 21, 2008 at 06:02:20PM +0100, Marco Gerards wrote: > Robert Millan <[EMAIL PROTECTED]> writes: > > > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > >> > >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > >> > - grub_dprintf ("mem", "Using memory for heap: a

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: >> >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: >> > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", >> > addr, (unsigned int) size); >> > + grub_dprintf (

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-19 Thread Pavel Roskin
On Sat, 2008-01-19 at 22:50 +0100, Robert Millan wrote: > On Tue, Jan 15, 2008 at 07:00:55PM +0100, Robert Millan wrote: > > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > > > > > > On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > > > > - grub_dprintf ("mem", "Using memo

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-19 Thread Robert Millan
On Tue, Jan 15, 2008 at 07:00:55PM +0100, Robert Millan wrote: > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > > > > On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > > > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", > > > addr, (unsigned int) size)

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-15 Thread Robert Millan
On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > > On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", > > addr, (unsigned int) size); > > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n"

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-15 Thread Pavel Roskin
On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", > addr, (unsigned int) size); > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", > addr, addr + size); Maybe addr+size-1 would be better? Inclusive b

[PATCH] improve grub_mm_init_region() debug message

2008-01-15 Thread Robert Millan
This has bothered me for a while. By changing %u to %p this debug message becomes actually useful for checking offset problems. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) * kern/mm.c (grub_mm_init_region):