Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Robert Millan
On Tue, Aug 05, 2008 at 12:36:06PM +0200, Marco Gerards wrote: > > > > The name appleloader may be a little confusing, bootcamp seems to be a > > better choice. > > How about legacyloader or even legacy? Legacy is ambigous. Does it mean BIOS? msdos partmap? Or perhaps EFI? -- Robert Millan

Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Colin D Bennett
On Tue, 5 Aug 2008 22:14:37 +0800 Bean <[EMAIL PROTECTED]> wrote: > On Tue, Aug 5, 2008 at 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> > wrote: > > For some reason I have some doubts about lib/. But I do not have a > > better name in mind either. What does belong in there? Do you > > happen to h

Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Bean
On Tue, Aug 5, 2008 at 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: > Hi, > > Bean <[EMAIL PROTECTED]> writes: > >> This is a collection of miscellaneous patches, it includes: > > Please do not collect patches. Independant changes can better go into > independant patches. Mails like this are

Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > This is a collection of miscellaneous patches, it includes: Please do not collect patches. Independant changes can better go into independant patches. Mails like this are easily overseen and so are important changes made by such patch. > 1, move util/env

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 3:33 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Sun, 2008-07-27 at 15:30 +0800, Bean wrote: >> On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> >> >> BTW, any comment about the other changes ? >> >> > >> >> > Why do we need "crc"? If there a

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 15:30 +0800, Bean wrote: > On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > >> >> BTW, any comment about the other changes ? > >> > > >> > Why do we need "crc"? If there are chances that it will be used for > >> > security, we should be using SHA-1.

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> >> BTW, any comment about the other changes ? >> > >> > Why do we need "crc"? If there are chances that it will be used for >> > security, we should be using SHA-1. >> >> crc is useful in many place. For example, png, jffs

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 15:14 +0800, Bean wrote: > > Fine. > > I'm sorry, do you mean it's fine to use bootcamp, or keep the name > appleloader ? Fine to use "appleloader". Actually, I've never had a chance to play with an Intel Mac, so I don't know the details. > >> BTW, any comment about the o

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
Hi, On Sun, Jul 27, 2008 at 3:05 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> > IMHO that even worse. Using a trademarked name like "linux" to run the >> > trademarked software could be justified. But using a trademarked name >> > to replace or emulate the original software is asking for a big

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 14:00 +0800, Bean wrote: > Hi, > > On Sun, Jul 27, 2008 at 12:55 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > Our main repository is in Subversion, so whoever applies the patch > > should use "svn move" to keep the contiguous file history. Unlike git, > > which trusts the

Re: [PATCH] Misc patches for grub2

2008-07-26 Thread Bean
Hi, On Sun, Jul 27, 2008 at 12:55 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > Our main repository is in Subversion, so whoever applies the patch > should use "svn move" to keep the contiguous file history. Unlike git, > which trusts the contents in the first place, Subversion is more > sensitiv

Re: [PATCH] Misc patches for grub2

2008-07-26 Thread Pavel Roskin
On Sat, 2008-07-26 at 12:28 +0800, Bean wrote: > On Sat, Jul 26, 2008 at 4:53 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Sat, Jul 26, 2008 at 12:38:59AM +0800, Bean wrote: > >> 4. rename appleloader command to bootcamp > >> > >> The name appleloader may be a little confusing, bootcamp seem

Re: [PATCH] Misc patches for grub2

2008-07-26 Thread Pavel Roskin
On Fri, 2008-07-25 at 14:58 -0400, Chris Knadle wrote: > On Friday 25 July 2008, Bean wrote: > > On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <[EMAIL PROTECTED]> > wrote: > > > On Friday 25 July 2008, Bean wrote: > > >> 4. rename appleloader command to bootcamp > > >> > > >> The name appleloader

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Bean
On Sat, Jul 26, 2008 at 4:53 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jul 26, 2008 at 12:38:59AM +0800, Bean wrote: >> 4. rename appleloader command to bootcamp >> >> The name appleloader may be a little confusing, bootcamp seems to be a >> better choice. > > I'm not sure if this woul

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Robert Millan
On Sat, Jul 26, 2008 at 12:38:59AM +0800, Bean wrote: > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. I'm not sure if this would comply with Apple trademarks. What does this command do? -- Robert Millan I

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Bean wrote: > On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <[EMAIL PROTECTED]> wrote: > > On Friday 25 July 2008, Bean wrote: > >> 4. rename appleloader command to bootcamp > >> > >> The name appleloader may be a little confusing, bootcamp seems to be a > >> better choice.

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Bean
On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <[EMAIL PROTECTED]> wrote: > On Friday 25 July 2008, Bean wrote: >> 4. rename appleloader command to bootcamp >> >> The name appleloader may be a little confusing, bootcamp seems to be a >> better choice. > > Rather than patching all of the content fr

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Bean wrote: > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. Rather than patching all of the content from appleloader.c to bootcamp.c you may want to consider doing a 'git-mv' to rena

[PATCH] Misc patches for grub2

2008-07-25 Thread Bean
Hi, This is a collection of miscellaneous patches, it includes: 1, move util/envblk.c to lib/envblk.c As envblk.c is used by module loadenv and tool grub-editenv, I think it's better to move it to lib directory. 2. seperate hexdump function, and move it to lib/hexdump.c hexdump module consists