On Tue, Aug 5, 2008 at 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: > Hi, > > Bean <[EMAIL PROTECTED]> writes: > >> This is a collection of miscellaneous patches, it includes: > > Please do not collect patches. Independant changes can better go into > independant patches. Mails like this are easily overseen and so are > important changes made by such patch. >
ok, I'd remember this the next time, :-). >> 1, move util/envblk.c to lib/envblk.c >> >> As envblk.c is used by module loadenv and tool grub-editenv, I think >> it's better to move it to lib directory. > > > For some reason I have some doubts about lib/. But I do not have a > better name in mind either. What does belong in there? Do you happen > to have other names in mind as a suggestion? :-) The files in this directory are used by both modules and utilities, while files in util/ are only used by utilities. I also sense that lib is a little strange, but I can't think of a better name. Some alternative name could be: shared, common, helper. >> 4. rename appleloader command to bootcamp >> >> The name appleloader may be a little confusing, bootcamp seems to be a >> better choice. > > How about legacyloader or even legacy? Isn't that what it does > without actually using possibly trademarked names people are afraid of > using? There is a legacy boot protocol in efi, but apple doesn't use it. Therefore, I think it's better to use a name to indicate that this is apple related, to distinguish from the generic service. -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
