Re: we need a doc too

2009-08-14 Thread Marco Gerards
Hi, "J.Bakshi" writes: > It is nice to see that grub 1.97 is on its way. Everyone is waiting > for this power pack. But we also need a good doc for it. > The wiki is out-dated. You are completely right. Do you volunteer to write documentation? -- Marco _

Re: Three question about grub2

2009-08-07 Thread Marco Gerards
"J.Bakshi" writes: > Coming back with one more question in mind. ( already searched bot no > luck yet ). "echo" can dispaly message. Is there ( by any luck ) any > command to display message from a file ? cat -- Marco ___ Grub-devel mailing list Gr

Re: [PATCH 1/2] Relocator framework

2009-08-07 Thread Marco Gerards
Robert Millan writes: [...] >> Apple linker can't handle 64-bit differences > > This seems like a bug. Can GNU binutils be used on MacOS to resolve this? > > If it's workable, I'd rather make binutils a build requirement than adding > more of this (the other APPLE_CC ifdefs will probably need s

New maintainers

2009-08-05 Thread Marco Gerards
Hello, After a long discussion, I am happy to announce that Pavel and Robert are added to the list of GNU GRUB maintainers. I really hope this will improve the current situation. I will add them to savannah soonish, but they already are official GNU GRUB maintainers. Thanks, Marco __

Re: Some ideas about new features of grub

2009-07-31 Thread Marco Gerards
Pavel Roskin writes: > On Thu, 2009-07-02 at 16:48 +0800, Bean wrote: >> Hi, >> >> Here are some of my ideas about the new features of grub. >> >> Move kernel to a module. >> This make it possible to relocate the kernel. For example, we can use >> it to move grub-pc to upper memory, and free co

Re: [PATCH] File access library for lua

2009-07-31 Thread Marco Gerards
Bean writes: > Hi, > > Update for this patch: > > 1, enum_device now pass fs and uuid as well > 2, enum_file change parameter order, now the callback function is the > first, path is the second > 3, add parameter checking for library function > 4, add three function > > file_eof - test if eof is

Re: Proposal for GNU indent compatibility

2009-07-31 Thread Marco Gerards
Hi, Pavel Roskin writes: > In order to encourage developers to use proper indentation on the newly > added code, I suggest that we accept the default style of GNU indent. > That is, the space after "!" should not be needed. That's the only > difference I'm aware of. > > Running indent on the co

Re: GRUB 1.96 - unknown commands

2009-07-10 Thread Marco Gerards
Hello, Bean writes: > You need to add module sh, minicmd and linux. What was the reason it was split up? Sorry, I must have missed a discussion. I prefer scripting and normal.mod to be integrated, to prevent problems like these. -- Marco ___ Gru

Re: GRUB 1.96 - unknown commands

2009-07-10 Thread Marco Gerards
Hi, Chris Smart writes: > Here is the simple grub.cfg that I am using: > > set timeout=10 > set default=0 > menuentry "Linux" { > linux /efi/grub/vmlinuz > initrd /efi/grub/initrd > } > > > Here is what happens: > > Boot PC to rEFIt > Select grub.efi boot option > Computer says "Starting gru

Re: [RFC] New object format for grub2

2009-07-08 Thread Marco Gerards
Hi, Bean writes: > Why another format ? Here are some reason: > > The current object format is ELF. Most unix based os use ELF as native > object format, but there are minor difference, and gcc may add extra > segment which is of no use for grub. Mingw/cygwin uses PE, and we need > to convert it

Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean )

2009-06-28 Thread Marco Gerards
Hi, Robert Millan writes: > This commit accidentally broke "hiddenmenu" functionality > (http://grub.enbug.org/Hiddenmenu). Instead of displaying the sleep > prompt without clearing the screen, and then clearing the screen and > drawing the menu, it first clears the screen, draws the menu and t

Re: [RFC] New menu design based on MVC

2009-06-28 Thread Marco Gerards
Hi, Bean writes: > The current menu system is a little chaotic, the various components > are mixed together which make it difficult to maintain and extend. > Therefore, I propose a new design which seperates model, view and > controller. > > Model. It's the menu items. Currently, menu are added

Re: [PATCH 4/4] Define fields in terms of the Class Code register

2009-06-08 Thread Marco Gerards
Oliver Henshaw writes: Can you please send in patches in such a way they are recognised as text or inline? Please include a Changelog entry. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: > >> > So what should I do now? >> > Placing it in normal.mod or minicmd.mod where it's included in rescue >> > mode or placing it into

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> >> Felix Zielcke writes: >> >> >> >> > A

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' >> > Serbinenko: >> >> However convention

Re: [PATCH] add true and false commands

2009-06-04 Thread Marco Gerards
Felix Zielcke writes: > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' > Serbinenko: >> However convention for >> creating false is: >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); >> and not >> return 1; > > Ok changed it. If everyone is fine with placing this in no

Re: Data loss at savannah.gnu.org

2009-06-02 Thread Marco Gerards
David Miller writes: > From: Felix Zielcke > Date: Tue, 02 Jun 2009 12:13:02 +0200 > >> Unfortunately Okuji already objected against git [0] > > That was a year and a half ago, and how much has Okuji even made > postings to this mailing list lately? > > Remind me what the definition of "maintain

Absence

2009-05-28 Thread Marco Gerards
Hi, Many of you might have noticed that I have not been very active lately. This is mainly caused by my new study, work and personal circumstances. To be honest, I have no idea when this will change. When I have some spare time, I will be here. -- Marco _

Re: Parser

2009-03-07 Thread Marco Gerards
Kevin Lacquement writes: > Again looking at the script parser, I notices that it uses a > Yacc-generated parser, but a hand-written tokenizer. Is there a reason > that it doesn't use Lex? Is it due to external dependencies, and if so, > is there a way to recreate these deps (library or whatever)

Re: Menus and Functions

2009-03-03 Thread Marco Gerards
Hi, Kevin Lacquement writes: > I was browsing through the recent SVN head, and noticed that functions > and menu items are implemented separately. I was wondering if there's > actually a reason for that. > > It seems to me that a menu entry is nothing more than a function that, > instead of bei

Re: USB support merge (Re: [PATCH] (ata.mod) Fix ATAPI protocol)

2009-02-16 Thread Marco Gerards
Robert Millan writes: > On Mon, Jan 19, 2009 at 11:15:41AM +0100, Marco Gerards wrote: >> Perhaps my USB code might help in some occasions >> for scsi.c, I am not completely sure if they are in sync. I sent in >> the USB code earlier. This code can be committed, althoug

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-20 Thread Marco Gerards
Christian Franke writes: > Christian Franke wrote: >> Marco Gerards wrote: >> >>> Christian Franke <...> writes: >>> >>> >>>> This patch fixes the data I/O protocol of the ATA PACKET command. >>>> >>>> The cu

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-19 Thread Marco Gerards
Christian Franke writes: > This patch fixes the data I/O protocol of the ATA PACKET command. > > The current implementation does not read the byte count > registers. ATAPI read may not work if the drive sends the data in more > than one block. > > In conjunction with my recent SCSI blocksize patc

Re: USB support

2008-11-04 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Nov 04, 2008 at 04:21:39PM +0100, Felix Zielcke wrote: >> Am Dienstag, den 04.11.2008, 06:17 -0800 schrieb Viswesh S: >> > Hi, >> > >> > Is the USB support for grub2 completed or still in progress ? >> > >> > Is it possible to know,if incomplet

Re: grub2 summer code theme in debian?

2008-09-24 Thread Marco Gerards
"J.Bakshi" <[EMAIL PROTECTED]> writes: > On Wednesday 24 Sep 2008 8:12:40 am Bean wrote: >> On Wed, Sep 24, 2008 at 12:19 AM, Vesa Jääskeläinen <[EMAIL PROTECTED]> >> wrote: >> > J.Bakshi wrote: >> >> In my debian lenny, the grub2 has very simple look. I know it can be >> >> tweak to get ubuntu s

Absence

2008-09-21 Thread Marco Gerards
Hi, Due to circumstances, I will not actively read the list for a while. Actually, I didn't read the most of the e-mails on this list last month. I am sorry for this and how this situation can change soon. It will help a lot if other people can review incoming patches. And of course, please hav

Re: [PATCH] fix disk->id abuse

2008-09-02 Thread Marco Gerards
[...] >> We could write a macro for ID comparison that would compare both the >> "driver ID" (disk->dev->id) and "device ID" (disk->id). In this case, >> we can omit disk->id initialization in the drivers supporting only one >> device (e.g. memdisk) and only leave it where it's indeed needed for

Re: debian upstream bugs

2008-08-29 Thread Marco Gerards
[EMAIL PROTECTED] writes: > Gentlemen, I submitted some what I thought were downstream bugs: > http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=grub-pc;[EMAIL PROTECTED] Ehm? Can you please just start a discussion, I think that will give a better result than pointing to a website. -- Marco _

Re: Handlers

2008-08-29 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> If I knew a better way, I would have used it. I think the >> alternatives will all end up in either code duplication or a loss of >> type safety that now is at least present through warnings. Bu

Re: grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-29 Thread Marco Gerards
Hi Hans, [EMAIL PROTECTED] (Hans Lambermont) writes: > Felix Zielcke wrote on 20080828: > >> Am Donnerstag, den 28.08.2008, 13:14 +0200 schrieb Hans Lambermont: >>> My colleague Jan Derk Gerlings found a bug in the way grub 1.96, svn >>> version 20080813 (and earlier) reads the circular lvm2 meta

Re: grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-29 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Felix Zielcke wrote: >> The Changelog entry should be seperate, i.e. not a diff against the >> actual ChangeLog file but you can have it above inside your patch >> For example here my last small patch send to the list > > That is perfectly fine there

Re: Handlers

2008-08-29 Thread Marco Gerards
Hi, Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> This patch adds handler support to GRUB 2. This makes it easier to >> add new handlers to GRUB without duplicating code over and over. Bean >> wanted this for some of his ideas :-) >>

Re: Handlers

2008-08-29 Thread Marco Gerards
ertainly looks good, thanks for the suggestion. However, I do not think we have the same goals. For example, I focus on size and do not need many features. > Two comments: > > At Fri, 29 Aug 2008 14:36:56 +0200, > Marco Gerards wrote: >> +void >> +grub_handler_unregister

Handlers

2008-08-29 Thread Marco Gerards
most people agree with. I just don't want to commit this without proper review. Thanks, Marco 2008-08-29 Marco Gerards <[EMAIL PROTECTED]> * conf/i386-efi.rmk (grub_emu_SOURCES): Add `kern/handler.c'. (kernel_img_SOURCES): Likewise. (grub_setup_SO

Re: [PATCH] new static const char[] modname

2008-08-28 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Seems like it isn't that bad to review your own patches _before_ sending > them and actually to compile them .. ...and include a changelog entry? ;-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org

Absence

2008-08-23 Thread Marco Gerards
Hi, Since my modem is broken, I will most likely not read the list for a week or so. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

USB Support

2008-08-17 Thread Marco Gerards
Hi, Lately I have been working on USB support for GRUB 2. It's not completely ready yet. The code was only tested on QEMu and supports UHCI, OHCI, USB Mass Storage and HID. Most likely it will not immediately work on real hardware. But please test and report if you want to be sure ;-) You can

Re: [PATCH] romfs support for Grub2

2008-08-17 Thread Marco Gerards
"y.volta" <[EMAIL PROTECTED]> writes: > thanks bean, for your suggestion. I'm not famliar with GNU coding, so, would > you please show me some links to learn? especially the indent style. > and, this patch is just a work-able one, so, i'd like to improve it. > > for the legancy romfs patch, you c

Re: [PATCH] Replace magic numbers by constants

2008-08-17 Thread Marco Gerards
Hi, Carles Pina i Estany <[EMAIL PROTECTED]> writes: > When I did the Home/End keys patch I noticied that in normal/menu.c > there was some magic numbers (and some constants was already defined, in > include/grub/term.h (actually, reading the ChangeLog was committed by > Robert Millan on 2008-02-

Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader

2008-08-16 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Aug 13, 2008 at 07:52:59PM +0200, Marco Gerards wrote: >> > #include >> > #include >> > +#include/* For struct grub_mmap_entry, which is >> > also >> > +

Re: [Fwd: Re: Bug#495049: grub-pc: does not boot because module "normal" is not loaded]

2008-08-15 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 18:40 +0200 schrieb Felix Zielcke: >> Hello, >> >> anyone has an idea why grub itself fails to switch from rescue to normal >> mode, but just `insmod normal; normal' does work? >> >> For me this doestn't make any sense at

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
Hi Felix, Felix Zielcke <[EMAIL PROTECTED]> writes: [...] > 2008-08-14 Felix Zielcke <[EMAIL PROTECTED]> > > * include/grub.err.h (grub_err_printf): New function prototype. grub.err.h -> grub/err.h > * util/misc.c (grub_err_printf): New function. > * kern/misc.c [! GR

Re: [PATCH] Drivemap module

2008-08-14 Thread Marco Gerards
Javier Martín <[EMAIL PROTECTED]> writes: > Ok, making a mixup reply... Please don't. Unless you do not like it that your mails go unread. >> > Having a small kernel is highly desireable for most users. If the kernel >> > is >> > too big, it won't fit and then either we have to use blocklists

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: > > Honourly I want that whole topic discussed with everyone who is > subscribed here and not just with you Marco, but it's very kind that at > least you reply :

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke: >> >> This time dear Marco I didn't bother to read through the changelog, it >> might be still not perfect and I'm even tired now. > > I should have better gone to bed instead of making q

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Mittwoch, den 13.08.2008, 20:41 +0200 schrieb Marco Gerards: >> So what do you propose? :-) You lost me midway since you change >> subjects a bit often ;( > > Oh sorry for that this time I only changed [PATCH] to [RFC]

Re: [PATCH] add support for GRUB_GFXMODE variable

2008-08-13 Thread Marco Gerards
Hi, Felix Zielcke <[EMAIL PROTECTED]> writes: > seems like nobody responded to this one :) > > Am Donnerstag, den 31.07.2008, 17:35 +0200 schrieb Felix Zielcke: >> Here's a patch to add a GRUB_GFXMODE variable for update-grub >> to set the gfxmode. >> >> >> 2008-07-31 Felix Zielcke <[EMAIL P

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Hello, > > Am Mittwoch, den 13.08.2008, 11:38 +0200 schrieb Marco Gerards: >> > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> >> > >> > * kern/err.c [GRUB_UTIL]: Include . >> >

Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader

2008-08-13 Thread Marco Gerards
Hi, Robert Millan <[EMAIL PROTECTED]> writes: > And here we go *AGAIN*, this time not forgetting to include all files in the > patch. [...] > Index: include/grub/i386/pc/init.h > === > --- include/grub/i386/pc/init.h (revisio

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: [...] >> > This is a lot of code being added to kernel, and space in kernel is highly >> > valuable. >> > >> > Would the same functionality work if put inside a module? >> For the reasons discussed above in the loader.h snippet, I don't think >> so: the

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
Hi, Javier Martín <[EMAIL PROTECTED]> writes: > El mié, 13-08-2008 a las 15:00 +0200, Robert Millan escribió: >> Hi, >> >> Marco asked me to review this. > So he finally got fed up of me... Understandable ^^ No, but I am not as qualified regarding the BIOS as Robert is, except for general remar

Re: [PATCH] Home-End keys in menu

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote: >> Hi, >> >> Carles Pina i Estany <[EMAIL PROTECTED]> writes: >> >> [...] >> >> > 2008-08-06 Carles Pina i Estany <[EMAI

Re: Idea: use menu hook to implement the savedefault command

2008-08-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > Hi, > > Now it's possible to implement savedefault with load_env and save_env, > but the problem is we need to add it to every menuitem, it's tedious > process, and new item don't get it automatically. > > I'm thinking about using menu hook to solve this. I can t

Re: [PATCH] Do not mess with libc's prototypes

2008-08-13 Thread Marco Gerards
[EMAIL PROTECTED] writes: > Due to some more breakage, here's some more patch: > > According to POSIX memmove and memcpy can actually be macros or whatever > (IIRC). We'd better not play with those in code that uses libc's headers > and is to be linked with libc. > > 2008-08-08 Lubomir Rintel <[

Re: [PATCH] Warning fixes

2008-08-13 Thread Marco Gerards
Hi, Pavel Roskin <[EMAIL PROTECTED]> writes: > I've fixed the trivial stuff, but this may require comments. I'll be > mostly offline for the next 3 weeks, so if it's OK, please apply it for > me. > > ChangeLog: > > * disk/ata.c (grub_ata_pciinit): Mark pciid unused. Oh, I changed this, so

Re: [PATCH] New command checktime

2008-08-13 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > > Oh, please take a look at my other post "Idea: implementation of the > password command", it sugguest to implement password with hooks, for > example, reading $GET_PASSWORD would prompt the user for password and > return the encrypted form. > > BTW, I'm t

Re: [PATCH] Home-End keys in menu

2008-08-13 Thread Marco Gerards
Hi, Carles Pina i Estany <[EMAIL PROTECTED]> writes: [...] > 2008-08-06 Carles Pina i Estany <[EMAIL PROTECTED]> > > * menu/normal.c (run_menu): Add Home and End keys in grub-menu. This looks fine to me at first sight. Do others have problems with this? Otherwise it can be committed.

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
Javier Martín <[EMAIL PROTECTED]> writes: > In this reply-to-myself hoping to keep the thread continuity, I put > forth the new "version 7" of the patch with the following changes: > > - A new switch -s/--swap has been implemented, so that running > "drivemap -s hd0 hd1" is equivalent to issuing

Re: [PATCH] Split of raid scan code

2008-08-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 4:30 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> On Tue, Aug 12, 2008 at 04:24:26AM +0800, Bean wrote: >>> - disk/lvm.c disk/raid.c grub_probe_init.c >>> + disk/lvm.c disk/raid.c disk/mdraid_linux.c grub_probe_init.c >> >> Hi,

Re: [PATCH] add pkzip support for gzio

2008-08-13 Thread Marco Gerards
"Gregg Levine" <[EMAIL PROTECTED]> writes: > On Mon, Aug 11, 2008 at 1:22 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> "y.volta" <[EMAIL PROTECTED]> writes: >> >>> i've made a little patch for pkzipe

Re: Idea: Use extended blocklist format to support installing to raid device.

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 05:20:54PM +0800, Bean wrote: >> >> Hi, >> >> Right, but we can't get rid of it totally. For example, if they don't >> reserve enough space at the beginning of disk, there is no way to >> install grub2 without blocklist. And, so

Re: Is romfs supported in Grub2

2008-08-13 Thread Marco Gerards
"y.volta" <[EMAIL PROTECTED]> writes: > romfs is useful for me, so is there any existing mod or functions > existed in current Grub2? > > if no, i'd like to add this mod to Grub2 from previous Grub0.97 patch. Who owns the copyright? BTW, GRUB 2 and GRUB Legacy filesystem code are *VERY* differen

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: >> > * kern/err.c [GRUB_UTIL]: Include . > >> Please don't do this. Why do you want this? > > It's needed for fprintf, and fprintf is on

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: >> > [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) >> > instead of >> > grub_printf. >> >&g

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Here's now the patch Robert requested. > grub_print_error shouldn't use stdout for the utils. > > Why? > > # grub-install /dev/sda > Unknown extra argument `Unsupported'. > > This is with Bean's or mine lastest RAID patch. > /dev/sda isn't on a raid at a

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 12.08.2008, 17:41 +0200 schrieb Robert Millan: >> On Tue, Aug 12, 2008 at 05:30:15PM +0200, Felix Zielcke wrote: >> > >> > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> >> > >> > * kern/err.c [GRUB_UTIL]: Include . >> >

Re: [PATCH] Enable grub_cpu_idle for i386 to halt the CPU

2008-08-13 Thread Marco Gerards
David Fries <[EMAIL PROTECTED]> writes: > Enable grub_cpu_idle for i386 to halt the CPU and modify the menu code > to make use of it. This will save power when booting. > Or maybe I should say it will keep the CPU from running so hot when > the timer is counting down. > > It isn't safe to call ha

Re: Idea: implementation of the password command

2008-08-13 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > First of all, we can store the encrypted password in a variable, like > PASSWORD. It's better to store it in grubenv. as it is more flexible, > and also allows the user to change it from the grub environment. I am not sure if this is what we want. It might

Re: [PATCH] grub-mkelfimage

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > If there are no objections, I will check this in soon. Looks fine to me. Didn't you break the ability to cross compile for PPC on x86 along the way? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] New command checktime

2008-08-12 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 5:07 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> >>> * commands/date.c: New file. >>> >>> * commands/datetime.c: Likewise. >> >> This is not a command. But I d

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-12 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke: > > Ok naming the old patch kern_err.diff and the new one raid_err.diff > isn't a good idea :( > > > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> > > * kern/err.c [GRUB_UTIL]: In

ATAPI split-off

2008-08-12 Thread Marco Gerards
-12 Marco Gerards <[EMAIL PROTECTED]> * conf/i386-pc.rmk (pkglib_MODULES): Add scsi.mod. (scsi_mod_SOURCES): New variable. (scsi_mod_CFLAGS): Likewise (scsi_mod_LDFLAGS): Likewise. * disk/scsi.c: New file. * include/grub/scsi.h: Li

Re: [PATCH] New command checktime

2008-08-11 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Mon, Aug 11, 2008 at 2:04 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Bean <[EMAIL PROTECTED]> writes: >> >>> I implement this command for grub4dos some time ago, now it's ported

Re: [PATCH] add pkzip support for gzio

2008-08-11 Thread Marco Gerards
Hi, "y.volta" <[EMAIL PROTECTED]> writes: > i've made a little patch for pkziped ( deflate mode ) file. by > using this, we can have both gunzip and pkunzip supported: they have > only header different with the same file. ;-) > > please note, if your file is too small, pkzip will not comp

Re: [PATCH] New command checktime

2008-08-10 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > I implement this command for grub4dos some time ago, now it's ported to grub2. > > Usage: > > checktime min hour day_of_month month day_of_week Personally I would prefer it if it worked a bit more GRUB2/bash like. So can you make this variables? For exam

Re: Crypto Patch: Legal Issues

2008-08-09 Thread Marco Gerards
Hi Michael, Michael Gorven <[EMAIL PROTECTED]> writes: > Two months ago[1] I announced on this list that I was working on adding > support for LUKS encrypted partitions to GRUB. I had some queries[2] > regarding other code which I have used, and still haven't had a proper > response to those q

Re: ATA update

2008-08-08 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: >> I currently always boot directly from my Raid 0 >> GRUB + Vista bootmgr + Vista \Windows\ is on Raid 0 >> my Linux / and so /boot is on my PATA disk. >> This works totally fine for booting Vista and Linux. > > Oh and I forgot the Vista bootmgr file is

Re: ATA update

2008-08-08 Thread Marco Gerards
Hi Felix, Felix Zielcke <[EMAIL PROTECTED]> writes: >> One minute ago I committed a patch to improve ATA support. >> > Probable better if I just send you know a mail instead of telling on > IRC: > > This is shown for device 4,0 and 4,1 > PCI Dev (0,8,0) compat=1 rega=0x9e0=regb=0xbe0 > > My firs

ATA update

2008-08-07 Thread Marco Gerards
Hi, One minute ago I committed a patch to improve ATA support. The new stuff: - It isn't very slow anymore - It even works for Robert ;-) - It works on QEmu - The error handling significantly improved - Added timeouts, so ata.mod does not endlessly wait for nothing - Detected controllers are all

Re: NEWS update

2008-08-07 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> I have just updated the NEWS file. Can you please look at it to see >> if I forgot something important? >> >> > Builds & runs out-of-the-box on Cygwin? Good one, can you please add i

NEWS update

2008-08-07 Thread Marco Gerards
Hi, I have just updated the NEWS file. Can you please look at it to see if I forgot something important? If someone can update DISTLIST, I will be *very* happy :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman

Re: [PATCH] Fix infinite loop in grub_pit_wait()

2008-08-07 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > grub2 from current SVN hangs if run in VirtualPC, the problem was > introduced with 'svn diff -r 1779:1780'. > > Here is a proposed fix. > > Christian > > 2008-08-07 Christian Franke <[EMAIL PROTECTED]> > > * kern/i386/pit.c (TIMER2_SPEAKER):

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> Colin D Bennett <[EMAIL PROTECTED]> writes: >>> I think we should remove conf/*.mk from the Subversion repository. If >>> people are going to be developing on GRUB and checking out svn

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards: >> Felix Zielcke <[EMAIL PROTECTED]> writes: >> >> > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> >> > >> >* partmap

Re: [PATCH] Home-End keys in menu

2008-08-05 Thread Marco Gerards
Hi, Carles Pina i Estany <[EMAIL PROTECTED]> writes: > Some weeks ago I sent a patch that didn't have any discussion. I'm > sending it again, maybe everybody was in holidays :-) > > Actually I updated the patch (added some spaces to comply with the > coding style). > > * menu/normal.c: Add Home a

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> > > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid > BSD > magic or if there's no space left, use grub_dprintf to issue a warning. Looks fine. > + { > +

Re: [PATCH] High resolution time/TSC patch v3

2008-08-05 Thread Marco Gerards
Hi Colin, Colin D Bennett <[EMAIL PROTECTED]> writes: > Another updated TSC patch. Now it detects TSC support for x86 CPUs at > runtime and selects either the TSC or RTC time source. This way 386 > and 486 CPUs without RDTSC instruction support are supported. > > Robert Millan was interested in

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
Hi, Javier Martín <[EMAIL PROTECTED]> writes: >> Anyway, since "they" are more likely to maintain the code in >> the long run than you, in general, the question is whether >> the code is more likely to become buggy by their hacking on >> it, if it follows project coding style or someone else's

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
Hi, Javier Martín <[EMAIL PROTECTED]> writes: >> > There is, however, one point in which I keep my objection: comparisons >> > between a variable and a constant should be of the form CONSTANT == >> > variable and not in the reverse order, since an erroneous but quite >> > possible change of == fo

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
Hi Javier, Javier Martín <[EMAIL PROTECTED]> writes: > El lun, 04-08-2008 a las 22:51 +0200, Marco Gerards escribió: >> Javier Martín <[EMAIL PROTECTED]> writes: >> >> > After your latest replay, I "reevaluated" my stubbornness WRT some of &g

Re: [PATCH] Test for files with ls

2008-08-05 Thread Marco Gerards
Hi, Lampersperger Andreas <[EMAIL PROTECTED]> writes: > I have there a small patch to commands/ls.c, whichs makes the > ls-command return an error for non existing fils (as the bash ls > command). > > With this patch, one can have in the grub.cfg files statements like: > > if ls /boot/grub/grub.c

Re: [PATCH] Fix color problem the grub-emu

2008-08-05 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 5, 2008 at 6:15 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Bean <[EMAIL PROTECTED]> writes: >> >>> Currently, the color handling in grub-emu is broken, sometimes you see

Re: Bug#475718: Bug #475718 grub gets confused by hybrid apple/pc partmap

2008-08-05 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Jul 25, 2008 at 07:36:25PM -0400, Chris Knadle wrote: >> >>If you ask me, I think this unfortunately looks like a complex detection >> problem -- which I think is eventually going to start with a *successful* >> detection of the Apple part

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
Hi, Colin D Bennett <[EMAIL PROTECTED]> writes: [...] > I think we should remove conf/*.mk from the Subversion repository. If > people are going to be developing on GRUB and checking out svn > branches, then I think it's fine to require them to have Ruby. For > released tarballs that we expect

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
Hi, Christian Franke <[EMAIL PROTECTED]> writes: > For a release tarball, It IMO also makes sense to include > util/parser.tab.c. It is platform-independent and rarely changed. This > would remove bison from the list of prerequisites. Fine for me. -- Marco ___

Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > This is a collection of miscellaneous patches, it includes: Please do not collect patches. Independant changes can better go into independant patches. Mails like this are easily overseen and so are important changes made by such patch. > 1, move util/env

Re: GRUB has a problem with a big grub.cfg

2008-08-05 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > I have found the bug, it's caused by buffer overflown. In get_line > (normal/main.c), if the string length is multiple of 64, the ending \0 > will overflow the buffer, this patch fix the problem: Looks fine to me. -- Marco __

Re: [PATCH] Add support for /dev/md/N style mdraid devices

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Freitag, den 01.08.2008, 17:09 +0200 schrieb Felix Zielcke: > >> Maybe there's a way to make it even better so please comment all of you >> grub-devels :) > > Thanks to Robert who suggested asprintf > > I hope the #define _GNU_SOURCE which is needed f

Re: two bugs in configfile parser

2008-08-05 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > Ok, I've found the bug. In editor_getline (normal/menu_entry.c), it > should return a string allocated with grub_strdup, instead of the > original one, as the result will be release in the lexer once it's > done. The patch looks fine. You can commit it, if

  1   2   3   4   5   6   7   8   9   10   >