Christian Franke <christian.fra...@t-online.de> writes: > Christian Franke wrote: >> Marco Gerards wrote: >> >>> Christian Franke <...> writes: >>> >>> >>>> This patch fixes the data I/O protocol of the ATA PACKET command. >>>> >>>> The current implementation does not read the byte count >>>> registers. ATAPI read may not work if the drive sends the data in >>>> more than one block. >>>> >>>> In conjunction with my recent SCSI blocksize patch, ATAPI CD/DVD >>>> drives should now work. >>>> >>>> >>> Sorry for not commenting on many things on this list. I am too busy >>> to check all this. >> >> N.P. >> >> Meantime, I have tested the SCSI and ATAPI fixes on several PC. If there >> are no further comments, I will commit these soon. >> >> > > Committed, plus an additional wait in grub_atapi_identify.
Great! :-) > Open issues: > - grub_pio_read/write() check the ERR bit without ensuring !BSY. > - ata_read fails if (batch % size) == 0. > - ata_write does not work at all, it uses the read cmd. grub_ata_write does not use the read cmd, or do you mean indirectly? In that case, where does it use the read command? -- Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
