Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI

2023-02-25 Thread Javier Martinez Canillas
update the module and command name in some commit messages as well. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
On 8/31/22 00:07, Philip Müller wrote: > On 30.08.22 23:34, Javier Martinez Canillas wrote: >>> You could add a feature flag, which causes grub-core to set an >>> environment variable when a new feature is supported. See the features >>> array in grub-core/normal/

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
feature flag in the grub.d snippet > before calling fwsetup --is-supported. > Please don't. As mentioned, I think we should aim to simplify the grub.cfg instead of making it more complicated. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat __

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Javier Martinez Canillas
Hello Daniel, On 2/25/22 13:03, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: >> Hello Peter, >> >> Thanks a lot for your patch. >> >> On 2/24/22 22:55, Peter Jones wrote: >>> ChangeLog-2015 has be

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Javier Martinez Canillas
get rid of this ChangeLog. It doesn't add any value AFAICT and makes doing greps over the codebase much harder. > Signed-off-by: Peter Jones > Reviewed-by: Daniel Axtens > Reviewed-by: Robbie Harwood Reviewed-by: Javier Martinez Canillas --

Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text output

2022-01-30 Thread Javier Martinez Canillas
;) > Signed-off-by: Hans de Goede > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] EFI: console: Do not set colorstate until the first text output

2022-01-30 Thread Javier Martinez Canillas
t; text output actually happens. During refactoring to move the > grub_console_setcolorstate () up higher in the grub-core/term/efi/console.c > file the code to cache the color-state + bail early was accidentally > dropped. > > Restore the cache the color-state + bail early behavi

Re: [PATCH 0/2] ieee1275/powerpc: implement ofpath to enable hint feature for FC and dm devices

2021-11-15 Thread Javier Martinez Canillas
codes for both groups of devices and with > them we can get the --hint-ieee1275 working properly. > We are using these patches in Fedora and RHEL for some time and it does solve the mentioned issues. Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linu

Re: blscfg module $early_initrd and $default_kernelopts variables

2021-08-18 Thread Javier Martinez Canillas
Hello Mike, On Wed, Aug 11, 2021 at 3:17 PM Mike Beaton wrote: > > I was wondering if anybody could possibly help out and clarify, is there any > official documentation around the existence, and correct use, of the blscfg > $early_initrd and $default_kernelopts variables? > The blscfg module i

Re: UEFI Secureboot not succeeding with Grub 2.06 and later version

2021-07-16 Thread Javier Martinez Canillas
nks for testing. Dmitry, any idea why header->type == OBJ_TYPE_DISABLE_SHIM_LOCK won't be true when the for loop happens in shim_lock_verifier_write() ? But in any case, Daniel does not agree with this approach. We would need a different solution for this. Best re

Re: UEFI Secureboot not succeeding with Grub 2.06 and later version

2021-07-15 Thread Javier Martinez Canillas
give it a try to this one now? I built tested this time but still couldn't test it. I should be able to do that but no earlier than next week. From a7c205faef72df4dd6decb114b35b53941c17014 Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas Date: Thu, 15 Jul 2021 13:08:11 +0200 Subject: [RF

Re: UEFI Secureboot not succeeding with Grub 2.06 and later version

2021-07-15 Thread Javier Martinez Canillas
ou for some tests. > > Thanks for the information. Sure, will look forward for the change and > further experiments to perform. > Could you please try the following patch? I've not tested it yet but I think that should make GRUB to support your use case. From 37157118e237f216866

[PATCH 1/2] templates: Check for EFI at runtime instead of config generation time

2021-07-06 Thread Javier Martinez Canillas
FW_UI bit is set, since that's already done by the "fwsetup" command when is executed. Signed-off-by: Javier Martinez Canillas --- util/grub.d/30_uefi-firmware.in | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/util/grub.d/30_uefi-firmwa

[PATCH 2/2] efi: Print an error if boot to firmware setup is not supported

2021-07-06 Thread Javier Martinez Canillas
etting a "can't find command `fwsetup`" error if it is not supported by the firmware, let's just always register the command but print a more accurate message if the firmware doesn't support this option. Signed-off-by: Javier Martinez Canillas -

[PATCH 0/2] Improve logic to check for fwsetup support

2021-07-06 Thread Javier Martinez Canillas
h grub_platform == "efi" and when the command is executed. That way, the 30_uefi-firmware template won't make any assumption about the firmware support of the machine that's booted. Best regards, Javier Javier Martinez Canillas (2): templates: Check for EFI at runtime instead of

[PATCH] fs/ext2: Ignore checksum seed incompat feature support

2021-06-11 Thread Javier Martinez Canillas
o the read-only FS driver. Suggested-by: Eric Sandeen Suggested-by: Lukas Czerner Signed-off-by: Javier Martinez Canillas --- grub-core/fs/ext2.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c index 848bf939dba..238b2d76

[2.06 RELEASE PATCH v3 4/4] fs/xfs: Add needsrepair incompat feature support

2021-05-24 Thread Javier Martinez Canillas
reading or booting fails, the user can figure out that the failures may be related to the XFS filesystem needing to be repaired. Suggested-by: Eric Sandeen Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Improved commit message in patch #4 (dkiper). - Make the debug message more cle

[2.06 RELEASE PATCH v3 2/4] fs: Use 64-bit type for filesystem timestamp

2021-05-24 Thread Javier Martinez Canillas
() helper has been used. These changes enables the GRUB to support dates beyond y2038. Signed-off-by: Carlos Maiolino Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- Changes in v3: - Add dkiper Reviewed-by tag to patch #2. - Include grub/mm.h instead of the stdef.h header

[2.06 RELEASE PATCH v3 3/4] fs/xfs: Add bigtime incompat feature support

2021-05-24 Thread Javier Martinez Canillas
. Signed-off-by: Carlos Maiolino Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Fix commit message in patch #3 (dkiper). - Drop unrelated cleanups in patch #3 (dkiper). - Fix issues pointed out in v1 that were missed on v2 (dkiper). Changes in v2: - Improve the commit message of

[2.06 RELEASE PATCH v3 0/4] Add XFS bigtime and needsrepair support

2021-05-24 Thread Javier Martinez Canillas
ommit message of patch #4 (dkiper). - Fix typo in debug message of patch #4 (dkiper). Carlos Maiolino (2): fs: Use 64-bit type for filesystem timestamp fs/xfs: Add bigtime incompat feature support Javier Martinez Canillas (2): types: Define PRI{x,d}GRUB_INT{32,64}_T format specifiers fs/xfs

[2.06 RELEASE PATCH v3 1/4] types: Define PRI{x, d}GRUB_INT{32, 64}_T format specifiers

2021-05-24 Thread Javier Martinez Canillas
There are already constant macros defined for unsigned integers but no for signed integers. Add macro constants for format specifiers of the latter. Suggested-by: Daniel Kiper Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- Changes in v3: - Add dkiper Reviewed-by tag

Re: [2.06 RELEASE PATCH v2 3/4] fs/xfs: Add bigtime incompat feature support

2021-05-17 Thread Javier Martinez Canillas
Hello Daniel, On 5/17/21 4:09 PM, Daniel Kiper wrote: > On Wed, May 12, 2021 at 05:46:15PM +0200, Javier Martinez Canillas wrote: >> From: Carlos Maiolino >> >> The XFS filesystem supports a bigtime feature to overcome y2038 problem. >> This patch makes the G

[2.06 RELEASE PATCH v2 4/4] fs/xfs: Add needsrepair incompat feature support

2021-05-12 Thread Javier Martinez Canillas
. That way, if the reading or later booting fail, the user can figure out that may be related to this. Suggested-by: Eric Sandeen Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Improve commit message of patch #4 (dkiper). - Fix typo in debug message of patch #4 (dkiper). grub-cor

[2.06 RELEASE PATCH v2 3/4] fs/xfs: Add bigtime incompat feature support

2021-05-12 Thread Javier Martinez Canillas
current situation, since the timestamps in GRUB are 32-bit values. Signed-off-by: Carlos Maiolino Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Improve the commit message of patch #3 (dkiper). - Drop Reviewed-by tag from patch #3 (dkiper). _ Drop unrelated changes in patch #3

[2.06 RELEASE PATCH v2 0/4] Add XFS bigtime and needsrepair support

2021-05-12 Thread Javier Martinez Canillas
e for filesystem timestamp fs/xfs: Add bigtime incompat feature support Javier Martinez Canillas (2): types: Define PRI{x,d}GRUB_INT{32,64}_T format specifiers fs/xfs: Add needsrepair incompat feature support grub-core/fs/affs.c | 2 +- grub-core/fs/ext2.c | 2 +- grub-co

[2.06 RELEASE PATCH v2 2/4] fs: Use 64-bit type for filesystem timestamp

2021-05-12 Thread Javier Martinez Canillas
() helper has been used. These changes enables the GRUB to support dates beyond y2038. Signed-off-by: Carlos Maiolino Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Improve commit message for patch #2 (dkiper). - Drop Reviewed-by tag from patch #2 (dkiper). - A few code cleanups

[2.06 RELEASE PATCH v2 1/4] types: Define PRI{x, d}GRUB_INT{32, 64}_T format specifiers

2021-05-12 Thread Javier Martinez Canillas
There are already constant macros defined for unsigned integers but no for signed integers. Add macro constants for format specifiers of the latter. Suggested-by: Daniel Kiper Signed-off-by: Javier Martinez Canillas --- (no changes since v1) include/grub/types.h | 6 ++ 1 file changed, 6

[2.06 RELEASE PATCH 2/3] fs/xfs: Add bigtime incompat feature support

2021-05-05 Thread Javier Martinez Canillas
grub work properly with files with timestamps up to INT32_MAX (y2038), any file with timestamps bigger than this will overflow the counter, causing grub to show wrong timestamps (not really much difference on current situation). Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino

[2.06 RELEASE PATCH 1/3] fs: Use 64bit type for filesystem timestamp

2021-05-05 Thread Javier Martinez Canillas
has been used. These changes enables grub to support dates beyond y2038. Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino Signed-off-by: Javier Martinez Canillas --- grub-core/fs/affs.c | 2 +- grub-core/fs/ext2.c | 2 +- grub-core/fs/fat.c | 4

[2.06 RELEASE PATCH 3/3] fs/xfs: Add needsrepair incompat feature support

2021-05-05 Thread Javier Martinez Canillas
ggested-by: Eric Sandeen Signed-off-by: Javier Martinez Canillas --- grub-core/fs/xfs.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c index 2ce76ec70f9..9e290a144a0 100644 --- a/grub-core/fs/xfs.c +++ b/grub-cor

[2.06 RELEASE PATCH 0/3] Add XFS bigtime and needsrepair support

2021-05-05 Thread Javier Martinez Canillas
[0]: https://www.mail-archive.com/grub-devel@gnu.org/msg32079.html [1]: https://www.mail-archive.com/grub-devel@gnu.org/msg32158.html Best regards, Javier Carlos Maiolino (2): fs: Use 64bit type for filesystem timestamp fs/xfs: Add bigtime incompat feature support Javier Martinez Canillas (1)

[PATCH v3] xfs: Include needsrepair in the supported incompat features list

2021-05-03 Thread Javier Martinez Canillas
ggested-by: Eric Sandeen Signed-off-by: Javier Martinez Canillas --- Hello, This is a v3 of the XFS needsrepair patch addressing the issue pointed out by Vladimir. As mentioned this patch isn't really optional if the feature flag XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR is set, since it will prevent

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-05-03 Thread Javier Martinez Canillas
Hello Daniel, On 4/29/21 4:32 PM, Daniel Kiper wrote: > On Thu, Apr 29, 2021 at 11:05:20AM +0200, Carlos Maiolino wrote: >> On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: >>> Hello Vladimir, >>> >>> On 4/22/21 4:56 PM,

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
On 4/27/21 12:48 PM, John Paul Adrian Glaubitz wrote: > On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: [snip] >> } >> #endif >> + >> + if (image_target->id == IMAGE_EFI) >> +layout->kern

[PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
sizes and offsets in the PE section headers to match relevant sections in the PE32+ binary file. Reported-by: John Paul Adrian Glaubitz Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Drop the RFC prefix since I'm confident now about the solution. - Improve commit message (sugg

Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
ossible. > Thanks! I was busy this morning with other things but I'll post a v3 now. I'll keep your Tested-by tag since the size calculated should be the same, but would be good to test it again just to make sure that's the case. > Adrian &

Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-26 Thread Javier Martinez Canillas
ckly! I really appreciate it since don't have access to an Itanium system to verify the patch. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-26 Thread Javier Martinez Canillas
avier Martinez Canillas --- Changes in v2: - Align up for any arch in the is_relocatable (image_target) patch and not only for MKIMAGE_ELF64 or EM_AARCH64 (suggested by Daniel Kiper). util/grub-mkimagexx.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/grub-mkimagexx.c b/util

Re: [PATCH 2.06 RELEASE 3/3] term/terminfo: Fix the terminfo command help and documentation

2021-04-23 Thread Javier Martinez Canillas
On 4/14/21 5:48 PM, Daniel Kiper wrote: > Additionally, fix the terminfo spelling mistake in > the GRUB development documentation. > > Signed-off-by: Daniel Kiper > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - D

Re: [PATCH 2.06 RELEASE 2/3] i18n: Align N_() formatting with the rest of GRUB code

2021-04-23 Thread Javier Martinez Canillas
s true that this change makes it consistent with the rest of the GRUB codebase, so the patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat __

Re: [PATCH 2.06 RELEASE 1/3] i18n: Format large integers before the translation message - take 2

2021-04-23 Thread Javier Martinez Canillas
On 4/14/21 5:48 PM, Daniel Kiper wrote: > This is an additional fix which has been missing from the commit 837fe48de > (i18n: Format large integers before the translation message). > > Signed-off-by: Daniel Kiper > --- Looks good to me. Reviewed-by: Javier Martinez Canillas

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Javier Martinez Canillas
just ignore the flag then and drop this patch or it is worth to have some debugging printouts with grub_dprintf("xfs", ... ) ? Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat ___ Grub-deve

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Javier Martinez Canillas
t; XFS_SB_VERSION_5 only? Should not we use ">=" instead of "=="? >> Does not older XFS versions support this flag? > > No, only xfs V5 superblock supports needsrepair flag. > Indeed, and there's no plan for a XFS v5+ in the near future as was explained

[RFC PATCH] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-21 Thread Javier Martinez Canillas
avier Martinez Canillas --- Hello, this is an RFC because I want someone else more familiar with this to double check that this approach is sane. It would be also useful if someone can test on an aarch64 machine, I have compared the generated EFI binaries and are the same in both cases. But sti

Re: GRUB error: unknown filesystem on ia64

2021-04-21 Thread Javier Martinez Canillas
On 4/19/21 7:56 PM, Javier Martinez Canillas wrote: [snip] >> >> Could you send the patch to the mailing list separately with git send-email >> or so that it doesn't get overlooked in the longer discussion we had? >> > > Yes, I was waiting for someone else mo

Re: GRUB error: unknown filesystem on ia64

2021-04-19 Thread Javier Martinez Canillas
On 4/19/21 5:33 PM, John Paul Adrian Glaubitz wrote: > Hi Javier1 > > On 4/16/21 11:32 PM, Javier Martinez Canillas wrote: >>> I can confirm that this fixes the issue and makes GRUB work again on ia64. >>> >>> Tested-by: John Paul Adrian Glaubitz >>

[PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-19 Thread Javier Martinez Canillas
filesystem, the user can understand why that and take any needed action. Suggested-by: Eric Sandeen Signed-off-by: Javier Martinez Canillas --- grub-core/fs/xfs.c | 16 1 file changed, 16 insertions(+) diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c index 43023e03fb3..2

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, On 4/16/21 10:32 PM, John Paul Adrian Glaubitz wrote: [snip] >> > > I can confirm that this fixes the issue and makes GRUB work again on ia64. > > Tested-by: John Paul Adrian Glaubitz > Great, thanks a lot for the quick testing! Best regards, Javier

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
ata, pe_size - layout.reloc_size - > sbat_size - raw_data, but I've forward ported to current master branch now and also made the patch more clear. I've only tested on x64 so it would be great if can test it on ia64: From 767fdee805ce4bdd19c23c15c1f29a314282eaaf Mon Sep 17 00:00:00

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, Sorry for the delay, I didn't have time to look at this issue before. On 4/12/21 8:57 AM, John Paul Adrian Glaubitz wrote: > Hi Javier! > > On 4/12/21 8:21 AM, Javier Martinez Canillas wrote: >> Interesting, thanks for the input. >> >> Could you

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, Sorry for the delay, I didn't have time to look at this issue before. On 4/12/21 8:57 AM, John Paul Adrian Glaubitz wrote: > Hi Javier! > > On 4/12/21 8:21 AM, Javier Martinez Canillas wrote: >> Interesting, thanks for the input. >> >> Could you

Re: [PATCH 2/2] Use 64bit type for filesystem timestamp

2021-04-13 Thread Javier Martinez Canillas
tetime() to receive a 64-bit timestamp > argument and do 64bit-safe divisions. > > Both changes enables grub to support dates beyond y2038. > > Signed-off-by: Carlos Maiolino > --- Assuming changing this doesn't cause issues for 32-bit arches: Reviewed-by: Javier Ma

Re: [PATCH 1/2] Add bigtime support for xfs driver

2021-04-13 Thread Javier Martinez Canillas
verflow the counter, causing grub to show wrong timestamps > (not really much difference on current situation). > > Signed-off-by: Carlos Maiolino Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: GRUB error: unknown filesystem on ia64

2021-04-11 Thread Javier Martinez Canillas
Hello Adrian, On Sat, Apr 10, 2021 at 11:41 AM John Paul Adrian Glaubitz wrote: > > On 4/8/21 7:30 PM, John Paul Adrian Glaubitz wrote: > > On 4/8/21 7:10 PM, Javier Martinez Canillas wrote: > >>> Any news on this? I assume this should be trivial to fix when con

Re: GRUB error: unknown filesystem on ia64

2021-04-08 Thread Javier Martinez Canillas
[ adding Peter Jones who authored the patch ] On 4/8/21 6:45 PM, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > On 3/26/21 7:43 PM, Daniel Kiper wrote: >>> The address pointing to the modules within the GRUB core.img no longer >>> matches >>> the actual position of the modules. Hence, GRUB ca

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Javier Martinez Canillas
On 3/23/21 2:27 PM, Colin Watson wrote: > On Tue, Mar 23, 2021 at 12:37:20PM +0100, Javier Martinez Canillas wrote: [snip] >> >> For this particular case, it might be better for distros to just revert >> commit >> 9e95f45ceee ("verifiers: Move verifiers

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Javier Martinez Canillas
thing set in their /etc/default/grub wouldn't have entries for other OS in their GRUB config file anymore. [0]: https://lists.endsoftwarepatents.org/archive/html/grub-devel/2020-03/msg00053.html Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _

Re: [PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-03-03 Thread Javier Martinez Canillas
err_ignore environment variable in grub.cfg to false. Then if the > TPM UEFI calls fail for any reason machine boot fails. Does it work for > you guys? > That sounds sensible to me. As long as the default is to ignore errors as you suggested (i.e: leading to an unbootable system is opt-

Re: [PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-28 Thread Javier Martinez Canillas
On 2/28/21 7:25 PM, James Bottomley wrote: > On Sun, 2021-02-28 at 18:58 +0100, Javier Martinez Canillas wrote: [snip] >> I don't see how that would be the case. For anyone doing measured >> boot, they can check the TPM event log to verify what has been >> measured dur

Re: [PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-28 Thread Javier Martinez Canillas
Hello James, On 2/28/21 8:10 AM, James Bottomley wrote: > On Sun, 2021-02-28 at 00:05 +0100, Javier Martinez Canillas wrote: >> Currently if an EFI firmware fails to do a TPM measurement for a >> file, the error will be propagated to the verifiers framework which >> will pr

Re: [PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-28 Thread Javier Martinez Canillas
[re-sending since I got a 'Recipient server unavailable or busy' error, sorry if someone gets this email twice] Hello James, On 2/28/21 8:10 AM, James Bottomley wrote: > On Sun, 2021-02-28 at 00:05 +0100, Javier Martinez Canillas wrote: >> Currently if an EFI firmwar

[PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-27 Thread Javier Martinez Canillas
do a TPM measurement isn't expected to be a fatal error that causes the system to be unbootable. To avoid this, don't return errors from .write and .verify_string callbacks and just print a debug message in the case of a TPM measurement failure. Signed-off-by: Javier Martinez Canillas

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2021-01-19 Thread Javier Martinez Canillas
rwise, X being the queried mode. >> >> Additionally, in controller_fini, nothing has to be restored, since >> nothing was changed. This fixes an issue when switching between >> at_keyboard, console, and at_keyboard again, in case queried set is >> not the actual used set. >&

Re: [PATCH 8/9] efi: Only register shim_lock verifier if shim_lock protocol is found and SB enabled

2020-12-16 Thread Javier Martinez Canillas
e pushing the patches. > Sorry about that. I did build and test the patches but it may be that I reordered a little bit before posting and introduced this. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-14 Thread Javier Martinez Canillas
e keys are corrupted and it's impossible to do >> anything. >> >> Digging into this, it appears that query_mode() returns 2 (so set2 needs to >> be used), but in fact internally the keycode are the ones expected by set1. > > This is because the patch doesn&#x

[PATCH 8/9] efi: Only register shim_lock verifier if shim_lock protocol is found and SB enabled

2020-12-03 Thread Javier Martinez Canillas
is called, and check for it on every call to this function. Reported-by: Michael Chang Reported-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub-core/commands/efi/shim_lock.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/grub-core/command

[PATCH 9/9] loader/linux: Report the UEFI Secure Boot status to the Linux kernel

2020-12-03 Thread Javier Martinez Canillas
From: Daniel Kiper Now that the GRUB has a grub_efi_get_secureboot() function to check the UEFI Secure Boot status, use it to report that to the Linux kernel. Signed-off-by: Ignat Korchagin Signed-off-by: Daniel Kiper Signed-off-by: Marco A Benatto Signed-off-by: Javier Martinez Canillas

[PATCH 6/9] efi: Add a function to read EFI variables with attributes

2020-12-03 Thread Javier Martinez Canillas
From: Daniel Kiper It will be used to properly detect and report UEFI Secure Boot status to the x86 Linux kernel. The functionality will be added by subsequent patches. Signed-off-by: Ignat Korchagin Signed-off-by: Daniel Kiper Signed-off-by: Marco A Benatto Signed-off-by: Javier Martinez

[PATCH 5/9] efi: Return grub_efi_status_t from grub_efi_get_variable()

2020-12-03 Thread Javier Martinez Canillas
From: Daniel Kiper This is needed to properly detect and report UEFI Secure Boot status to the x86 Linux kernel. The functionality will be added by subsequent patches. Signed-off-by: Daniel Kiper Signed-off-by: Marco A Benatto Signed-off-by: Javier Martinez Canillas --- grub-core/commands

[PATCH 0/9] Add UEFI Secure Boot detection and report the status to Linux

2020-12-03 Thread Javier Martinez Canillas
to the Linux kernel Javier Martinez Canillas (4): i386: Don't include in coreboot and ieee1275 startup.S include/grub/i386/linux.h: Include missing header arm/term: Fix linking error due multiple ps2_state definitions efi: Only register shim_lock verifier if shim_lock protocol is

[PATCH 3/9] arm/term: Fix linking error due multiple ps2_state definitions

2020-12-03 Thread Javier Martinez Canillas
When building with --target=arm-linux-gnu --with-platform=coreboot a linking error occurs caused by multiple definitions of the ps2_state variable. Mark them as static since they aren't used outside their compilation unit. Signed-off-by: Javier Martinez Canillas --- grub-core/term/arm/c

[PATCH 2/9] include/grub/i386/linux.h: Include missing header

2020-12-03 Thread Javier Martinez Canillas
| grub_uint64_t addr; Signed-off-by: Javier Martinez Canillas --- include/grub/i386/linux.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/grub/i386/linux.h b/include/grub/i386/linux.h index ce30e7fb01b..6da5f030fd1 100644 --- a/include/grub/i386/linux.h +++ b/include/grub/i386/linux.h

[PATCH 1/9] i386: Don't include in coreboot and ieee1275 startup.S

2020-12-03 Thread Javier Martinez Canillas
such instruction: `typedef signed char grub_int8_t' ../include/grub/types.h:77: Error: no such instruction: `typedef short grub_int16_t' ../include/grub/types.h:78: Error: no such instruction: `typedef int grub_int32_t' Signed-off-by: Javier Martinez Canillas --- grub-core/ker

[PATCH 7/9] efi: Add secure boot detection

2020-12-03 Thread Javier Martinez Canillas
From: Daniel Kiper Introduce grub_efi_get_secureboot() function which returns whether UEFI Secure Boot is enabled or not on UEFI systems. Signed-off-by: Ignat Korchagin Signed-off-by: Daniel Kiper Signed-off-by: Marco A Benatto Signed-off-by: Javier Martinez Canillas --- grub-core

[PATCH 4/9] efi: Make shim_lock GUID and protocol type public

2020-12-03 Thread Javier Martinez Canillas
. Signed-off-by: Daniel Kiper Signed-off-by: Marco A Benatto Signed-off-by: Javier Martinez Canillas --- grub-core/commands/efi/shim_lock.c | 12 include/grub/efi/api.h | 19 +++ 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/grub-core

[PATCH] arm64: Include missing header

2020-11-09 Thread Javier Martinez Canillas
Martinez Canillas --- include/grub/arm64/linux.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/grub/arm64/linux.h b/include/grub/arm64/linux.h index 4269adc6dae..7e22b4ab699 100644 --- a/include/grub/arm64/linux.h +++ b/include/grub/arm64/linux.h @@ -19,6 +19,8 @@ #ifndef

[PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-11-06 Thread Javier Martinez Canillas
Set 1. For example, this is the case in Lenovo P71 and HP Elitebook 8770W laptops that report key scan codes using Set 2. Instead of hardcoding to Set 1, use the value that was queried before. Reported-by: Renaud Métrich Signed-off-by: Javier Martinez Canillas --- grub-core/term/at_keyboard.c

[PATCH 1/2] loader/i386/linux: Include missing header

2020-11-05 Thread Javier Martinez Canillas
| grub_uint64_t addr; Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- include/grub/i386/linux.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/grub/i386/linux.h b/include/grub/i386/linux.h index ce30e7fb01b..6da5f030fd1 100644 --- a/include/grub/i386/linux.h

[PATCH 2/2] arm: Include missing header

2020-11-05 Thread Javier Martinez Canillas
ff-by: Javier Martinez Canillas --- include/grub/arm/system.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/grub/arm/system.h b/include/grub/arm/system.h index f62c18c13a8..f15ce9751a5 100644 --- a/include/grub/arm/system.h +++ b/include/grub/arm/system.h @@ -1,6 +1,7 @@ #i

[PATCH v2] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Javier Martinez Canillas
file transfers of unlimited size again, re-introduce a block counter roll-over so the data packets are acked preventing the timeouts. [0]: https://tools.ietf.org/html/rfc2348 [1]: https://tools.ietf.org/html/rfc1350 Fixes: 781b3e5efc3 (tftp: Do not use priority queue) Suggested-by: Peter Jones Si

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Javier Martinez Canillas
, etc. not the >> commit id. > > I think “Fixes: commit id” should remain in place. It provides direct > information > from what commit the bug existed in case of regression. > Yes, I think the same. For example I usually do git log --grep="Fixes:", but don

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-09 Thread Javier Martinez Canillas
Hello Daniel, Thanks for the review. On 9/7/20 9:36 PM, Daniel Kiper wrote: > On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: >> Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression > > Please drop the quotes. > Sure

[PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-01 Thread Javier Martinez Canillas
Suggested-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub-core/net/tftp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/grub-core/net/tftp.c b/grub-core/net/tftp.c index 644135caf46..ba90c2bc45a 100644 --- a/grub-core/net/tftp.c +++ b/grub-core/

Re: [PATCH 3/4] efinet: UEFI IPv6 PXE support

2020-06-05 Thread Javier Martinez Canillas
f I got the intention wrong. I can post your original patches and then the squashed changes separately as a follow-up if you prefer it that way. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/4] grub.texi: Add net_bootp6 document

2020-06-04 Thread Javier Martinez Canillas
From: Michael Chang Update grub documentation for net_bootp6 command. Signed-off-by: Michael Chang Signed-off-by: Ken Lin Signed-off-by: Javier Martinez Canillas --- docs/grub.texi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi

[PATCH 2/4] bootp: New net_bootp6 command

2020-06-04 Thread Javier Martinez Canillas
From: Michael Chang Implement new net_bootp6 command for IPv6 network auto configuration via the DHCPv6 protocol (RFC3315). Signed-off-by: Michael Chang Signed-off-by: Ken Lin Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub-core/net/bootp.c | 914

[PATCH 0/4] UEFI IPv6 and DHCPv6 support

2020-06-04 Thread Javier Martinez Canillas
Hello, This series contains patches that come from the SUSE package that adds a net_bootp6 command to auto configure the network interfaces by using the DHCPv6 protocol. They also add support to do the auto configuration when GRUB is booted from UEFI IPv6 PXE. We have been carrying these for a lo

[PATCH 1/4] net: read bracketed ipv6 addrs and port numbers

2020-06-04 Thread Javier Martinez Canillas
From: Aaron Miller Allow specifying port numbers for http and tftp paths, and allow ipv6 addresses to be recognized with brackets around them, which is required to specify a port number Signed-off-by: Aaron Miller Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub

[PATCH 3/4] efinet: UEFI IPv6 PXE support

2020-06-04 Thread Javier Martinez Canillas
: Ken Lin Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub-core/net/drivers/efi/efinet.c | 45 +++-- include/grub/efi/api.h | 146 +++-- 2 files changed, 177 insertions(+), 14 deletions(-) diff --git a/grub-core/net/drivers

[PATCH v2] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2020-05-29 Thread Javier Martinez Canillas
eon E3-1275v3 on an Intel Server Board S1200V3RPS using the SDV.RP.B8 "Release" build here: https://firmware.intel.com/sites/default/files/UEFIDevKit_S1200RP_vB8.zip Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- Hello Daniel, I think that addressed all the issu

Re: [PATCH 6/6] efi/tpm: Fix typo in grub_efi_tpm2_protocol struct

2020-05-28 Thread Javier Martinez Canillas
ActivePcrBanks); >grub_efi_status_t (*set_active_pcr_banks) (struct grub_efi_tpm2_protocol * >this, > grub_efi_uint32_t > Reviewed-by: Javier Martinez Canillas Best regards, --

Re: [PATCH 4/6] tpm: Drop unneeded code

2020-05-28 Thread Javier Martinez Canillas
t); > - I think this would be useful if we ever add support for sending TPM commands. But I agree that should be removed since is unused and can always be brought back from the git history if needed. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software E

Re: [PATCH 5/6] i386/efi/init: Drop bogus include

2020-05-28 Thread Javier Martinez Canillas
-- a/grub-core/kern/i386/efi/init.c > +++ b/grub-core/kern/i386/efi/init.c > @@ -27,7 +27,6 @@ > #include > #include > #include > -#include > > void > grub_machine_init (void) > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canill

Re: [PATCH 3/6] docs: Fix devicetree command description

2020-05-28 Thread Javier Martinez Canillas
On 5/25/20 9:02 PM, Daniel Kiper wrote: > Specifically fix the subsection and drop bogus reference to the GNU/Linux. > > Reported-by: Patrick Higgins > Signed-off-by: Daniel Kiper > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas So

Re: [PATCH 2/6] net/http: Return an error on HTTP error responses

2020-05-28 Thread Javier Martinez Canillas
> There is one case that is still returning GRUB_ERR_NONE even when is taken as an error and that is when the HTTP version != 1.1. Maybe fixing that as well? Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/6] grub-install: Fix inverted test for NLS enabled when copying locales

2020-05-27 Thread Javier Martinez Canillas
Signed-off-by: Martin Whitaker > Signed-off-by: Daniel Kiper > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat ___ Grub-devel mailing li

[PATCH v2] net: break out nested function

2020-05-19 Thread Javier Martinez Canillas
tic helper function to make the code portable again. Reported-by: Daniel Axtens Signed-off-by: Javier Martinez Canillas Tested-by: Daniel Axtens --- Changes in v2: - Reword subject and commit message as suggested by Leif Lindholm. - Fix code style issue on function definition. - Add Daniel Axt

[PATCH] tpm: Enable module for all EFI platforms

2020-05-19 Thread Javier Martinez Canillas
The module is only enabled for x86_64, but there's nothing specific to x86_64 in the implementation and can be enabled for all EFI platforms. Signed-off-by: Javier Martinez Canillas --- grub-core/Makefile.core.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub

[PATCH] net: Don't use nested functions to allow building with clang

2020-05-19 Thread Javier Martinez Canillas
ned-off-by: Javier Martinez Canillas --- grub-core/net/net.c | 65 +++-- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/grub-core/net/net.c b/grub-core/net/net.c index c42f0f4f71d..ec7e2899ed5 100644 --- a/grub-core/net/net.c +++ b/gru

Re: [PATCH v3 2/5] configure: Set gnu99 C language standard by default

2020-05-19 Thread Javier Martinez Canillas
Hello Daniel, On 5/19/20 3:47 AM, Daniel Axtens wrote: > Javier Martinez Canillas writes: > >> Hello Daniel, >> >> On 5/18/20 5:49 PM, Daniel Kiper wrote: >> >> [snip] >> >>>> >>>> Without this patch, clang-9 fails on the use of

  1   2   3   >